16 comments:
Patch Set #14, Line 7: google/kukui: Elaborate panel support for Kukui family boards.
Please remove the dot/period at the end.
Ack
information?
Ack
its
Ack
its
Ack
one space
Ack
File src/mainboard/google/kukui/Makefile.inc:
$(CONFIG_BOARD_GOOGLE_KUKUI)
Ack
File src/mainboard/google/kukui/display.h:
/*
* board related functions
*/
Are these comments needed?
Ack
File src/mainboard/google/kukui/display.c:
if (CONFIG(BOARD_GOOGLE_KUKUI))
return &kukui_display_intf;
else
return NULL;
This implies we'll need to include all interfaces for any builds. […]
Ack
Patch Set #8, Line 116: return ERR;
return of an errno should typically be negative (ie: return -ERR)
Ack
File src/mainboard/google/kukui/display.c:
Did you run this through clang-format?
Ack
Patch Set #14, Line 38: printk(BIOS_ERR, "%s: wrong parameters\n", __func__);
Error messages should be more elaborate, so a user can understand it.
Ack
Patch Set #14, Line 52: printk(BIOS_ERR, "dsi init fail\n");
Maybe? […]
Ack
Patch Set #14, Line 93: /* Exported Functions */
Are these comments neeeded?
Ack
We have error codes in coreboot. […]
Ack
File src/mainboard/google/kukui/mainboard.c:
boolean or the coreboot CB_SUCCESS/ERROR enums.
Done
File src/mainboard/google/kukui/panel_kukui.c:
Patch Set #14, Line 34: .name = "768x1024@60Hz",
Isn’t it landscape?
Ack
To view, visit change 32511. To unsubscribe, or for help writing mail filters, visit settings.