View Change

2 comments:

• File src/mainboard/google/kukui/panel.h:

  • Patch Set #38, Line 32: _INIT_DCS_CMD

    Let's not start the thing that we actually want to use in the panel file with an underscore (underscores are for intermediary macros hidden away in some header). I'd either just call this something else (e.g. INIT_DCS() or PANEL_INIT_DCS or something) or rename the integer constant (e.g. call the macro INIT_DCS_CMD() and the constant INIT_DCS_CMD_OPCODE or something).

  • Patch Set #38, Line 34: .len = sizeof((u8[]){__VA_ARGS__}), \

    Nice, that's way more clever than what I said!

To view, visit change 32511. To unsubscribe, or for help writing mail filters, visit settings.