coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[S] Change in coreboot[main]: mb/google/nissa/var/telith: Support x32 memory configuration
by Qinghong Zeng (Code Review) 11 Apr '25

11 Apr '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kun Liu, Nick Vaccaro, Subrata Banik. Qinghong Zeng has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/87212?usp=email ) Change subject: mb/google/nissa/var/telith: Support x32 memory configuration ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I969fea2aba858f76870c1a31ad4bd884ec9b6ff3 Gerrit-Change-Number: 87212 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 01:49:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/glassway: Support Memory Hynix H58G56CK8BX146
by Subrata Banik (Code Review) 11 Apr '25

11 Apr '25

Attention is currently required from: Daniel Peng, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro. Subrata Banik has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/87252?usp=email ) Change subject: mb/google/nissa/var/glassway: Support Memory Hynix H58G56CK8BX146 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d6bbb778e75f6f32012e0cf6f427101d3616246 Gerrit-Change-Number: 87252 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 01:47:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/glassway: Support Memory Hynix H58G56CK8BX146
by Daniel Peng (Code Review) 11 Apr '25

11 Apr '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Daniel Peng has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/87252?usp=email ) Change subject: mb/google/nissa/var/glassway: Support Memory Hynix H58G56CK8BX146 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi Googler, Kindly ping to review the CL if no concern. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/87252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d6bbb778e75f6f32012e0cf6f427101d3616246 Gerrit-Change-Number: 87252 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 11 Apr 2025 01:45:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/telith: Support x32 memory configuration
by Kun Liu (Code Review) 11 Apr '25

11 Apr '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kun Liu, Nick Vaccaro, Qinghong Zeng, Subrata Banik. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87212?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Qinghong Zeng, Verified+1 by build bot (Jenkins) Change subject: mb/google/nissa/var/telith: Support x32 memory configuration ...................................................................... mb/google/nissa/var/telith: Support x32 memory configuration Use GPP_E19 level to determine whether x32 memory configuration is supported. BUG=b:405303038 TEST=emerge-nissa coreboot chromeos-bootimage Change-Id: I969fea2aba858f76870c1a31ad4bd884ec9b6ff3 Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/telith/Makefile.mk M src/mainboard/google/brya/variants/telith/gpio.c A src/mainboard/google/brya/variants/telith/memory.c 4 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/87212/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I969fea2aba858f76870c1a31ad4bd884ec9b6ff3 Gerrit-Change-Number: 87212 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>

1 0

[L] Change in coreboot[main]: mb/intel/ptlrvp: Introduce PTL RVP External and Internal EC Configura...
by Jérémy Compostella (Code Review) 11 Apr '25

11 Apr '25

Attention is currently required from: Bora Guvendik, Jamie Ryu, Zhixing Ma. Jérémy Compostella has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/86991?usp=email ) Change subject: mb/intel/ptlrvp: Introduce PTL RVP External and Internal EC Configurations ...................................................................... Patch Set 11: (6 comments) File src/mainboard/intel/ptlrvp/Kconfig: https://review.coreboot.org/c/coreboot/+/86991/comment/ea3bcddb_1b549f03?us… : PS11, Line 61: P_EXT_EC Could it be `BOARD_INTEL_PTLRVP_GOOGLE_CHROMEEC` ? File src/mainboard/intel/ptlrvp/Kconfig.name: https://review.coreboot.org/c/coreboot/+/86991/comment/08c82bb7_8eda149d?us… : PS11, Line 9: Ptlrvp External EC Google Chrome EC File src/mainboard/intel/ptlrvp/chromeos.c: https://review.coreboot.org/c/coreboot/+/86991/comment/211a10e2_f52d2ee8?us… : PS11, Line 27: int get_lid_switch(void) In an effort to limit file differences with fatcat, I would suggest a dedicated C file like non_google.c to hold those, or something even more suitable. What do you think? File src/mainboard/intel/ptlrvp/ec.c: https://review.coreboot.org/c/coreboot/+/86991/comment/da8791a9_b4b3c7ed?us… : PS11, Line 24: google_chromeec_events_init Could we have defined as a stub in my suggested non_intel.c source file? File src/mainboard/intel/ptlrvp/smihandler.c: https://review.coreboot.org/c/coreboot/+/86991/comment/e9fcb0b9_1fffc2df?us… : PS11, Line 10: void mainboard_smi_sleep(u8 slp_typ) Could we have a non_chromeec_smihandler.c compiled instead ? File src/mainboard/intel/ptlrvp/variants/baseboard/ptlrvp/ramstage.c: https://review.coreboot.org/c/coreboot/+/86991/comment/01fcef90_83b130c5?us… : PS11, Line 55: EC_GOOGLE_CHROMEEC Couldn't we just skip compiling this file is not EC_GOOGLE_CHROMEEC ? -- To view, visit https://review.coreboot.org/c/coreboot/+/86991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic3e40f2a19d7ed4f7a16e6e516a284a9a778b9fd Gerrit-Change-Number: 86991 Gerrit-PatchSet: 11 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Comment-Date: Thu, 10 Apr 2025 22:31:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mb/intel/ptlrvp: Introduce PTL RVP External and Internal EC Configura...
by Jérémy Compostella (Code Review) 11 Apr '25

11 Apr '25

1 0

[S] Change in coreboot[main]: ec/intel: read board ID one time from EC per stage
by Jérémy Compostella (Code Review) 11 Apr '25

11 Apr '25

Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Wonkyu Kim. Jérémy Compostella has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/87247?usp=email ) Change subject: ec/intel: read board ID one time from EC per stage ...................................................................... Patch Set 8: Code-Review+1 (1 comment) File src/ec/intel/board_id.c: https://review.coreboot.org/c/coreboot/+/87247/comment/3cc4d16d_c2c8f024?us… : PS8, Line 35: WinEC nit: WindowsEC -- To view, visit https://review.coreboot.org/c/coreboot/+/87247?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I166ca1abdf7838f91319d0bcf11354055ed93eef Gerrit-Change-Number: 87247 Gerrit-PatchSet: 8 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Comment-Date: Thu, 10 Apr 2025 22:09:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: ec/intel: read board ID one time from EC per stage
by Wonkyu Kim (Code Review) 11 Apr '25

11 Apr '25

Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Wonkyu Kim. Hello Bora Guvendik, Cliff Huang, Jamie Ryu, Jérémy Compostella, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87247?usp=email to look at the new patch set (#9). Change subject: ec/intel: read board ID one time from EC per stage ...................................................................... ec/intel: read board ID one time from EC per stage Using static variables to store the board ID optimizes boot time by reading the ID once per stage and retaining it for subsequent use. This approach reduces redundant hardware access, ensuring efficient and consistent retrieval of the board ID throughout the boot process. Static variables help streamline operations, minimize overhead, and improve performance by maintaining the board ID in a fixed memory location, enhancing the efficiency of each boot stage. Rewrite function to avoid unnecessary ChromeEC wrapper function. Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com> Change-Id: I166ca1abdf7838f91319d0bcf11354055ed93eef --- M src/ec/intel/board_id.c 1 file changed, 31 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/87247/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/87247?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I166ca1abdf7838f91319d0bcf11354055ed93eef Gerrit-Change-Number: 87247 Gerrit-PatchSet: 9 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>

1 0

[L] Change in coreboot[main]: mb/intel/ptlrvp: Introduce PTL RVP External and Internal EC Configura...
by Bora Guvendik (Code Review) 11 Apr '25

11 Apr '25

Attention is currently required from: Jamie Ryu, Jérémy Compostella, Zhixing Ma. Bora Guvendik has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/86991?usp=email ) Change subject: mb/intel/ptlrvp: Introduce PTL RVP External and Internal EC Configurations ...................................................................... Patch Set 11: (1 comment) File src/mainboard/intel/ptlrvp/chromeos.c: https://review.coreboot.org/c/coreboot/+/86991/comment/d18edfc7_f1766ec4?us… : PS5, Line 29: /* Lid always open */ > > `code indent should use tabs where possible` […] Jeremy I thought I fixed this already between patchset 6 and 7. Am I missing something? https://review.coreboot.org/c/coreboot/+/86991/6..7/src/mainboard/intel/ptl… -- To view, visit https://review.coreboot.org/c/coreboot/+/86991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic3e40f2a19d7ed4f7a16e6e516a284a9a778b9fd Gerrit-Change-Number: 86991 Gerrit-PatchSet: 11 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Thu, 10 Apr 2025 22:07:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[S] Change in coreboot[main]: ec/intel: read board ID one time from EC per stage
by Jérémy Compostella (Code Review) 11 Apr '25

11 Apr '25

Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Wonkyu Kim. Jérémy Compostella has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/87247?usp=email ) Change subject: ec/intel: read board ID one time from EC per stage ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87247?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I166ca1abdf7838f91319d0bcf11354055ed93eef Gerrit-Change-Number: 87247 Gerrit-PatchSet: 8 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Comment-Date: Thu, 10 Apr 2025 22:07:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025