coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[S] Change in coreboot[main]: mb/google/nissa/var/telith: Support x32 memory configuration
by Jayvik Desai (Code Review) 11 Apr '25

11 Apr '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kun Liu, Nick Vaccaro, Subrata Banik. Jayvik Desai has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/87212?usp=email ) Change subject: mb/google/nissa/var/telith: Support x32 memory configuration ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I969fea2aba858f76870c1a31ad4bd884ec9b6ff3 Gerrit-Change-Number: 87212 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 06:11:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Increase heap size for high-quality FW splash
by Jayvik Desai (Code Review) 10 Apr '25

10 Apr '25

Attention is currently required from: Intel coreboot Reviewers, Pranava Y N, Subrata Banik. Jayvik Desai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87265?usp=email ) Change subject: soc/intel/pantherlake: Increase heap size for high-quality FW splash ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87265?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I850247befc3904b6dc52e9872e8b99d53c2c9564 Gerrit-Change-Number: 87265 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 05:55:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Increase heap size for high-quality FW splash
by Kapil Porwal (Code Review) 10 Apr '25

10 Apr '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Pranava Y N, Subrata Banik. Kapil Porwal has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87265?usp=email ) Change subject: soc/intel/pantherlake: Increase heap size for high-quality FW splash ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87265?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I850247befc3904b6dc52e9872e8b99d53c2c9564 Gerrit-Change-Number: 87265 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 05:35:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/telith: Support x32 memory configuration
by Kapil Porwal (Code Review) 10 Apr '25

10 Apr '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kun Liu, Nick Vaccaro, Subrata Banik. Kapil Porwal has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/87212?usp=email ) Change subject: mb/google/nissa/var/telith: Support x32 memory configuration ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I969fea2aba858f76870c1a31ad4bd884ec9b6ff3 Gerrit-Change-Number: 87212 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 04:50:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree
by Subrata Banik (Code Review) 10 Apr '25

10 Apr '25

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86747?usp=email ) ( 8 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree ...................................................................... mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree Update devicetree to support Realtek ALC1320 codec. The ALC1320 soundwire class_id is MIPI_CLASS_SDCA(1). BUG=b:378629979 TEST=emerge-fatcat coreboot check the ssdt dump PCI0.HDAS.SNDW including 0x000331025D132001 Change-Id: Ie8763888810f56eb45523e3bcf7ef082900b1225 Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86747 Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Mac Chiang <mac.chiang(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jayvik Desai <jayvik(a)google.com> Reviewed-by: Pranava Y N <pranavayn(a)google.com> --- M src/mainboard/google/fatcat/Kconfig M src/mainboard/google/fatcat/variants/felino/overridetree.cb 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Pranava Y N: Looks good to me, approved build bot (Jenkins): Verified Mac Chiang: Looks good to me, but someone else must approve Kapil Porwal: Looks good to me, approved Jayvik Desai: Looks good to me, approved diff --git a/src/mainboard/google/fatcat/Kconfig b/src/mainboard/google/fatcat/Kconfig index 08a5eba..d24f3c0 100644 --- a/src/mainboard/google/fatcat/Kconfig +++ b/src/mainboard/google/fatcat/Kconfig @@ -84,6 +84,7 @@ select BOARD_GOOGLE_BASEBOARD_FATCAT select FSP_UGOP_EARLY_SIGN_OF_LIFE select HAVE_SLP_S0_GATE + select DRIVERS_SOUNDWIRE_ALC1320 select MAINBOARD_HAS_GOOGLE_STRAUSS_KEYBOARD config BOARD_GOOGLE_FRANCKA diff --git a/src/mainboard/google/fatcat/variants/felino/overridetree.cb b/src/mainboard/google/fatcat/variants/felino/overridetree.cb index 29a178d..ff7d07a 100644 --- a/src/mainboard/google/fatcat/variants/felino/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/felino/overridetree.cb @@ -297,6 +297,13 @@ register "alc711_address.part_id" = "MIPI_DEV_ID_REALTEK_ALC712" device generic 3.0 on end # SoundWire Link 3 ID 0 end + chip drivers/soundwire/alc1320 + register "desc" = ""Speaker Amp"" + register "alc1320_address.version" = "SOUNDWIRE_VERSION_1_2" + register "alc1320_address.class" = "MIPI_CLASS_SDCA" + register "alc1320_address.part_id" = "MIPI_DEV_ID_REALTEK_ALC1320" + device generic 3.1 on end # SoundWire Link 3 ID 1 + end end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/86747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8763888810f56eb45523e3bcf7ef082900b1225 Gerrit-Change-Number: 86747 Gerrit-PatchSet: 15 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: drivers/soundwire/alc1320: use common struct to set soundwire ADDR_
by Subrata Banik (Code Review) 10 Apr '25

10 Apr '25

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86939?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: drivers/soundwire/alc1320: use common struct to set soundwire ADDR_ ...................................................................... drivers/soundwire/alc1320: use common struct to set soundwire ADDR_ Add common soundwire address struct for acpi table configuration over overridetree. refer to: commit 2411942a0518 ("drivers/soundwire/alc711: Add common Kconfig for ALC7xx soundwire codecs") BUG=b:378629979 TEST=emerge-fatcat coreboot check the ssdt dump PCI0.HDAS.SNDW has address: 0x000331025D132001 Change-Id: I2d3531eef6adf21a28a26dcc3ac1bb7830877905 Signed-off-by: Mac Chiang <mac.chiang(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86939 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Reviewed-by: Pranava Y N <pranavayn(a)google.com> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/drivers/soundwire/alc1320/alc1320.c M src/drivers/soundwire/alc1320/chip.h 2 files changed, 8 insertions(+), 10 deletions(-) Approvals: Weimin Wu: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified Pranava Y N: Looks good to me, approved diff --git a/src/drivers/soundwire/alc1320/alc1320.c b/src/drivers/soundwire/alc1320/alc1320.c index 1362675..10c58e1 100644 --- a/src/drivers/soundwire/alc1320/alc1320.c +++ b/src/drivers/soundwire/alc1320/alc1320.c @@ -10,13 +10,6 @@ #include "chip.h" -static struct soundwire_address alc1320_address = { - .version = SOUNDWIRE_VERSION_1_2, - .manufacturer_id = MIPI_MFG_ID_REALTEK, - .part_id = MIPI_DEV_ID_REALTEK_ALC1320, - .class = MIPI_CLASS_NONE -}; - static struct soundwire_slave alc1320_slave = { .wake_up_unavailable = false, .test_mode_supported = false, @@ -106,10 +99,11 @@ acpigen_write_device(acpi_device_name(dev)); /* Set codec address IDs. */ - alc1320_address.link_id = dev->path.generic.id; - alc1320_address.unique_id = dev->path.generic.subid; + config->alc1320_address.link_id = dev->path.generic.id; + config->alc1320_address.unique_id = dev->path.generic.subid; + config->alc1320_address.manufacturer_id = MIPI_MFG_ID_REALTEK; - acpigen_write_ADR_soundwire_device(&alc1320_address); + acpigen_write_ADR_soundwire_device(&config->alc1320_address); acpigen_write_name_string("_DDN", config->desc ? : dev->chip_ops->name); acpigen_write_STA(acpi_device_status(dev)); diff --git a/src/drivers/soundwire/alc1320/chip.h b/src/drivers/soundwire/alc1320/chip.h index 028c200..4278aef 100644 --- a/src/drivers/soundwire/alc1320/chip.h +++ b/src/drivers/soundwire/alc1320/chip.h @@ -3,9 +3,13 @@ #ifndef __DRIVERS_SOUNDWIRE_ALC1320_CHIP_H__ #define __DRIVERS_SOUNDWIRE_ALC1320_CHIP_H__ +#include <device/soundwire.h> +#include <mipi/ids.h> + struct drivers_soundwire_alc1320_config { const char *name; const char *desc; + struct soundwire_address alc1320_address; }; #endif /* __DRIVERS_SOUNDWIRE_ALC1320_CHIP_H__ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/86939?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d3531eef6adf21a28a26dcc3ac1bb7830877905 Gerrit-Change-Number: 86939 Gerrit-PatchSet: 9 Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree
by Mac Chiang (Code Review) 10 Apr '25

10 Apr '25

Attention is currently required from: Paul Menzel, Subrata Banik, Weimin Wu. Mac Chiang has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/86747?usp=email ) Change subject: mb/google/fatcat/var/felino: Add ALC1320 codec to devicetree ...................................................................... Patch Set 14: Code-Review+1 (1 comment) Patchset: PS12: > yes, need rebase to https://review.coreboot.org/c/coreboot/+/86939. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8763888810f56eb45523e3bcf7ef082900b1225 Gerrit-Change-Number: 86747 Gerrit-PatchSet: 14 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 03:44:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: Update arm-trusted-firmware submodule to upstream master
by Yidi Lin (Code Review) 10 Apr '25

10 Apr '25

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87269?usp=email ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Update arm-trusted-firmware submodule to upstream master Updating from commit id e5a1f4abeec3: 2025-03-03 16:21:54 +0100 - (Merge "feat(mt8196): fix MT8196 gpio driver" into integration) to commit id 57ac3f74b34a: 2025-04-09 20:07:35 +0200 - (Merge "feat(stm32mp15-fdts): add Linux Automation GmbH TAC" into integration) This brings in 244 new commits. Change-Id: I22ec128c99e84fd80fbc7de06f2791c627ae790a Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M 3rdparty/arm-trusted-firmware 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/87269/1 diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware index e5a1f4a..57ac3f7 160000 --- a/3rdparty/arm-trusted-firmware +++ b/3rdparty/arm-trusted-firmware @@ -1 +1 @@ -Subproject commit e5a1f4abeec3311e65412a2905873a110a9abdd1 +Subproject commit 57ac3f74b34a3303f03deee264a1f2247c68008d -- To view, visit https://review.coreboot.org/c/coreboot/+/87269?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I22ec128c99e84fd80fbc7de06f2791c627ae790a Gerrit-Change-Number: 87269 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: util/scripts/update_submodules: Fix "branch: unbound variable" error
by Yidi Lin (Code Review) 10 Apr '25

10 Apr '25

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87268?usp=email ) Change subject: util/scripts/update_submodules: Fix "branch: unbound variable" error ...................................................................... util/scripts/update_submodules: Fix "branch: unbound variable" error After CB:86803, ${branch} variable is no longer valid. Use ${branch_name} instead ${branch} for generating the commit message. TEST=./util/scripts/update_submodules -R 3rdparty/arm-trusted-firmware/ The script generates the new commit successfully. Change-Id: Ia528379b8721e6d419984bab28de7cf427e42423 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M util/scripts/update_submodules 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/87268/1 diff --git a/util/scripts/update_submodules b/util/scripts/update_submodules index cbf2364..9eeb383 100755 --- a/util/scripts/update_submodules +++ b/util/scripts/update_submodules @@ -132,7 +132,7 @@ cd "${TOP}" || exit 1 git add "${submodule}" > /dev/null 2>&1 || exit 1 git commit -s -F- > /dev/null 2>&1 <<-EOF - Update ${submodule##*/} submodule to upstream ${branch##*/} + Update ${submodule##*/} submodule to upstream ${branch_name##*/} Updating from commit id ${initial_commit_id}: $initial_commit_description -- To view, visit https://review.coreboot.org/c/coreboot/+/87268?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia528379b8721e6d419984bab28de7cf427e42423 Gerrit-Change-Number: 87268 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com>

1 0

[L] Change in coreboot[main]: Documentation/lib: Update Timestamp documentation
by Martin L Roth (Code Review) 10 Apr '25

10 Apr '25

Martin L Roth has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/87186?usp=email ) Change subject: Documentation/lib: Update Timestamp documentation ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Thanks for the feedback! -- To view, visit https://review.coreboot.org/c/coreboot/+/87186?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6e4cc244edf6cc860cc66165173f134a30a81589 Gerrit-Change-Number: 87186 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Apr 2025 02:49:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025