Attention is currently required from: Yidi Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/87226?usp=email )
Change subject: util/mediatek: Add check-pi-img.py
......................................................................
Patch Set 2:
(1 comment)
File util/mediatek/check-pi-img.py:
https://review.coreboot.org/c/coreboot/+/87226/comment/9356eb05_9177c869?us… :
PS2, Line 24: {} cookies found
Maybe extend the error message, that exactly two cookies need to be present.
--
To view, visit https://review.coreboot.org/c/coreboot/+/87226?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I27011492c7fab747aa3ee12d514d20a6a52d0a4d
Gerrit-Change-Number: 87226
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 06:46:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Alok Agarwal has posted comments on this change by Alok Agarwal. ( https://review.coreboot.org/c/coreboot/+/86949?usp=email )
Change subject: src/soc/intel/pantherlake: Adopt the MEMORY_INFO_DATA_HOB.
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/86949?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1f7ee111e299ef53795912f80b444c07facde11e
Gerrit-Change-Number: 86949
Gerrit-PatchSet: 4
Gerrit-Owner: Alok Agarwal <alok.agarwal(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 11 Apr 2025 06:45:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Maxim Polyakov, Nicholas Chin, Yidi Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/87224?usp=email )
Change subject: Documentation,util: Run util_readme.sh to regen *.md
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/87224?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3d3f87517c445d650e9cea61448b28d005d46737
Gerrit-Change-Number: 87224
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 06:44:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Nick Vaccaro, Subrata Banik.
Daniel Peng has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/87235?usp=email )
Change subject: mb/google/brya/var/guren: Add Stylus Pen Function
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Kindly ping to submit if no concern. Wait for CL[1] to be merged first. Thanks.
[1]: https://review.coreboot.org/c/coreboot/+/87238
--
To view, visit https://review.coreboot.org/c/coreboot/+/87235?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46d679d29b35d0f4fc70d63b74975d3bdfc40b7b
Gerrit-Change-Number: 87235
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Fri, 11 Apr 2025 06:42:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Brian Hsu, Dinesh Gehlot, Jayvik Desai, Nick Vaccaro, Subrata Banik.
Daniel Peng has posted comments on this change by Brian Hsu. ( https://review.coreboot.org/c/coreboot/+/87238?usp=email )
Change subject: mb/google/nissa/var/guren: Add touch screen FTSC1000 support
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Patchset:
PS5:
Kindly ping to submit if no concern. Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/87238?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icfe5f57c69d1bd98e0852a1aa3baed8c1444e4d9
Gerrit-Change-Number: 87238
Gerrit-PatchSet: 5
Gerrit-Owner: Brian Hsu <brian_hsu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Li <david_li(a)pegatron.corp-partner.google.com>
Gerrit-CC: Samuel Chen <samuel_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Brian Hsu <brian_hsu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Fri, 11 Apr 2025 06:40:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Martin L Roth.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86975?usp=email )
Change subject: util/crossgcc: Upgrade CMake from 3.31.3 to 4.0.0
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Jenkins or/and something is broken.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86975?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46f63e0b6c41f871ccff2454b2db8b99b765d4f5
Gerrit-Change-Number: 86975
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 06:32:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Daniel Peng, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro.
Jayvik Desai has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/87252?usp=email )
Change subject: mb/google/nissa/var/glassway: Support Memory Hynix H58G56CK8BX146
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/87252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1d6bbb778e75f6f32012e0cf6f427101d3616246
Gerrit-Change-Number: 87252
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 06:21:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes