Attention is currently required from: Mac Chiang, Pranava Y N.
Paul Menzel has posted comments on this change by Mac Chiang. ( https://review.coreboot.org/c/coreboot/+/87237?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/fatcat/var/felino: Correct the DMIC1 function pin mapping
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87237/comment/132f6636_c1fba6bb?us… :
PS1, Line 9: The DMIC_CLK_A1 and DMIC_DAT_A1 function pins on GPP_D16 and GPP_D17
Please start by describing the problem.
https://review.coreboot.org/c/coreboot/+/87237/comment/0304e3ae_0694aba5?us… :
PS1, Line 9: The DMIC_CLK_A1 and DMIC_DAT_A1 function pins on GPP_D16 and GPP_D17
: are configured to NF3.
Why? According to what source?
--
To view, visit https://review.coreboot.org/c/coreboot/+/87237?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic73b43e6d58376e0c592ef4a1a9c9d9fc7e66928
Gerrit-Change-Number: 87237
Gerrit-PatchSet: 1
Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 07:28:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Alok Agarwal, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, Ronak Kanabar, srinivas.kulkarni(a)intel.com.
Hello Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, Ronak Kanabar, Subrata Banik, srinivas.kulkarni(a)intel.com,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86949?usp=email
to look at the new patch set (#5).
Change subject: soc/intel/pantherlake: Adopt the MEMORY_INFO_DATA_HOB
......................................................................
soc/intel/pantherlake: Adopt the MEMORY_INFO_DATA_HOB
Update MEMORY_INFO_DATA_HOB, child structures and their data for SMBIOS type 16/17 design change. Related changes of MEMORY_INFO_DATA_HOB are available from FSP 3103_05 onwards.
BUG=b:406375765
TEST=Verify that the updates to MEMORY_INFO_DATA_HOB and its child
structures for SMBIOS type 16/17 design change are correctly
integrated from FSP 3103_05 onwards. Ensure that the build process for
google/fatcat completes successfully without errors, confirming that
the build error in coreboot is resolved and able to boot.
Change-Id: I1f7ee111e299ef53795912f80b444c07facde11e
Signed-off-by: Alok Agarwal <alok.agarwal(a)intel.corp-partner.google.com>
---
M src/soc/intel/pantherlake/romstage/romstage.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/86949/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/86949?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1f7ee111e299ef53795912f80b444c07facde11e
Gerrit-Change-Number: 86949
Gerrit-PatchSet: 5
Gerrit-Owner: Alok Agarwal <alok.agarwal(a)intel.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: srinivas.kulkarni(a)intel.com
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Alok Agarwal <alok.agarwal(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Attention: srinivas.kulkarni(a)intel.com
Attention is currently required from: Mac Chiang, Pranava Y N.
Jayvik Desai has posted comments on this change by Mac Chiang. ( https://review.coreboot.org/c/coreboot/+/87237?usp=email )
Change subject: mb/google/fatcat/var/felino: Correct the DMIC1 function pin mapping
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/87237?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic73b43e6d58376e0c592ef4a1a9c9d9fc7e66928
Gerrit-Change-Number: 87237
Gerrit-PatchSet: 1
Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 07:19:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Alok Agarwal, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, Ronak Kanabar, srinivas.kulkarni(a)intel.com.
Subrata Banik has posted comments on this change by Alok Agarwal. ( https://review.coreboot.org/c/coreboot/+/86949?usp=email )
Change subject: src/soc/intel/pantherlake: Adopt the MEMORY_INFO_DATA_HOB.
......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86949/comment/9c1ce02e_fbc73185?us… :
PS4, Line 7: src
remove `src`
https://review.coreboot.org/c/coreboot/+/86949/comment/23bb1d28_dc9cc9cd?us… :
PS4, Line 7: .
no `.` in title
https://review.coreboot.org/c/coreboot/+/86949/comment/90b671f7_85fb6912?us… :
PS4, Line 8:
: Update MEMORY_INFO_DATA_HOB, child structures and their data for SMBIOS type 16/17 design change.
:
wrap up text
https://review.coreboot.org/c/coreboot/+/86949/comment/00dfd783_85ed04eb?us… :
PS4, Line 11: 406375765
please file a bug to understand this failure better. IMO, this is due to change in mem info data hob which is part of the new FSP release. There is no value to change the code unless we first land the FSP headers.
https://review.coreboot.org/c/coreboot/+/86949/comment/588b918e_c4e482aa?us… :
PS4, Line 12: Able to build google/fatcat.
Use a meaningful TEST message to explain what issue this CL resolves.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86949?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1f7ee111e299ef53795912f80b444c07facde11e
Gerrit-Change-Number: 86949
Gerrit-PatchSet: 4
Gerrit-Owner: Alok Agarwal <alok.agarwal(a)intel.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: srinivas.kulkarni(a)intel.com
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Alok Agarwal <alok.agarwal(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Attention: srinivas.kulkarni(a)intel.com
Gerrit-Comment-Date: Fri, 11 Apr 2025 06:59:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Alok Agarwal.
Alok Agarwal has posted comments on this change by Alok Agarwal. ( https://review.coreboot.org/c/coreboot/+/87000?usp=email )
Change subject: vc/intel/fsp/ptl: Update header files from FSP 3071_00 to FSP 3103_05
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/87000?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I054e419ef23ada67347750e7a68014c2bb112199
Gerrit-Change-Number: 87000
Gerrit-PatchSet: 3
Gerrit-Owner: Alok Agarwal <alok.agarwal(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Alok Agarwal <alok.agarwal(a)intel.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 06:54:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Julius Werner, Kapil Porwal, Paul Menzel.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87271?usp=email )
Change subject: soc/qualcomm: Use runtime check for QUP wrapper 2 init
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87271/comment/2e3efe51_ab8e1efa?us… :
PS1, Line 10: Added
> Add
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/87271?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I553ee4891abc5dd744b69bcbee1cca2efd993ef3
Gerrit-Change-Number: 87271
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 11 Apr 2025 06:51:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Julius Werner, Kapil Porwal, Subrata Banik.
Hello Julius Werner, Kapil Porwal, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/87271?usp=email
to look at the new patch set (#2).
Change subject: soc/qualcomm: Use runtime check for QUP wrapper 2 init
......................................................................
soc/qualcomm: Use runtime check for QUP wrapper 2 init
Refactor the initialization logic for the optional QUPv3 wrapper 2.
Add a runtime check of the `QUP_WRAP2_BASE` macro's value within
`qupv3_fw_init`.
This approach simplifies the QUP wrapper 2 initialization, making the
code flow depend directly on whether a valid base address is defined
for the target SoC.
To facilitate this, explicitly define `QUP_WRAP2_BASE` as 0 (acting as
a dummy entry) for SoCs like sc7180 and sc7280 which do not include
this hardware block. The `if (QUP_WRAP2_BASE)` check will correctly
evaluate to false for these platforms, skipping the initialization.
Platforms that do have QUP wrapper 2 should define its non-zero base
address.
TEST=Able to build google/herobine.
Change-Id: I553ee4891abc5dd744b69bcbee1cca2efd993ef3
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M src/soc/qualcomm/common/qupv3_config.c
M src/soc/qualcomm/sc7180/include/soc/addressmap.h
M src/soc/qualcomm/sc7280/include/soc/addressmap.h
3 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/87271/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/87271?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I553ee4891abc5dd744b69bcbee1cca2efd993ef3
Gerrit-Change-Number: 87271
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Yidi Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/87226?usp=email )
Change subject: util/mediatek: Add check-pi-img.py
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87226/comment/b7693ee6_c45bd689?us… :
PS2, Line 9: Add a script to perform validity check of the PI_IMG firmware.
For ignorants like me:
> According to document X, the firmware needs to have exactly two “cookies” after some offset.
--
To view, visit https://review.coreboot.org/c/coreboot/+/87226?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I27011492c7fab747aa3ee12d514d20a6a52d0a4d
Gerrit-Change-Number: 87226
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 06:47:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No