Attention is currently required from: Felix Singer, Harrie Paijmans, Maxim Polyakov.
Erik van den Bogaert has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/87198?usp=email )
Change subject: superio/fintek: Add support for f81966d
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/87198?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibe3987b6e15eb07b92d7f5a7de2bd511de85e2f7
Gerrit-Change-Number: 87198
Gerrit-PatchSet: 4
Gerrit-Owner: Harrie Paijmans <hpaijmans(a)eltan.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Harrie Paijmans <hpaijmans(a)eltan.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 09:02:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Erik van den Bogaert, Felix Singer, Maxim Polyakov.
Frans Hendriks has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/87198?usp=email )
Change subject: superio/fintek: Add support for f81966d
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/87198?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibe3987b6e15eb07b92d7f5a7de2bd511de85e2f7
Gerrit-Change-Number: 87198
Gerrit-PatchSet: 4
Gerrit-Owner: Harrie Paijmans <hpaijmans(a)eltan.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 09:00:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Erik van den Bogaert, Felix Singer, Frans Hendriks, Maxim Polyakov.
Harrie Paijmans has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/87198?usp=email )
Change subject: superio/fintek: Add support for f81966d
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87198/comment/f8fddc09_ed496ca4?us… :
PS2, Line 16: TEST
> Please add information about this in the commit message TEST=.... […]
changed to verified with 'superiotool -de'
File src/superio/fintek/f81966d/f81966d_hwm.c:
https://review.coreboot.org/c/coreboot/+/87198/comment/e3439610_c3c6e9b6?us… :
PS3, Line 27: pnp_enter_conf_mode(dev);
> There is no need to set the configuration mode for HWM, doesn't break initialization, it's just not […]
Yes the indexed writes don't need unlocking. So can be safely removed.
Verified the change with 'superiotool -de' and writing non default 'hwm_amd_tsi_addr' functions as expected.
--
To view, visit https://review.coreboot.org/c/coreboot/+/87198?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibe3987b6e15eb07b92d7f5a7de2bd511de85e2f7
Gerrit-Change-Number: 87198
Gerrit-PatchSet: 4
Gerrit-Owner: Harrie Paijmans <hpaijmans(a)eltan.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 08:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Comment-In-Reply-To: Harrie Paijmans <hpaijmans(a)eltan.com>
Attention is currently required from: Erik van den Bogaert, Felix Singer, Frans Hendriks, Harrie Paijmans, Maxim Polyakov.
Hello Erik van den Bogaert, Felix Singer, Frans Hendriks, Maxim Polyakov, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/87198?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+2 by Frans Hendriks, Code-Review+2 by Maxim Polyakov, Verified+1 by build bot (Jenkins)
Change subject: superio/fintek: Add support for f81966d
......................................................................
superio/fintek: Add support for f81966d
This patch adds support for the Fintek f81966d SuperIO,
which is very similar to the fintek/f81866d.
Datasheet:
- Name: F81966D/A, Release Date: Oct 2023, Version: V0.21P
BUG=NA
TEST=Customer platform with F81966D, verified with 'superiotool -de'
Change-Id: Ibe3987b6e15eb07b92d7f5a7de2bd511de85e2f7
Signed-off-by: Harrie Paijmans <hpaijmans(a)eltan.com>
---
M src/superio/fintek/Makefile.mk
A src/superio/fintek/f81966d/Kconfig
A src/superio/fintek/f81966d/Makefile.mk
A src/superio/fintek/f81966d/chip.h
A src/superio/fintek/f81966d/f81966d.h
A src/superio/fintek/f81966d/f81966d_gpio.c
A src/superio/fintek/f81966d/f81966d_hwm.c
A src/superio/fintek/f81966d/f81966d_uart.c
A src/superio/fintek/f81966d/fintek_internal.h
A src/superio/fintek/f81966d/superio.c
10 files changed, 575 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/87198/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/87198?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibe3987b6e15eb07b92d7f5a7de2bd511de85e2f7
Gerrit-Change-Number: 87198
Gerrit-PatchSet: 4
Gerrit-Owner: Harrie Paijmans <hpaijmans(a)eltan.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Harrie Paijmans <hpaijmans(a)eltan.com>
Attention is currently required from: Julius Werner, Subrata Banik.
Kapil Porwal has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87270?usp=email )
Change subject: soc/qualcomm/common: Avoid hardcoding SPI bus from QUP range
......................................................................
Patch Set 1:
(1 comment)
File src/soc/qualcomm/common/spi.c:
https://review.coreboot.org/c/coreboot/+/87270/comment/306417aa_eba5d98b?us… :
PS1, Line 32: CONFIG_BOOT_DEVICE_SPI_FLASH_BUS
Can we use `QUPV3_SE_MAX` here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/87270?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e9ec555a6d72d93bc23285e48eab52030978e1a
Gerrit-Change-Number: 87270
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 11 Apr 2025 08:50:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/87226?usp=email )
Change subject: util/mediatek: Add check-pi-img.py
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/87226?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I27011492c7fab747aa3ee12d514d20a6a52d0a4d
Gerrit-Change-Number: 87226
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 08:47:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Erik van den Bogaert, Frans Hendriks, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Harrie Paijmans has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/87243?usp=email )
Change subject: device/pci_ids: Add Amston Lake CPU IDs
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87243/comment/86af3115_dd9f869e?us… :
PS2, Line 7: Amstonlake
> Amston Lake
done
https://review.coreboot.org/c/coreboot/+/87243/comment/9f5a95ff_b9914a85?us… :
PS2, Line 13: Alderlake
> Alder Lake
done
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/87243/comment/6dfa3d4a_9b1a9683?us… :
PS2, Line 4430: #define PCI_DID_INTEL_ASL_ID_1 0x4675
: #define PCI_DID_INTEL_ASL_ID_2 0x4674
: #define PCI_DID_INTEL_ASL_ID_3 0x4632
> Is the mapping 1 to 0x4675 from the datasheet, or could the smaller number 0x4632 be 1?
The mapping was done in the order of the datasheet.
I changed the order to be inline with the other ID's in the source.
--
To view, visit https://review.coreboot.org/c/coreboot/+/87243?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia43945887e7d536b5b7387a4dda4e245973c27ee
Gerrit-Change-Number: 87243
Gerrit-PatchSet: 3
Gerrit-Owner: Harrie Paijmans <hpaijmans(a)eltan.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Fri, 11 Apr 2025 08:44:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>