Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/86152?usp=email )
Change subject: soc/intel/cmn/blk/include/intelblock: Use bit field for cse status
......................................................................
Patch Set 8:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86152?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e4f240c71dc5a8847726dc5b5f4be75f0cb54c9
Gerrit-Change-Number: 86152
Gerrit-PatchSet: 8
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 29 Mar 2025 20:57:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Intel coreboot Reviewers, Kapil Porwal, Subrata Banik.
Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/86153?usp=email )
Change subject: soc/intel/cmn/blk: Remove boot partition check for forced cse sync
......................................................................
Patch Set 13:
(4 comments)
This change is ready for review.
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/86153/comment/c51b2cfa_674d6baa?us… :
PS12, Line 748: if (!(CONFIG(VBOOT) && vboot_is_gbb_flag_set(VB2_GBB_FLAG_FORCE_CSE_SYNC)))
: return;
> shouldn't this logic be like either VBOOT not enable or GBB not set ? […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/86153/comment/87fbb503_fed3bf66?us… :
PS12, Line 755: //cse_info_in_cmos.cse_sync_status &= ~CSE_ENFORCED_SYNC_REQ;
> remove
Acknowledged
https://review.coreboot.org/c/coreboot/+/86153/comment/277557c1_7af87052?us… :
PS12, Line 765: is_cse_sync_enforced
> this is just prerequisite code that tells if CSE sync enforcement is required or not. […]
The ESOL screen function at romstage also calls `is_cse_sync_enforced()`. At that stage, the enforce CSE sync status flags have not been updated. Therefore, an update to these status flags is required.
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/86153/comment/1e4f6a7e_489d726d?us… :
PS12, Line 187: REQ
> write in full.
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/86153?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1e4180cb5fec3990fdee2b0e412173b1c8c6ded
Gerrit-Change-Number: 86153
Gerrit-PatchSet: 13
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Sat, 29 Mar 2025 20:57:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87046?usp=email )
Change subject: mb/starlabs/starbook/mtl: Add the option to enable the VPU
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/87046?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I747d85c6764e5affcc202e063abe7ec786d04e39
Gerrit-Change-Number: 87046
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Sat, 29 Mar 2025 20:34:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/87046?usp=email )
Change subject: mb/starlabs/starbook/mtl: Add the option to enable the VPU
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/87046?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I747d85c6764e5affcc202e063abe7ec786d04e39
Gerrit-Change-Number: 87046
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Sat, 29 Mar 2025 20:15:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Alexander Couzens, Krystian Hebel, Michał Żygowski, Paul Menzel.
Hello Alexander Couzens, Krystian Hebel, Michał Żygowski, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84873?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/lenovo/m900_tiny: Update VBT to build 1037 with Kaby Lake gfx support
......................................................................
mb/lenovo/m900_tiny: Update VBT to build 1037 with Kaby Lake gfx support
Update VBT to one extracted from newer Lenovo UEFI, version FWKTBFA.
The newer VBT has build number 1037 and supports Kaby Lake graphics,
while the old VBT with build number 1000 only supports Skylake.
The old VBT starts with $VBT_SKYLAKE while the new one starts with
$VBT_KABYLAKE.
TEST=Insert CPU with integrated HD 630 graphics (i3-7100) and check if
all video outputs work in firmware.
Change-Id: I5e108d4ad8bf0663f3e1fa32145e40ea9babeac5
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
---
M src/mainboard/lenovo/m900_tiny/data.vbt
A src/mainboard/lenovo/m900_tiny/vbt.new
A src/mainboard/lenovo/m900_tiny/vbt.old
3 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/84873/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/84873?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e108d4ad8bf0663f3e1fa32145e40ea9babeac5
Gerrit-Change-Number: 84873
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Attention is currently required from: Alexander Couzens, Krystian Hebel, Michał Żygowski, Paul Menzel.
Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/84873?usp=email )
Change subject: mb/lenovo/m900_tiny: Update VBT to build 1037 with Kaby Lake gfx support
......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84873/comment/1a6bbb11_faec5bd9?us… :
PS1, Line 7: Update VBT
> Maybe more specific: […]
Updated commit message (shortened to make it fit in 72 cols)
https://review.coreboot.org/c/coreboot/+/84873/comment/5068caf5_6b558686?us… :
PS1, Line 12: old VBT
> Which build number does this have?
Added to the commit message
https://review.coreboot.org/c/coreboot/+/84873/comment/0e8c3d7b_dee45f25?us… :
PS1, Line 12: supported
> supports
Done
https://review.coreboot.org/c/coreboot/+/84873/comment/4c48a1f6_68f515e6?us… :
PS1, Line 13:
> Did you analyze the differences in the VBT?
I've only verified that the old one starts with $VBT SKYLAKE, and the new one with $VBT KABYLAKE. I haven't analyzed all differences in VBT configuration, if there are any
https://review.coreboot.org/c/coreboot/+/84873/comment/3294ba2c_c7965736?us… :
PS1, Line 14: Change-Id: I5e108d4ad8bf0663f3e1fa32145e40ea9babeac5
> How did you test the patch?
Added TEST= line to the commit message
--
To view, visit https://review.coreboot.org/c/coreboot/+/84873?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e108d4ad8bf0663f3e1fa32145e40ea9babeac5
Gerrit-Change-Number: 84873
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sat, 29 Mar 2025 20:07:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Alexander Couzens, Krystian Hebel, Michał Kopeć, Michał Żygowski.
Hello Alexander Couzens, Krystian Hebel, Michał Żygowski, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84873?usp=email
to look at the new patch set (#3).
Change subject: mb/lenovo/m900_tiny: Update VBT to build 1037 with Kaby Lake gfx support
......................................................................
mb/lenovo/m900_tiny: Update VBT to build 1037 with Kaby Lake gfx support
Update VBT to one extracted from newer Lenovo UEFI, version FWKTBFA.
The newer VBT has build number 1037 and supports Kaby Lake graphics,
while the old VBT with build number 1000 only supports Skylake.
The old VBT starts with $VBT_SKYLAKE while the new one starts with
$VBT_KABYLAKE.
TEST=Insert CPU with integrated HD 630 graphics (i3-7100) and check it
all video outputs work in firmware.
Change-Id: I5e108d4ad8bf0663f3e1fa32145e40ea9babeac5
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
---
M src/mainboard/lenovo/m900_tiny/data.vbt
1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/84873/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/84873?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e108d4ad8bf0663f3e1fa32145e40ea9babeac5
Gerrit-Change-Number: 84873
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Attention is currently required from: Alexander Couzens, Maciej Pijanowski, Martin L Roth, Michał Kopeć, Michał Żygowski.
Hello Alexander Couzens, Maciej Pijanowski, Martin L Roth, Michał Żygowski, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84860?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+2 by Martin L Roth, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: mb/lenovo/m900_tiny: enable power LED blink in S3 and S4
......................................................................
mb/lenovo/m900_tiny: enable power LED blink in S3 and S4
The power LED may be disabled by GPP_D1. The pin is PWM capable, so
configure it in PWM mode with a frequency of 0.5Hz, duty cycle of 50%
when entering sleep.
The result is that the power LED toggles on/off every second.
TEST=Boot to Windows 10, enter S3, and wake. The power LED will blink
when system is asleep and glow continuously when awake.
Change-Id: I121e0ef3e47aec1cacdace3f2af47a3fdacf69cf
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
---
M src/mainboard/lenovo/m900_tiny/Makefile.mk
M src/mainboard/lenovo/m900_tiny/gpio.c
M src/mainboard/lenovo/m900_tiny/ramstage.c
A src/mainboard/lenovo/m900_tiny/smihandler.c
4 files changed, 33 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/84860/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/84860?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I121e0ef3e47aec1cacdace3f2af47a3fdacf69cf
Gerrit-Change-Number: 84860
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Attention is currently required from: Alexander Couzens, Krystian Hebel, Michał Kopeć, Michał Żygowski.
Hello Alexander Couzens, Krystian Hebel, Michał Żygowski, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84873?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/lenovo/m900_tiny: Update VBT to version 1037
......................................................................
mb/lenovo/m900_tiny: Update VBT to version 1037
Update VBT to one extracted from newer Lenovo UEFI, version FWKTBFA.
The newer VBT has build number 1037 and supports Kaby Lake graphics,
while the old VBT with build number 1000 only supports Skylake.
The old VBT starts with $VBT_SKYLAKE while the new one starts with
$VBT_KABYLAKE.
TEST=Insert CPU with integrated HD 630 graphics (i3-7100) and check it
all video outputs work in firmware.
Change-Id: I5e108d4ad8bf0663f3e1fa32145e40ea9babeac5
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
---
M src/mainboard/lenovo/m900_tiny/data.vbt
1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/84873/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84873?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e108d4ad8bf0663f3e1fa32145e40ea9babeac5
Gerrit-Change-Number: 84873
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Żygowski.
Hello Krystian Hebel, Maciej Pijanowski, Michał Żygowski,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/87044?usp=email
to look at the new patch set (#3).
Change subject: Documentation/mainboard/lenovo: Add ThinkCentre M700/M900 Tiny
......................................................................
Documentation/mainboard/lenovo: Add ThinkCentre M700/M900 Tiny
Heavily based on M710s documentation.
Change-Id: I8c3860ba6254919769082c9ed749f8bb287a5f5e
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/lenovo/thinkcentre_m900_tiny.md
A Documentation/mainboard/lenovo/thinkcentre_m900_tiny_spi_location.jpg
3 files changed, 89 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/87044/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/87044?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8c3860ba6254919769082c9ed749f8bb287a5f5e
Gerrit-Change-Number: 87044
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>