coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update MCUPM firmware to v1.2
by agogo (Code Review) 19 Feb '25

19 Feb '25

Attention is currently required from: Jarried Lin, Yu-Ping Wu, agogo. Hello Jarried Lin, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/86511?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Yu-Ping Wu Change subject: soc/mediatek/mt8196: Update MCUPM firmware to v1.2 ...................................................................... soc/mediatek/mt8196: Update MCUPM firmware to v1.2 Update coefficient for MCU-LVTS reboot temperature setting. TEST=NA BUG=b:317009620 BRANCH=rauru Change-Id: I81e745a7290c31fe15240102df0a78dfaadf54e7 Signed-off-by: Agogo Huang <agogo.huang(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/mcupm.bin M soc/mediatek/mt8196/mcupm.bin.md5 M soc/mediatek/mt8196/mcupm_release_notes.txt 3 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/11/86511/3 -- To view, visit https://review.coreboot.org/c/blobs/+/86511?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I81e745a7290c31fe15240102df0a78dfaadf54e7 Gerrit-Change-Number: 86511 Gerrit-PatchSet: 3 Gerrit-Owner: agogo <agogo.huang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: agogo <agogo.huang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/dirks: Update ddi_ports_config
by Ivy Jian (Code Review) 19 Feb '25

19 Feb '25

Ivy Jian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86537?usp=email ) Change subject: mb/google/nissa/var/dirks: Update ddi_ports_config ...................................................................... mb/google/nissa/var/dirks: Update ddi_ports_config Update ddi_ports_config to match VBT's settings. DDI_PORT_A = HDMI DDI_PORT_B = HDMI DDI_PORT_1 = Type-C DP BUG=b:389391653 TEST=emerge-nissa coreboot Change-Id: I67e9fcf4a3caa303ec8d873507a7533389c095ae Signed-off-by: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/dirks/overridetree.cb 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/86537/1 diff --git a/src/mainboard/google/brya/variants/dirks/overridetree.cb b/src/mainboard/google/brya/variants/dirks/overridetree.cb index bc1c186..a953b4c 100644 --- a/src/mainboard/google/brya/variants/dirks/overridetree.cb +++ b/src/mainboard/google/brya/variants/dirks/overridetree.cb @@ -87,6 +87,16 @@ # Enable the Cnvi BT Audio Offload register "cnvi_bt_audio_offload" = "1" + # Disable eDP on DDI portA + register "ddi_portA_config" = "0" + + # Enable HPD and DDC for DDI port A + register "ddi_ports_config" = "{ + [DDI_PORT_A] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_1] = DDI_ENABLE_HPD + }" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | -- To view, visit https://review.coreboot.org/c/coreboot/+/86537?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I67e9fcf4a3caa303ec8d873507a7533389c095ae Gerrit-Change-Number: 86537 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: google/fatcat/var/fatcat: Update THC Interrupt for Touchpad Development
by Jayvik Desai (Code Review) 19 Feb '25

19 Feb '25

Attention is currently required from: Andy Ebrahiem, Henry Barnor, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik. Hello Andy Ebrahiem, Henry Barnor, Kapil Porwal, Pranava Y N, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86479?usp=email to look at the new patch set (#7). Change subject: google/fatcat/var/fatcat: Update THC Interrupt for Touchpad Development ...................................................................... google/fatcat/var/fatcat: Update THC Interrupt for Touchpad Development This patch updates the TCH_PAD_INT_N GPP from A13 to F18 The Touch Pad's interrupt line (TCH_PAD_INT_N) was previously connected to GPP_A13, This patch moves the interrupt line to GPP_F18, aligning it with the THC1-i2c interface. Both LPSS-i2c and THC1-i2c share SCL/SDA signals, with the exception of the interrupt pin. This change ensures the interrupt pin shared between both the interface. BUG=b:395160736 TEST=able to build fatcat Change-Id: Ied917427225035a484a5873fa734f4c9f14277c0 Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/fatcat/variants/fatcat/fw_config.c 1 file changed, 8 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/86479/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/86479?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied917427225035a484a5873fa734f4c9f14277c0 Gerrit-Change-Number: 86479 Gerrit-PatchSet: 7 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Reviewer: Henry Barnor <hbarnor(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Henry Barnor <hbarnor(a)chromium.org>

1 0

[S] Change in coreboot[main]: google/fatcat/var/fatcat: Update THC Interrupt for Touchpad Development
by Jayvik Desai (Code Review) 19 Feb '25

19 Feb '25

Attention is currently required from: Andy Ebrahiem, Henry Barnor, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik. Hello Andy Ebrahiem, Henry Barnor, Kapil Porwal, Pranava Y N, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86479?usp=email to look at the new patch set (#6). Change subject: google/fatcat/var/fatcat: Update THC Interrupt for Touchpad Development ...................................................................... google/fatcat/var/fatcat: Update THC Interrupt for Touchpad Development This patch updates the TCH_PAD_INT_N GPP from A13 to F18 The Touch Pad's interrupt line (TCH_PAD_INT_N) was previously connected to GPP_A13, This patch moves the interrupt line to GPP_F18, aligning it with the THC1-i2c interface. Both LPSS-i2c and THC1-i2c share SCL/SDA signals, with the exception of the interrupt pin. This change ensures the interrupt pin shared between both the interface. BUG=b:395160736 TEST=able to build fatcat Change-Id: Ied917427225035a484a5873fa734f4c9f14277c0 Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/fatcat/variants/fatcat/fw_config.c 1 file changed, 8 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/86479/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/86479?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied917427225035a484a5873fa734f4c9f14277c0 Gerrit-Change-Number: 86479 Gerrit-PatchSet: 6 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Reviewer: Henry Barnor <hbarnor(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Henry Barnor <hbarnor(a)chromium.org>

1 0

[S] Change in coreboot[main]: Update THC Interrupt for Touchpad Development
by Jayvik Desai (Code Review) 19 Feb '25

19 Feb '25

Attention is currently required from: Andy Ebrahiem, Henry Barnor, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik. Hello Andy Ebrahiem, Henry Barnor, Kapil Porwal, Pranava Y N, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86479?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by Andy Ebrahiem, Verified+1 by build bot (Jenkins) Change subject: Update THC Interrupt for Touchpad Development ...................................................................... Update THC Interrupt for Touchpad Development This patch updates the TCH_PAD_INT_N GPP from A13 to F18 BUG=b:395160736 TEST=able to build fatcat Change-Id: Ied917427225035a484a5873fa734f4c9f14277c0 Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/fatcat/variants/fatcat/fw_config.c 1 file changed, 8 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/86479/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/86479?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied917427225035a484a5873fa734f4c9f14277c0 Gerrit-Change-Number: 86479 Gerrit-PatchSet: 5 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Reviewer: Henry Barnor <hbarnor(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Henry Barnor <hbarnor(a)chromium.org>

1 0

[XL] Change in coreboot[main]: libpayload: Remove legacy CBFS API
by Elyes Haouas (Code Review) 19 Feb '25

19 Feb '25

Elyes Haouas has posted comments on this change by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/80650?usp=email ) Change subject: libpayload: Remove legacy CBFS API ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: payloads/libpayload/tests/Makefile also needs a legacy removal, isn't it? please see https://review.coreboot.org/c/coreboot/+/86536 Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/80650?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0ed157ac2d1376b8dff4537af9a63731064b45f6 Gerrit-Change-Number: 80650 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 20 Feb 2025 06:56:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: libpayload/tests: Remove reference to non-existent files
by Elyes Haouas (Code Review) 19 Feb '25

19 Feb '25

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86536?usp=email ) Change subject: libpayload/tests: Remove reference to non-existent files ...................................................................... libpayload/tests: Remove reference to non-existent files Change-Id: Id2cec6a56ba5ce98832aced6fc2cfd8ebda91f02 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M payloads/libpayload/tests/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/86536/1 diff --git a/payloads/libpayload/tests/Makefile b/payloads/libpayload/tests/Makefile index 8c55053..e122f34 100644 --- a/payloads/libpayload/tests/Makefile +++ b/payloads/libpayload/tests/Makefile @@ -2,7 +2,7 @@ INCLUDES=-I. -I../include -I../include/x86 TARGETS=cbfs-x86-test -cbfs-x86-test: cbfs-x86-test.c ../arch/x86/rom_media.c ../libcbfs/ram_media.c ../libcbfs/cbfs.c +cbfs-x86-test: cbfs-x86-test.c ../libcbfs/cbfs.c $(CC) -o $@ $^ $(INCLUDES) -- To view, visit https://review.coreboot.org/c/coreboot/+/86536?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id2cec6a56ba5ce98832aced6fc2cfd8ebda91f02 Gerrit-Change-Number: 86536 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: mb/siemens/fa_ehl/variants/fa_ehl: Remove I210 driver
by Mario Scheithauer (Code Review) 19 Feb '25

19 Feb '25

Attention is currently required from: Johannes Hahn, Paul Menzel, Uwe Poeche, Werner Zeh. Mario Scheithauer has posted comments on this change by Johannes Hahn. ( https://review.coreboot.org/c/coreboot/+/86425?usp=email ) Change subject: mb/siemens/fa_ehl/variants/fa_ehl: Remove I210 driver ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86425?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I413cb334ee06e3fc7183dc2621b6091f0d0b602b Gerrit-Change-Number: 86425 Gerrit-PatchSet: 2 Gerrit-Owner: Johannes Hahn <johannes-hahn(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Attention: Johannes Hahn <johannes-hahn(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 20 Feb 2025 06:48:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: drivers/intel/fsp2_0: Add early low-battery shutdown during memory init
by Subrata Banik (Code Review) 19 Feb '25

19 Feb '25

Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Ronak Kanabar. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86452?usp=email ) Change subject: drivers/intel/fsp2_0: Add early low-battery shutdown during memory init ...................................................................... Patch Set 6: (1 comment) File src/drivers/intel/fsp2_0/memory_init.c: https://review.coreboot.org/c/coreboot/+/86452/comment/1acc7b1b_9236922e?us… : PS6, Line 351: platform_display_early_shutdown_notification(NULL); > I am wondering if ux.h can be moved from soc/intel/${soc}/romstage/ into either src/drivers/intel/ux/ux.h or src/vendorcode/intel/ux/ux.h. It can export the following APIs: > bool ux_inform_user_of_update_operation(const char *name, void *arg); > bool ux_inform_user_of_poweroff_operation(const char *name, void *arg, bool *defer_poweroff); > > Then ux_libgfxinit.c and ux_ugop.c can be added. ux_libgfxinit.c re-uses the code as is from soc/intel/alderlake/romstage/ux.c. arg is unused in this driver. ux_ugop.c gathers all the common codes for meteorlake, pantherlake and uses arg as fspm_upd. At most one of them gets enabled depending on the SoC. > > With that this part can be simplified as: > ``` > if (CONFIG(PLATFORM_HAS_EARLY_LOW_BATTERY_INDICATOR)) { > ux_inform_user_of_poweroff_operation("low-battery-shutdown", fspm_upd, defer_shutdown); > if (!defer_shutdown) > do_low_battery_poweroff(); > } > ``` > > That way we don't need platform_display_early_shutdown_notification hook. This will also address Julius's comment here: https://review.coreboot.org/c/coreboot/+/85454/comment/3280809d_e258c525/ > > I am suggesting this since it is getting harder to wrap up the flow with too many if(CONFIG(...)) checks and platform_specific hooks. I guess the only motivation is to keep this code inside SoC local due to the number of UPDs (using fspm_upd) that it's aiming to use. Some discussion is here https://review.coreboot.org/c/coreboot/+/85454/comment/3280809d_e258c525/ where we are discussing if moving UPD handing into common code is a good idea (knowing there is no standard spec for UPD naming and usage) -- To view, visit https://review.coreboot.org/c/coreboot/+/86452?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia135b238d1e16722c2ca8d3b461e83b4ce513adf Gerrit-Change-Number: 86452 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 20 Feb 2025 06:38:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Adjust and save HW protect temperature to SRAM
by Yidi Lin (Code Review) 19 Feb '25

19 Feb '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86533?usp=email ) Change subject: soc/mediatek/mt8196: Adjust and save HW protect temperature to SRAM ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Please split the patch into two. 1. The patch of `LVTS_COF_T_SLP_GLD` and `LVTS_COF_COUNT_R_GLD` adjustment and explain the reason. 2. The patch of saving the temperature to SRAM and explain the reason. -- To view, visit https://review.coreboot.org/c/coreboot/+/86533?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied0a7e710e77a4e74372590374f9342c5edc9122 Gerrit-Change-Number: 86533 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Zhaoqing Jiu <zhaoqing.jiu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 20 Feb 2025 06:37:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025