coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[S] Change in coreboot[main]: mb/google/puff: Add missing device names to Kconfig.name
by Felix Singer (Code Review) 19 Feb '25

19 Feb '25

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86461?usp=email ) Change subject: mb/google/puff: Add missing device names to Kconfig.name ...................................................................... mb/google/puff: Add missing device names to Kconfig.name Taken from: https://dl.google.com/dl/edgedl/chromeos/recovery/recovery2.json https://dl.google.com/dl/edgedl/chromeos/recovery/workspaceHardware_recover… Change-Id: I1da5c129c3912b4158bdc5349eb038265f80bf85 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86461 Reviewed-by: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M src/mainboard/google/puff/Kconfig.name 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Andy Ebrahiem: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/puff/Kconfig.name b/src/mainboard/google/puff/Kconfig.name index fe35e06..fa5b0f5 100644 --- a/src/mainboard/google/puff/Kconfig.name +++ b/src/mainboard/google/puff/Kconfig.name @@ -3,10 +3,10 @@ comment "Puff" config BOARD_GOOGLE_AMBASSADOR - bool "-> Ambassador" + bool "-> Ambassador (Meet Compute System [Intel 10th Gen])" config BOARD_GOOGLE_DOOLY - bool "-> Dooly" + bool "-> Dooly (HP Chromebase 21.5)" config BOARD_GOOGLE_DUFFY_LEGACY bool "-> Duffy Legacy (32MB)" @@ -18,7 +18,7 @@ bool "-> Faffy (ASUS Fanless Chromebox)" config BOARD_GOOGLE_GENESIS - bool "-> Genesis" + bool "-> Genesis (Meet Compute System - Series One [Intel 10th Gen])" config BOARD_GOOGLE_KAISA_LEGACY bool "-> Kaisa Legacy (32MB)" @@ -27,7 +27,7 @@ bool "-> Kaisa (Acer Chromebox CXI4)" config BOARD_GOOGLE_MOONBUGGY - bool "-> Moonbuggy" + bool "-> Moonbuggy (Series One Board 65)" config BOARD_GOOGLE_NOIBAT bool "-> Noibat (HP Chromebox G3)" @@ -36,7 +36,7 @@ bool "-> Puff" config BOARD_GOOGLE_SCOUT - bool "-> Scout" + bool "-> Scout (Series One Desk 27)" config BOARD_GOOGLE_WYVERN bool "-> Wyvern (CTL Chromebox CBx2)" -- To view, visit https://review.coreboot.org/c/coreboot/+/86461?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1da5c129c3912b4158bdc5349eb038265f80bf85 Gerrit-Change-Number: 86461 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/puff: Set SMBIOS system type
by Felix Singer (Code Review) 19 Feb '25

19 Feb '25

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86460?usp=email ) Change subject: mb/google/puff: Set SMBIOS system type ...................................................................... mb/google/puff: Set SMBIOS system type Puff variants will now correctly show their SMBIOS type as an all-in-one (dooly, scout) or a mini-pc (all other variants) rather than the default desktop type. Change-Id: Id24ff40f0aacade359f281def8be2a41c752d0d6 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86460 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M src/mainboard/google/puff/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/puff/Kconfig b/src/mainboard/google/puff/Kconfig index 0abe53a..3e64f05 100644 --- a/src/mainboard/google/puff/Kconfig +++ b/src/mainboard/google/puff/Kconfig @@ -35,6 +35,7 @@ select SPD_CACHE_IN_FMAP select SPD_READ_BY_WORD select SPI_TPM + select SYSTEM_TYPE_MINIPC if !SYSTEM_TYPE_ALL_IN_ONE select TPM_GOOGLE_CR50 config BOARD_GOOGLE_AMBASSADOR @@ -44,6 +45,7 @@ config BOARD_GOOGLE_DOOLY select BOARD_GOOGLE_BASEBOARD_PUFF select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_ALL_IN_ONE config BOARD_GOOGLE_DUFFY_LEGACY select BOARD_GOOGLE_BASEBOARD_PUFF @@ -85,6 +87,7 @@ config BOARD_GOOGLE_SCOUT select BOARD_GOOGLE_BASEBOARD_PUFF + select SYSTEM_TYPE_ALL_IN_ONE config BOARD_GOOGLE_WYVERN select BOARD_GOOGLE_BASEBOARD_PUFF -- To view, visit https://review.coreboot.org/c/coreboot/+/86460?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id24ff40f0aacade359f281def8be2a41c752d0d6 Gerrit-Change-Number: 86460 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/jecht: Set SMBIOS system type
by Felix Singer (Code Review) 19 Feb '25

19 Feb '25

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86459?usp=email ) Change subject: mb/google/jecht: Set SMBIOS system type ...................................................................... mb/google/jecht: Set SMBIOS system type Jecht variants will now correctly show their SMBIOS type as mini-pc rather than the default desktop type. Change-Id: I4f1be147bcfdad6247101db5b5943301466e60ad Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86459 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M src/mainboard/google/jecht/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig index c8cf7d6..eb3b985 100644 --- a/src/mainboard/google/jecht/Kconfig +++ b/src/mainboard/google/jecht/Kconfig @@ -13,6 +13,7 @@ select MAINBOARD_HAS_TPM1 select SOC_INTEL_BROADWELL select SUPERIO_ITE_IT8772F + select SYSTEM_TYPE_MINIPC config BOARD_GOOGLE_GUADO select BOARD_GOOGLE_BASEBOARD_JECHT -- To view, visit https://review.coreboot.org/c/coreboot/+/86459?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4f1be147bcfdad6247101db5b5943301466e60ad Gerrit-Change-Number: 86459 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/fizz: Set SMBIOS system type
by Felix Singer (Code Review) 19 Feb '25

19 Feb '25

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86458?usp=email ) Change subject: mb/google/fizz: Set SMBIOS system type ...................................................................... mb/google/fizz: Set SMBIOS system type Fizz variants will now correctly show their SMBIOS type as an all-in-one (karma) or a mini-pc (all other variants) rather than the default desktop type. Change-Id: Ida61c68d3664115ca29cb11e6820edb1496e4709 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86458 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/fizz/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index 44ea908..84a5145 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -24,6 +24,7 @@ select RT8168_GET_MAC_FROM_VPD select RT8168_SUPPORT_LEGACY_VPD_MAC select RT8168_SET_LED_MODE + select SYSTEM_TYPE_MINIPC if !SYSTEM_TYPE_ALL_IN_ONE select TPM_GOOGLE_CR50 config BOARD_GOOGLE_FIZZ @@ -34,6 +35,7 @@ select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_DA7219 select EXCLUDE_NATIVE_SD_INTERFACE + select SYSTEM_TYPE_ALL_IN_ONE config BOARD_GOOGLE_ENDEAVOUR select BOARD_GOOGLE_BASEBOARD_FIZZ -- To view, visit https://review.coreboot.org/c/coreboot/+/86458?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida61c68d3664115ca29cb11e6820edb1496e4709 Gerrit-Change-Number: 86458 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/cyan: Set SYSTEM_TYPE_CONVERTIBLE for cyan/kefka
by Felix Singer (Code Review) 19 Feb '25

19 Feb '25

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86457?usp=email ) Change subject: mb/google/cyan: Set SYSTEM_TYPE_CONVERTIBLE for cyan/kefka ...................................................................... mb/google/cyan: Set SYSTEM_TYPE_CONVERTIBLE for cyan/kefka Cyan and Kefka are convertible devices, so set them as such so their SMBIOS type is set correctly, necessary for some Linux tablet drivers. Change-Id: Ief81c7ba83eb5326dd6199508a3194008dee243b Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86457 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/cyan/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index 2bb6b92..eacc8ef 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -29,12 +29,14 @@ config BOARD_GOOGLE_CYAN select BOARD_GOOGLE_BASEBOARD_CYAN + select SYSTEM_TYPE_CONVERTIBLE config BOARD_GOOGLE_EDGAR select BOARD_GOOGLE_BASEBOARD_CYAN config BOARD_GOOGLE_KEFKA select BOARD_GOOGLE_BASEBOARD_CYAN + select SYSTEM_TYPE_CONVERTIBLE config BOARD_GOOGLE_REKS select BOARD_GOOGLE_BASEBOARD_CYAN -- To view, visit https://review.coreboot.org/c/coreboot/+/86457?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ief81c7ba83eb5326dd6199508a3194008dee243b Gerrit-Change-Number: 86457 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/beltino: Set SMBIOS system type
by Felix Singer (Code Review) 19 Feb '25

19 Feb '25

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86456?usp=email ) Change subject: mb/google/beltino: Set SMBIOS system type ...................................................................... mb/google/beltino: Set SMBIOS system type Beltino variants will now correctly show their SMBIOS type as an all-in-one (monroe) or a mini-pc (all other variants) rather than the default desktop type. Change-Id: Ia9f17236c415b626fd5d553a453cf43d4145ef41 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86456 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/beltino/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig index b3695cc..8bde8e6 100644 --- a/src/mainboard/google/beltino/Kconfig +++ b/src/mainboard/google/beltino/Kconfig @@ -15,12 +15,14 @@ select NORTHBRIDGE_INTEL_HASWELL select SOUTHBRIDGE_INTEL_LYNXPOINT select SUPERIO_ITE_IT8772F + select SYSTEM_TYPE_MINIPC if !SYSTEM_TYPE_ALL_IN_ONE config BOARD_GOOGLE_MCCLOUD select BOARD_GOOGLE_BASEBOARD_BELTINO config BOARD_GOOGLE_MONROE select BOARD_GOOGLE_BASEBOARD_BELTINO + select SYSTEM_TYPE_ALL_IN_ONE config BOARD_GOOGLE_PANTHER select BOARD_GOOGLE_BASEBOARD_BELTINO -- To view, visit https://review.coreboot.org/c/coreboot/+/86456?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9f17236c415b626fd5d553a453cf43d4145ef41 Gerrit-Change-Number: 86456 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/google/auron: Clean up Kconfig selections
by Felix Singer (Code Review) 19 Feb '25

19 Feb '25

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86455?usp=email ) Change subject: mb/google/auron: Clean up Kconfig selections ...................................................................... mb/google/auron: Clean up Kconfig selections Select the newly-added SYSTEM_TYPE_ALL_IN_ONE for Buddy variant, and use that as a discriminator to de-duplicate selections for system type and HAVE_SPD_IN_CBFS. Change-Id: I0d28bc496ff6bcfa9947a4d15ed2d8f75cf74ac3 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86455 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M src/mainboard/google/auron/Kconfig 1 file changed, 3 insertions(+), 10 deletions(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index 72f7758..2381c79 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -10,6 +10,7 @@ select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE + select HAVE_SPD_IN_CBFS if !SYSTEM_TYPE_ALL_IN_ONE select INTEL_GMA_HAVE_VBT select INTEL_INT15 select MAINBOARD_HAS_CHROMEOS @@ -17,34 +18,26 @@ select MEMORY_MAPPED_TPM select MAINBOARD_HAS_TPM1 select SOC_INTEL_BROADWELL + select SYSTEM_TYPE_LAPTOP if !SYSTEM_TYPE_ALL_IN_ONE config BOARD_GOOGLE_AURON_PAINE select BOARD_GOOGLE_BASEBOARD_AURON - select HAVE_SPD_IN_CBFS - select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_AURON_YUNA select BOARD_GOOGLE_BASEBOARD_AURON - select HAVE_SPD_IN_CBFS - select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_BUDDY select BOARD_GOOGLE_BASEBOARD_AURON + select SYSTEM_TYPE_ALL_IN_ONE config BOARD_GOOGLE_GANDOF select BOARD_GOOGLE_BASEBOARD_AURON - select HAVE_SPD_IN_CBFS - select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_LULU select BOARD_GOOGLE_BASEBOARD_AURON - select HAVE_SPD_IN_CBFS - select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_SAMUS select BOARD_GOOGLE_BASEBOARD_AURON - select HAVE_SPD_IN_CBFS - select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_BASEBOARD_AURON -- To view, visit https://review.coreboot.org/c/coreboot/+/86455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0d28bc496ff6bcfa9947a4d15ed2d8f75cf74ac3 Gerrit-Change-Number: 86455 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/skyrim/var/frostflow: Set SYSTEM_TYPE_CONVERTIBLE
by Felix Singer (Code Review) 19 Feb '25

19 Feb '25

1 0

[XS] Change in coreboot[main]: mb/google/skyrim/var/frostflow: Set SYSTEM_TYPE_CONVERTIBLE
by Felix Singer (Code Review) 19 Feb '25

19 Feb '25

Attention is currently required from: Jason Nien, Martin Roth, Matt DeVillier. Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86468?usp=email ) Change subject: mb/google/skyrim/var/frostflow: Set SYSTEM_TYPE_CONVERTIBLE ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/skyrim/Kconfig: https://review.coreboot.org/c/coreboot/+/86468/comment/44477593_478f8a00?us… : PS1, Line 33: select ACPI_S1_NOT_SUPPORTED : select AMD_FWM_POSITION_C20000_DEFAULT : select AMD_SOC_CONSOLE_UART : select BOARD_ROMSIZE_KB_16384 : select DISABLE_KEYBOARD_RESET_PIN : select DISABLE_SPI_FLASH_ROM_SHARING : select DRIVERS_GENERIC_GPIO_KEYS : select DRIVERS_GENERIC_MAX98357A : select DRIVERS_ACPI_THERMAL_ZONE : select DRIVERS_I2C_GENERIC : select DRIVERS_I2C_HID : select DRIVERS_I2C_NAU8825 : select DRIVERS_USB_HUB : select DRIVERS_UART_ACPI : select DRIVERS_PCIE_GENERIC : select DRIVERS_PCIE_RTD3_DEVICE : select EC_GOOGLE_CHROMEEC : select EC_GOOGLE_CHROMEEC_BOARDID : select EC_GOOGLE_CHROMEEC_ESPI : select EC_GOOGLE_CHROMEEC_SKUID : select ELOG : select ELOG_GSMI : select FW_CONFIG : select FW_CONFIG_SOURCE_CHROMEEC_CBI : select GOOGLE_SMBIOS_MAINBOARD_VERSION : select HAS_RECOVERY_MRC_CACHE : select I2C_TPM : select MAINBOARD_HAS_CHROMEOS : select MAINBOARD_HAS_TPM2 : select MB_COMPRESS_RAMSTAGE_LZ4 : select PCIEXP_ASPM : select PCIEXP_CLK_PM : select PCIEXP_COMMON_CLOCK : select PCIEXP_L1_SUB_STATE : select SOC_AMD_MENDOCINO : select SOC_AMD_COMMON_BLOCK_I2C3_TPM_SHARED_WITH_PSP : select SOC_AMD_COMMON_BLOCK_USE_ESPI : select SOC_AMD_GFX_CACHE_VBIOS_IN_FMAP if CHROMEOS && RUN_FSP_GOP : select SYSTEM_TYPE_LAPTOP if !SYSTEM_TYPE_CONVERTIBLE : select TPM_GOOGLE_TI50 > Could you add a patch on top that moves the selects under BOARD_GOOGLE_BASEBOARD_SKYRIM? That allows […] Not a todo here, marking as resolved. -- To view, visit https://review.coreboot.org/c/coreboot/+/86468?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c3306270cbc80bb55fb536a1fc51a5546287649 Gerrit-Change-Number: 86468 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 20 Feb 2025 01:24:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[XS] Change in coreboot[main]: mb/google/glados/var/cave: Set SYSTEM_TYPE_CONVERTIBLE
by Felix Singer (Code Review) 19 Feb '25

19 Feb '25

Attention is currently required from: Matt DeVillier. Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86467?usp=email ) Change subject: mb/google/glados/var/cave: Set SYSTEM_TYPE_CONVERTIBLE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86467?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f2ec82c97676aa315c18286b5e2eb94d46004ec Gerrit-Change-Number: 86467 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Feb 2025 01:23:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025