coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Reconfigure the vGPIO's for CNVi BT
by Matt DeVillier (Code Review) 20 Feb '25

20 Feb '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86387?usp=email ) Change subject: mb/starlabs/starlite_adl: Reconfigure the vGPIO's for CNVi BT ...................................................................... Patch Set 4: (2 comments) File src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c: https://review.coreboot.org/c/coreboot/+/86387/comment/6116709e_31014ccd?us… … [View More]

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook_adl_n: Fix USB port assignments/descriptions
by Sean Rhodes (Code Review) 20 Feb '25

20 Feb '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86346?usp=email ) Change subject: mb/starlabs/starbook_adl_n: Fix USB port assignments/descriptions ...................................................................... mb/starlabs/starbook_adl_n: Fix USB port assignments/descriptions Fix USB port assignments/descriptions to match actual topology. TEST=build/boot Win11 on starlabs/starbook_adl_n. Verify ports match assignmented in devicetree using … [View More]USBTreeview. Change-Id: If0b341f1c5f99b53df8fff69f8a58fa732adbbc4 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86346 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb 1 file changed, 11 insertions(+), 32 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb index d84c243..2c66936 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb @@ -37,23 +37,19 @@ [DDI_PORT_1] = DDI_ENABLE_HPD, }" end - device ref gna on end - device ref xhci on + device ref gna on end + device ref xhci on # Motherboard USB 3.0 Type-C Front 9557 mil - register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC_SKIP)" - register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" - - # Motherboard USB 3.0 Type-C Back 7893 mil register "usb2_ports[2]" = "USB2_PORT_TYPE_C(OC_SKIP)" - register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC_SKIP)" + register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Motherboard USB 3.0 Type-A 8916 mil register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" - register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" + register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Daughterboard USB 3.0 Type-A 2229 mil register "usb2_ports[0]" = "USB2_PORT_SHORT(OC_SKIP)" - register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" + register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Internal Webcam 9070 mil register "usb2_ports[CONFIG_CCD_PORT]" = "USB2_PORT_MID(OC_SKIP)" @@ -67,18 +63,6 @@ chip drivers/usb/acpi device ref xhci_root_hub on chip drivers/usb/acpi - register "desc" = ""Back USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS" - register "group" = "ACPI_PLD_GROUP(0, 0)" - device ref usb2_port2 on end - end - chip drivers/usb/acpi - register "desc" = ""Back USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS" - register "group" = "ACPI_PLD_GROUP(0, 0)" - device ref usb3_port3 on end - end - chip drivers/usb/acpi register "desc" = ""Front USB Type-C"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "group" = "ACPI_PLD_GROUP(0, 1)" @@ -88,7 +72,7 @@ register "desc" = ""Front USB Type-C"" register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "group" = "ACPI_PLD_GROUP(0, 1)" - device ref usb3_port4 on end + device ref usb3_port3 on end end chip drivers/usb/acpi register "desc" = ""Left USB Type-A"" @@ -100,7 +84,7 @@ register "desc" = ""Left USB Type-A"" register "type" = "UPC_TYPE_USB3_A" register "group" = "ACPI_PLD_GROUP(0, 2)" - device ref usb3_port1 on end + device ref usb3_port2 on end end chip drivers/usb/acpi register "desc" = ""Right USB Type-A"" @@ -112,7 +96,7 @@ register "desc" = ""Right USB Type-A"" register "type" = "UPC_TYPE_USB3_A" register "group" = "ACPI_PLD_GROUP(0, 3)" - device ref usb3_port2 on end + device ref usb3_port1 on end end chip drivers/usb/acpi register "desc" = ""Internal Webcam"" @@ -205,8 +189,8 @@ device ref uart0 on end device ref pch_espi on register "gen1_dec" = "0x00040069" - register "gen2_dec" = "0x00fc0e01" - register "gen3_dec" = "0x00fc0f01" + register "gen2_dec" = "0x00040069" + register "gen3_dec" = "0x00040069" chip drivers/pc80/tpm device pnp 0c31.0 on end @@ -239,15 +223,10 @@ chip drivers/intel/pmc_mux device generic 0 on chip drivers/intel/pmc_mux/conn - use usb2_port2 as usb2_port + use usb2_port3 as usb2_port use usb3_port3 as usb3_port device generic 0 alias conn0 on end end - chip drivers/intel/pmc_mux/conn - use usb2_port3 as usb2_port - use usb3_port4 as usb3_port - device generic 1 alias conn1 on end - end end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/86346?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0b341f1c5f99b53df8fff69f8a58fa732adbbc4 Gerrit-Change-Number: 86346 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> [View Less]

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/{kbl,cml}: Unselect LIBGFXINIT
by Sean Rhodes (Code Review) 20 Feb '25

20 Feb '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86515?usp=email ) Change subject: mb/starlabs/starbook/{kbl,cml}: Unselect LIBGFXINIT ...................................................................... mb/starlabs/starbook/{kbl,cml}: Unselect LIBGFXINIT Unselect LIBGFXINIT to bring these two variants inline with the others. Change-Id: If0fdc9ffd391f2710f252be7358d87644a77b36a Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://… [View More]

1 0

[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Reconfigure the vGPIO's for CNVi BT
by Sean Rhodes (Code Review) 20 Feb '25

20 Feb '25

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86387?usp=email ) Change subject: mb/starlabs/starlite_adl: Reconfigure the vGPIO's for CNVi BT ...................................................................... Patch Set 4: (2 comments) File src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c: https://review.coreboot.org/c/coreboot/+/86387/comment/459f7160_94478ca9?us… … [View More]

1 0

[XS] Change in coreboot[main]: mb/google/trulo/var/uldrenite: Enable DPTF oem_variables
by John Su (Code Review) 20 Feb '25

20 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik. John Su has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86394?usp=email ) Change subject: mb/google/trulo/var/uldrenite: Enable DPTF oem_variables ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86394/comment/… [View More]

1 0

[S] Change in coreboot[main]: mb/trulo/var/uldrenite: Fix boot time caused by WWAN initialization
by John Su (Code Review) 20 Feb '25

20 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86514?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/… [View More]trulo/var/uldrenite: Fix boot time caused by WWAN initialization ...................................................................... mb/trulo/var/uldrenite: Fix boot time caused by WWAN initialization Move WWAN power sequence to GPIO control to reduce boot time caused by WWAN initialization. BUG=b:383212261 BRANCH=firmware-trulo-15217.771.B TEST=Confirm the measured WWAN power sequence Change-Id: Ie01019eca7eaa4bbb34dd80aeb65b9b6b08587fd Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/uldrenite/gpio.c M src/mainboard/google/brya/variants/uldrenite/include/variant/gpio.h M src/mainboard/google/brya/variants/uldrenite/variant.c M src/mainboard/google/brya/wwan_power.asl 4 files changed, 11 insertions(+), 33 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/86514/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/86514?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie01019eca7eaa4bbb34dd80aeb65b9b6b08587fd Gerrit-Change-Number: 86514 Gerrit-PatchSet: 5 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> [View Less]

1 0

[XS] Change in coreboot[main]: mb/google/brya/var/agah: Remove the AGAH DPTF OEM variant
by John Su (Code Review) 20 Feb '25

20 Feb '25

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Dinesh Gehlot, Eric Lai, Ivy Jian, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik, Tony Huang, Wisley Chen. John Su has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86493?usp=email ) Change subject: mb/google/brya/var/agah: Remove the AGAH DPTF OEM variant ...................................................................... Patch Set 5: (1 comment) File … [View More]src/ec/google/chromeec/acpi/ec.asl: https://review.coreboot.org/c/coreboot/+/86493/comment/09243ecf_b05074ea?us… : PS4, Line 383: #ifdef DPTF_ENABLE_OEM_VARIABLES : Local0 = ToInteger(EOVD) & EC_OEM_VARIABLE_DATA_MASK : \_SB.DPTF.ODUP(0, Local0) : Local0 = \_SB.DPTF.ODGT(0) : \_SB.DPTF.ODVP() : Notify (\_SB.DPTF, INT3400_ODVP_CHANGED) : #endif > I think it should be OK to just remove this entire block, as agah is not supported anymore (agah EC […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86493?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2929eaa65a518b06f32e33cc31ae4a01bcfb77e8 Gerrit-Change-Number: 86493 Gerrit-PatchSet: 5 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Thu, 20 Feb 2025 14:57:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Boris Mittelberg <bmbm(a)google.com> [View Less]

1 0

[XS] Change in coreboot[main]: mb/google/brya/var/agah: Remove the AGAH DPTF OEM variant
by John Su (Code Review) 20 Feb '25

20 Feb '25

Attention is currently required from: Caveh Jalali, Dinesh Gehlot, Eric Lai, Ivy Jian, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik, Tony Huang, Wisley Chen. Hello Boris Mittelberg, Caveh Jalali, Dinesh Gehlot, Eric Lai, Ivy Jian, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tony Huang, Wisley Chen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86493?usp=email to look at the … [View More]new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/brya/var/agah: Remove the AGAH DPTF OEM variant ...................................................................... mb/google/brya/var/agah: Remove the AGAH DPTF OEM variant Because the AGAH EC code is based on monitoring adapter current to choose the corresponding DPTF OEM variable table, but not every project follows this design. Based on the comment below, the AGAH EC code was removed in 2023, so remove the AGAH DPTF OEM variant, allowing each OEM to adjust in EC ASL accordingly. BUG=b:394177292 BRANCH=None TEST=None Change-Id: I2929eaa65a518b06f32e33cc31ae4a01bcfb77e8 Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com> --- M src/ec/google/chromeec/acpi/ec.asl 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/86493/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/86493?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2929eaa65a518b06f32e33cc31ae4a01bcfb77e8 Gerrit-Change-Number: 86493 Gerrit-PatchSet: 5 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> [View Less]

1 0

[XS] Change in coreboot[main]: mb/trulo/var/uldrenite: Decrease ROM size to 16MB
by Matt DeVillier (Code Review) 20 Feb '25

20 Feb '25

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86501?usp=email ) Change subject: mb/trulo/var/uldrenite: Decrease ROM size to 16MB ...................................................................... mb/trulo/var/uldrenite: Decrease ROM size to 16MB According to the design, the SPI ROM will be replaced with a 16MB size, so the Kconfig is modified to 16MB. BUG=b:397372760 TEST=emerge-nissa coreboot and check rom size is 16MB Change-Id: … [View More]I3ef1aa2401d44259e4301f65e2ba0ac7b9418bbd Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86501 Reviewed-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/brya/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Dtrain Hsu: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index fd88c1b..aac2393 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -656,7 +656,6 @@ config BOARD_GOOGLE_ULDRENITE select BOARD_GOOGLE_BASEBOARD_TRULO - select BOARD_ROMSIZE_KB_32768 select CHROMEOS_WIFI_SAR if CHROMEOS select DRIVERS_WWAN_FM350GL select ENFORCE_MEM_CHANNEL_DISABLE -- To view, visit https://review.coreboot.org/c/coreboot/+/86501?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ef1aa2401d44259e4301f65e2ba0ac7b9418bbd Gerrit-Change-Number: 86501 Gerrit-PatchSet: 3 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> [View Less]

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/meliks: Add VBT data file
by Matt DeVillier (Code Review) 20 Feb '25

20 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Nick Vaccaro, SH Kim, Subrata Banik. Matt DeVillier has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/86508?usp=email ) Change subject: mb/google/nissa/var/meliks: Add VBT data file ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Do we really need this? yes, if you want the board to actually be functional … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025