coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2887 discussions

[S] Change in coreboot[main]: soc/amd/glinda/cpu: Update smbios parameters
by Naresh Solanki (Code Review) 28 Feb '25

28 Feb '25

Attention is currently required from: Naresh Solanki. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85637?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/amd/glinda/cpu: Update smbios parameters ...................................................................... soc/amd/glinda/cpu: Update smbios parameters Update smbios parameters for cache type, operation mode & error correction type. source: UEFI reference BIOS Change-Id: If8eaa54c9a0086f4d397a7ddb01009acfd3f1aee Signed-off-by: Naresh Solanki <naresh.solanki(a)9elements.com> --- M src/soc/amd/glinda/cpu.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/85637/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/85637?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If8eaa54c9a0086f4d397a7ddb01009acfd3f1aee Gerrit-Change-Number: 85637 Gerrit-PatchSet: 5 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/mtl: Don't configure MUX pins
by Sean Rhodes (Code Review) 28 Feb '25

28 Feb '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86651?usp=email ) Change subject: mb/starlabs/starbook/mtl: Don't configure MUX pins ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86651?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I70708212c4652ed77c875242340c30edf5b935a1 Gerrit-Change-Number: 86651 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 28 Feb 2025 14:20:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/tigerlake: Use common ASPM helper functions
by Sean Rhodes (Code Review) 28 Feb '25

28 Feb '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86024?usp=email ) Change subject: soc/intel/tigerlake: Use common ASPM helper functions ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86024?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I95dcd836d9a31871f25ad2b036ca05f694b40940 Gerrit-Change-Number: 86024 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Feb 2025 14:20:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: configs: enable TPM PPI for asrock_b85m_pro4.tpm2_txt_placeholder_acms
by Sergii Dmytruk (Code Review) 28 Feb '25

28 Feb '25

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81696?usp=email ) Change subject: configs: enable TPM PPI for asrock_b85m_pro4.tpm2_txt_placeholder_acms ...................................................................... Abandoned 4/4 copies of CB:81800 (not sure how I made them) -- To view, visit https://review.coreboot.org/c/coreboot/+/81696?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I316747a79b3142e9d6188c5986b344c7751d92d7 Gerrit-Change-Number: 81696 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: configs: enable TPM PPI for asrock_b85m_pro4.tpm2_txt_placeholder_acms
by Sergii Dmytruk (Code Review) 28 Feb '25

28 Feb '25

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81695?usp=email ) Change subject: configs: enable TPM PPI for asrock_b85m_pro4.tpm2_txt_placeholder_acms ...................................................................... Abandoned 3/4 copies of CB:81800 (not sure how I made them) -- To view, visit https://review.coreboot.org/c/coreboot/+/81695?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I316747a79b3142e9d6188c5986b344c7751d92d7 Gerrit-Change-Number: 81695 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: configs: enable TPM PPI for asrock_b85m_pro4.tpm2_txt_placeholder_acms
by Sergii Dmytruk (Code Review) 28 Feb '25

28 Feb '25

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81694?usp=email ) Change subject: configs: enable TPM PPI for asrock_b85m_pro4.tpm2_txt_placeholder_acms ...................................................................... Abandoned 2/4 copies of CB:81800 (not sure how I made them) -- To view, visit https://review.coreboot.org/c/coreboot/+/81694?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I316747a79b3142e9d6188c5986b344c7751d92d7 Gerrit-Change-Number: 81694 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: configs: enable TPM PPI for asrock_b85m_pro4.tpm2_txt_placeholder_acms
by Sergii Dmytruk (Code Review) 28 Feb '25

28 Feb '25

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81697?usp=email ) Change subject: configs: enable TPM PPI for asrock_b85m_pro4.tpm2_txt_placeholder_acms ...................................................................... Abandoned 1/4 copies of CB:81800 (not sure how I made them) -- To view, visit https://review.coreboot.org/c/coreboot/+/81697?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I316747a79b3142e9d6188c5986b344c7751d92d7 Gerrit-Change-Number: 81697 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/mtl: Don't reconfigure GPIOs in ramstage
by Matt DeVillier (Code Review) 28 Feb '25

28 Feb '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86650?usp=email ) Change subject: mb/starlabs/starbook/mtl: Don't reconfigure GPIOs in ramstage ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86650?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4b813370cf259fb1ca138dd1922c16f801b40cc4 Gerrit-Change-Number: 86650 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 28 Feb 2025 13:49:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/mtl: Don't reconfigure GPIOs in ramstage
by Sean Rhodes (Code Review) 28 Feb '25

28 Feb '25

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86650?usp=email ) Change subject: mb/starlabs/starbook/mtl: Don't reconfigure GPIOs in ramstage ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86650/comment/c7e0eb1d_945c907c?us… : PS1, Line 9: GPP_H08 and GPP_H09 are configured in the bootblock, so remove the : configuration in ramstage. > is there any benefit to not doing so? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86650?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4b813370cf259fb1ca138dd1922c16f801b40cc4 Gerrit-Change-Number: 86650 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Fri, 28 Feb 2025 13:48:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/mtl: Don't reconfigure GPIOs in ramstage
by Sean Rhodes (Code Review) 28 Feb '25

28 Feb '25

Attention is currently required from: Sean Rhodes. Hello Matt DeVillier, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86650?usp=email to look at the new patch set (#2). Change subject: mb/starlabs/starbook/mtl: Don't reconfigure GPIOs in ramstage ...................................................................... mb/starlabs/starbook/mtl: Don't reconfigure GPIOs in ramstage GPP_H08 and GPP_H09 are configured in the bootblock, so remove the configuration in ramstage to allow the serial output in ramstage. Change-Id: I4b813370cf259fb1ca138dd1922c16f801b40cc4 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/mainboard/starlabs/starbook/variants/mtl/gpio.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/86650/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86650?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4b813370cf259fb1ca138dd1922c16f801b40cc4 Gerrit-Change-Number: 86650 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

← Newer
1
2
3
4
5
6
7
...
289
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025