Attention is currently required from: Elyes Haouas, Felix Singer, Martin L Roth.
Maximilian Brune has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86100?usp=email )
Change subject: [This Must Fail]Upgrade GCC to 15-20250119 Snapshot
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I tried downloading compiling the toolchain using this patch, but it fails (some linking error against a gnat function when building GCC). Do I need any other patches?
--
To view, visit https://review.coreboot.org/c/coreboot/+/86100?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e6c3745eebeb6ded494c153010283b761498184
Gerrit-Change-Number: 86100
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Wed, 05 Feb 2025 17:57:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Julius Werner, Karthik Ramasubramanian, Subrata Banik.
Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86223?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: util/cbfstool/eventlog: Add low battery event type
......................................................................
Patch Set 5:
(1 comment)
File util/cbfstool/eventlog.c:
https://review.coreboot.org/c/coreboot/+/86223/comment/a5f6a553_17a3ad45?us… :
PS5, Line 173: {ELOG_TYPE_LOW_BATTERY_INDICATOR, "Low Battery Boot "},
Remove space at the end of the string.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86223?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5cc5e5f540657c7dfd174a4928e697a272da813a
Gerrit-Change-Number: 86223
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 16:33:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Julius Werner, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun.
Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86283?usp=email )
Change subject: lib: Refactor ux_locales_get_text API
......................................................................
Patch Set 2:
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86283/comment/566290b7_c1dec45c?us… :
PS2, Line 14: - ux_locales_get_text: Get UX locales msg based on locales name.
message.
https://review.coreboot.org/c/coreboot/+/86283/comment/0870851d_e2fe18df?us… :
PS2, Line 15: msg
message
https://review.coreboot.org/c/coreboot/+/86283/comment/453a076e_25a9df8d?us… :
PS2, Line 15: - ux_locales_get_text_by_id - Get UX locales msg based on msg ID.
Use colon instead of dash
https://review.coreboot.org/c/coreboot/+/86283/comment/97af349f_bbcbcc9a?us… :
PS2, Line 17: `ux_locales_get_text_by_id` retrieve fallback text message depending
retrieves
https://review.coreboot.org/c/coreboot/+/86283/comment/61ecef9c_0792bd1c?us… :
PS2, Line 18: upon the msg ID incase UX locales not available. `ux_locales_get_text`
s/incase/if/
File src/include/ux_locales.h:
https://review.coreboot.org/c/coreboot/+/86283/comment/1082dafe_e5f1ea55?us… :
PS2, Line 20: english
English
https://review.coreboot.org/c/coreboot/+/86283/comment/d3358ea5_87bb73d1?us… :
PS2, Line 20: fallback_msg
fallback_text ?
File src/lib/ux_locales.c:
https://review.coreboot.org/c/coreboot/+/86283/comment/deb27f74_7a2c374b?us… :
PS2, Line 35: ux_locale_msg_list
Could we index with `enum ux_locale_msg` avoiding an unnecessary loop?
https://review.coreboot.org/c/coreboot/+/86283/comment/ff32661d_30b207ff?us… :
PS2, Line 225: if (!msg_id_found)
I am wondering if a `printk(BIOS_ERR` would be appropriate in addition to this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86283?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4952802396265b9ee8d164d6e43a7f2b3599d6c0
Gerrit-Change-Number: 86283
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 16:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Felix Singer, Jakub "Kuba" Czapiga, Julius Werner, Martin L Roth, Maximilian Brune.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86012?usp=email )
Change subject: tree: Switch to C23
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> We can't revert it unless we find a solution to the problem. […]
The problem is now Jenkins is doing wrong !
https://review.coreboot.org/c/coreboot/+/86100 is supposed to fail but it didn't !
--
To view, visit https://review.coreboot.org/c/coreboot/+/86012?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4b2184e5c57143b11e3cc433d09d74a83028420
Gerrit-Change-Number: 86012
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Wed, 05 Feb 2025 16:14:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/86053?usp=email )
Change subject: AArch64: Drop unused and deprecated ILP32
......................................................................
Abandoned
I'm definitely wrong
--
To view, visit https://review.coreboot.org/c/coreboot/+/86053?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie1cb249541d9afd893df6dde0111ad45c8a5ff98
Gerrit-Change-Number: 86053
Gerrit-PatchSet: 7
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Attention is currently required from: Elyes Haouas, Felix Singer, Jakub "Kuba" Czapiga, Julius Werner, Martin L Roth.
Maximilian Brune has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86012?usp=email )
Change subject: tree: Switch to C23
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> should we revert commit 84347d0b4598 and commit 7bcec7a2efc4 ?
We can't revert it unless we find a solution to the problem. I agree that it is not the optimal solution, but I didn't have time to figure out how to compile our coreboot toolchain to make it work with linux as well as coreboot. And to be quite honest I also didn't want to. I don't think we should change our toolchain just because one of our payloads needs to be built somehow special. But if you ask me this is just a side effect of another problem:
I personally don't think coreboot should be distributor for payloads (I don't think that is gonna change though). The maintenance effort is just not worth it. That is also the reason why many of our payloads don't work for most platforms.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86012?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4b2184e5c57143b11e3cc433d09d74a83028420
Gerrit-Change-Number: 86012
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Wed, 05 Feb 2025 16:02:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Ronak Kanabar.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86226?usp=email )
Change subject: drivers/intel/fsp2_0: Add platform callback for critical shutdown
......................................................................
Patch Set 2:
(2 comments)
File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/86226/comment/76602b8a_0aa38255?us… :
PS2, Line 262: if (CONFIG(CHROMEOS_LOW_BATTERY_INDICATOR_SCREEN))
> > Is this required especially with the weak override? […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/86226/comment/1a36213a_7bfc5e6e?us… :
PS2, Line 263: platform_is_critical_shutdown_needed();
> Having a function that sounds like a question hang the boot flow is not very intuitive. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/86226?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2d6677d70dea3d24f5a19d70608fd21229a271a0
Gerrit-Change-Number: 86226
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 15:57:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>