coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2887 discussions

[XS] Change in coreboot[main]: soc/intel/alderlake: Display low battery message on screen
by Subrata Banik (Code Review) 05 Feb '25

05 Feb '25

Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86224?usp=email ) Change subject: soc/intel/alderlake: Display low battery message on screen ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > You could put this into the locales API but you would have to do string matching, e.g. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/86224?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3b24d2c89ade8cc62b7e47c487d52d47b7f3376d Gerrit-Change-Number: 86224 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 05 Feb 2025 10:05:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Specify MTKLIB_PATH for building BL31
by Yidi Lin (Code Review) 05 Feb '25

05 Feb '25

Yidi Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86252?usp=email ) Change subject: soc/mediatek/mt8196: Specify MTKLIB_PATH for building BL31 ...................................................................... soc/mediatek/mt8196: Specify MTKLIB_PATH for building BL31 Add BL31 static library path to BL31 build argument. BRANCH=rauru BUG=b:317009620 TEST=Build pass with and without static library. boot ok. Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2 Signed-off-by: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86252 Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yidi Lin <yidilin(a)google.com> --- M src/soc/mediatek/mt8196/Makefile.mk 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Yidi Lin: Looks good to me, approved build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/src/soc/mediatek/mt8196/Makefile.mk b/src/soc/mediatek/mt8196/Makefile.mk index d780ebd..4dd2d2d 100644 --- a/src/soc/mediatek/mt8196/Makefile.mk +++ b/src/soc/mediatek/mt8196/Makefile.mk @@ -93,6 +93,12 @@ MT8196_BLOB_DIR := 3rdparty/blobs/soc/mediatek/mt8196 +BL31_LIB := $(top)/$(MT8196_BLOB_DIR)/libbl31.a + +ifneq ($(wildcard $(BL31_LIB)),) +BL31_MAKEARGS += MTKLIB_PATH=$(BL31_LIB) +endif + mcu-firmware-files := \ $(CONFIG_DPM_DM_FIRMWARE) \ $(CONFIG_DPM_PM_FIRMWARE) \ -- To view, visit https://review.coreboot.org/c/coreboot/+/86252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2 Gerrit-Change-Number: 86252 Gerrit-PatchSet: 4 Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in coreboot[main]: mb/google/nissa/var/dirks: Add initial override devicetree
by Jayvik Desai (Code Review) 05 Feb '25

05 Feb '25

Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Ivy Jian, Kapil Porwal, Nick Vaccaro, Subrata Banik. Jayvik Desai has posted comments on this change by Ivy Jian. ( https://review.coreboot.org/c/coreboot/+/86250?usp=email ) Change subject: mb/google/nissa/var/dirks: Add initial override devicetree ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86250?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic0b80e3121d94ede771ecc30cf0c66a67b9a41d0 Gerrit-Change-Number: 86250 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 05 Feb 2025 08:49:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/rauru: Support the panel with a load switch control
by Yidi Lin (Code Review) 05 Feb '25

05 Feb '25

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86282?usp=email ) Change subject: mb/google/rauru: Support the panel with a load switch control ...................................................................... mb/google/rauru: Support the panel with a load switch control The Rauru follower device goes `load switch` path to ensure the discharge timing meets the panel power-off sequence. Refactor panel.c to support this hardware change. BRANCH=rauru BUG=b:339580836 TEST=verify firmware screen on Navi Change-Id: I57dcaa2a0b5af94fe3fa3eaf04e9f3159c51d144 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/mainboard/google/rauru/panel.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/86282/1 diff --git a/src/mainboard/google/rauru/panel.c b/src/mainboard/google/rauru/panel.c index 8564f4c..37e4001 100644 --- a/src/mainboard/google/rauru/panel.c +++ b/src/mainboard/google/rauru/panel.c @@ -27,23 +27,23 @@ .orientation = LB_FB_ORIENTATION_NORMAL, }; -static void power_on_oled_panel(void) +static void power_on_load_switch(void) { gpio_output(GPIO_EN_PP3300_EDP_X, 1); gpio_set_mode(GPIO_EDP_HPD_1V8, GPIO_FUNC(EINT13, EDP_TX_HPD)); } -static struct panel_description oled_panel = { +static struct panel_description edp_panel = { .configure_backlight = configure_backlight, - .power_on = power_on_oled_panel, + .power_on = power_on_load_switch, .disp_path = DISP_PATH_EDP, .orientation = LB_FB_ORIENTATION_NORMAL, }; struct panel_description *get_active_panel(void) { - if (fw_config_probe(FW_CONFIG(PANEL, OLED))) { - return &oled_panel; - } - return &panel; + if (CONFIG(BOARD_GOOGLE_RAURU)) + return &panel; + + return &edp_panel; } -- To view, visit https://review.coreboot.org/c/coreboot/+/86282?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I57dcaa2a0b5af94fe3fa3eaf04e9f3159c51d144 Gerrit-Change-Number: 86282 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/trulo/var/uldrenite: Add fw_config probe for Cellular
by Dtrain Hsu (Code Review) 05 Feb '25

05 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro. Dtrain Hsu has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86255?usp=email ) Change subject: mb/google/trulo/var/uldrenite: Add fw_config probe for Cellular ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/mainboard/google/brya/variants/uldrenite/overridetree.cb: https://review.coreboot.org/c/coreboot/+/86255/comment/568f90f6_c60b630d?us… : PS2, Line 476: end Should we also need to disable pcie_rp2 when CELLULAR_ABSENT? probe DB_CELLULAR CELLULAR_RW350R -- To view, visit https://review.coreboot.org/c/coreboot/+/86255?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib664f543c6012b44a0a604d0943416519d92a057 Gerrit-Change-Number: 86255 Gerrit-PatchSet: 2 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 05 Feb 2025 08:27:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: [This Must Fail]Upgrade GCC to 15-20250119 Snapshot
by Elyes Haouas (Code Review) 05 Feb '25

05 Feb '25

Attention is currently required from: Felix Singer, Martin L Roth. Hello Felix Singer, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86100?usp=email to look at the new patch set (#4). Change subject: [This Must Fail]Upgrade GCC to 15-20250119 Snapshot ...................................................................... [This Must Fail]Upgrade GCC to 15-20250119 Snapshot Must fail, at least to build qemu-i440fx: from build/mainboard/emulation/qemu-i440fx/static.c:2: src/commonlib/include/commonlib/loglevel.h:170:26: error: initializer-string for array of 'char' is too long [-Werror=unterminated-string-initialization] 170 | [BIOS_EMERG] = "EMERG", | ^~~~~~~ otherwise there is a problem! Change-Id: I5e6c3745eebeb6ded494c153010283b761498184 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc R util/crossgcc/patches/gcc-15-20250119_asan_shadow_offset_callback.patch R util/crossgcc/patches/gcc-15-20250119_gnat.patch R util/crossgcc/patches/gcc-15-20250119_libcpp.patch R util/crossgcc/patches/gcc-15-20250119_libgcc.patch R util/crossgcc/patches/gcc-15-20250119_musl_poisoned_calloc.patch R util/crossgcc/patches/gcc-15-20250119_rv32iafc.patch D util/crossgcc/sum/gcc-14.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-15-20250119.tar.xz.cksum 9 files changed, 48 insertions(+), 39 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/86100/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/86100?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e6c3745eebeb6ded494c153010283b761498184 Gerrit-Change-Number: 86100 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/mtl: Disconnect WAKE_N GPIO
by Sean Rhodes (Code Review) 05 Feb '25

05 Feb '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86269?usp=email ) Change subject: mb/starlabs/starbook/mtl: Disconnect WAKE_N GPIO ...................................................................... mb/starlabs/starbook/mtl: Disconnect WAKE_N GPIO This is not connected, so update the configuration to reflect that. Change-Id: I2922988758e0fa73b4d29ac13380f20f4606cd8e Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86269 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/mtl/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index cd90996..02f1db7 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -57,7 +57,7 @@ /* V13 */ PAD_NC(GPP_V13, NONE), /* V14: WAKE_N */ - PAD_CFG_NF(GPP_V14, NONE, DEEP, NF1), + PAD_NC(GPP_V14, NONE), /* V15: */ PAD_NC(GPP_V15, NONE), /* V16: */ -- To view, visit https://review.coreboot.org/c/coreboot/+/86269?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2922988758e0fa73b4d29ac13380f20f4606cd8e Gerrit-Change-Number: 86269 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/mtl: Disable DQS interleaving
by Sean Rhodes (Code Review) 05 Feb '25

05 Feb '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86268?usp=email ) Change subject: mb/starlabs/starbook/mtl: Disable DQS interleaving ...................................................................... mb/starlabs/starbook/mtl: Disable DQS interleaving This causes FSP-M to fail memory training, so disable it. Change-Id: I4a3544a153d6d4da95c4d679665d9c92bd04ed87 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86268 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starbook/variants/mtl/romstage.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/starlabs/starbook/variants/mtl/romstage.c b/src/mainboard/starlabs/starbook/variants/mtl/romstage.c index 956f9c5..14b2664 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/romstage.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/romstage.c @@ -11,6 +11,9 @@ .type = MEM_TYPE_DDR5, .ect = false, .UserBd = BOARD_TYPE_MOBILE, + .ddr_config = { + .dq_pins_interleaved = false, + } }; const bool half_populated = false; -- To view, visit https://review.coreboot.org/c/coreboot/+/86268?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a3544a153d6d4da95c4d679665d9c92bd04ed87 Gerrit-Change-Number: 86268 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/mtl: Disconnect CNVi GPIOs
by Sean Rhodes (Code Review) 05 Feb '25

05 Feb '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86267?usp=email ) Change subject: mb/starlabs/starbook/mtl: Disconnect CNVi GPIOs ...................................................................... mb/starlabs/starbook/mtl: Disconnect CNVi GPIOs This board does not use CNVi, so disconnect the unused GPIOs. Change-Id: I93457ed65e11c9f6f3bff052bb0d82a0389b67c9 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86267 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/mtl/gpio.c 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index fd4a090..cd90996 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -306,17 +306,17 @@ * End: GPP_F23 */ /* F00: CNV_BRI_DT */ - PAD_CFG_NF(GPP_F00, NONE, DEEP, NF1), + PAD_NC(GPP_F00, NONE), /* F01: CNV_BRI_RSP */ - PAD_CFG_NF(GPP_F01, UP_20K, DEEP, NF1), + PAD_NC(GPP_F01, NONE), /* F02: CNV_RGI_DT */ - PAD_CFG_NF(GPP_F02, NONE, DEEP, NF1), + PAD_NC(GPP_F02, NONE), /* F03: CNV_RGI_RSP */ - PAD_CFG_NF(GPP_F03, UP_20K, DEEP, NF1), + PAD_NC(GPP_F03, NONE), /* F04: CNVI_RF_RESET_N */ - PAD_CFG_NF(GPP_F00, NONE, DEEP, NF1), + PAD_NC(GPP_F00, NONE), /* F05: MODEM_CLKREQ */ - PAD_CFG_NF(GPP_F00, NONE, DEEP, NF3), + PAD_NC(GPP_F00, NONE), /* F06: */ PAD_NC(GPP_F06, NONE), /* F07: */ -- To view, visit https://review.coreboot.org/c/coreboot/+/86267?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93457ed65e11c9f6f3bff052bb0d82a0389b67c9 Gerrit-Change-Number: 86267 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/francka: Enable CNVi wifi core
by Ian Feng (Code Review) 05 Feb '25

05 Feb '25

Attention is currently required from: Kapil Porwal, Pranava Y N. Ian Feng has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/86262?usp=email ) Change subject: mb/google/fatcat/var/francka: Enable CNVi wifi core ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > note if you have FW config for WIFI with different models then you can handle this using FW config. […] OK, now francka only one WIFI module. Thank you. -- To view, visit https://review.coreboot.org/c/coreboot/+/86262?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I80c38882aab801dedb05355774e5b930a8528fed Gerrit-Change-Number: 86262 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 05 Feb 2025 08:17:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025