Attention is currently required from: Felix Held, Julius Werner, Lean Sheng Tan, Matt DeVillier, Maximilian Brune, Philipp Hug, ron minnich.
Benjamin Doron has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/84796?usp=email )
Change subject: lib/{fit,fit_payload}.c: Enhance support for FIT images
......................................................................
Patch Set 13:
(7 comments)
Patchset:
PS13:
Thank you for all the reviews, Julius, and for helping me fix up EDK2's bugs/quirks by showing me coreboot's implementation and view on FITs!
File payloads/Kconfig:
https://review.coreboot.org/c/coreboot/+/84796/comment/1b29e6fa_14449ad9?us… :
PS11, Line 33: depends on ARCH_ARM64 || ARCH_RISCV || ARCH_ARM || ARCH_X86
> Actually, does this line still make sense at all? You aren't adding any x86-specific code in this pa […]
Done
File src/lib/fit.c:
https://review.coreboot.org/c/coreboot/+/84796/comment/1cec744d_52948c87?us… :
PS11, Line 512: strcmp(config->name, default_config_name)
> I thought I pushed that, it's in my local copy. It might've gotten lost in my git stashes. […]
Ugh, no, this was a rebase error: it landed in the follow-up instead. Fixed now.
File src/lib/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/84796/comment/ea4e4e35_75d9ca09?us… :
PS6, Line 271: code.size += image_chain->image->size;
> In the kernel case `fit_payload_arch()` determines the uncompressed size and and modifies the `kerne […]
UefiPayload doesn't support compressing FIT image nodes yet (it's my belief that EDK2-based Platform Init treats the whole .FIT file as a raw file inside a UEFI FV, and applies compression/decompression at that level), so I hadn't gotten around to this earlier, because we wouldn't encounter it yet anyways.
However, since we decided that "firmware" can refer to UPL at the moment, because we don't have another project/ABI to support at the moment, I'm decoding `uncomp-size` if present and we'll allocate that much memory instead.
File src/lib/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/84796/comment/c439952e_434e62fe?us… :
PS9, Line 22: printk(BIOS_CRIT, "WEAK: Generic code called to load a FIT kernel!\n");
> Right, like in the other comment, I think I answered some of these before pushing my work on new yea […]
Accidentally slipped into the follow-up instead.
https://review.coreboot.org/c/coreboot/+/84796/comment/2f1f61e2_eba42b72?us… :
PS9, Line 401: bool status = false;
> FWIW, the use of a boolean to report the result of an "action" type function here was always wrong a […]
I'd rather not continue to expand the scope of this patch by changing function prototypes both here and elsewhere in the tree, this was about 50 lines once. Granted, that's because I imported a bug + an assumption that a bootloader/Platform Init doesn't have adequate FIT support from EDK2 (and so I wrote code that copied the FIT header into memory too), so this was necessary and I agree that the patch is better this as it is than before. Genuinely, thank you for the help, and the help in finding EDK2's bugs through showing me coreboot's perspective on FITs!
At this point, I'd rather prioritise bigger issues and then get this in, if that's alright
File src/lib/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/84796/comment/9ca65f1a_ec858121?us… :
PS11, Line 181: /* Collect info for fit_linux_arch_quirks */
> This is totally off-topic to your patch (already a bug in the existing code), but I think there shou […]
Oh, it's as good a time as any, and it's not a big deal. Done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84796?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6a21954c0dc5fd820d135e8cd0599ce87903a1c0
Gerrit-Change-Number: 84796
Gerrit-PatchSet: 13
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 05 Feb 2025 22:52:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Felix Held, Julius Werner, Lean Sheng Tan, Matt DeVillier, Maximilian Brune, Philipp Hug, ron minnich.
Hello Felix Held, Julius Werner, Lean Sheng Tan, Matt DeVillier, Maximilian Brune, Philipp Hug, build bot (Jenkins), ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84796?usp=email
to look at the new patch set (#13).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: lib/{fit,fit_payload}.c: Enhance support for FIT images
......................................................................
lib/{fit,fit_payload}.c: Enhance support for FIT images
Implement support for loading images from FIT "firmware" props.
These do not require quirks, so the implementation is common across
architectures. This is done with the intention of supporting Universal Payload.
We implement support for the "load" and "entry" props. Here, these
are implemented as fdt64_t. A follow-up will read prop-sized ints.
The selected configuration no longer requires an FDT. In this case,
we'll attempt a config matching the board ID, then fallback to the
FIT default compat.
Change-Id: I6a21954c0dc5fd820d135e8cd0599ce87903a1c0
Signed-off-by: Benjamin Doron <benjamin.doron(a)9elements.com>
---
M payloads/Kconfig
M src/arch/arm/fit_payload.c
M src/arch/arm64/fit_payload.c
M src/arch/riscv/fit_payload.c
M src/include/fit.h
M src/lib/fit.c
M src/lib/fit_payload.c
7 files changed, 308 insertions(+), 93 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/84796/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/84796?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6a21954c0dc5fd820d135e8cd0599ce87903a1c0
Gerrit-Change-Number: 84796
Gerrit-PatchSet: 13
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86289?usp=email )
Change subject: mb/starlabs/starbook/adl: Change soft strap GPIO to DEEP reset
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86289?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia2d9284a7dfd29f47356860d6085c7aa5b94adb4
Gerrit-Change-Number: 86289
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Wed, 05 Feb 2025 20:30:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86288?usp=email )
Change subject: mb/starlabs/starbook/adl: Remove OverCurrent config
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86288?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e2b087b348fbae12edaf085fb61776277514c93
Gerrit-Change-Number: 86288
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Wed, 05 Feb 2025 20:30:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86287?usp=email )
Change subject: mb/starlabs/starbook/adl: Change the HPD to DEEP reset
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86287?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04e243c6409af64fef0996b474aa448ce32b2da9
Gerrit-Change-Number: 86287
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Wed, 05 Feb 2025 20:30:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86286?usp=email )
Change subject: mb/starlabs/starbook/adl: Disconnect the WLAN Sleep GPIO
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib21048fa0972231410b7e8f7829a9eeac1d065c7
Gerrit-Change-Number: 86286
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Wed, 05 Feb 2025 20:30:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Matt DeVillier.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86286?usp=email )
Change subject: mb/starlabs/starbook/adl: Disconnect the WLAN Sleep GPIO
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/86286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib21048fa0972231410b7e8f7829a9eeac1d065c7
Gerrit-Change-Number: 86286
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 20:21:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86287?usp=email )
Change subject: mb/starlabs/starbook/adl: Change the HPD to DEEP reset
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/86287?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04e243c6409af64fef0996b474aa448ce32b2da9
Gerrit-Change-Number: 86287
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Wed, 05 Feb 2025 20:21:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86288?usp=email )
Change subject: mb/starlabs/starbook/adl: Remove OverCurrent config
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/86288?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e2b087b348fbae12edaf085fb61776277514c93
Gerrit-Change-Number: 86288
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Wed, 05 Feb 2025 20:21:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No