coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Set the driving strength of SPMI-P to maximum
by Yidi Lin (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86341?usp=email ) Change subject: soc/mediatek/mt8196: Set the driving strength of SPMI-P to maximum ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86341/comment/231268c7_fef3ac12?us… : PS3, … [View More]

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Remove tvdpll3 disable/enable
by Jarried Lin (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Jarried Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86343?usp=email ) Change subject: soc/mediatek/mt8196: Remove tvdpll3 disable/enable ...................................................................... soc/mediatek/mt8196: Remove tvdpll3 disable/enable The enable operation cause tvdpll3 cannot be disabled during suspend, so we remove it. tvdpll3 can be enabled/disabled … [View More]

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Correct MMinfra vote register
by Jarried Lin (Code Review) 09 Feb '25

09 Feb '25

Jarried Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86342?usp=email ) Change subject: soc/mediatek/mt8196: Correct MMinfra vote register ...................................................................... soc/mediatek/mt8196: Correct MMinfra vote register Correct MMinfra vote register to fix MMinfra power off fail during suspend. BRANCH=rauru BUG=b:377628718 TEST=Bootup OK and Suspend/Resume OK, with MMinfra kernel/vcp patch, mminfra can be turned … [View More]

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Set the driving strength of SPMI-P to maximum
by Jarried Lin (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86341?usp=email to look at the new patch set (#3). Change subject: soc/mediatek/mt8196: Set the driving strength of SPMI-P to maximum ...................................................................... soc/mediatek/mt8196: Set the driving strength of SPMI-P … [View More]

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Set the driving strength of SPMI-P to maximum
by Jarried Lin (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86341?usp=email to look at the new patch set (#2). Change subject: soc/mediatek/mt8196: Set the driving strength of SPMI-P to maximum ...................................................................... soc/mediatek/mt8196: Set the driving strength of SPMI-P … [View More]

1 0

[S] Change in coreboot[main]: soc/intel/cmn/pmc: Add support for early power off
by Angel Pons (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Subrata Banik. Angel Pons has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86336?usp=email ) Change subject: soc/intel/cmn/pmc: Add support for early power off ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS2: > > AIUI, the problem here is that the PCH doesn'… [View More]

1 0

[S] Change in coreboot[main]: soc/intel/cmn/pmc: Add support for early power off
by Subrata Banik (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Angel Pons, Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86336?usp=email ) Change subject: soc/intel/cmn/pmc: Add support for early power off ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > AIUI, the problem here is that the PCH doesn't want to power … [View More]

1 0

[S] Change in coreboot[main]: soc/intel/cmn/pmc: Add support for early power off
by Subrata Banik (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Subrata Banik. Hello Angel Pons, Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86336?usp=email to look at the new patch set (#3). Change subject: soc/intel/cmn/pmc: Add support for early power off .........................................................… [View More]............. soc/intel/cmn/pmc: Add support for early power off This commit adds support for early power off on Intel platforms along with existing PMC based implementation to support power off at later stage (like ramsatge). A new function, `platform_do_early_poweroff`, is added to the pmclib to handle platform-specific early power off procedures. This function is called before memory initialization (in romstage or earlier). A weak default implementation is provided which prints an error message and halts the system if EC_GOOGLE_CHROMEEC Kconfig not present. Otherwise call into `google_chromeec_do_early_poweroff` to power off the platform. BUG=b:339673254 TEST=Able to build and boot google/brox. Change-Id: I39f516640b3f75ab4c6a09826922289c0533f79b Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/common/block/include/intelblocks/pmclib.h M src/soc/intel/common/block/pmc/pmclib.c 2 files changed, 39 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/86336/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/86336?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I39f516640b3f75ab4c6a09826922289c0533f79b Gerrit-Change-Number: 86336 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> [View Less]

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Set the driving strength of SPMI-P to maximum
by Jarried Lin (Code Review) 09 Feb '25

09 Feb '25

Jarried Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86341?usp=email ) Change subject: soc/mediatek/mt8196: Set the driving strength of SPMI-P to maximum ...................................................................... soc/mediatek/mt8196: Set the driving strength of SPMI-P to maximum To fix the SPMI-P glitch, the driving strength of SPMI-P needs to be set to maximum. Additionally, a hardware solution is also required. TEST=Build pass and boot … [View More]

1 0

[S] Change in coreboot[main]: soc/intel/cmn/pmc: Add support for early power off
by Angel Pons (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, Subrata Banik. Angel Pons has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86336?usp=email ) Change subject: soc/intel/cmn/pmc: Add support for early power off ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86336?usp=email To … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025