Attention is currently required from: Matt DeVillier.
Hello Matt DeVillier,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86344?usp=email
to look at the new patch set (#2).
Change subject: mb/starlabs/*: Correct PAD ownership
......................................................................
mb/starlabs/*: Correct PAD ownership
Commit `57aca97a2c6e524b442c80d67b033a813bf10e8e` correctly changed the
reset types of GPIOs used in ACPI, but incorrectly set the pads to GPIO
mode, rather than ACPI mode.
This patch corrects that.
Change-Id: I7207d4d00e810c15d071eca0bea83796989e3735
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c
M src/mainboard/starlabs/starbook/variants/adl/gpio.c
M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c
M src/mainboard/starlabs/starbook/variants/cml/gpio.c
M src/mainboard/starlabs/starbook/variants/mtl/gpio.c
M src/mainboard/starlabs/starbook/variants/rpl/gpio.c
M src/mainboard/starlabs/starbook/variants/tgl/gpio.c
M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c
M src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c
9 files changed, 42 insertions(+), 42 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/86344/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86344?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7207d4d00e810c15d071eca0bea83796989e3735
Gerrit-Change-Number: 86344
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86344?usp=email )
Change subject: mb/starlabs/*: Correct PAD ownership
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/86344?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7207d4d00e810c15d071eca0bea83796989e3735
Gerrit-Change-Number: 86344
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Mon, 10 Feb 2025 14:44:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Ana Carolina Cabral, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86300?usp=email )
Change subject: soc/amd/common/block/graphics: Support non VGA IGDs
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> That's possible, this change is only to make sure vbt_get() returns a proper VBIOS to FSP. […]
Will update the commit message that more work is to be done to get the amdgpu driver working.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86300?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6ab28aab74f3169d45d7d852a37ddfcfc75b7c88
Gerrit-Change-Number: 86300
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 10 Feb 2025 14:36:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Ana Carolina Cabral, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86300?usp=email )
Change subject: soc/amd/common/block/graphics: Support non VGA IGDs
......................................................................
Patch Set 2:
(3 comments)
File src/device/pci_rom.c:
--
To view, visit https://review.coreboot.org/c/coreboot/+/86300?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6ab28aab74f3169d45d7d852a37ddfcfc75b7c88
Gerrit-Change-Number: 86300
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 10 Feb 2025 14:36:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Ana Carolina Cabral, Fred Reitberger, Jason Glenesk, Matt DeVillier, Patrick Rudolph.
Felix Held has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86300?usp=email )
Change subject: soc/amd/common/block/graphics: Support non VGA IGDs
......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS2:
added some comments on the pci_rom.c file for an idea how to possibly make the vfct generation work in the non-vga igpu case. completely untested though
File src/device/pci_rom.c:
--
To view, visit https://review.coreboot.org/c/coreboot/+/86300?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6ab28aab74f3169d45d7d852a37ddfcfc75b7c88
Gerrit-Change-Number: 86300
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Comment-Date: Mon, 10 Feb 2025 14:32:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Guangjie Song has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86343?usp=email )
Change subject: soc/mediatek/mt8196: Remove tvdpll3 disable/enable
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86343/comment/4a1f47d8_0039d0dc?us… :
PS1, Line 9: The enable operation cause tvdpll3 cannot be disabled during suspend,
: so we remove it.
: tvdpll3 can be enabled/disabled according to its downstream clock
: demand automatically.
> Do you mean we leave the enablement of tvdpll3 to hardware?
yes
it is enabled automatically when its downstream clock is enabled
https://review.coreboot.org/c/coreboot/+/86343/comment/cf605196_6aedd7de?us… :
PS1, Line 16: TEST=Bootup OK and Suspend/Resume OK, with MMinfra kernel/vcp patch,
: mminfra can be turned off to reduce power consumption
> Please also verify the correctness of FW screen.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/86343?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib9c72a1602c1f76dc94cca5c4a61a542a853560b
Gerrit-Change-Number: 86343
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Guangjie Song <guangjie.song(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Mon, 10 Feb 2025 13:33:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Hung-Te Lin, Jarried Lin.
Guangjie Song has uploaded a new patch set (#3) to the change originally created by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86343?usp=email )
Change subject: soc/mediatek/mt8196: Remove tvdpll3 disable/enable
......................................................................
soc/mediatek/mt8196: Remove tvdpll3 disable/enable
The enable operation cause tvdpll3 cannot be disabled during suspend,
so we remove it.
tvdpll3 can be enabled/disabled according to its downstream clock
demand automatically.
BRANCH=rauru
BUG=b:377628718
TEST=Bootup OK, Suspend/Resume OK and FW screen shown OK, with MMinfra
kernel/vcp patch, mminfra can be turned off to reduce power consumption.
Signed-off-by: Guangjie Song <guangjie.song(a)mediatek.com>
Change-Id: Ib9c72a1602c1f76dc94cca5c4a61a542a853560b
---
M src/soc/mediatek/mt8196/pll.c
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/86343/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/86343?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib9c72a1602c1f76dc94cca5c4a61a542a853560b
Gerrit-Change-Number: 86343
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Attention is currently required from: Felix Singer, Filip Lewiński, Martin L Roth, Michał Kopeć.
Krystian Hebel has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82041?usp=email )
Change subject: payloads/external/iPXE: introduce support for named configurations
......................................................................
Patch Set 9:
(1 comment)
File payloads/external/iPXE/Makefile:
https://review.coreboot.org/c/coreboot/+/82041/comment/2058ca31_79d26d45?us… :
PS9, Line 55: config: checkout apply_named_config
> This is different from what I had in mind, and it doesn't solve the original problem of modified fil […]
Actually, the `cp` doesn't seem to be needed, it should be enough to just remove old files. Empty files are created as needed by the build system.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82041?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibf7c2d9e4407035bfdf0115f4628f23b38272656
Gerrit-Change-Number: 82041
Gerrit-PatchSet: 9
Gerrit-Owner: Filip Lewiński <filip.lewinski(a)3mdeb.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Filip Lewiński <filip.lewinski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Mon, 10 Feb 2025 13:19:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Attention is currently required from: Felix Singer, Filip Lewiński, Martin L Roth, Michał Kopeć.
Krystian Hebel has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82041?usp=email )
Change subject: payloads/external/iPXE: introduce support for named configurations
......................................................................
Patch Set 9:
(1 comment)
File payloads/external/iPXE/Makefile:
https://review.coreboot.org/c/coreboot/+/82041/comment/b59f0495_c793a836?us… :
PS9, Line 55: config: checkout apply_named_config
This is different from what I had in mind, and it doesn't solve the original problem of modified files in git directory if `make build` fails.
I was thinking about using named config unconditionally (i.e. no Kconfig option), and, in this `make` target, creating files in the directory of named config, with possible `#undef`s if needed. For example, for serial (I hope I haven't made any typos):
```
cp "$(project_dir)/src/config/local/"*.h "$(NAMED_CONFIG_SRC_DIR)/"
ifeq ($(CONSOLE_SERIAL),yy)
echo "#define CONSOLE_SERIAL" >> "$(NAMED_CONFIG_SRC_DIR)/console.h"
echo "#undef COMCONSOLE" >> "$(NAMED_CONFIG_SRC_DIR)/serial.h"
echo "#define COMCONSOLE $(IPXE_UART)" >> "$(NAMED_CONFIG_SRC_DIR)/serial.h"
echo "#undef COMSPEED" >> "$(NAMED_CONFIG_SRC_DIR)/serial.h"
echo "#define COMSPEED $(CONFIG_TTYS0_BAUD)" >> "$(NAMED_CONFIG_SRC_DIR)/serial.h"
endif
```
Similarly for remaining options below.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82041?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibf7c2d9e4407035bfdf0115f4628f23b38272656
Gerrit-Change-Number: 82041
Gerrit-PatchSet: 9
Gerrit-Owner: Filip Lewiński <filip.lewinski(a)3mdeb.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Filip Lewiński <filip.lewinski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Mon, 10 Feb 2025 13:08:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86342?usp=email )
Change subject: soc/mediatek/mt8196: Correct MMinfra vote register
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c23c3c53c68b0de85d8b6189b685de7f8398e8b
Gerrit-Change-Number: 86342
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 10 Feb 2025 12:21:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes