coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[L] Change in coreboot[main]: mb/lenovo: Add ThinkCentre M900 (Skylake/LGA 1151)
by Angel Pons (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Alexander Couzens, Felix Singer, Jan Philipp Groß, Nicholas Chin, Paul Menzel. Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email ) Change subject: mb/lenovo: Add ThinkCentre M900 (Skylake/LGA 1151) ...................................................................... Patch Set 5: (1 comment) File src/mainboard/lenovo/m900/cmos.layout: https://review.coreboot.org/c/coreboot/+/74187/comment/79a5588c_cf82874c?us… : PS4, Line 28: ChromeOS > It seems like there is an intention to deprecate VBOOT_VBNV_CMOS (https://issuetracker.google. […] Okay, then I'd at least update the comment to say vboot instead of ChromeOS -- To view, visit https://review.coreboot.org/c/coreboot/+/74187?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4e70c9f42c19f130a00170b32ae74b61f0483a22 Gerrit-Change-Number: 74187 Gerrit-PatchSet: 5 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 09 Feb 2025 21:37:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/lenovo: Add ThinkCentre M900 (Skylake/LGA 1151)
by Angel Pons (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Alexander Couzens, Felix Singer, Jan Philipp Groß, Nicholas Chin, Paul Menzel. Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email ) Change subject: mb/lenovo: Add ThinkCentre M900 (Skylake/LGA 1151) ...................................................................... Patch Set 5: (1 comment) File src/mainboard/lenovo/m900/acpi/dptf.asl: PS4: > No. […] Yes, along with other DPTF stuff. I don't think it's meaningful on a desktop anyway -- To view, visit https://review.coreboot.org/c/coreboot/+/74187?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4e70c9f42c19f130a00170b32ae74b61f0483a22 Gerrit-Change-Number: 74187 Gerrit-PatchSet: 5 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 09 Feb 2025 21:36:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Add missing USB port definitions
by Matt DeVillier (Code Review) 09 Feb '25

09 Feb '25

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86319?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/intel/meteorlake: Add missing USB port definitions ...................................................................... soc/intel/meteorlake: Add missing USB port definitions The TCSS_XHCI controller has a single USB2 port followed by 4 USB3 ports; the XHCI controller has 12 USB2 ports followed by 2 USB3 ports. The topology was queried from the root hub on each controller and returned via the descriptor. Add the 2 missing USB2 ports to the XHCI controller and the one to the TSS_XHCI controller. TEST=build/boot Win11, Linux 6.x on starlabs/starbook_mtl. Change-Id: I5dc97f150ff064d55e7969f10c1cea8ba72d6bfb Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86319 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/soc/intel/meteorlake/chipset.cb 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Sean Rhodes: Looks good to me, approved diff --git a/src/soc/intel/meteorlake/chipset.cb b/src/soc/intel/meteorlake/chipset.cb index 9087dd8..7b26670 100644 --- a/src/soc/intel/meteorlake/chipset.cb +++ b/src/soc/intel/meteorlake/chipset.cb @@ -70,6 +70,9 @@ register "type" = "UPC_TYPE_HUB" device usb 0.0 alias tcss_root_hub off chip drivers/usb/acpi + device usb 2.0 alias tcss_usb2_port1 off end + end + chip drivers/usb/acpi device usb 3.0 alias tcss_usb3_port0 off end end chip drivers/usb/acpi @@ -132,6 +135,12 @@ device usb 2.9 alias usb2_port10 off end end chip drivers/usb/acpi + device usb 2.a alias usb2_port11 off end + end + chip drivers/usb/acpi + device usb 2.b alias usb2_port12 off end + end + chip drivers/usb/acpi device usb 3.0 alias usb3_port1 off end end chip drivers/usb/acpi -- To view, visit https://review.coreboot.org/c/coreboot/+/86319?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5dc97f150ff064d55e7969f10c1cea8ba72d6bfb Gerrit-Change-Number: 86319 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/common: Measure mtk_fsp_load_and_run() execution time
by Matt DeVillier (Code Review) 09 Feb '25

09 Feb '25

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86325?usp=email ) Change subject: soc/mediatek/common: Measure mtk_fsp_load_and_run() execution time ...................................................................... soc/mediatek/common: Measure mtk_fsp_load_and_run() execution time Measure mtk_fsp_load_and_run() execution time. This info helps AP boot time analysis. The logs show as below. [INFO ] mtk_fsp_load_and_run: run fallback/mtk_fsp_romstage at phase 0x30 in 0 msecs [INFO ] mtk_fsp_load_and_run: run fallback/mtk_fsp_ramstage at phase 0x50 in 41 msecs BUG=none BRANCH=rauru TEST=cbmem -1|grep "mtk_fsp_load_and_run" Change-Id: I61706952bef4590c5bfd09707a08a4f1a25fbda2 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86325 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M src/soc/mediatek/common/mtk_fsp.c 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/src/soc/mediatek/common/mtk_fsp.c b/src/soc/mediatek/common/mtk_fsp.c index bc1b5d5..073a079 100644 --- a/src/soc/mediatek/common/mtk_fsp.c +++ b/src/soc/mediatek/common/mtk_fsp.c @@ -3,6 +3,7 @@ #include <cbfs.h> #include <console/console.h> #include <soc/mtk_fsp.h> +#include <timer.h> #define MAX_PARAM_ENTRIES 32 #define FSP_INTF_SIZE (sizeof(struct mtk_fsp_intf) + \ @@ -82,7 +83,9 @@ enum cb_err mtk_fsp_load_and_run(void) { struct prog fsp = PROG_INIT(PROG_REFCODE, mtk_fsp_file()); + struct stopwatch sw; + stopwatch_init(&sw); if (cbfs_prog_stage_load(&fsp)) { printk(BIOS_ERR, "%s: CBFS load program failed\n", __func__); return CB_ERR; @@ -101,8 +104,8 @@ return CB_ERR; } - printk(BIOS_INFO, "%s: run %s at phase %#x done\n", - __func__, mtk_fsp_file(), intf->phase); + printk(BIOS_INFO, "%s: run %s at phase %#x in %lld msecs\n", + __func__, mtk_fsp_file(), intf->phase, stopwatch_duration_msecs(&sw)); return CB_SUCCESS; } -- To view, visit https://review.coreboot.org/c/coreboot/+/86325?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I61706952bef4590c5bfd09707a08a4f1a25fbda2 Gerrit-Change-Number: 86325 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/{volteer,brya,rex}: Disable 8254 timers by default
by Alicja Michalska (Code Review) 09 Feb '25

09 Feb '25

Alicja Michalska has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/85976?usp=email ) Change subject: mb/google/{volteer,brya,rex}: Disable 8254 timers by default ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/85976?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I61f617c65707b7e9113770162885fd13a13a1d67 Gerrit-Change-Number: 85976 Gerrit-PatchSet: 2 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/erying/tgl: Drop specifying which timers to use
by Alicja Michalska (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Jérémy Compostella, Matt DeVillier. Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/86093?usp=email ) Change subject: mb/erying/tgl: Drop specifying which timers to use ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86093/comment/a92a8505_bfacf8ad?us… : PS5, Line 10: If we build coreboot with both timers =N, system enters s0ix state (although it doesn't cut the power to the platform) and can be woken up by pressing the key on the keyboard. > Please wrap lines at 72 characters Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86093?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If6e0ac1d289447c292a49111251d321c951078e2 Gerrit-Change-Number: 86093 Gerrit-PatchSet: 6 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sun, 09 Feb 2025 20:35:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/erying/tgl: Drop specifying which timers to use
by Alicja Michalska (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Alicja Michalska, Jérémy Compostella, Matt DeVillier. Hello Angel Pons, Jérémy Compostella, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86093?usp=email to look at the new patch set (#6). Change subject: mb/erying/tgl: Drop specifying which timers to use ...................................................................... mb/erying/tgl: Drop specifying which timers to use With 8254 timer enabled, system would hang while entering s0ix state. If we build coreboot with both timers =N, system enters s0ix state (although it doesn't cut the power to the platform) and can be woken up by pressing the key on the keyboard. Since there's less potential for data loss in case of accidental suspend, I think it makes sense to do it this way. Change-Id: If6e0ac1d289447c292a49111251d321c951078e2 Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com> --- M src/mainboard/erying/tgl/Kconfig 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/86093/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/86093?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If6e0ac1d289447c292a49111251d321c951078e2 Gerrit-Change-Number: 86093 Gerrit-PatchSet: 6 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[L] Change in coreboot[main]: {ec,mb}/starlabs: Consolidate EC-related CFR options in ec directory
by Sean Rhodes (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86318?usp=email ) Change subject: {ec,mb}/starlabs: Consolidate EC-related CFR options in ec directory ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86318?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I831559184de917b32e4993e8e34ffbc7b7e883e4 Gerrit-Change-Number: 86318 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sun, 09 Feb 2025 20:25:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: ec/starlabs/merlin: Only include lid switch ACPI when needed
by Matt DeVillier (Code Review) 09 Feb '25

09 Feb '25

Attention is currently required from: Matt DeVillier, Sean Rhodes. Hello Sean Rhodes, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86322?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Sean Rhodes, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: ec/starlabs/merlin: Only include lid switch ACPI when needed ...................................................................... ec/starlabs/merlin: Only include lid switch ACPI when needed Desktop devices don't need and shouldn't define a lid switch. TEST=build/boot starlabs/byte,starlite_adl Change-Id: Iecf3e2558e244cc0bec301a505c0bc86684954aa Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/ec/starlabs/merlin/acpi/ec.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/86322/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86322?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iecf3e2558e244cc0bec301a505c0bc86684954aa Gerrit-Change-Number: 86322 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[XS] Change in coreboot[main]: ec/starlabs/merlin: Drop unused reference to events.asl
by Matt DeVillier (Code Review) 09 Feb '25

09 Feb '25

Matt DeVillier has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/86321?usp=email ) Change subject: ec/starlabs/merlin: Drop unused reference to events.asl ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/86321?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifbb986378dd49c6a1d316a4922c46c46180497ee Gerrit-Change-Number: 86321 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025