coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[XS] Change in coreboot[main]: mb/google/nissa/var/dirks: Update GPIO table
by Ivy Jian (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Ivy Jian has posted comments on this change by Ivy Jian. ( https://review.coreboot.org/c/coreboot/+/86351?usp=email ) Change subject: mb/google/nissa/var/dirks: Update GPIO table ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > isn't these two changes are independent like gpio. […] updated, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/86351?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iefc6aefeae0a3a05ba04fb2718c6c3a3058de5f8 Gerrit-Change-Number: 86351 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 11 Feb 2025 08:05:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Fix issue of RTC recovery failed
by Yidi Lin (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Hung-Te Lin, Jarried Lin. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86353?usp=email ) Change subject: soc/mediatek/mt8196: Fix issue of RTC recovery failed ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/86353/comment/19254050_7dc32cbe?us… : PS1, Line 16: rtc will boot normally RTC boots normally. https://review.coreboot.org/c/coreboot/+/86353/comment/dfc42d74_70de3ab6?us… : PS1, Line 16: charge charger ? -- To view, visit https://review.coreboot.org/c/coreboot/+/86353?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iea44f13af030f24c02993dd43a35a9d8b4f72179 Gerrit-Change-Number: 86353 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Tue, 11 Feb 2025 08:03:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/dirks: Update GPIO table
by Ivy Jian (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Ivy Jian has posted comments on this change by Ivy Jian. ( https://review.coreboot.org/c/coreboot/+/86351?usp=email ) Change subject: mb/google/nissa/var/dirks: Update GPIO table ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86351?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iefc6aefeae0a3a05ba04fb2718c6c3a3058de5f8 Gerrit-Change-Number: 86351 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 11 Feb 2025 08:00:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Add validity check for PI_IMG
by Yidi Lin (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/86352?usp=email ) Change subject: soc/mediatek/mt8196: Add validity check for PI_IMG ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86352?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7b8085c1229c1a7a8cad904e166471ff8bda5cfb Gerrit-Change-Number: 86352 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 11 Feb 2025 07:59:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/dirks: Use a separate ec.h for dirks
by Ivy Jian (Code Review) 11 Feb '25

11 Feb '25

Ivy Jian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86354?usp=email ) Change subject: mb/google/nissa/var/dirks: Use a separate ec.h for dirks ...................................................................... mb/google/nissa/var/dirks: Use a separate ec.h for dirks Dirks are chromebox, so they need different settings in ec.h. Add a new dirks baseboard ec.h and use it for dirks.Remove everything related to: - Lid - Battery - Built-in keyboard - AC connect/disconnect - Mode changes BUG=b:389391653 TEST=emerge-nissa coreboot Change-Id: I8089a2aff3032a4271212765f65881a09f42c1ae Signed-off-by: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> --- A src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/dirks/ec.h M src/mainboard/google/brya/variants/dirks/include/variant/ec.h 2 files changed, 45 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/86354/1 diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/dirks/ec.h b/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/dirks/ec.h new file mode 100644 index 0000000..d9697d7 --- /dev/null +++ b/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/dirks/ec.h @@ -0,0 +1,44 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __BASEBOARD_EC_H__ +#define __BASEBOARD_EC_H__ + +#include <ec/ec.h> +#include <ec/google/chromeec/ec_commands.h> +#include <baseboard/gpio.h> + +#define MAINBOARD_EC_SCI_EVENTS \ + (EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX)) +#define MAINBOARD_EC_SMI_EVENTS 0 +/* EC can wake from S5 with power button */ +#define MAINBOARD_EC_S5_WAKE_EVENTS \ + (EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON)) +/* EC can wake from S3 with power button */ +#define MAINBOARD_EC_S3_WAKE_EVENTS (MAINBOARD_EC_S5_WAKE_EVENTS) +#define MAINBOARD_EC_S0IX_WAKE_EVENTS \ + (MAINBOARD_EC_S3_WAKE_EVENTS |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_HANG_DETECT)) +/* Log EC wake events plus EC shutdown events */ +#define MAINBOARD_EC_LOG_EVENTS \ + (EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_SHUTDOWN) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_PANIC)) +/* + * ACPI related definitions for ASL code. + */ +/* Enable cros_ec_keyb device */ +#define EC_ENABLE_MKBP_DEVICE +#define EC_ENABLE_WAKE_PIN GPE_EC_WAKE +/* Enable EC backed PD MCU device in ACPI */ +#define EC_ENABLE_PD_MCU_DEVICE +#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ +#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ + +#define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp support */ + +#endif /* __BASEBOARD_EC_H__ */ diff --git a/src/mainboard/google/brya/variants/dirks/include/variant/ec.h b/src/mainboard/google/brya/variants/dirks/include/variant/ec.h index 7a2a6ff..469e75c 100644 --- a/src/mainboard/google/brya/variants/dirks/include/variant/ec.h +++ b/src/mainboard/google/brya/variants/dirks/include/variant/ec.h @@ -3,6 +3,6 @@ #ifndef __VARIANT_EC_H__ #define __VARIANT_EC_H__ -#include <baseboard/ec.h> +#include <baseboard/dirks/ec.h> #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/86354?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8089a2aff3032a4271212765f65881a09f42c1ae Gerrit-Change-Number: 86354 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Fix issue of RTC recovery failed
by Yu-Ping Wu (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86353?usp=email ) Change subject: soc/mediatek/mt8196: Fix issue of RTC recovery failed ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86353/comment/ad36fdf4_683c8d84?us… : PS1, Line 7: issue of RTC recovery failed RTC recovery by disabling external XTAL -- To view, visit https://review.coreboot.org/c/coreboot/+/86353?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iea44f13af030f24c02993dd43a35a9d8b4f72179 Gerrit-Change-Number: 86353 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 11 Feb 2025 07:51:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Fix issue of RTC recovery failed
by Yu-Ping Wu (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86353?usp=email ) Change subject: soc/mediatek/mt8196: Fix issue of RTC recovery failed ...................................................................... Patch Set 1: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/86353/comment/4d10bf87_2ddfffcc?us… : PS1, Line 9: decide whether decides whether to https://review.coreboot.org/c/coreboot/+/86353/comment/57d206cd_e424317a?us… : PS1, Line 9: pmic PMIC https://review.coreboot.org/c/coreboot/+/86353/comment/6f707b01_7d87d650?us… : PS1, Line 9: Config Configure https://review.coreboot.org/c/coreboot/+/86353/comment/e610013b_33b811e4?us… : PS1, Line 9: , : t . T https://review.coreboot.org/c/coreboot/+/86353/comment/7b347794_bc44c038?us… : PS1, Line 10: , which means without external : xtal. to disable external xtal. -- To view, visit https://review.coreboot.org/c/coreboot/+/86353?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iea44f13af030f24c02993dd43a35a9d8b4f72179 Gerrit-Change-Number: 86353 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 11 Feb 2025 07:50:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Fix issue of RTC recovery failed
by Jarried Lin (Code Review) 11 Feb '25

11 Feb '25

Jarried Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86353?usp=email ) Change subject: soc/mediatek/mt8196: Fix issue of RTC recovery failed ...................................................................... soc/mediatek/mt8196: Fix issue of RTC recovery failed Config pmic register 0x50c bit0 which decide whether use external xtal, this bit of mt6685 should be set to 1, which means without external xtal. BRANCH=rauru BUG=b:395485005 TEST=emerge-rauru coreboot chromeos-bootimage, remove battery and charge, then insert battery and charge, rtc will boot normally Signed-off-by: Shunxi Zhang <ot_shunxi.zhang(a)mediatek.com> Change-Id: Iea44f13af030f24c02993dd43a35a9d8b4f72179 --- M src/soc/mediatek/mt8196/mt6685_rtc.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/86353/1 diff --git a/src/soc/mediatek/mt8196/mt6685_rtc.c b/src/soc/mediatek/mt8196/mt6685_rtc.c index 4564a31..4e63f10 100644 --- a/src/soc/mediatek/mt8196/mt6685_rtc.c +++ b/src/soc/mediatek/mt8196/mt6685_rtc.c @@ -345,6 +345,10 @@ { printk(BIOS_INFO, "%s: enter\n", __func__); + config_interface(SCK_TOP_XTAL_SEL_ADDR, 1, SCK_TOP_XTAL_SEL_MASK, + SCK_TOP_XTAL_SEL_SHIFT); + udelay(100); + if (!retry(RECOVERY_RETRY_COUNT, rtc_frequency_meter_check() && rtc_init_after_recovery())) { -- To view, visit https://review.coreboot.org/c/coreboot/+/86353?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iea44f13af030f24c02993dd43a35a9d8b4f72179 Gerrit-Change-Number: 86353 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/dirks: Update GPIO table
by Subrata Banik (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Ivy Jian, Jayvik Desai, Kapil Porwal, Nick Vaccaro. Subrata Banik has posted comments on this change by Ivy Jian. ( https://review.coreboot.org/c/coreboot/+/86351?usp=email ) Change subject: mb/google/nissa/var/dirks: Update GPIO table ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: isn't these two changes are independent like gpio.c and makefile ? -- To view, visit https://review.coreboot.org/c/coreboot/+/86351?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iefc6aefeae0a3a05ba04fb2718c6c3a3058de5f8 Gerrit-Change-Number: 86351 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 11 Feb 2025 07:44:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Add validity check for PI_IMG
by Yu-Ping Wu (Code Review) 11 Feb '25

11 Feb '25

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86352?usp=email ) Change subject: soc/mediatek/mt8196: Add validity check for PI_IMG ...................................................................... soc/mediatek/mt8196: Add validity check for PI_IMG Add a simple validity check for the PI_IMG firmware file. BUG=none TEST=emerge-rauru coreboot BRANCH=rauru Change-Id: I7b8085c1229c1a7a8cad904e166471ff8bda5cfb Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/soc/mediatek/mt8196/Makefile.mk 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/86352/1 diff --git a/src/soc/mediatek/mt8196/Makefile.mk b/src/soc/mediatek/mt8196/Makefile.mk index 4dd2d2d..a67da6b 100644 --- a/src/soc/mediatek/mt8196/Makefile.mk +++ b/src/soc/mediatek/mt8196/Makefile.mk @@ -115,6 +115,13 @@ $(if $(wildcard $($(fw)-file)), $(eval cbfs-files-y += $(fw)), ) \ ) +# Validity check for PI_IMG. +PI_IMG_COOKIE_COUNT := $(shell xxd -p -c 4 --seek 0x200 $(MT8196_BLOB_DIR)/$(CONFIG_PI_IMG_FIRMWARE) \ + | grep -c b4a6c317) +ifneq ($(PI_IMG_COOKIE_COUNT),2) +$(error Invalid PI_IMG $(CONFIG_PI_IMG_FIRMWARE)) +endif + DRAM_CBFS := $(CONFIG_CBFS_PREFIX)/dram $(DRAM_CBFS)-file := $(MT8196_BLOB_DIR)/dram.elf $(DRAM_CBFS)-type := stage -- To view, visit https://review.coreboot.org/c/coreboot/+/86352?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7b8085c1229c1a7a8cad904e166471ff8bda5cfb Gerrit-Change-Number: 86352 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025