coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[XL] Change in coreboot[main]: soc/intel/xeon-sp/spr: Hook up public FSP bin and headers
by Angel Pons (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Fabian Meyer, Intel coreboot Reviewers, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Shuo Liu, Srinidhi N Kaushik, Tim Chu. Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/80360?usp=email ) Change subject: soc/intel/xeon-sp/spr: Hook up public FSP bin and headers ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Arthur and all, the FSP repo update is upcoming, and here we updated the coreboot changes accordingl […] Looks like you need to update the 3rdparty/fsp submodule, I see there's stuff in https://github.com/intel/FSP/tree/master/EagleStreamFspBinPkg -- To view, visit https://review.coreboot.org/c/coreboot/+/80360?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I778d3535c273dff653330518653bdefcb45e66f4 Gerrit-Change-Number: 80360 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Fabian Meyer <fabian(a)meyfa.net> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Fabian Meyer <fabian(a)meyfa.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Attention: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 11 Feb 2025 09:24:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com>

1 0

[L] Change in coreboot[main]: {ec,mb}/starlabs: Consolidate EC-related CFR options in ec directory
by Sean Rhodes (Code Review) 11 Feb '25

11 Feb '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86318?usp=email ) Change subject: {ec,mb}/starlabs: Consolidate EC-related CFR options in ec directory ...................................................................... {ec,mb}/starlabs: Consolidate EC-related CFR options in ec directory Move all of the EC-related CFR options into a header in the ec directory, so it can be reused across multiple boards. TEST=build/boot starlabs/starbook_mtl,starlite_adl and verify CFR options work properly. Change-Id: I831559184de917b32e4993e8e34ffbc7b7e883e4 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86318 Reviewed-by: Sean Rhodes <sean(a)starlabs.systems> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- A src/ec/starlabs/merlin/cfr.h M src/mainboard/starlabs/lite/cfr.c M src/mainboard/starlabs/starbook/cfr.c M src/mainboard/starlabs/starfighter/cfr.c M src/mainboard/starlabs/starlite_adl/cfr.c 5 files changed, 118 insertions(+), 227 deletions(-) Approvals: build bot (Jenkins): Verified Sean Rhodes: Looks good to me, approved diff --git a/src/ec/starlabs/merlin/cfr.h b/src/ec/starlabs/merlin/cfr.h new file mode 100644 index 0000000..b56e7d2 --- /dev/null +++ b/src/ec/starlabs/merlin/cfr.h @@ -0,0 +1,114 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +/* + * CFR enums and structs which are used to control EC settings. + */ + +#include <drivers/option/cfr_frontend.h> +#include "ec.h" + +/* + * Keyboard Backlight Timeout + */ +static const struct sm_object kbl_timeout = SM_DECLARE_ENUM({ + .opt_name = "kbl_timeout", + .ui_name = "Keyboard Backlight Timeout", + .ui_helptext = "Set the amount of time before the keyboard backlight turns off" + " when un-used", + .default_value = 0, + .values = (struct sm_enum_value[]) { + { "30 seconds", 0 }, + { "1 minute", 1 }, + { "3 minutes", 2 }, + { "5 minutes", 3 }, + { "Never", 4 }, + SM_ENUM_VALUE_END }, +}); + + +/* + * Function-Control Swap + */ +static const struct sm_object fn_ctrl_swap = SM_DECLARE_BOOL({ + .opt_name = "fn_ctrl_swap", + .ui_name = "Fn Ctrl Reverse", + .ui_helptext = "Swap the functions of the [Fn] and [Ctrl] keys", + .default_value = false, +}); + +/* + * Maximum Battery Charge Level + */ +static const struct sm_object max_charge = SM_DECLARE_ENUM({ + .opt_name = "max_charge", + .ui_name = "Maximum Charge Level", + .ui_helptext = "Set the maximum level the battery will charge to.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "100%", 0 }, + { "80%", 1 }, + { "60%", 2 }, + SM_ENUM_VALUE_END }, +}); + +/* + * Fan Mode + */ +static const struct sm_object fan_mode = SM_DECLARE_ENUM({ + .opt_name = "fan_mode", + .ui_name = "Fan Mode", + .ui_helptext = "Adjust the fan curve to prioritize performance or noise levels.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Normal", 0 }, + { "Aggressive", 1 }, + { "Quiet", 2 }, + { "Disabled", 3 }, + SM_ENUM_VALUE_END }, +}); + +/* + * Charging Speed + */ +static const struct sm_object charging_speed = SM_DECLARE_ENUM({ + .opt_name = "charging_speed", + .ui_name = "Charging Speed", + .ui_helptext = "Set the maximum speed to charge the battery. Charging faster" + " will increase heat and battery wear.", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "1.0C", 0 }, + { "0.5C", 1 }, + { "0.2C", 2 }, + SM_ENUM_VALUE_END }, +}); + +/* + * Lid Switch + */ +static const struct sm_object lid_switch = SM_DECLARE_ENUM({ + .opt_name = "lid_switch", + .ui_name = "Lid Switch", + .ui_helptext = "Configure what opening or closing the lid will do.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Normal", 0 }, + { "Sleep Only", 1 }, + { "Disabled", 2 }, + SM_ENUM_VALUE_END }, +}); + +/* + * Power LED Brightness + */ +static const struct sm_object power_led = SM_DECLARE_ENUM({ + .opt_name = "power_led", + .ui_name = "Power LED Brightness", + .ui_helptext = "Control the maximum brightness of the power LED", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Normal", 0 }, + { "Reduced", 1 }, + SM_ENUM_VALUE_END, + }, +}); diff --git a/src/mainboard/starlabs/lite/cfr.c b/src/mainboard/starlabs/lite/cfr.c index e0d22e6..251f55c 100644 --- a/src/mainboard/starlabs/lite/cfr.c +++ b/src/mainboard/starlabs/lite/cfr.c @@ -3,6 +3,7 @@ #include <boot/coreboot_tables.h> #include <commonlib/coreboot_tables.h> #include <drivers/option/cfr_frontend.h> +#include <ec/starlabs/merlin/cfr.h> #include <inttypes.h> #include <intelblocks/pcie_rp.h> #include <string.h> @@ -54,28 +55,6 @@ }); #endif -static const struct sm_object fn_ctrl_swap = SM_DECLARE_BOOL({ - .opt_name = "fn_ctrl_swap", - .ui_name = "Fn Ctrl Reverse", - .ui_helptext = "Swap the functions of the [Fn] and [Ctrl] keys", - .default_value = false, -}); - -static const struct sm_object kbl_timeout = SM_DECLARE_ENUM({ - .opt_name = "kbl_timeout", - .ui_name = "Keyboard Backlight Timeout", - .ui_helptext = "Set the amount of time before the keyboard backlight turns off" - " when un-used", - .default_value = 0, - .values = (struct sm_enum_value[]) { - { "30 seconds", 0 }, - { "1 minute", 1 }, - { "3 minutes", 2 }, - { "5 minutes", 3 }, - { "Never", 4 }, - SM_ENUM_VALUE_END }, -}); - static const struct sm_object power_on_after_fail = SM_DECLARE_BOOL({ .opt_name = "power_on_after_fail", .ui_name = "Power on after failure", diff --git a/src/mainboard/starlabs/starbook/cfr.c b/src/mainboard/starlabs/starbook/cfr.c index bf0e4b0..1e08ba1 100644 --- a/src/mainboard/starlabs/starbook/cfr.c +++ b/src/mainboard/starlabs/starbook/cfr.c @@ -3,6 +3,7 @@ #include <boot/coreboot_tables.h> #include <commonlib/coreboot_tables.h> #include <drivers/option/cfr_frontend.h> +#include <ec/starlabs/merlin/cfr.h> #include <inttypes.h> #include <intelblocks/pcie_rp.h> #include <string.h> @@ -27,21 +28,6 @@ .default_value = true, }); -#if CONFIG(EC_STARLABS_CHARGING_SPEED) -static const struct sm_object charging_speed = SM_DECLARE_ENUM({ - .opt_name = "charging_speed", - .ui_name = "Charging Speed", - .ui_helptext = "Set the maximum speed to charge the battery. Charging faster" - " will increase heat and battery wear.", - .default_value = 1, - .values = (const struct sm_enum_value[]) { - { "1.0C", 0 }, - { "0.5C", 1 }, - { "0.2C", 2 }, - SM_ENUM_VALUE_END }, -}); -#endif - static const struct sm_object debug_level = SM_DECLARE_ENUM({ .opt_name = "debug_level", .ui_name = "Debug Level", @@ -60,19 +46,6 @@ SM_ENUM_VALUE_END }, }); -static const struct sm_object fan_mode = SM_DECLARE_ENUM({ - .opt_name = "fan_mode", - .ui_name = "Fan Mode", - .ui_helptext = "Adjust the fan curve to prioritize performance or noise levels.", - .default_value = 0, - .values = (const struct sm_enum_value[]) { - { "Normal", 0 }, - { "Aggressive", 1 }, - { "Quiet", 2 }, - { "Disabled", 3 }, - SM_ENUM_VALUE_END }, -}); - #if CONFIG(BOARD_STARLABS_STARBOOK_ADL) || CONFIG(BOARD_STARLABS_STARBOOK_RPL) static const struct sm_object fingerprint_reader = SM_DECLARE_BOOL({ .opt_name = "fingerprint_reader", @@ -82,13 +55,6 @@ }); #endif -static const struct sm_object fn_ctrl_swap = SM_DECLARE_BOOL({ - .opt_name = "fn_ctrl_swap", - .ui_name = "Fn Ctrl Reverse", - .ui_helptext = "Swap the functions of the [Fn] and [Ctrl] keys", - .default_value = false, -}); - #if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE) static const struct sm_object gna = SM_DECLARE_BOOL({ .opt_name = "gna", @@ -107,47 +73,6 @@ }); #endif -static const struct sm_object kbl_timeout = SM_DECLARE_ENUM({ - .opt_name = "kbl_timeout", - .ui_name = "Keyboard Backlight Timeout", - .ui_helptext = "Set the amount of time before the keyboard backlight turns off" - " when un-used", - .default_value = 0, - .values = (struct sm_enum_value[]) { - { "30 seconds", 0 }, - { "1 minute", 1 }, - { "3 minutes", 2 }, - { "5 minutes", 3 }, - { "Never", 4 }, - SM_ENUM_VALUE_END }, -}); - -#if CONFIG(EC_STARLABS_LID_SWITCH) -static const struct sm_object lid_switch = SM_DECLARE_ENUM({ - .opt_name = "lid_switch", - .ui_name = "Lid Switch", - .ui_helptext = "Configure what opening or closing the lid will do.", - .default_value = 0, - .values = (const struct sm_enum_value[]) { - { "Normal", 0 }, - { "Sleep Only", 1 }, - { "Disabled", 2 }, - SM_ENUM_VALUE_END }, -}); -#endif - -static const struct sm_object max_charge = SM_DECLARE_ENUM({ - .opt_name = "max_charge", - .ui_name = "Maximum Charge Level", - .ui_helptext = "Set the maximum level the battery will charge to.", - .default_value = 0, - .values = (const struct sm_enum_value[]) { - { "100%", 0 }, - { "80%", 1 }, - { "60%", 2 }, - SM_ENUM_VALUE_END }, -}); - static const struct sm_object me_state = SM_DECLARE_ENUM({ .opt_name = "me_state", .ui_name = "Intel Management Engine", diff --git a/src/mainboard/starlabs/starfighter/cfr.c b/src/mainboard/starlabs/starfighter/cfr.c index f310f86..7e040cc 100644 --- a/src/mainboard/starlabs/starfighter/cfr.c +++ b/src/mainboard/starlabs/starfighter/cfr.c @@ -3,6 +3,7 @@ #include <boot/coreboot_tables.h> #include <commonlib/coreboot_tables.h> #include <drivers/option/cfr_frontend.h> +#include <ec/starlabs/merlin/cfr.h> #include <inttypes.h> #include <intelblocks/pcie_rp.h> #include <string.h> @@ -20,21 +21,6 @@ SM_ENUM_VALUE_END }, }); -#if CONFIG(EC_STARLABS_CHARGING_SPEED) -static const struct sm_object charging_speed = SM_DECLARE_ENUM({ - .opt_name = "charging_speed", - .ui_name = "Charging Speed", - .ui_helptext = "Set the maximum speed to charge the battery. Charging faster" - " will increase heat and battery wear.", - .default_value = 1, - .values = (const struct sm_enum_value[]) { - { "1.0C", 0 }, - { "0.5C", 1 }, - { "0.2C", 2 }, - SM_ENUM_VALUE_END }, -}); -#endif - static const struct sm_object debug_level = SM_DECLARE_ENUM({ .opt_name = "debug_level", .ui_name = "Debug Level", @@ -53,26 +39,6 @@ SM_ENUM_VALUE_END }, }); -static const struct sm_object fan_mode = SM_DECLARE_ENUM({ - .opt_name = "fan_mode", - .ui_name = "Fan Mode", - .ui_helptext = "Adjust the fan curve to prioritize performance or noise levels.", - .default_value = 0, - .values = (const struct sm_enum_value[]) { - { "Normal", 0 }, - { "Aggressive", 1 }, - { "Quiet", 2 }, - { "Disabled", 3 }, - SM_ENUM_VALUE_END }, -}); - -static const struct sm_object fn_ctrl_swap = SM_DECLARE_BOOL({ - .opt_name = "fn_ctrl_swap", - .ui_name = "Fn Ctrl Reverse", - .ui_helptext = "Swap the functions of the [Fn] and [Ctrl] keys", - .default_value = false, -}); - #if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE) static const struct sm_object gna = SM_DECLARE_BOOL({ .opt_name = "gna", @@ -89,47 +55,6 @@ .default_value = true, }); -static const struct sm_object kbl_timeout = SM_DECLARE_ENUM({ - .opt_name = "kbl_timeout", - .ui_name = "Keyboard Backlight Timeout", - .ui_helptext = "Set the amount of time before the keyboard backlight turns off" - " when un-used", - .default_value = 0, - .values = (struct sm_enum_value[]) { - { "30 seconds", 0 }, - { "1 minute", 1 }, - { "3 minutes", 2 }, - { "5 minutes", 3 }, - { "Never", 4 }, - SM_ENUM_VALUE_END }, -}); - -#if CONFIG(EC_STARLABS_LID_SWITCH) -static const struct sm_object lid_switch = SM_DECLARE_ENUM({ - .opt_name = "lid_switch", - .ui_name = "Lid Switch", - .ui_helptext = "Configure what opening or closing the lid will do.", - .default_value = 0, - .values = (const struct sm_enum_value[]) { - { "Normal", 0 }, - { "Sleep Only", 1 }, - { "Disabled", 2 }, - SM_ENUM_VALUE_END }, -}); -#endif - -static const struct sm_object max_charge = SM_DECLARE_ENUM({ - .opt_name = "max_charge", - .ui_name = "Maximum Charge Level", - .ui_helptext = "Set the maximum level the battery will charge to.", - .default_value = 0, - .values = (const struct sm_enum_value[]) { - { "100%", 0 }, - { "80%", 1 }, - { "60%", 2 }, - SM_ENUM_VALUE_END }, -}); - static const struct sm_object me_state = SM_DECLARE_ENUM({ .opt_name = "me_state", .ui_name = "Intel Management Engine", diff --git a/src/mainboard/starlabs/starlite_adl/cfr.c b/src/mainboard/starlabs/starlite_adl/cfr.c index a8e44fa..a00a7a7 100644 --- a/src/mainboard/starlabs/starlite_adl/cfr.c +++ b/src/mainboard/starlabs/starlite_adl/cfr.c @@ -3,6 +3,7 @@ #include <boot/coreboot_tables.h> #include <commonlib/coreboot_tables.h> #include <drivers/option/cfr_frontend.h> +#include <ec/starlabs/merlin/cfr.h> #include <inttypes.h> #include <intelblocks/pcie_rp.h> #include <string.h> @@ -27,21 +28,6 @@ SM_ENUM_VALUE_END }, }); -#if CONFIG(EC_STARLABS_CHARGING_SPEED) -static const struct sm_object charging_speed = SM_DECLARE_ENUM({ - .opt_name = "charging_speed", - .ui_name = "Charging Speed", - .ui_helptext = "Set the maximum speed to charge the battery. Charging faster" - " will increase heat and battery wear.", - .default_value = 1, - .values = (const struct sm_enum_value[]) { - { "1.0C", 0 }, - { "0.5C", 1 }, - { "0.2C", 2 }, - SM_ENUM_VALUE_END }, -}); -#endif - static const struct sm_object debug_level = SM_DECLARE_ENUM({ .opt_name = "debug_level", .ui_name = "Debug Level", @@ -69,32 +55,6 @@ }); #endif -#if CONFIG(EC_STARLABS_LID_SWITCH) -static const struct sm_object lid_switch = SM_DECLARE_ENUM({ - .opt_name = "lid_switch", - .ui_name = "Lid Switch", - .ui_helptext = "Configure what opening or closing the lid will do.", - .default_value = 0, - .values = (const struct sm_enum_value[]) { - { "Normal", 0 }, - { "Sleep Only", 1 }, - { "Disabled", 2 }, - SM_ENUM_VALUE_END }, -}); -#endif - -static const struct sm_object max_charge = SM_DECLARE_ENUM({ - .opt_name = "max_charge", - .ui_name = "Maximum Charge Level", - .ui_helptext = "Set the maximum level the battery will charge to.", - .default_value = 0, - .values = (const struct sm_enum_value[]) { - { "100%", 0 }, - { "80%", 1 }, - { "60%", 2 }, - SM_ENUM_VALUE_END }, -}); - static const struct sm_object me_state = SM_DECLARE_ENUM({ .opt_name = "me_state", .ui_name = "Intel Management Engine", @@ -194,18 +154,6 @@ }); #endif -static const struct sm_object power_led = SM_DECLARE_ENUM({ - .opt_name = "power_led", - .ui_name = "Power LED Brightness", - .ui_helptext = "Control the maximum brightness of the power LED", - .default_value = 0, - .values = (const struct sm_enum_value[]) { - { "Normal", 0 }, - { "Reduced", 1 }, - SM_ENUM_VALUE_END, - }, -}); - static const struct sm_object reboot_counter = SM_DECLARE_NUMBER({ .opt_name = "reboot_counter", .ui_name = "Reboot Counter", -- To view, visit https://review.coreboot.org/c/coreboot/+/86318?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I831559184de917b32e4993e8e34ffbc7b7e883e4 Gerrit-Change-Number: 86318 Gerrit-PatchSet: 5 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[NoOp] Change in coreboot[main]: mb/starlabs/starlite_adl: Increase display brightness at POST
by Sean Rhodes (Code Review) 11 Feb '25

11 Feb '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86345?usp=email ) Change subject: mb/starlabs/starlite_adl: Increase display brightness at POST ...................................................................... mb/starlabs/starlite_adl: Increase display brightness at POST Adjust the POST brightness level in the VBT from 50 to 150 (max 255). Change-Id: I1704a3479c38510b29427d582ee14c740401cd38 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86345 Reviewed-by: Sean Rhodes <sean(a)starlabs.systems> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starlite_adl/variants/mk_v/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Sean Rhodes: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/data.vbt b/src/mainboard/starlabs/starlite_adl/variants/mk_v/data.vbt index cbd4a5a..a985a4b 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/data.vbt +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/data.vbt Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/86345?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1704a3479c38510b29427d582ee14c740401cd38 Gerrit-Change-Number: 86345 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: ec/starlabs/merlin: Only include lid switch ACPI when needed
by Sean Rhodes (Code Review) 11 Feb '25

11 Feb '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86322?usp=email ) Change subject: ec/starlabs/merlin: Only include lid switch ACPI when needed ...................................................................... ec/starlabs/merlin: Only include lid switch ACPI when needed Desktop devices don't need and shouldn't define a lid switch. TEST=build/boot starlabs/byte,starlite_adl Change-Id: Iecf3e2558e244cc0bec301a505c0bc86684954aa Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86322 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/ec/starlabs/merlin/acpi/ec.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sean Rhodes: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/ec/starlabs/merlin/acpi/ec.asl b/src/ec/starlabs/merlin/acpi/ec.asl index f3fdb07..ae50927 100644 --- a/src/ec/starlabs/merlin/acpi/ec.asl +++ b/src/ec/starlabs/merlin/acpi/ec.asl @@ -112,11 +112,11 @@ #include "ac.asl" #if CONFIG(SYSTEM_TYPE_LAPTOP) || CONFIG(SYSTEM_TYPE_DETACHABLE) #include "battery.asl" + #include "lid.asl" #endif #if !CONFIG(EC_STARLABS_MERLIN) #include "events.asl" #endif - #include "lid.asl" #if CONFIG(SYSTEM_TYPE_DETACHABLE) #include "dock.asl" #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/86322?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iecf3e2558e244cc0bec301a505c0bc86684954aa Gerrit-Change-Number: 86322 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: mb/starlabs/*: Correct PAD ownership
by Sean Rhodes (Code Review) 11 Feb '25

11 Feb '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86344?usp=email ) Change subject: mb/starlabs/*: Correct PAD ownership ...................................................................... mb/starlabs/*: Correct PAD ownership Commit `57aca97a2c6e524b442c80d67b033a813bf10e8e` correctly changed the reset types of GPIOs used in ACPI, but incorrectly set the pads to GPIO mode, rather than ACPI mode. This patch corrects that. Change-Id: I7207d4d00e810c15d071eca0bea83796989e3735 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86344 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c M src/mainboard/starlabs/starbook/variants/adl/gpio.c M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c M src/mainboard/starlabs/starbook/variants/cml/gpio.c M src/mainboard/starlabs/starbook/variants/mtl/gpio.c M src/mainboard/starlabs/starbook/variants/rpl/gpio.c M src/mainboard/starlabs/starbook/variants/tgl/gpio.c M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c 9 files changed, 42 insertions(+), 42 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index 8ec1666..6981b85 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -63,7 +63,7 @@ /* A12: PCH M.2 SSD PEDET */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14: Type C VBUS OverCurrent */ PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1), /* A15: Test Point 3 */ @@ -229,7 +229,7 @@ /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), /* D16: PCH M.2 SSD Power Enable */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_D16, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17: Not Connected */ PAD_NC(GPP_D17, NONE), /* D18: Not Connected */ @@ -244,7 +244,7 @@ /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), /* E3: WiFi RF Kill */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_E3, 1, DEEP), /* E4: Test Point 7 */ PAD_NC(GPP_E4, NONE), /* E5: Not Connected */ @@ -340,7 +340,7 @@ PAD_NC(GPP_F23, NONE), /* H0: PCH M.2 SSD Reset */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_H0, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ @@ -452,7 +452,7 @@ PAD_NC(GPP_R7, NONE), /* BT_EN */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_VGPIO_0, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_VGPIO_0, 1, DEEP), /* CNVi BT UART0 */ PAD_NC(GPP_VGPIO_6, NONE), diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 2ab629f..4cc9888 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -63,7 +63,7 @@ /* A12: PCH M.2 SSD PEDET */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), /* A15: Test Point 52 */ @@ -228,7 +228,7 @@ /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), /* D16: PCH M.2 SSD Power Enable */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_D16, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17: Not used Fingerprint ID */ PAD_NC(GPP_D17, NONE), /* D18: Not Connected */ @@ -243,7 +243,7 @@ /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), /* E3: WiFi RF Kill */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_E3, 1, DEEP), /* E4: Test Point 14 */ PAD_NC(GPP_E4, NONE), /* E5: Not Connected */ @@ -339,11 +339,11 @@ PAD_NC(GPP_F23, NONE), /* H0: PCH M.2 SSD Reset */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_H0, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_H2, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), /* H4: I2C 0 SDA Touchpad */ diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index e61c9a0..3c5c7d0 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -63,7 +63,7 @@ /* A12: Not Connected */ PAD_NC(GPP_A12, NONE), /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), /* A15: Test Point 52 */ @@ -228,7 +228,7 @@ /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), /* D16: PCH M.2 SSD Power Enable */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_D16, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17: Not used Fingerprint ID */ PAD_NC(GPP_D17, NONE), /* D18: Not Connected */ @@ -243,7 +243,7 @@ /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), /* E3: WiFi RF Kill */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_E3, 1, DEEP), /* E4: Test Point 14 */ PAD_NC(GPP_E4, NONE), /* E5: Not Connected */ @@ -339,11 +339,11 @@ PAD_NC(GPP_F23, NONE), /* H0: PCH M.2 SSD Reset */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_H0, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_H2, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), /* H4: I2C 0 SDA Touchpad */ diff --git a/src/mainboard/starlabs/starbook/variants/cml/gpio.c b/src/mainboard/starlabs/starbook/variants/cml/gpio.c index 2baac30..e29cd81 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/cml/gpio.c @@ -116,7 +116,7 @@ /* B3: CLICK_PAD_INT_R_N */ PAD_CFG_GPI_APIC_LOW(GPP_B3, NONE, PLTRST), /* B4: BT_RF_KILL_N */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_B4, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_B4, 1, DEEP), /* B5: WLAN_CLKREQ# */ PAD_CFG_NF(GPP_B5, NONE, DEEP, NF1), /* B6: CLKREQ1_SSD_N */ @@ -161,7 +161,7 @@ /* C1: SMB_DATA */ PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C2: WIFI_RF_KILL_N */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_C2, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_C2, 1, DEEP), /* C3: Not Connected */ PAD_NC(GPP_C3, NONE), /* C4: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index 02f1db7..e64baa3 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -249,14 +249,14 @@ * End: GPP_H23 */ /* H00: M.2_PCH_SSD_RESET_N */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_H00, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_H00, 1, PLTRST), /* H01: FLASH RECOVERY * HIGH: ENABLED * LOW: DISABLED * WEAK INTERNAL PD 20K */ PAD_NC(GPP_H01, NONE), /* H02: WLAN_RST_N */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_H02, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_H02, 1, PLTRST), /* H03: */ PAD_NC(GPP_H03, NONE), /* H04: */ @@ -266,7 +266,7 @@ /* H06: */ PAD_NC(GPP_H06, NONE), /* H07: M.2_CPU_SSD_PWREN */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_H07, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_H07, 1, DEEP), /* H08: */ PAD_NC(GPP_H08, NONE), /* H09: */ @@ -432,9 +432,9 @@ /* B17: */ PAD_NC(GPP_B17, NONE), /* B18: BT_RF_KILL_N */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_B18, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_B18, 1, DEEP), /* B19: WIFI_RF_KILL_N */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_B19, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_B19, 1, DEEP), /* B20: */ PAD_NC(GPP_B20, NONE), /* B21: */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 5e3cd00..542aa32 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -63,7 +63,7 @@ /* A12: PCH M.2 SSD PEDET */ PAD_NC(GPP_A12, NONE), /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), /* A15: Test Point 52 */ @@ -224,7 +224,7 @@ /* D13: Wireless LAN Wake */ PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_D14, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_D14, 1, DEEP), /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), /* D16: PCH M.2 SSD Power Enable */ @@ -243,9 +243,9 @@ /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), /* E3: WiFi RF Kill */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_E3, 1, DEEP), /* E4: Retimer Force Power */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_E4, 0, DEEP, NONE), + PAD_CFG_GPO(GPP_E4, 0, DEEP), /* E5: Not Connected */ PAD_NC(GPP_E5, NONE), /* E6: JTAG ODT No internal PD @@ -330,7 +330,7 @@ /* F19: Not Connected */ PAD_NC(GPP_F19, NONE), /* F20: CPU M.2 SSD Reset */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_F20, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_F20, 1, PLTRST), /* F21: GPPC_F21 */ PAD_NC(GPP_F21, NONE), /* F22: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index f1350c5..2526f7f 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -66,7 +66,7 @@ /* A10: WLAN_PCM_IN */ PAD_NC(GPP_A10, NONE), /* A11: M2_CPU_SSD_RST_N */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_A11, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_A11, 1, PLTRST), /* A12: SATAGP_1 */ PAD_CFG_NF(GPP_A12, UP_20K, DEEP, NF1), /* A13: Not Connected */ @@ -90,7 +90,7 @@ /* A22: Not Connected */ PAD_NC(GPP_A22, NONE), /* A23: TC_RETIMER_FORCE_PWR */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_A23, 0, DEEP, NONE), + PAD_CFG_GPO(GPP_A23, 0, DEEP), /* B0: CORE_VID_0 */ PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), @@ -219,7 +219,7 @@ /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), /* D16: CPU_SSD_PWREN */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_D16, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17: Not Connected */ PAD_NC(GPP_D17, NONE), /* D18: Not Connected */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index a69b210..bfd0674 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -72,7 +72,7 @@ /* A12: PCH M.2 SSD PEDET */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), /* A15: Test Point 52 */ @@ -229,7 +229,7 @@ /* D13: Wireless LAN Wake */ PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_D14, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_D14, 1, DEEP), /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), /* D16: PCH M.2 SSD Power Enable */ @@ -248,9 +248,9 @@ /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), /* E3: WiFi RF Kill */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_E3, 1, DEEP), /* E4: Retimer Force Power */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_E4, 0, DEEP, NONE), + PAD_CFG_GPO(GPP_E4, 0, DEEP), /* E5: Not Connected */ PAD_NC(GPP_E5, NONE), /* E6: JTAG ODT No internal PD @@ -327,7 +327,7 @@ /* F19: Not Connected */ PAD_NC(GPP_F19, NONE), /* F20: CPU M.2 SSD Reset */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_F20, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_F20, 1, PLTRST), /* F21: GPPC_F21 */ PAD_NC(GPP_F21, NONE), /* F22: Not Connected */ @@ -340,7 +340,7 @@ /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_H2, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), /* H4: I2C 0 SDA Touchpad */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index edde160..f7a9737 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -63,7 +63,7 @@ /* A12: Not Connected */ PAD_NC(GPP_A12, NONE), /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A14: Camera Power Enable */ PAD_NC(GPP_A14, NONE), /* A15: Camera Reset */ @@ -227,7 +227,7 @@ /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), /* D16: PCH M.2 SSD Power Enable */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_D16, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D17: Not used Fingerprint ID */ PAD_NC(GPP_D17, NONE), /* D18: Bluetooth Wake */ @@ -242,7 +242,7 @@ /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), /* E3: WiFi RF Kill */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_E3, 1, DEEP), /* E4: P Offset */ PAD_NC(GPP_E4, NONE), /* E5: P Out */ @@ -323,7 +323,7 @@ /* F16: Not Connected */ PAD_NC(GPP_F16, NONE), /* F17: Touch Panel Reset */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_F17, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_F17, 1, PLTRST), /* F18: Touch Panel Interrupt */ PAD_CFG_GPI_APIC(GPP_F18, NONE, PLTRST, LEVEL, INVERT), /* F19: Not Connected */ @@ -338,7 +338,7 @@ PAD_NC(GPP_F23, NONE), /* H0: PCH M.2 SSD Reset */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_H0, 1, PLTRST, NONE), + PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ @@ -450,7 +450,7 @@ PAD_NC(GPP_R7, NONE), /* BT_EN */ - PAD_CFG_GPO_GPIO_DRIVER(GPP_VGPIO_0, 1, DEEP, NONE), + PAD_CFG_GPO(GPP_VGPIO_0, 1, DEEP), /* CNVi BT UART0 */ PAD_NC(GPP_VGPIO_6, NONE), -- To view, visit https://review.coreboot.org/c/coreboot/+/86344?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7207d4d00e810c15d071eca0bea83796989e3735 Gerrit-Change-Number: 86344 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Disconnect unused GPIOs
by Sean Rhodes (Code Review) 11 Feb '25

11 Feb '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86347?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Disconnect unused GPIOs ...................................................................... mb/starlabs/starbook/adl_n: Disconnect unused GPIOs These are not connected, so configure them as such. Change-Id: I5dfeb5c1503ca85baf3641f1f5803519ec517b81 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86347 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 835d8f6..e61c9a0 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -37,7 +37,7 @@ /* GPD8: Suspend Clock */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* GPD9: Wireless LAN Sleep */ - PAD_CFG_NF(GPD9, NONE, DEEP, NF1), + PAD_NC(GPD9, NONE), /* GPD10: Sleep S5 */ PAD_NC(GPD10, NONE), /* GPD11: LAN PHY Enable */ @@ -60,8 +60,8 @@ /* A10: ESPI Reset */ /* A11: Not Connected */ PAD_NC(GPP_A11, NONE), - /* A12: PCH M.2 SSD PEDET */ - PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), + /* A12: Not Connected */ + PAD_NC(GPP_A12, NONE), /* A13: BlueTooth RF Kill */ PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE), /* A14: Test Point 45 */ @@ -69,7 +69,7 @@ /* A15: Test Point 52 */ PAD_NC(GPP_A15, NONE), /* A16: USB OverCurrent 3 */ - PAD_CFG_NF(GPP_A16, NONE, DEEP, NF1), + PAD_NC(GPP_A16, NONE), /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), /* A18: DDI B DP HPD */ @@ -257,7 +257,7 @@ /* E8: DRAM Sleep */ PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ - PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), + PAD_NC(GPP_E9, NONE), /* E10: PWD Amplifier Input */ PAD_NC(GPP_E10, NONE), /* E11: TPM IRQ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/86347?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5dfeb5c1503ca85baf3641f1f5803519ec517b81 Gerrit-Change-Number: 86347 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: soc/intel/common: Add low battery shutdown function
by Subrata Banik (Code Review) 11 Feb '25

11 Feb '25

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86361?usp=email ) Change subject: soc/intel/common: Add low battery shutdown function ...................................................................... soc/intel/common: Add low battery shutdown function This commit adds a `do_low_battery_shutdown()` function to handle system shutdown due to critically low battery levels. The function logs a low battery event, introduces a short delay for logging, and then initiates a power off sequence. This provides a standardized way to handle low battery shutdowns across platforms. BUG=b:339673254 TEST=Able to build and boot google/brox. Change-Id: I92e9003c70c2608770972f1a302f954ebdf17bc4 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/include/reset.h M src/soc/intel/common/reset.c 2 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/86361/1 diff --git a/src/include/reset.h b/src/include/reset.h index 95fe066..be3460a 100644 --- a/src/include/reset.h +++ b/src/include/reset.h @@ -41,4 +41,16 @@ */ void do_board_reset(void); +/* + * Issue shutdown due to low battery + * + * Call this function to power off the platform if the battery level is critically low. + * It performs the following actions: + * + * 1. Logs an event indicating a low battery shutdown. + * 2. Introduces a short delay to allow time for logging. + * 3. Sends a shutdown command. + */ +void do_low_battery_shutdown(void); + #endif diff --git a/src/soc/intel/common/reset.c b/src/soc/intel/common/reset.c index c6c394b..6ee4c10 100644 --- a/src/soc/intel/common/reset.c +++ b/src/soc/intel/common/reset.c @@ -3,6 +3,8 @@ #include <arch/cache.h> #include <cf9_reset.h> #include <console/console.h> +#include <delay.h> +#include <elog.h> #include <halt.h> #include <reset.h> @@ -21,3 +23,12 @@ { full_reset(); } + +void do_low_battery_shutdown(void) +{ + elog_add_event_byte(ELOG_TYPE_LOW_BATTERY_INDICATOR, ELOG_FW_ISSUE_SHUTDOWN); + + delay(3); + + poweroff(); +} -- To view, visit https://review.coreboot.org/c/coreboot/+/86361?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92e9003c70c2608770972f1a302f954ebdf17bc4 Gerrit-Change-Number: 86361 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>

1 0

[M] Change in coreboot[main]: vc/google/chromeos: Implement platform callback for critical shutdown
by Subrata Banik (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Julius Werner, Karthik Ramasubramanian. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86228?usp=email ) Change subject: vc/google/chromeos: Implement platform callback for critical shutdown ...................................................................... Patch Set 9: (1 comment) File src/vendorcode/google/chromeos/battery.c: https://review.coreboot.org/c/coreboot/+/86228/comment/2c8cda35_43783dfe?us… : PS9, Line 49: void platform_issue_low_battery_shutdown(void) > Due to CB:86336 we can move this into common code somewhere, it doesn't need to be in `vendorcode/ch […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/86228?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I119f80a45c045a6095cae98f179c755a2e948e9c Gerrit-Change-Number: 86228 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 11 Feb 2025 09:11:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[XL] Change in coreboot[main]: soc/intel/xeon-sp/spr: Hook up public FSP bin and headers
by Shuo Liu (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Angel Pons, Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Fabian Meyer, Intel coreboot Reviewers, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Srinidhi N Kaushik, Tim Chu. Shuo Liu has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/80360?usp=email ) Change subject: soc/intel/xeon-sp/spr: Hook up public FSP bin and headers ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Arthur and all, the FSP repo update is upcoming, and here we updated the coreboot changes accordingly in parallel. But we still need to wait till the FSP repo update completes to move ahead. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/80360?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I778d3535c273dff653330518653bdefcb45e66f4 Gerrit-Change-Number: 80360 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Fabian Meyer <fabian(a)meyfa.net> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Fabian Meyer <fabian(a)meyfa.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Attention: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 11 Feb 2025 09:06:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in coreboot[main]: soc/intel/xeon-sp/spr: Hook up public FSP bin and headers
by Shuo Liu (Code Review) 11 Feb '25

11 Feb '25

Attention is currently required from: Angel Pons, Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Fabian Meyer, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Shuo Liu, Srinidhi N Kaushik, Tim Chu. Shuo Liu has uploaded a new patch set (#5) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/80360?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by Shuo Liu Change subject: soc/intel/xeon-sp/spr: Hook up public FSP bin and headers ...................................................................... soc/intel/xeon-sp/spr: Hook up public FSP bin and headers TEST=Build and boot on intel/archercity CRB Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: Shuo Liu <shuo.liu(a)intel.com> Signed-off-by: Jincheng Li <jincheng.li(a)intel.com> Change-Id: I778d3535c273dff653330518653bdefcb45e66f4 --- M configs/builder/config.intel.crb.ac M src/soc/intel/xeon_sp/spr/Kconfig M src/soc/intel/xeon_sp/spr/Makefile.mk M src/soc/intel/xeon_sp/spr/romstage.c D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/CxlNodeHob.h D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/FspEas.h D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/FspErrorInfoHob.h D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/FspUpd.h D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/FspmUpd.h D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/FspsUpd.h D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/FsptUpd.h D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/IioPcieConfigUpd.h D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/IioUniversalDataHob.h D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/MemoryMapDataHob.h D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/PrevBootErrSrcHob.h D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/SystemInfoHob.h 16 files changed, 7 insertions(+), 3,093 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/80360/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/80360?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I778d3535c273dff653330518653bdefcb45e66f4 Gerrit-Change-Number: 80360 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-CC: Fabian Meyer <fabian(a)meyfa.net> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Fabian Meyer <fabian(a)meyfa.net> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Attention: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025