Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86115?usp=email )
Change subject: symbols: Add REGION() and REGION_END() macros
......................................................................
symbols: Add REGION() and REGION_END() macros
Define the REGION() and REGION_END() macros for platform code to
reference to the region start and end addresses more easily.
Note that memlayout.h also defines macros of the same name, but that's
fine, as that header is supposed to be included from memlayout.ld only.
Change-Id: Ie80275a74a4015e72eaab204982b915e4435a339
Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org>
---
M src/include/symbols.h
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/86115/1
diff --git a/src/include/symbols.h b/src/include/symbols.h
index 36e4c10..622c5c8 100644
--- a/src/include/symbols.h
+++ b/src/include/symbols.h
@@ -7,6 +7,8 @@
extern u8 _dram[];
+#define REGION(name) ((uintptr_t)_##name)
+#define REGION_END(name) ((uintptr_t)_e##name)
#define REGION_SIZE(name) ((size_t)_##name##_size)
#define DECLARE_REGION(name) \
--
To view, visit https://review.coreboot.org/c/coreboot/+/86115?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie80275a74a4015e72eaab204982b915e4435a339
Gerrit-Change-Number: 86115
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Filip Brozovic, Sean Rhodes.
Julius Werner has posted comments on this change by Filip Brozovic. ( https://review.coreboot.org/c/coreboot/+/86099?usp=email )
Change subject: lib/crc_byte: Parenthesize buffer address in CRC macro
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86099?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I55bbd2f208a94068ea3b3b3ae97b1683434c3007
Gerrit-Change-Number: 86099
Gerrit-PatchSet: 2
Gerrit-Owner: Filip Brozovic <fbrozovic(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Filip Brozovic <fbrozovic(a)gmail.com>
Gerrit-Comment-Date: Wed, 22 Jan 2025 23:59:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/86111?usp=email )
Change subject: soc/intel/alderlake/romstage: Disable UFS controller on every boot
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Isn't it conflicting with https://review.coreboot. […]
That change has taken only 2 kinds of reset into account - warm reset and S5 reset. There are other kinds of resets during the boot flow. One such reset scenario happens when a user switches from developer mode to normal/secure mode in ChromeOS. That change unfortunately has caused regression in those kind of resets.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86111?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1d7089a90bc42a2b36c26b05b81c1a2f12861fdc
Gerrit-Change-Number: 86111
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 22 Jan 2025 22:38:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>