coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3270 discussions

[XS] Change in coreboot[main]: mb/google/fatcat: Enable PCH Energy Report
by Jamie Ryu (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Bora Guvendik, Hima B Chilmakuru, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Subrata Banik, Vikrant L Jadeja, Wonkyu Kim. Hello Bora Guvendik, Hima B Chilmakuru, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Vikrant L Jadeja, Wonkyu Kim, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85615?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/fatcat: Enable PCH Energy Report ...................................................................... mb/google/fatcat: Enable PCH Energy Report This enables PCH Energy report feature. BUG=b:373915085 TEST=Build fatcat and check UPD-PchPmDisableEnergyReport is configured correctly. Change-Id: Ie318f21cf00a74fd68c86dd39efb5e020e444085 Signed-off-by: Jamie Ryu <jamie.m.ryu(a)intel.com> --- M src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/85615/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie318f21cf00a74fd68c86dd39efb5e020e444085 Gerrit-Change-Number: 85615 Gerrit-PatchSet: 3 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com>

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add PI_IMG firmware v1.0
by Yu-Ping Wu (Code Review) 24 Jan '25

24 Jan '25

Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/blobs/+/86095?usp=email ) Change subject: soc/mediatek/mt8196: Add PI_IMG firmware v1.0 ...................................................................... soc/mediatek/mt8196: Add PI_IMG firmware v1.0 Add initial PI_IMG firmware using MTK release branch and align with MCUPM. TEST=Build pass BUG=b:317009620 Change-Id: I4b36c928ad194f155442cf0e4314a826cfd3ef68 Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/README.md A soc/mediatek/mt8196/pi_img.img A soc/mediatek/mt8196/pi_img.img.md5 A soc/mediatek/mt8196/pi_img_release_notes.txt 4 files changed, 25 insertions(+), 0 deletions(-) Approvals: Yu-Ping Wu: Verified; Looks good to me, approved Yidi Lin: Looks good to me, approved diff --git a/soc/mediatek/mt8196/README.md b/soc/mediatek/mt8196/README.md index 87c62d9..e64601b 100644 --- a/soc/mediatek/mt8196/README.md +++ b/soc/mediatek/mt8196/README.md @@ -6,6 +6,7 @@ - dram.elf - spm_firmware.bin - gpueb_fw.img +- pi_img.img -------------------------------------------------------------------------------- # MCUPM introduction @@ -216,3 +217,21 @@ `$ strings gpueb_fw.img | grep "gpueb firmware"` -------------------------------------------------------------------------------- +# PI_IMG introduction +The main purpose of the pi_img is to pass various frequency and voltage scaling parameters and +settings to MCUPM. + +## Who uses it +Coreboot will load pi_img firmware at ramstage and parse it using mtk_fsp_ramstage. + +## How to load `pi_img` +Load `pi_img.img` from CBFS. +No need to pass other parameters to pi_img. + +## Return values +No return value. + +## Version +`$ strings pi_img.img | grep "pi_img firmware"` + +-------------------------------------------------------------------------------- diff --git a/soc/mediatek/mt8196/pi_img.img b/soc/mediatek/mt8196/pi_img.img new file mode 100644 index 0000000..4ad7ad3 --- /dev/null +++ b/soc/mediatek/mt8196/pi_img.img Binary files differ diff --git a/soc/mediatek/mt8196/pi_img.img.md5 b/soc/mediatek/mt8196/pi_img.img.md5 new file mode 100644 index 0000000..10fa074 --- /dev/null +++ b/soc/mediatek/mt8196/pi_img.img.md5 @@ -0,0 +1 @@ +d0f3a0a5d3b89a7228e7db08d905db17 *pi_img.img diff --git a/soc/mediatek/mt8196/pi_img_release_notes.txt b/soc/mediatek/mt8196/pi_img_release_notes.txt new file mode 100644 index 0000000..50fb8fa --- /dev/null +++ b/soc/mediatek/mt8196/pi_img_release_notes.txt @@ -0,0 +1,5 @@ +** Build from MediaTek Internal ** + +# Version 1.0 +1. Add initial PI_IMG firmware using MTK release branch and align with +MCUPM. -- To view, visit https://review.coreboot.org/c/blobs/+/86095?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I4b36c928ad194f155442cf0e4314a826cfd3ef68 Gerrit-Change-Number: 86095 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Remove Safe Settings
by Jamie Ryu (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Bora Guvendik, Hima B Chilmakuru, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Subrata Banik, Vikrant L Jadeja, Wonkyu Kim. Jamie Ryu has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/85615?usp=email ) Change subject: mb/google/fatcat: Remove Safe Settings ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85615/comment/870c638d_d5d57678?us… : PS1, Line 38: : # TODO: Safe Setting. Needs to be removed later : # Disable C1 C-state auto-demotion : register "disable_c1_state_auto_demotion" = "true" > all previous generation devices had this config set to `true` therefore, we might use the same confi […] Let me check this with PTL and update. -- To view, visit https://review.coreboot.org/c/coreboot/+/85615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie318f21cf00a74fd68c86dd39efb5e020e444085 Gerrit-Change-Number: 85615 Gerrit-PatchSet: 2 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 04:43:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Update Crashlog config
by Jamie Ryu (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Bora Guvendik, Intel coreboot Reviewers, Jamie Ryu, Jayvik Desai, Kapil Porwal, Pranava Y N, Sowmya Aralguppe, Vikrant L Jadeja, Wonkyu Kim. Hello Bora Guvendik, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Sowmya Aralguppe, Subrata Banik, Vikrant L Jadeja, Wonkyu Kim, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85614?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/pantherlake: Update Crashlog config ...................................................................... soc/intel/pantherlake: Update Crashlog config This will configure CpuCrashLogEnable regardless of Tracehub configuration as Crashlog feature does not have a dependency with Tracehub. TEST=Build fatcat and check Crashlog is enabled without enabling Tracehub. Change-Id: I6f37e9f4a1f55ffc576af955c92d4073068eb97a Signed-off-by: Jamie Ryu <jamie.m.ryu(a)intel.com> --- M src/soc/intel/pantherlake/romstage/fsp_params.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/85614/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85614?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f37e9f4a1f55ffc576af955c92d4073068eb97a Gerrit-Change-Number: 85614 Gerrit-PatchSet: 2 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add mtk_fsp_romstage version v1.0
by Yidi Lin (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Jarried Lin. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/86110?usp=email ) Change subject: soc/mediatek/mt8196: Add mtk_fsp_romstage version v1.0 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/86110?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: Ice4a51f375a86693674545a7730b16e656c57ac4 Gerrit-Change-Number: 86110 Gerrit-PatchSet: 4 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 02:59:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add PI_IMG firmware v1.0
by Yidi Lin (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Jarried Lin. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/86095?usp=email ) Change subject: soc/mediatek/mt8196: Add PI_IMG firmware v1.0 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/86095?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I4b36c928ad194f155442cf0e4314a826cfd3ef68 Gerrit-Change-Number: 86095 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 02:59:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Correct the region size for mcufw_reserved
by Yidi Lin (Code Review) 24 Jan '25

24 Jan '25

Yidi Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86108?usp=email ) Change subject: soc/mediatek/mt8196: Correct the region size for mcufw_reserved ...................................................................... soc/mediatek/mt8196: Correct the region size for mcufw_reserved Adjust the allocated region size for mcufw_reserved from 52K to 68K. TEST=Build pass. BUG=b:390334489 Change-Id: I1c17c1492d5568f4d51ff45e1fb90e067eae5cb1 Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86108 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yidi Lin <yidilin(a)google.com> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M src/soc/mediatek/mt8196/include/soc/memlayout.ld 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Yu-Ping Wu: Looks good to me, approved Yidi Lin: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/soc/mediatek/mt8196/include/soc/memlayout.ld b/src/soc/mediatek/mt8196/include/soc/memlayout.ld index 74f1543..ef6a146 100644 --- a/src/soc/mediatek/mt8196/include/soc/memlayout.ld +++ b/src/soc/mediatek/mt8196/include/soc/memlayout.ld @@ -24,18 +24,18 @@ /* EMPTY(0x0010bc90, 29K - 144) */ /* * MCUPM exchanges data with kernel driver using SRAM 0x00113000 ~ - * 0x0011ffff. The address is hardcoded in MCUPM image. + * 0x00123fff. The address is hardcoded in MCUPM image. */ - REGION(mcufw_reserved, 0x00113000, 52K, 4K) + REGION(mcufw_reserved, 0x00113000, 68K, 4K) /* End of regions that need to stay in SRAM. */ /* Regions can be moved to SRAM_L2C. */ - CBFS_MCACHE(0x00120000, 16k) - VBOOT2_WORK(0x00124000, 12K) - FMAP_CACHE(0x00127000, 2k) - TPM_LOG(0x00127800, 2k) - TIMESTAMP(0x00128000, 1k) + CBFS_MCACHE(0x00124000, 16k) + VBOOT2_WORK(0x00128000, 12K) + FMAP_CACHE(0x0012B000, 2k) + TPM_LOG(0x0012B800, 2k) + TIMESTAMP(0x0012C000, 1k) /* End of regions that can also be moved to SRAM_L2C. */ - /* EMPTY(0x00128400, 95K) */ + /* EMPTY(0x0012C400, 79K) */ SRAM_END(0x00140000) /* -- To view, visit https://review.coreboot.org/c/coreboot/+/86108?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1c17c1492d5568f4d51ff45e1fb90e067eae5cb1 Gerrit-Change-Number: 86108 Gerrit-PatchSet: 4 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Increase ANX7625 data trail time
by Xin Ji (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Hung-Te Lin, Paul Menzel. Xin Ji has posted comments on this change by Xin Ji. ( https://review.coreboot.org/c/coreboot/+/86101?usp=email ) Change subject: mb/google/corsola: Increase ANX7625 data trail time ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/86101/comment/9bf10e94_e349481b?us… : PS3, Line 15: > Please mention this in the commit message. (*Copy* instead of *migrated* seems to be more correct. […] Acknowledged Commit Message: https://review.coreboot.org/c/coreboot/+/86101/comment/4117262d_edbd415f?us… : PS4, Line 16: id:391304679 > b:391304679 Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/86101?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I677667240c7f3b0e14c6a728931921e32f539c57 Gerrit-Change-Number: 86101 Gerrit-PatchSet: 4 Gerrit-Owner: Xin Ji <xji(a)analogix.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 24 Jan 2025 02:17:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Xin Ji <xji(a)analogix.corp-partner.google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Increase ANX7625 data trail time
by Xin Ji (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Hung-Te Lin, Xin Ji. Hello Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86101?usp=email to look at the new patch set (#5). Change subject: mb/google/corsola: Increase ANX7625 data trail time ...................................................................... mb/google/corsola: Increase ANX7625 data trail time Currently, the eDP panel has display shift issue. This issue is caused by too short HS-trail time. Based on hardware design ANX7625 requires more HS-trail time to finish mipi data packet decoding before entering LP mode. So increase HS-trail time to avoid effect of entering LP mode. da_hs_trail value copy from "kukui/panel_anx7625.c", verified on corsola. BUG=b:391304679 BRANCH=corsola TEST=Display is normal on corsola Change-Id: I677667240c7f3b0e14c6a728931921e32f539c57 Signed-off-by: Xin Ji <xji(a)analogix.corp-partner.google.com> --- M src/mainboard/google/corsola/panel_anx7625.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/86101/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/86101?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I677667240c7f3b0e14c6a728931921e32f539c57 Gerrit-Change-Number: 86101 Gerrit-PatchSet: 5 Gerrit-Owner: Xin Ji <xji(a)analogix.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xin Ji <xji(a)analogix.corp-partner.google.com>

1 0

[M] Change in coreboot[main]: libpayload: Unify selfboot() implementations
by Julius Werner (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Stephen Boyd, Subrata Banik, Yu-Ping Wu. Julius Werner has posted comments on this change by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/86142?usp=email ) Change subject: libpayload: Unify selfboot() implementations ...................................................................... Patch Set 1: (1 comment) File payloads/libpayload/libc/selfboot.c: https://review.coreboot.org/c/coreboot/+/86142/comment/fbba02a0_e8231ae9?us… : PS1, Line 35: __attribute__((__regparm__(0))) I think technically this doesn't really do anything, because our default calling convention is already `regparm(0)` to begin with. But coreboot also still does it when loading the payload, so I guess it's more consistent to do it here too. -- To view, visit https://review.coreboot.org/c/coreboot/+/86142?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If14040e38d968b5eea31cd6cd25efb1845a7b081 Gerrit-Change-Number: 86142 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Stephen Boyd <swboyd(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Stephen Boyd <swboyd(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 00:59:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025