coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3270 discussions

[XS] Change in coreboot[main]: commonlib/dt: Fix incorrect cell properties
by Kapil Porwal (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Julius Werner, Kapil Porwal. Kapil Porwal has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/86030?usp=email ) Change subject: commonlib/dt: Fix incorrect cell properties ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > We need this patch. Consider below example - […] I see it now. These properties are actually meant for the child nodes. Hence we need to fix the test case instead. -- To view, visit https://review.coreboot.org/c/coreboot/+/86030?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d360a4cc0a02462a53866bf375e5d4c85177a05 Gerrit-Change-Number: 86030 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 24 Jan 2025 05:47:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[XS] Change in coreboot[main]: commonlib/dt: Fix incorrect cell properties
by Subrata Banik (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Julius Werner, Kapil Porwal. Subrata Banik has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/86030?usp=email ) Change subject: commonlib/dt: Fix incorrect cell properties ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > We need this patch. Consider below example - > > Input node: /abc > > PASS#1: > Parent="/" > Path="abc", '/0' > Cell Properties: From parent i.e. "/" > Path[0] is not NULL so proceed with recursion. > > PASS#2: > Parent="/abc" > Path='/0' > Cell Properties: From parent i.e. "/abc" > Path[0] is NULL so break from recursion. > > > If we exit from PASS#2 without returning cell properties of current parent (i.e. "/abc") the cell properties would contain values from PASS#1 which is not correct. > > Please let me know if I am missing anything. if `parent` variable acts as both input and output inside dt_read_cell_props then we need this CL to return `parent` after returning from `dt_read_cell_props`. Otherwise, this CL doesn't add any value IMO. -- To view, visit https://review.coreboot.org/c/coreboot/+/86030?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d360a4cc0a02462a53866bf375e5d4c85177a05 Gerrit-Change-Number: 86030 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 24 Jan 2025 05:36:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[XS] Change in coreboot[main]: commonlib/dt: Fix incorrect cell properties
by Kapil Porwal (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Julius Werner. Kapil Porwal has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/86030?usp=email ) Change subject: commonlib/dt: Fix incorrect cell properties ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The previous patch failed the CQ while building DC. Refer https://crrev/c/6178415 […] We need this patch. Consider below example - Input node: /abc PASS#1: Parent="/" Path="abc", '/0' Cell Properties: From parent i.e. "/" Path[0] is not NULL so proceed with recursion. PASS#2: Parent="/abc" Path='/0' Cell Properties: From parent i.e. "/abc" Path[0] is NULL so break from recursion. If we exit from PASS#2 without returning cell properties of current parent (i.e. "/abc") the cell properties would contain values from PASS#1 which is not correct. Please let me know if I am missing anything. -- To view, visit https://review.coreboot.org/c/coreboot/+/86030?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d360a4cc0a02462a53866bf375e5d4c85177a05 Gerrit-Change-Number: 86030 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 24 Jan 2025 05:22:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Enable PCH Energy Report
by Jamie Ryu (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Bora Guvendik, Hima B Chilmakuru, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Vikrant L Jadeja, Wonkyu Kim. Jamie Ryu has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/85615?usp=email ) Change subject: mb/google/fatcat: Enable PCH Energy Report ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85615/comment/54691854_743b7eda?us… : PS3, Line 44: > please drop this empty line ? done in patchset#4. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/85615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie318f21cf00a74fd68c86dd39efb5e020e444085 Gerrit-Change-Number: 85615 Gerrit-PatchSet: 4 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 05:05:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Enable PCH Energy Report
by Subrata Banik (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Bora Guvendik, Hima B Chilmakuru, Jamie Ryu, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Vikrant L Jadeja, Wonkyu Kim. Subrata Banik has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/85615?usp=email ) Change subject: mb/google/fatcat: Enable PCH Energy Report ...................................................................... Patch Set 4: Code-Review+2 (2 comments) File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85615/comment/f4fffc5c_98f10022?us… : PS1, Line 38: : # TODO: Safe Setting. Needs to be removed later : # Disable C1 C-state auto-demotion : register "disable_c1_state_auto_demotion" = "true" > I am keeping C state auto demotion disabled for PTL in patchset#3, similar to previous generations. Acknowledged File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85615/comment/7a833067_ba85adb9?us… : PS3, Line 44: > please drop this empty line ? Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/85615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie318f21cf00a74fd68c86dd39efb5e020e444085 Gerrit-Change-Number: 85615 Gerrit-PatchSet: 4 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 05:05:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Jamie Ryu <jamie.m.ryu(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Enable PCH Energy Report
by Jamie Ryu (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Bora Guvendik, Hima B Chilmakuru, Jamie Ryu, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Subrata Banik, Vikrant L Jadeja, Wonkyu Kim. Hello Bora Guvendik, Hima B Chilmakuru, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Subrata Banik, Vikrant L Jadeja, Wonkyu Kim, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85615?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+2 by Subrata Banik Change subject: mb/google/fatcat: Enable PCH Energy Report ...................................................................... mb/google/fatcat: Enable PCH Energy Report This enables PCH Energy report feature. BUG=b:373915085 TEST=Build fatcat and check UPD-PchPmDisableEnergyReport is configured correctly. Change-Id: Ie318f21cf00a74fd68c86dd39efb5e020e444085 Signed-off-by: Jamie Ryu <jamie.m.ryu(a)intel.com> --- M src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/85615/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie318f21cf00a74fd68c86dd39efb5e020e444085 Gerrit-Change-Number: 85615 Gerrit-PatchSet: 4 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Update Crashlog config
by Jamie Ryu (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Bora Guvendik, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Sowmya Aralguppe, Vikrant L Jadeja, Wonkyu Kim. Jamie Ryu has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/85614?usp=email ) Change subject: soc/intel/pantherlake: Update Crashlog config ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/pantherlake/Kconfig: https://review.coreboot.org/c/coreboot/+/85614/comment/0d675704_132f6bbd?us… : PS1, Line 97: select SOC_INTEL_DEBUG_CONSENT # TODO: Remove the safe setting for ES SoC > +1 this is removed in patchset#3 as the revert CL landed. -- To view, visit https://review.coreboot.org/c/coreboot/+/85614?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f37e9f4a1f55ffc576af955c92d4073068eb97a Gerrit-Change-Number: 85614 Gerrit-PatchSet: 3 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 05:02:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Enable PCH Energy Report
by Jamie Ryu (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Bora Guvendik, Hima B Chilmakuru, Jamie Ryu, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Vikrant L Jadeja, Wonkyu Kim. Jamie Ryu has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/85615?usp=email ) Change subject: mb/google/fatcat: Enable PCH Energy Report ...................................................................... Patch Set 3: (2 comments) File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85615/comment/6b62b599_6abde8b8?us… : PS1, Line 38: : # TODO: Safe Setting. Needs to be removed later : # Disable C1 C-state auto-demotion : register "disable_c1_state_auto_demotion" = "true" > Let me check this with PTL and update. I am keeping C state auto demotion disabled for PTL in patchset#3, similar to previous generations. https://review.coreboot.org/c/coreboot/+/85615/comment/c40d0fac_91863c1a?us… : PS1, Line 42: # Enable Energy Reporting : register "pch_pm_energy_report_enable" = "true" > can you please submit this CL for review The patch is updated for review. Thank you. -- To view, visit https://review.coreboot.org/c/coreboot/+/85615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie318f21cf00a74fd68c86dd39efb5e020e444085 Gerrit-Change-Number: 85615 Gerrit-PatchSet: 3 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 05:00:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jamie Ryu <jamie.m.ryu(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Update Crashlog config
by Subrata Banik (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Bora Guvendik, Intel coreboot Reviewers, Jamie Ryu, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Sowmya Aralguppe, Vikrant L Jadeja, Wonkyu Kim. Subrata Banik has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/85614?usp=email ) Change subject: soc/intel/pantherlake: Update Crashlog config ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File src/soc/intel/pantherlake/romstage/fsp_params.c: https://review.coreboot.org/c/coreboot/+/85614/comment/f1c19547_ed00b054?us… : PS1, Line 254: m_cfg->CpuCrashLogEnable = CONFIG(SOC_INTEL_CRASHLOG); > I would think that now that that this non-dependency has been identified and considering the very lo […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/85614?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f37e9f4a1f55ffc576af955c92d4073068eb97a Gerrit-Change-Number: 85614 Gerrit-PatchSet: 3 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 05:00:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Enable PCH Energy Report
by Subrata Banik (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Bora Guvendik, Hima B Chilmakuru, Jamie Ryu, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Vikrant L Jadeja, Wonkyu Kim. Subrata Banik has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/85615?usp=email ) Change subject: mb/google/fatcat: Enable PCH Energy Report ...................................................................... Patch Set 3: Code-Review+2 (3 comments) File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85615/comment/b265ed61_8faacba3?us… : PS1, Line 38: : # TODO: Safe Setting. Needs to be removed later : # Disable C1 C-state auto-demotion : register "disable_c1_state_auto_demotion" = "true" > Let me check this with PTL and update. Acknowledged https://review.coreboot.org/c/coreboot/+/85615/comment/2e87b0e3_7d5135c7?us… : PS1, Line 42: # Enable Energy Reporting : register "pch_pm_energy_report_enable" = "true" > can you please submit this CL for review Acknowledged File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85615/comment/28009fae_dd55617d?us… : PS3, Line 44: please drop this empty line ? -- To view, visit https://review.coreboot.org/c/coreboot/+/85615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie318f21cf00a74fd68c86dd39efb5e020e444085 Gerrit-Change-Number: 85615 Gerrit-PatchSet: 3 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Hima B Chilmakuru <hima.b.chilmakuru(a)intel.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 04:59:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Jamie Ryu <jamie.m.ryu(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025