coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
794 discussions

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Václav Straka (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Angel Pons. Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email ) Change subject: mb/hp: Add Pro 3400 ...................................................................... Patch Set 7: (1 comment) File Documentation/mainboard/hp/pro_3x00_series.md: PS1: > If possible, yes Done. I'll create a follow up right now. -- To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Gerrit-Change-Number: 85825 Gerrit-PatchSet: 7 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 00:49:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Václav Straka <venda.straka(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Václav Straka (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Václav Straka. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85825?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/hp: Add Pro 3400 ...................................................................... mb/hp: Add Pro 3400 Based on autoport and HP Pro 3500. As part of this change renamed 3500 to 3x00 and added this as it's variant. It's an almost identical board to the 3500 but has a smaller flash. Other differences between boards were identified by autoport. They may or may not important but were included anyway. Tested on HP Pro 3400, behaves exactly as 3500 described in the docs. Changes were not significant enough to require retesting on 3500. Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Signed-off-by: Vesek <venda.straka(a)gmail.com> --- M Documentation/mainboard/hp/pro_3500_series.md M Documentation/mainboard/index.md D src/mainboard/hp/pro_3500_series/Kconfig A src/mainboard/hp/pro_3x00_series/Kconfig R src/mainboard/hp/pro_3x00_series/Kconfig.name R src/mainboard/hp/pro_3x00_series/Makefile.mk R src/mainboard/hp/pro_3x00_series/acpi/ec.asl R src/mainboard/hp/pro_3x00_series/acpi/platform.asl R src/mainboard/hp/pro_3x00_series/acpi/superio.asl R src/mainboard/hp/pro_3x00_series/acpi_tables.c A src/mainboard/hp/pro_3x00_series/board_info.txt A src/mainboard/hp/pro_3x00_series/cmos.default A src/mainboard/hp/pro_3x00_series/cmos.layout R src/mainboard/hp/pro_3x00_series/common_defines.h R src/mainboard/hp/pro_3x00_series/devicetree.cb R src/mainboard/hp/pro_3x00_series/dsdt.asl R src/mainboard/hp/pro_3x00_series/early_init.c R src/mainboard/hp/pro_3x00_series/gma-mainboard.ads R src/mainboard/hp/pro_3x00_series/hda_verb.c R src/mainboard/hp/pro_3x00_series/led.c R src/mainboard/hp/pro_3x00_series/led.h R src/mainboard/hp/pro_3x00_series/mainboard.c R src/mainboard/hp/pro_3x00_series/smihandler.c C src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/board_info.txt A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/data.vbt A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/gpio.c A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/board_info.txt R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/data.vbt R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/gpio.c A src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/overridetree.cb 31 files changed, 431 insertions(+), 96 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/85825/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Gerrit-Change-Number: 85825 Gerrit-PatchSet: 7 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Angel Pons (Code Review) 04 Jan '25

04 Jan '25

Attention is currently required from: Václav Straka. Angel Pons has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email ) Change subject: mb/hp: Add Pro 3400 ...................................................................... Patch Set 6: (1 comment) File Documentation/mainboard/hp/pro_3x00_series.md: PS1: > Yes, that would be possible. Do you still want this? I am not sure since it's marked as resolved. If possible, yes -- To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Gerrit-Change-Number: 85825 Gerrit-PatchSet: 6 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com> Gerrit-Comment-Date: Sat, 04 Jan 2025 00:36:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Václav Straka <venda.straka(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Václav Straka (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Angel Pons. Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email ) Change subject: mb/hp: Add Pro 3400 ...................................................................... Patch Set 6: (1 comment) File Documentation/mainboard/hp/pro_3x00_series.md: PS1: > It's really annoying that Gerrit doesn't show this file as being renamed. […] Yes, that would be possible. Do you still want this? I am not sure since it's marked as resolved. -- To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Gerrit-Change-Number: 85825 Gerrit-PatchSet: 6 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Jan 2025 22:48:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[M] Change in coreboot[main]: soc/amd/common/acpi: Add SPI flash controller
by Felix Held (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Ana Carolina Cabral, Fred Reitberger, Jason Glenesk, Matt DeVillier, Paul Menzel. Felix Held has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/84918?usp=email ) Change subject: soc/amd/common/acpi: Add SPI flash controller ...................................................................... Patch Set 5: (1 comment) File src/soc/amd/common/acpi/spi.asl: https://review.coreboot.org/c/coreboot/+/84918/comment/5c5c9c47_ce8ddb7c?us… : PS5, Line 21: ASCE different values get written to this field from the ASSC method when the driver acquires the bus vs when it releases the bus resulting in different spi chip select pins being used; since the spi flash will always use the same chip select pin, this likely breaks functionality in some case; not sure though which exact case -- To view, visit https://review.coreboot.org/c/coreboot/+/84918?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0f2c1e3351671ad47fbe5c890e4f99d2e19dbfbf Gerrit-Change-Number: 84918 Gerrit-PatchSet: 5 Gerrit-Owner: Ana Carolina Cabral Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Ana Carolina Cabral Gerrit-Comment-Date: Fri, 03 Jan 2025 21:40:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: drivers/amd/opensil: Add openSIL timepoint calls
by Felix Held (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier, Nick Kochlowski, Paul Menzel, Varshit Pandya. Felix Held has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85631?usp=email ) Change subject: drivers/amd/opensil: Add openSIL timepoint calls ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85631?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0559fc0ff0ec55e9ef131e5ed20dfb5baa651da Gerrit-Change-Number: 85631 Gerrit-PatchSet: 8 Gerrit-Owner: Nick Kochlowski <nickkochlowski(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Kochlowski <nickkochlowski(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Jan 2025 20:54:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: cpu/x86/64bit: Back up/restore CR3 on mode switch
by Maximilian Brune (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Arthur Heymans, Felix Held, Jérémy Compostella, Patrick Rudolph, Paul Menzel. Maximilian Brune has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/82164?usp=email ) Change subject: cpu/x86/64bit: Back up/restore CR3 on mode switch ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If94a24925994ac9599be24f6454ea28d02ff0c67 Gerrit-Change-Number: 82164 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 03 Jan 2025 19:02:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: cpu/x86/64bit/mode_switch: Add workaround for FSP bug
by Maximilian Brune (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Arthur Heymans, Jérémy Compostella, Patrick Rudolph. Maximilian Brune has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85789?usp=email ) Change subject: cpu/x86/64bit/mode_switch: Add workaround for FSP bug ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/cpu/x86/64bit/mode_switch.S: https://review.coreboot.org/c/coreboot/+/85789/comment/910ecd05_99d71d66?us… : PS2, Line 30: push $0 : push $0 nit: Could you use `pushq` to make it more obvious how much you push onto the stack? Since we are in both x86_32 and x86_64 in this file it would make it easier for me to see how much is being pushed at a glance. -- To view, visit https://review.coreboot.org/c/coreboot/+/85789?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56367d8153aa10a9b1bcaa5ffde8ebe202e8c00c Gerrit-Change-Number: 85789 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 03 Jan 2025 18:59:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/amd/crater: Add Crater mainboard support for Renoir/Cezanne SOC
by Felix Held (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Bao Zheng, Fred Reitberger, Jason Glenesk, Matt DeVillier. Felix Held has posted comments on this change by Anand Vaikar. ( https://review.coreboot.org/c/coreboot/+/85749?usp=email ) Change subject: mb/amd/crater: Add Crater mainboard support for Renoir/Cezanne SOC ...................................................................... Patch Set 8: (18 comments) File src/mainboard/amd/crater/Kconfig: https://review.coreboot.org/c/coreboot/+/85749/comment/24ad4303_7c02d175?us… : PS8, Line 33: if BOARD_AMD_CRATER_RENOIR this if is redundant, since this config option is already inside a "if BOARD_AMD_CRATER_RENOIR" block. same for the 2 config options below https://review.coreboot.org/c/coreboot/+/85749/comment/15e6fe79_6bbf5204?us… : PS8, Line 61: default "3rdparty/blobs/mainboard/amd/crater/EcSig_Crater.bin" since this file isn't available in the public blobs repo, i'd say that we should have this in the .config used in the build instead of here in the kconfig https://review.coreboot.org/c/coreboot/+/85749/comment/614f27a5_06046f2d?us… : PS8, Line 87: there should only be one empty line https://review.coreboot.org/c/coreboot/+/85749/comment/47edcca6_ed1185c6?us… : PS8, Line 105: choice : prompt "I2C Speed Selection" : default SELECT_400KHz : help : Select Different speeds of I2C 400KHz / 1 MHz : : config SELECT_400KHz : bool "400KHz" : : config SELECT_1MHz : bool "1MHz" : : endchoice not needed, since the i2c speed can and should be configured in the devicetree File src/mainboard/amd/crater/chromeos.c: https://review.coreboot.org/c/coreboot/+/85749/comment/d8f3cd19_6eaf0658?us… : PS8, Line 17: Birman Crater File src/mainboard/amd/crater/chromeos_renoir.fmd: PS8: not sure if the PSP_NVRAM and PSP_RPMC_NVRAM fmpa sections would easily fit into the fmap. if so, it might be good to add those; i'm fine with that being looked into in some follow-up patch File src/mainboard/amd/crater/devicetree_renoir.cb: https://review.coreboot.org/c/coreboot/+/85749/comment/309ebf86_9f2ab003?us… : PS8, Line 3: only one empty line https://review.coreboot.org/c/coreboot/+/85749/comment/135b59cc_d9f03355?us… : PS8, Line 43: register "gpp_clk_config[0]" = "GPP_CLK_ON" : register "gpp_clk_config[1]" = "GPP_CLK_ON" : register "gpp_clk_config[2]" = "GPP_CLK_ON" : register "gpp_clk_config[3]" = "GPP_CLK_ON" : register "gpp_clk_config[4]" = "GPP_CLK_ON" : register "gpp_clk_config[5]" = "GPP_CLK_ON" : register "gpp_clk_config[6]" = "GPP_CLK_ON" haven't checked with the schematic, but some of those probably aren't correct. feel free to keep it as it is for now and revisit this later, since this would be mainly an optimization to lower the power consumption File src/mainboard/amd/crater/early_gpio.c: https://review.coreboot.org/c/coreboot/+/85749/comment/e812dac4_fac03143?us… : PS8, Line 13: should be tab not spaces https://review.coreboot.org/c/coreboot/+/85749/comment/091e1bcc_fe6ea363?us… : PS8, Line 70: }; i'd add an empty line between the array and the function here File src/mainboard/amd/crater/ec.h: https://review.coreboot.org/c/coreboot/+/85749/comment/3b45450c_1c235810?us… : PS8, Line 7: void crater_boardrevision(void); i'd add an empty line between the last function and the #endif File src/mainboard/amd/crater/ec.c: https://review.coreboot.org/c/coreboot/+/85749/comment/c2b17876_3f9f551b?us… : PS8, Line 156: void crater_boardrevision(void) hmm, i wonder if it would be cleaner if this file provides a function to get the board revision and have the revision-specific soc gpio configuration done in the mainboard code that configures the soc gpios File src/mainboard/amd/crater/gpio.c: PS8: this is probably missing some gpios https://review.coreboot.org/c/coreboot/+/85749/comment/5be01867_8a458178?us… : PS8, Line 16: tab File src/mainboard/amd/crater/port_descriptors_renoir.c: https://review.coreboot.org/c/coreboot/+/85749/comment/a6e9af65_d2961bca?us… : PS8, Line 96: ec_set_ports(CRATER_EC_CMD, CRATER_EC_DATA); : BoardRev = ec_read(ECRAM_BOARDID_OFFSET + 0x3); would be good to have a function in the mainboard's ec code for this https://review.coreboot.org/c/coreboot/+/85749/comment/0c481978_4bdf38a5?us… : PS8, Line 115: void __weak mainboard_fsp_mainboard_params_init(FSP_M_CONFIG *m_config) : { : : } i don't see this function being needed or called, so it can likely be removed. same for the prototype in line 12 File src/soc/amd/cezanne/chip.h: https://review.coreboot.org/c/coreboot/+/85749/comment/41fc7880_13d86a45?us… : PS8, Line 112: bool acp_i2s_use_external_48mhz_osc; this and the corresponding change in the cezanne soc code should be done in a separate patch before adding the mainboard File src/soc/amd/cezanne/include/soc/gpio.h: PS8: this change should also be split out into a separate patch, so that the mainboard patch doesn't need to touch any files outside of the mainboard directory -- To view, visit https://review.coreboot.org/c/coreboot/+/85749?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdb276fc160326c666d5990e34de5327813d9403 Gerrit-Change-Number: 85749 Gerrit-PatchSet: 8 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Ana Carolina Cabral Gerrit-Comment-Date: Fri, 03 Jan 2025 18:05:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: doc/util/ifdtool: Update instructions
by Nicholas Chin (Code Review) 03 Jan '25

03 Jan '25

Attention is currently required from: Felix Singer, Martin L Roth, Maximilian Brune. Nicholas Chin has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/85235?usp=email ) Change subject: doc/util/ifdtool: Update instructions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I868ea8918a1566cfade3bc161117f2ca8dfed31d Gerrit-Change-Number: 85235 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Fri, 03 Jan 2025 17:49:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

← Newer
1
...
60
61
62
63
64
65
66
...
80
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025