Attention is currently required from: Benjamin Doron, Lean Sheng Tan.
Julius Werner has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/85643?usp=email )
Change subject: commonlib/device_tree.c: Add a function that reads FDT ints
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85643/comment/5b18fc62_a597e002?us… :
PS5, Line 13: /
typo
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/85643/comment/2ef119c5_0c06b5a9?us… :
PS5, Line 266: printk(BIOS_ERR, "FDT integer property of size %u @%p doesn't match expected cell count %u\n", prop->size, prop->data, cells);
Should at least drop the arguments after the format string into a continuation line.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85643?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I02d27eb5e23dfbfc1404d209ee8d60968e22bb80
Gerrit-Change-Number: 85643
Gerrit-PatchSet: 5
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com>
Gerrit-Comment-Date: Thu, 02 Jan 2025 18:33:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Angel Pons, Keith Hui, Kevin Keijzer, Paul Menzel.
Nicholas Chin has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/78204?usp=email )
Change subject: Documentation/mb/asus/p8z77-m: Document latest test results
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78204?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f4c9268cd272caa83267be3f71d4a2022c26a1c
Gerrit-Change-Number: 78204
Gerrit-PatchSet: 4
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl>
Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Comment-Date: Thu, 02 Jan 2025 17:44:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Nicholas Chin, Václav Straka.
Angel Pons has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85831?usp=email )
Change subject: mb/hp/pro_3500_series: Move usb configuration
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/85831?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69f1f800e4e2de5367795400d619bf9c000ff184
Gerrit-Change-Number: 85831
Gerrit-PatchSet: 2
Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Thu, 02 Jan 2025 17:44:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Angel Pons.
Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
Change subject: mb/hp: Add Pro 3400
......................................................................
Patch Set 6:
(1 comment)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/85825/comment/48d8597e_25f330ee?us… :
PS1, Line 11: As a side effect fixed 3500's USB. (broken since 81878)
> Okay, I'll create a new change and rebase this one on top of that.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387
Gerrit-Change-Number: 85825
Gerrit-PatchSet: 6
Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 02 Jan 2025 16:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Václav Straka <venda.straka(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Václav Straka has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/85831?usp=email )
Change subject: mb/hp/pro_3500_series: Move usb configuration
......................................................................
mb/hp/pro_3500_series: Move usb configuration
Since commit 943b5409147 USB configurations are read from the
southbridge devicetree
This change only moves the USB configuration from early_init.c to
the devicetree
Change-Id: I69f1f800e4e2de5367795400d619bf9c000ff184
Signed-off-by: Vesek <venda.straka(a)gmail.com>
---
M src/mainboard/hp/pro_3500_series/devicetree.cb
M src/mainboard/hp/pro_3500_series/early_init.c
2 files changed, 16 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/85831/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85831?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69f1f800e4e2de5367795400d619bf9c000ff184
Gerrit-Change-Number: 85831
Gerrit-PatchSet: 2
Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Angel Pons.
Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
Change subject: mb/hp: Add Pro 3400
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85825/comment/634390b2_138baac1?us… :
PS1, Line 25: device ref pci_bridge off end
> Ah, right, there needs to be a device. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387
Gerrit-Change-Number: 85825
Gerrit-PatchSet: 4
Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 02 Jan 2025 15:38:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Václav Straka <venda.straka(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Angel Pons.
Václav Straka has uploaded a new patch set (#4). ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
Change subject: mb/hp: Add Pro 3400
......................................................................
mb/hp: Add Pro 3400
Based on autoport and HP Pro 3500.
As part of this change renamed 3500 to 3x00 and added this as
it's variant.
It's an almost identical board to the 3500 but has a smaller flash.
Other differences between boards were identified by autoport.
They may or may not important but were included anyway.
Tested on HP Pro 3400, behaves exactly as 3500 described in the docs.
Changes were not significant enough to require retesting on 3500.
Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387
Signed-off-by: Vesek <venda.straka(a)gmail.com>
---
D Documentation/mainboard/hp/pro_3500_series.md
A Documentation/mainboard/hp/pro_3x00_series.md
R Documentation/mainboard/hp/pro_3x00_series_flash.avif
R Documentation/mainboard/hp/pro_3x00_series_jumper.avif
M Documentation/mainboard/index.md
D src/mainboard/hp/pro_3500_series/Kconfig
A src/mainboard/hp/pro_3x00_series/Kconfig
R src/mainboard/hp/pro_3x00_series/Kconfig.name
R src/mainboard/hp/pro_3x00_series/Makefile.mk
R src/mainboard/hp/pro_3x00_series/acpi/ec.asl
R src/mainboard/hp/pro_3x00_series/acpi/platform.asl
R src/mainboard/hp/pro_3x00_series/acpi/superio.asl
R src/mainboard/hp/pro_3x00_series/acpi_tables.c
A src/mainboard/hp/pro_3x00_series/board_info.txt
A src/mainboard/hp/pro_3x00_series/cmos.default
A src/mainboard/hp/pro_3x00_series/cmos.layout
R src/mainboard/hp/pro_3x00_series/common_defines.h
R src/mainboard/hp/pro_3x00_series/devicetree.cb
R src/mainboard/hp/pro_3x00_series/dsdt.asl
R src/mainboard/hp/pro_3x00_series/early_init.c
R src/mainboard/hp/pro_3x00_series/gma-mainboard.ads
R src/mainboard/hp/pro_3x00_series/hda_verb.c
R src/mainboard/hp/pro_3x00_series/led.c
R src/mainboard/hp/pro_3x00_series/led.h
R src/mainboard/hp/pro_3x00_series/mainboard.c
R src/mainboard/hp/pro_3x00_series/smihandler.c
C src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/board_info.txt
A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/data.vbt
A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/gpio.c
A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb
R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/board_info.txt
R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/data.vbt
R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/gpio.c
A src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/overridetree.cb
34 files changed, 499 insertions(+), 165 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/85825/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387
Gerrit-Change-Number: 85825
Gerrit-PatchSet: 4
Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>