coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3270 discussions

[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Select more appropriate macros for USB ports
by Sean Rhodes (Code Review) 20 Jan '25

20 Jan '25

Attention is currently required from: Matt DeVillier, Sean Rhodes. Hello Matt DeVillier, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85974?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by Matt DeVillier, Verified+1 by build bot (Jenkins) Change subject: mb/starlabs/starlite_adl: Select more appropriate macros for USB ports ...................................................................... mb/starlabs/starlite_adl: Select more appropriate macros for USB ports Add the trace lengths as comments, and update the macros used for the USB ports accordingly. Like other boards, avoid the `USB2_PORT_TYPE_C` macro, as it makes ports behave inconsistantly. Change-Id: Id193b3ed86c58aedc7d5a1f384f2829a2bf18671 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/85974/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/85974?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id193b3ed86c58aedc7d5a1f384f2829a2bf18671 Gerrit-Change-Number: 85974 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[M] Change in coreboot[main]: soc/amd/glinda/cpu: Update cache info
by Naresh Solanki (Code Review) 20 Jan '25

20 Jan '25

Attention is currently required from: Angel Pons, Jérémy Compostella, Patrick Rudolph, Paul Menzel. Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email ) Change subject: soc/amd/glinda/cpu: Update cache info ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85640/comment/b43d9073_b8360246?us… : PS3, Line 8: > Please add that to the commit message. Sure. Will do that in next patchset File src/soc/amd/glinda/cpu.c: https://review.coreboot.org/c/coreboot/+/85640/comment/2adeed4a_4f152b2d?us… : PS3, Line 43: fill_cpu_cache_info > For level=(0-2) it's identical to `fill_cpu_cache_info`. […] I guess you imply that: Use fill_cpu_cache_info which intern can call SoC specific handler(say soc_fill_cpu_cache_info) which if returns valid data then use it else fallback to previous implementation? If so then yes I can update it in that way. Also with the cpu_cache_info in heap, zen_2_3_init can update it & can be update the information in soc_fill_cpu_cache_info for level 3. Let me know your thought & suggestion/improvements on that. Thanks https://review.coreboot.org/c/coreboot/+/85640/comment/2c0c8456_71fe8b85?us… : PS3, Line 60: struct cpu_cache_info info_list > Can you move `struct cpu_cache_info` to the heap and fill it in `zen_2_3_init` for LVL3 only? Yes. https://review.coreboot.org/c/coreboot/+/85640/comment/326e67a3_39ae0f0b?us… : PS3, Line 66: memcpy(info, &info_list[0], sizeof(*info)); > Oh, wait. This is only copying one element of the array. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/85640?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I46947e8ac62c903036a81642e03201e353c3dac6 Gerrit-Change-Number: 85640 Gerrit-PatchSet: 3 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 20 Jan 2025 11:14:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Naresh Solanki <naresh.solanki(a)9elements.com>

1 0

[XS] Change in coreboot[main]: util/crossgcc: Update variable use
by Paul Menzel (Code Review) 20 Jan '25

20 Jan '25

Attention is currently required from: Jon Murphy, Martin L Roth. Paul Menzel has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85718?usp=email ) Change subject: util/crossgcc: Update variable use ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85718/comment/9ed5283c_6eb2b5cf?us… : PS2, Line 7: Update variable use Maybe be more specific: > Quote DESTDIR to prevent unintended separation and globbing -- To view, visit https://review.coreboot.org/c/coreboot/+/85718?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9eb833b11f20b72db88e4094a3297a1d8891bac2 Gerrit-Change-Number: 85718 Gerrit-PatchSet: 2 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Comment-Date: Mon, 20 Jan 2025 10:57:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/rauru: Add DVFS support in romstage
by Jarried Lin (Code Review) 20 Jan '25

20 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86042?usp=email ) Change subject: mb/google/rauru: Add DVFS support in romstage ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/rauru/romstage.c: https://review.coreboot.org/c/coreboot/+/86042/comment/968a2354_52448991?us… : PS4, Line 46: dvfs_init(); > Ah, you're correct. Thanks~ 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/86042?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f290946365b4c5a650651ebea30ffc76583d2b2 Gerrit-Change-Number: 86042 Gerrit-PatchSet: 4 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 20 Jan 2025 10:13:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[XS] Change in coreboot[main]: mb/google/rauru: Add DVFS support in romstage
by Yu-Ping Wu (Code Review) 20 Jan '25

20 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86042?usp=email ) Change subject: mb/google/rauru: Add DVFS support in romstage ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File src/mainboard/google/rauru/romstage.c: https://review.coreboot.org/c/coreboot/+/86042/comment/7e150013_dc22e3c2?us… : PS4, Line 46: dvfs_init(); > Hi Yu-ping, this is romstage. kraken will run during the ramstage (soc.c). […] Ah, you're correct. -- To view, visit https://review.coreboot.org/c/coreboot/+/86042?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f290946365b4c5a650651ebea30ffc76583d2b2 Gerrit-Change-Number: 86042 Gerrit-PatchSet: 4 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 20 Jan 2025 10:03:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Jarried Lin <jarried.lin(a)mediatek.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/rauru: Add DVFS support in romstage
by Jarried Lin (Code Review) 20 Jan '25

20 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86042?usp=email ) Change subject: mb/google/rauru: Add DVFS support in romstage ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/rauru/romstage.c: https://review.coreboot.org/c/coreboot/+/86042/comment/bbe1bf16_2a739ed1?us… : PS4, Line 46: dvfs_init(); > Then, shouldn't we move `dvfs_init` call somewhere before `mtk_fsp_load_and_run`? Hi Yu-ping, this is romstage. kraken will run during the ramstage (soc.c). As far as I know, soc.c should execute after romstage.c. Or did I misunderstand your point? thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/86042?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f290946365b4c5a650651ebea30ffc76583d2b2 Gerrit-Change-Number: 86042 Gerrit-PatchSet: 4 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 20 Jan 2025 09:44:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[M] Change in coreboot[main]: mb/google/rauru: Add panel driver in mainboard
by Yu-Ping Wu (Code Review) 20 Jan '25

20 Jan '25

Attention is currently required from: Bincai Liu, Hung-Te Lin, Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85951?usp=email ) Change subject: mb/google/rauru: Add panel driver in mainboard ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85951?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iea610c97351beb94a49cc1044701a523b7c85a6e Gerrit-Change-Number: 85951 Gerrit-PatchSet: 9 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Bincai Liu <bincai.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Bincai Liu <bincai.liu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 20 Jan 2025 09:40:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/rauru: Add DVFS support in romstage
by Yu-Ping Wu (Code Review) 20 Jan '25

20 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86042?usp=email ) Change subject: mb/google/rauru: Add DVFS support in romstage ...................................................................... Patch Set 4: -Code-Review (1 comment) File src/mainboard/google/rauru/romstage.c: https://review.coreboot.org/c/coreboot/+/86042/comment/aeb145bf_55f4f6c7?us… : PS4, Line 46: dvfs_init(); > Hi Yu-ping, […] Then, shouldn't we move `dvfs_init` call somewhere before `mtk_fsp_load_and_run`? -- To view, visit https://review.coreboot.org/c/coreboot/+/86042?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f290946365b4c5a650651ebea30ffc76583d2b2 Gerrit-Change-Number: 86042 Gerrit-PatchSet: 4 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 20 Jan 2025 09:38:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Jarried Lin <jarried.lin(a)mediatek.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Enable SAGv
by Pranava Y N (Code Review) 20 Jan '25

20 Jan '25

Attention is currently required from: Bora Guvendik. Pranava Y N has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/85272?usp=email ) Change subject: mb/google/fatcat: Enable SAGv ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85272?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I340f4951fd33deadaac53edd30e2cf6bfc2a750b Gerrit-Change-Number: 85272 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Comment-Date: Mon, 20 Jan 2025 09:35:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/google/rauru: Add panel driver in mainboard
by Jarried Lin (Code Review) 20 Jan '25

20 Jan '25

Attention is currently required from: Bincai Liu, Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85951?usp=email ) Change subject: mb/google/rauru: Add panel driver in mainboard ...................................................................... Patch Set 9: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85951/comment/f816c0fd_49ecfd9d?us… : PS7, Line 9: ruaru > rauru Done https://review.coreboot.org/c/coreboot/+/85951/comment/19bcf8c0_817c7e68?us… : PS7, Line 9: oled > OLED Done File src/mainboard/google/rauru/Makefile.mk: https://review.coreboot.org/c/coreboot/+/85951/comment/7b419578_383e4201?us… : PS7, Line 15: ramstage-y += mainboard.c > sort Done File src/mainboard/google/rauru/panel.h: https://review.coreboot.org/c/coreboot/+/85951/comment/265d0baa_fd60a90a?us… : PS7, Line 3: KUKUI > RAURU Done https://review.coreboot.org/c/coreboot/+/85951/comment/989be9b7_67266fee?us… : PS7, Line 8: #endif /* __MAINBOARD_GOOGLE_KUKUI_PANEL_H__ */ > > `adding a line without newline at end of file` […] Done https://review.coreboot.org/c/coreboot/+/85951/comment/7f98a693_3666b4cb?us… : PS7, Line 8: KUKUI > RAURU Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85951?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iea610c97351beb94a49cc1044701a523b7c85a6e Gerrit-Change-Number: 85951 Gerrit-PatchSet: 9 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Bincai Liu <bincai.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Bincai Liu <bincai.liu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 20 Jan 2025 09:32:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025