coreboot-gerrit September 2024

coreboot-gerrit@coreboot.org

1 participants
3342 discussions

[S] Change in coreboot[main]: Documentation/soc/intel/xeon_sp: Update doc to use real FSP headers
by Shuo Liu (Code Review) 29 Sep '24

29 Sep '24

Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84550?usp=email ) Change subject: Documentation/soc/intel/xeon_sp: Update doc to use real FSP headers ...................................................................... Patch Set 3: (1 comment) File Documentation/soc/intel/xeon_sp/community_preview_guide.md: https://review.coreboot.org/c/coreboot/+/84550/comment/de4e82a8_42839873?us… : PS2, Line 115: Other needed firmware ingredients includes microcode, intel flash descriptor and platform boot : policy. The same flow to obtain and apply. > Fix applied. It is weird that the in-site apply didn't work here and I made the fix in https://review.coreboot.org/c/coreboot/+/84583. -- To view, visit https://review.coreboot.org/c/coreboot/+/84550?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a8b01a661a92630d41837a168e17a0fa3c50f04 Gerrit-Change-Number: 84550 Gerrit-PatchSet: 3 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sun, 29 Sep 2024 07:50:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[S] Change in coreboot[main]: Documentation/soc/intel/xeon_sp: Update doc to use real FSP headers
by Shuo Liu (Code Review) 29 Sep '24

29 Sep '24

Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84550?usp=email ) Change subject: Documentation/soc/intel/xeon_sp: Update doc to use real FSP headers ...................................................................... Patch Set 3: (2 comments) File Documentation/soc/intel/xeon_sp/community_preview_guide.md: https://review.coreboot.org/c/coreboot/+/84550/comment/b9ec9bff_c9b07b6c?us… : PS2, Line 111: to obtain > … them? Sure, fixed in https://review.coreboot.org/c/coreboot/+/84583. https://review.coreboot.org/c/coreboot/+/84550/comment/d689fb5c_260e88ad?us… : PS2, Line 112: onfigs/builder/config.intel.crb.avc and configs/builder/config.intel.crb.bnc > Mark up the paths? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84550?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a8b01a661a92630d41837a168e17a0fa3c50f04 Gerrit-Change-Number: 84550 Gerrit-PatchSet: 3 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sun, 29 Sep 2024 07:49:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: Documentation/soc/intel/xeon_sp: Misc format updates
by Shuo Liu (Code Review) 29 Sep '24

29 Sep '24

Shuo Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84583?usp=email ) Change subject: Documentation/soc/intel/xeon_sp: Misc format updates ...................................................................... Documentation/soc/intel/xeon_sp: Misc format updates Change-Id: I7b33bed56fdd86d7b4ab5bfefcd3abc4a3ba4ce9 Signed-off-by: Shuo Liu <shuo.liu(a)intel.com> --- M Documentation/soc/intel/xeon_sp/community_preview_guide.md 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/84583/1 diff --git a/Documentation/soc/intel/xeon_sp/community_preview_guide.md b/Documentation/soc/intel/xeon_sp/community_preview_guide.md index 33a6cf2..923a359 100644 --- a/Documentation/soc/intel/xeon_sp/community_preview_guide.md +++ b/Documentation/soc/intel/xeon_sp/community_preview_guide.md @@ -108,12 +108,19 @@ ## About Granite Rapids FSP binaries and other needed firmware ingredients -For the real Granite Rapids FSP binaries, please contact intel business interface to obtain. -Then please update configs/builder/config.intel.crb.avc and configs/builder/config.intel.crb.bnc -to apply. +For the real Granite Rapids FSP binaries, please contact intel business interface to obtain them. +Then please update below config files to apply. -Other needed firmware ingredients includes microcode, intel flash descriptor and platform boot -policy. The same flow to obtain and apply. +``` +configs/builder/config.intel.crb.avc +configs/builder/config.intel.crb.bnc +``` + +The following firmware ingredients are also obtained and applied using the same process: + +- Microcode updates +- Intel Flash Descriptor +- Platform Boot Policy ## Test Environment -- To view, visit https://review.coreboot.org/c/coreboot/+/84583?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7b33bed56fdd86d7b4ab5bfefcd3abc4a3ba4ce9 Gerrit-Change-Number: 84583 Gerrit-PatchSet: 1 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com>

1 0

[XS] Change in coreboot[main]: stddef.h: Introduce nullptr constant
by Elyes Haouas (Code Review) 29 Sep '24

29 Sep '24

Attention is currently required from: Jakub Czapiga, Martin L Roth, Nico Huber. Hello Jakub Czapiga, Martin L Roth, Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83459?usp=email to look at the new patch set (#25). Change subject: stddef.h: Introduce nullptr constant ...................................................................... stddef.h: Introduce nullptr constant GCC-13 introduced the nullptr constant. Use it when compiling with the C23 standard. Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/include/stddef.h 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/83459/25 -- To view, visit https://review.coreboot.org/c/coreboot/+/83459?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234 Gerrit-Change-Number: 83459 Gerrit-PatchSet: 25 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>

1 0

[XS] Change in coreboot[main]: tree: Use nullptr instead of 0 for pointer
by Elyes Haouas (Code Review) 29 Sep '24

29 Sep '24

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84582?usp=email to look at the new patch set (#3). Change subject: tree: Use nullptr instead of 0 for pointer ...................................................................... tree: Use nullptr instead of 0 for pointer Change-Id: I1d804ac7910834915057eddb287cf48de7fccaeb Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M payloads/libpayload/curses/form/frm_driver.c M util/cbfstool/amdcompress.c 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/84582/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/84582?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d804ac7910834915057eddb287cf48de7fccaeb Gerrit-Change-Number: 84582 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: tree: Use nullptr instead of 0 for-pointer
by Elyes Haouas (Code Review) 29 Sep '24

29 Sep '24

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84582?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: tree: Use nullptr instead of 0 for-pointer ...................................................................... tree: Use nullptr instead of 0 for-pointer Change-Id: I1d804ac7910834915057eddb287cf48de7fccaeb Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M payloads/libpayload/curses/form/frm_driver.c M util/cbfstool/amdcompress.c 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/84582/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84582?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d804ac7910834915057eddb287cf48de7fccaeb Gerrit-Change-Number: 84582 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: tree: Use nullptr instead of 0 for-pointer
by Elyes Haouas (Code Review) 29 Sep '24

29 Sep '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84582?usp=email ) Change subject: tree: Use nullptr instead of 0 for-pointer ...................................................................... tree: Use nullptr instead of 0 for-pointer Change-Id: I1d804ac7910834915057eddb287cf48de7fccaeb Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M payloads/libpayload/curses/form/frm_driver.c M util/cbfstool/amdcompress.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/84582/1 diff --git a/payloads/libpayload/curses/form/frm_driver.c b/payloads/libpayload/curses/form/frm_driver.c index 2759148..03cf24f 100644 --- a/payloads/libpayload/curses/form/frm_driver.c +++ b/payloads/libpayload/curses/form/frm_driver.c @@ -4504,7 +4504,7 @@ NCURSES_EXPORT(char *) field_buffer(const FIELD *field, int buffer) { - char *result = 0; + char *result = nullptr; T((T_CALLED("field_buffer(%p,%d)"), (const void *)field, buffer)); diff --git a/util/cbfstool/amdcompress.c b/util/cbfstool/amdcompress.c index 76089ea..3b81ffc 100644 --- a/util/cbfstool/amdcompress.c +++ b/util/cbfstool/amdcompress.c @@ -305,7 +305,7 @@ int main(int argc, char *argv[]) { int c; - char *inf = 0, *outf = 0, *scratch; + char *inf = nullptr, *outf = nullptr, *scratch; int direction = DIR_UNDEF; size_t max_size = 0; -- To view, visit https://review.coreboot.org/c/coreboot/+/84582?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d804ac7910834915057eddb287cf48de7fccaeb Gerrit-Change-Number: 84582 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: build test using C23
by Elyes Haouas (Code Review) 29 Sep '24

29 Sep '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84581?usp=email ) Change subject: build test using C23 ...................................................................... build test using C23 Change-Id: I252fd6e9606ff44586d8f4158fcff9fd6a557133 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/84581/1 diff --git a/src/Kconfig b/src/Kconfig index 04838fe..6e401e0 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -100,7 +100,7 @@ config ALLOW_EXPERIMENTAL_C23 bool - default n + default y help C23 dialect is experimental and unsupported. Enable only to build test and prepare for C23 dialect. -- To view, visit https://review.coreboot.org/c/coreboot/+/84581?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I252fd6e9606ff44586d8f4158fcff9fd6a557133 Gerrit-Change-Number: 84581 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: tree: Add kconfig option for C23 dialect
by Elyes Haouas (Code Review) 29 Sep '24

29 Sep '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84489?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: tree: Add kconfig option for C23 dialect ...................................................................... tree: Add kconfig option for C23 dialect This adds C23 dialect for testing and prepar for C23 support. Change-Id: I6fbfb1bd3ca2ae0e216023f54de792f7cbd5f50c Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk M payloads/libpayload/Makefile M payloads/libpayload/tests/Makefile.mk M src/Kconfig M tests/Makefile.common 5 files changed, 29 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/84489/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/84489?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6fbfb1bd3ca2ae0e216023f54de792f7cbd5f50c Gerrit-Change-Number: 84489 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Add initial FW_CONFIG
by Subrata Banik (Code Review) 29 Sep '24

29 Sep '24

Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84543?usp=email ) Change subject: mb/google/fatcat/var/fatcat: Add initial FW_CONFIG ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb: https://review.coreboot.org/c/coreboot/+/84543/comment/8d6597ba_09324842?us… : PS6, Line 37: field STORAGE 15 16 > > This is okay, but we are not limited to have single storage. For instance, two NVMe at the same time. > > what is the motivation of having two SSD working at the same time ? btw, `STORAGE_UNKNOWN` can be used to boot any storage (like between SSD Gen4 or Gen5) -- To view, visit https://review.coreboot.org/c/coreboot/+/84543?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5c90aac4873dcc57e65e641656dca3a96f84d6b8 Gerrit-Change-Number: 84543 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Comment-Date: Sun, 29 Sep 2024 04:02:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2024