Attention is currently required from: Hung-Te Lin, Paul Menzel, Xinxiong Xu, Yang Wu, Yu-Ping Wu.
Knox Chiou has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/20c7ebc9_f3df2f4b?us… :
PS6, Line 131: BOARD_GOOGLE_SQUIRTLE
> If we don't want Squirtle to be an exception, can we apply the same modification to Voltorb? We can […]
Sounds good from my end, as long as you could ensure the FW match with OS in the future.
Then it will be more cleaner from coreboot end.
Please make sure there's sufficient comment in boxster and kernel to avoid future maintenance efforts..
--
To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 6
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 19 Sep 2024 01:12:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Knox Chiou <knoxchiou(a)google.com>
Comment-In-Reply-To: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Hung-Te Lin, Knox Chiou, Paul Menzel, Yang Wu, Yu-Ping Wu.
Xinxiong Xu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/a6575902_7a4179d8?us… :
PS6, Line 131: BOARD_GOOGLE_SQUIRTLE
> Yes if the schedule can be met, otherwise there will be 2 exceptions. […]
If we don't want Squirtle to be an exception, can we apply the same modification to Voltorb? We can add 0x7FFFFEFF to the config.star file and support both 0x7FFFFEFF and 0x7FFFFFFF in the same DTS configuration, ensuring consistency.
Since we need to add 0x7FFFFEFF to Squirtle's config.star, and also add 0x7FFFFEFF to the DTS that supports 0x7FFFFFFF, this shouldn't cause any confusion.
In that case, there will be no need to add exceptions on the coreboot side.
What do you think?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 6
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 19 Sep 2024 00:41:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Knox Chiou <knoxchiou(a)google.com>
Comment-In-Reply-To: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Hung-Te Lin, Paul Menzel, Xinxiong Xu, Yang Wu, Yu-Ping Wu.
Knox Chiou has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/44817dd4_ee74778d?us… :
PS6, Line 131: BOARD_GOOGLE_SQUIRTLE
> Although Squirlte has only one DTS, since 0x7FFFFEFF is not configured in config. […]
Yes if the schedule can be met, otherwise there will be 2 exceptions.
As bug mentioned, 0x7FFFFEFF needs to be defined at the program level within boxster and exposed externally. This will ensure Corsola and Staryu utilize the same configuration going forward.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 6
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 19 Sep 2024 00:06:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Pranava Y N, Subrata Banik.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84407?usp=email )
Change subject: mb/google/fatcat: Add override tree
......................................................................
Patch Set 4:
(12 comments)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84407/comment/7bd373ac_dbbfe9ec?us… :
PS1, Line 3: # GPE configuration
: # Note that GPE events called out in ASL code rely on this
: # route. i.e. If this route changes then the affected GPE
: # offset bits also need to be changed.
: register "pmc_gpe0_dw0" = "GPP_B"
: register "pmc_gpe0_dw1" = "GPP_D"
: register "pmc_gpe0_dw2" = "GPP_E"
> this should do to baseboard devicetree
Done
https://review.coreboot.org/c/coreboot/+/84407/comment/3cf95aa1_4eb4267b?us… :
PS1, Line 40:
: register "tcss_cap_policy[0]" = "7"
: register "tcss_cap_policy[1]" = "7"
: register "tcss_cap_policy[2]" = "7"
: register "tcss_cap_policy[3]" = "7"
> Please let me know what this is.
cf. https://review.coreboot.org/c/coreboot/+/84419https://review.coreboot.org/c/coreboot/+/84407/comment/70eacce4_e804c88b?us… :
PS1, Line 45:
: # EC host command ranges are in 0x800-0x8ff & 0x200-0x20f
: register "gen1_dec" = "0x00fc0801"
: register "gen2_dec" = "0x000c0201"
: # EC memory map range is 0x900-0x9ff
: register "gen3_dec" = "0x00fc0901"
> same as previous comment
Done
https://review.coreboot.org/c/coreboot/+/84407/comment/229f1a07_5dae4ab2?us… :
PS1, Line 52: # This disabled autonomous GPIO power management for early PO
: register "gpio_override_pm" = "1"
: register "gpio_pm[COMM_0]" = "0"
: register "gpio_pm[COMM_1]" = "0"
: register "gpio_pm[COMM_3]" = "0"
: register "gpio_pm[COMM_4]" = "0"
: register "gpio_pm[COMM_5]" = "0"
> we don't need to override to zero value, unless defined the value should be zero
Done
https://review.coreboot.org/c/coreboot/+/84407/comment/c2e5c3e7_a913e179?us… :
PS1, Line 69: # Enable s0ix
: register "s0ix_enable" = "1"
> this should do to baseboard devicetree
Done
https://review.coreboot.org/c/coreboot/+/84407/comment/158050e6_cd37c8f5?us… :
PS1, Line 114: # Intel Common SoC Config
> we generally maintain a table to understand the I2Cx mapping, can you please apply that here as well […]
Done
https://review.coreboot.org/c/coreboot/+/84407/comment/cf8bfdf4_bb62c485?us… :
PS1, Line 151: device ref dtt off end
: device ref npu on end
: device ref iaa off end
:
: device ref heci1 on end
:
> you can move these to baseboard
Done
https://review.coreboot.org/c/coreboot/+/84407/comment/bac5177d_7b78f6db?us… :
PS1, Line 223:
> please use consistent tab
Done
https://review.coreboot.org/c/coreboot/+/84407/comment/c036bbb5_6098eb79?us… :
PS1, Line 246: device ref pcie_rp1 off
: # register "pcie_rp[PCIE_RP(1)]" = "{
: # .clk_src = 3,
: # .clk_req = 3,
: # .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER,
: # }"
: end # Gbe
> please don't add GBE support which is non-POR for Chrome, if you wish to keep RP0 enabled then keep […]
Done
https://review.coreboot.org/c/coreboot/+/84407/comment/a565a17c_80f8ed84?us… :
PS1, Line 305: device ref pcie_rp9 on
: register "pcie_rp[PCIE_RP(9)]" = "{
: .clk_src = 1,
: .clk_req = 1,
: .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER,
: }"
: chip soc/intel/common/block/pcie/rtd3
: register "is_storage" = "true"
: register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B16)"
: register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E03)"
: register "srcclk_pin" = "1"
: device generic 0 on end
: end
: end # Gen5 M.2 SSD / x4 PCIe slot
> please don't need Gen5 support. […]
Done
https://review.coreboot.org/c/coreboot/+/84407/comment/873e3e0f_030b6714?us… :
PS1, Line 330: lnlrvp_ish
> please don't enable everything as part of base CL. […]
Done
https://review.coreboot.org/c/coreboot/+/84407/comment/ef676e24_760a5b8b?us… :
PS1, Line 654: device ref hda on
: chip drivers/intel/soundwire
: device generic 0 on
: chip drivers/soundwire/alc711
: # SoundWire Link 1 ID 1
: register "desc" = ""Headset Codec""
: device generic 1.1 on end
: end
: end
: end
: chip drivers/generic/max98357a
: register "hid" = ""MX98357A""
: register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E19)"
: register "sdmode_delay" = "5"
: device generic 0 on end
: end
: chip drivers/generic/max98357a
: register "hid" = ""MX98360A""
: register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E19)"
: register "sdmode_delay" = "5"
: device generic 0 on end
: end
: end
:
: end
> please use consistent spacing
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84407?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d53
Gerrit-Change-Number: 84407
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Thu, 19 Sep 2024 00:02:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Pranava Y N <pranavayn(a)google.com>
Attention is currently required from: Kapil Porwal, Pranava Y N, Subrata Banik.
Jérémy Compostella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84419?usp=email )
Change subject: soc/intel/ptl: Provide the TCSS port policy setting options
......................................................................
soc/intel/ptl: Provide the TCSS port policy setting options
Each TCSS port can be associated a setting via the tcss_cap_policy
device tree field. The setting can be picked within five values listed
by this commit.
BUG=b/348678529
TEST=fatcat board build tcss_cap_policy[0]=TCSS_TYPE_C_PORT_FULL_FUN
Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d56
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
---
M src/soc/intel/pantherlake/chip.h
M src/soc/intel/pantherlake/include/soc/tcss.h
2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/84419/1
diff --git a/src/soc/intel/pantherlake/chip.h b/src/soc/intel/pantherlake/chip.h
index 27d766f..85dcccd 100644
--- a/src/soc/intel/pantherlake/chip.h
+++ b/src/soc/intel/pantherlake/chip.h
@@ -16,6 +16,7 @@
#include <soc/pci_devs.h>
#include <soc/pmc.h>
#include <soc/serialio.h>
+#include <soc/tcss.h>
#include <soc/usb.h>
#include <stdint.h>
diff --git a/src/soc/intel/pantherlake/include/soc/tcss.h b/src/soc/intel/pantherlake/include/soc/tcss.h
index 79604bc..a1d72b8 100644
--- a/src/soc/intel/pantherlake/include/soc/tcss.h
+++ b/src/soc/intel/pantherlake/include/soc/tcss.h
@@ -16,4 +16,12 @@
#define BIAS_CTRL_VW_INDEX_SHIFT 24
#define BIAS_CTRL_BIT_POS_SHIFT 16
+enum {
+ TCSS_TYPE_C_PORT_DISABLE,
+ TCSS_TYPE_C_PORT_DP_ONLY,
+ TCSS_TYPE_C_PORT_NO_TBT,
+ TCSS_TYPE_C_PORT_NO_PCIE,
+ TCSS_TYPE_C_PORT_FULL_FUN = 7
+};
+
#endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/84419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d56
Gerrit-Change-Number: 84419
Gerrit-PatchSet: 1
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Attention is currently required from: Jérémy Compostella, Pranava Y N.
Hello Pranava Y N, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84407?usp=email
to look at the new patch set (#4).
Change subject: mb/google/fatcat: Add override tree
......................................................................
mb/google/fatcat: Add override tree
BUG=b:348678529
TEST=Boot on google fatcat board
Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d53
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
---
M src/mainboard/google/fatcat/Kconfig
M src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb
A src/mainboard/google/fatcat/variants/fatcat/overridetree.cb
3 files changed, 670 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/84407/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/84407?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d53
Gerrit-Change-Number: 84407
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Attention is currently required from: Hung-Te Lin, Knox Chiou, Paul Menzel, Yang Wu, Yu-Ping Wu.
Xinxiong Xu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/428efa2c_f144e6d9?us… :
PS6, Line 131: BOARD_GOOGLE_SQUIRTLE
> As I said in another thread, we don't need `BOARD_GOOGLE_SQUIRTLE` because the board only has one DT […]
Although Squirlte has only one DTS, since 0x7FFFFEFF is not configured in config.star, if 0x7FFFFEFF is used, the machine will not be able to boot.
Do we need to add an additional configuration related to 0x7FFFFEFF in the Squirlte config.star file?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 6
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 18 Sep 2024 23:45:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Jérémy Compostella, Pranava Y N.
Cliff Huang has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84407?usp=email )
Change subject: mb/google/fatcat: Add override tree
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84407/comment/dd942d7b_54ebf2b6?us… :
PS1, Line 79: [PchSerialIoIndexI2C4] = PchSerialIoPci,
> I2C4 is used for Touchscreen.
I2C0 is function 0 (i.e. 00:15.0). We will need to enable it if any 00:15.[1..3] i2c device is enabled.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84407?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d53
Gerrit-Change-Number: 84407
Gerrit-PatchSet: 3
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Wed, 18 Sep 2024 23:34:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com>
Comment-In-Reply-To: Pranava Y N <pranavayn(a)google.com>
Attention is currently required from: Jérémy Compostella, Pranava Y N.
Hello Pranava Y N, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84407?usp=email
to look at the new patch set (#3).
Change subject: mb/google/fatcat: Add override tree
......................................................................
mb/google/fatcat: Add override tree
BUG=b:348678529
TEST=Boot on google fatcat board
Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d53
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
---
M src/mainboard/google/fatcat/Kconfig
M src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb
A src/mainboard/google/fatcat/variants/fatcat/overridetree.cb
3 files changed, 670 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/84407/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/84407?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d53
Gerrit-Change-Number: 84407
Gerrit-PatchSet: 3
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>