Attention is currently required from: Elyes Haouas.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84160?usp=email
to look at the new patch set (#2).
Change subject: tree: Use boolean for lpss_s0ix_enable
......................................................................
tree: Use boolean for lpss_s0ix_enable
lpss_s0ix_enable is already defined as boolean:
`git grep lpss_s0ix_enable $(find -type f -name "*.h")
src/soc/intel/apollolake/chip.h: bool lpss_s0ix_enable;`
Change-Id: I34bd568defe202daaad6136b9c184bc292a226b3
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/mainboard/google/octopus/variants/baseboard/devicetree.cb
M src/mainboard/google/reef/variants/baseboard/devicetree.cb
M src/mainboard/google/reef/variants/coral/devicetree.cb
M src/mainboard/google/reef/variants/pyro/devicetree.cb
M src/mainboard/google/reef/variants/sand/devicetree.cb
M src/mainboard/google/reef/variants/snappy/devicetree.cb
M src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb
7 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/84160/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84160?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34bd568defe202daaad6136b9c184bc292a226b3
Gerrit-Change-Number: 84160
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84171?usp=email )
Change subject: commonlib/loglevel.h: Fix Wunterminated-string-initialization error
......................................................................
commonlib/loglevel.h: Fix Wunterminated-string-initialization error
This fixes following error:
src/commonlib/include/commonlib/loglevel.h:170:26: error: initializer-string for array of 'char' is too long [-Werror=unterminated-string-initialization]
170 | [BIOS_EMERG] = "EMERG",
| ^~~~~~~
src/commonlib/include/commonlib/loglevel.h:171:26: error: initializer-string for array of 'char' is too long [-Werror=unterminated-string-initialization]
171 | [BIOS_ALERT] = "ALERT",
| ^~~~~~~
src/commonlib/include/commonlib/loglevel.h:172:26: error: initializer-string for array of 'char' is too long [-Werror=unterminated-string-initialization]
172 | [BIOS_CRIT] = "CRIT ",
| ^~~~~~~
src/commonlib/include/commonlib/loglevel.h:173:26: error: initializer-string for array of 'char' is too long [-Werror=unterminated-string-initialization]
173 | [BIOS_ERR] = "ERROR",
| ^~~~~~~
CC host/lib/cbfstool.o
src/commonlib/include/commonlib/loglevel.h:174:26: error: initializer-string for array of 'char' is too long [-Werror=unterminated-string-initialization]
174 | [BIOS_WARNING] = "WARN ",
| ^~~~~~~
src/commonlib/include/commonlib/loglevel.h:175:26: error: initializer-string for array of 'char' is too long [-Werror=unterminated-string-initialization]
175 | [BIOS_NOTICE] = "NOTE ",
| ^~~~~~~
src/commonlib/include/commonlib/loglevel.h:176:26: error: initializer-string for array of 'char' is too long [-Werror=unterminated-string-initialization]
176 | [BIOS_INFO] = "INFO ",
| ^~~~~~~
src/commonlib/include/commonlib/loglevel.h:177:26: error: initializer-string for array of 'char' is too long [-Werror=unterminated-string-initialization]
177 | [BIOS_DEBUG] = "DEBUG",
| ^~~~~~~
src/commonlib/include/commonlib/loglevel.h:178:26: error: initializer-string for array of 'char' is too long [-Werror=unterminated-string-initialization]
178 | [BIOS_SPEW] = "SPEW ",
| ^~~~~~~
Change-Id: I6b149239cf301aa00b2c1ee8ff811492590a07f9
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/commonlib/include/commonlib/loglevel.h
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/84171/1
diff --git a/src/commonlib/include/commonlib/loglevel.h b/src/commonlib/include/commonlib/loglevel.h
index 79fbcfc..19a9d9b 100644
--- a/src/commonlib/include/commonlib/loglevel.h
+++ b/src/commonlib/include/commonlib/loglevel.h
@@ -165,8 +165,7 @@
*/
#define BIOS_LOG_PREFIX_PATTERN "[%.5s] "
#define BIOS_LOG_PREFIX_MAX_LEVEL BIOS_SPEW
-static const char bios_log_prefix[BIOS_LOG_PREFIX_MAX_LEVEL + 1][5] = {
- /* Note: These strings are *not* null-terminated to save space. */
+static const char *bios_log_prefix[BIOS_LOG_PREFIX_MAX_LEVEL + 1] __attribute__((unused)) = {
[BIOS_EMERG] = "EMERG",
[BIOS_ALERT] = "ALERT",
[BIOS_CRIT] = "CRIT ",
--
To view, visit https://review.coreboot.org/c/coreboot/+/84171?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b149239cf301aa00b2c1ee8ff811492590a07f9
Gerrit-Change-Number: 84171
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Elyes Haouas.
Paul Menzel has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84170?usp=email )
Change subject: commonlib/coreboot_tables.h: Fix Wunterminated-string-initialization error
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84170/comment/990c3c63_bc8ea162?us… :
PS1, Line 7: Fix Wunterminated-string-initialization error
Maybe:
> Increase GPIO_MAX_NAME_LENGTH to 17 for *backlight enable*
https://review.coreboot.org/c/coreboot/+/84170/comment/9e2c2a9e_2565a5f8?us… :
PS1, Line 9: This to fix:
What GCC version do you use?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84170?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6fca7f067dab07bda5a31c9b5796272bea9763e1
Gerrit-Change-Number: 84170
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sun, 01 Sep 2024 05:29:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Elyes Haouas.
Paul Menzel has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84160?usp=email )
Change subject: tree: Use boolean for lpss_s0ix_enable
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84160/comment/a85a0b1c_6e29ef9d?us… :
PS1, Line 8:
Why?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84160?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34bd568defe202daaad6136b9c184bc292a226b3
Gerrit-Change-Number: 84160
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sun, 01 Sep 2024 05:19:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Paul Menzel has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83422?usp=email )
Change subject: drivers/efi/uefi_capsules.c: coalesce and store UEFI capsules
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Nice work. Please paste the new log lines in here for the record.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83422?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I162d678ae5c504906084b59c1a8d8c26dadb9433
Gerrit-Change-Number: 83422
Gerrit-PatchSet: 6
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 01 Sep 2024 05:16:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Paul Menzel.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84103?usp=email )
Change subject: soc/intel/common/block/acpi: Add GPE1 blocks to ACPI FADT table
......................................................................
Patch Set 13:
(4 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/84103/comment/5eb4794c_422abf59?us… :
PS7, Line 121: if (CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_USE_GPE1)) {
> sure. agree.
Acknowledged
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/84103/comment/af391b71_7bac40c5?us… :
PS11, Line 115: 0
> Subrata, […]
Acknowledged
File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/84103/comment/d426ee2b_f76c4125?us… :
PS13, Line 144: *
drop this new line
https://review.coreboot.org/c/coreboot/+/84103/comment/7cbea562_2a62725f?us… :
PS13, Line 146:
drop this new line
--
To view, visit https://review.coreboot.org/c/coreboot/+/84103?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia6928c35b86f4a2243d58597b17b2a3a5f54271e
Gerrit-Change-Number: 84103
Gerrit-PatchSet: 13
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 01 Sep 2024 03:11:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>