coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[XS] Change in coreboot[main]: Update fsp submodule to upstream main
by Sean Rhodes (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Felix Singer. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84111?usp=email ) Change subject: Update fsp submodule to upstream main ...................................................................... Patch Set 3: (1 comment) File 3rdparty/fsp: PS1: > This commit is quite old. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84111?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ief40f675556bce662601d7d8db6660f72dc35961 Gerrit-Change-Number: 84111 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Wed, 28 Aug 2024 08:47:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[XS] Change in coreboot[main]: Update fsp submodule to upstream main
by Sean Rhodes (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Sean Rhodes. Sean Rhodes has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/84111?usp=email ) Change subject: Update fsp submodule to upstream main ...................................................................... Update fsp submodule to upstream main Updating from commit id 800c857: 2024-06-25 15:47:28 +0800 - (Update Fsp.fd) to commit id 68328e2: 2024-08-05 16:00:43 +0800 - (NEX ADL-PS IPU 2024.4 (5045_03) FSP) This brings in 10 new commits: * NEX ADL-PS IPU 2024.4 (5045_03) FSP * NEX ADL-P IPU 2024.4 (5045_03) FSP * NEX ADL-S IPU 2024.4 (5045_03) FSP * IoT MTL-UH_MTL-PS MR1 (4053_57) FSP * NEX RPL-S MR4/RPL-S Refresh MR2 (5134_02) FSP * NEX RPL-P MR2 (5134_02) FSP * NEX ADL-P IPU 2024.3 (5045_02) FSP * NEX MTL-UH & MTL-PS Post PV * Iot ADL-N MR5 (5132_00) * remove file Change-Id: Ief40f675556bce662601d7d8db6660f72dc35961 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/84111/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/84111?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ief40f675556bce662601d7d8db6660f72dc35961 Gerrit-Change-Number: 84111 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[XS] Change in coreboot[main]: Update fsp submodule to upstream main
by Sean Rhodes (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Sean Rhodes. Sean Rhodes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/84111?usp=email ) Change subject: Update fsp submodule to upstream main ...................................................................... Update fsp submodule to upstream main Updating from commit id 800c857: 2024-06-25 15:47:28 +0800 - (Update Fsp.fd) to commit id bb12f17: 2023-10-31 16:00:43 +0800 - (Elkhart Lake MR7 FSP) This brings in 1 new commits: Change-Id: Ief40f675556bce662601d7d8db6660f72dc35961 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/84111/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84111?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ief40f675556bce662601d7d8db6660f72dc35961 Gerrit-Change-Number: 84111 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[XS] Change in coreboot[main]: mb/google/brox/jubilant: Update GPE0 routing
by Ren Kuo (Code Review) 28 Aug '24

28 Aug '24

Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84112?usp=email ) Change subject: mb/google/brox/jubilant: Update GPE0 routing ...................................................................... mb/google/brox/jubilant: Update GPE0 routing Update GPE0 routing for FP wake source. BUG=None TEST= Build jubilant firmware Check eventlog of FP wake up Change-Id: Ia1ad27786e0e3bd9c2110c8a28ab962c5567e16d Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brox/variants/jubilant/overridetree.cb 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/84112/1 diff --git a/src/mainboard/google/brox/variants/jubilant/overridetree.cb b/src/mainboard/google/brox/variants/jubilant/overridetree.cb index 9599769..755acdd 100644 --- a/src/mainboard/google/brox/variants/jubilant/overridetree.cb +++ b/src/mainboard/google/brox/variants/jubilant/overridetree.cb @@ -18,6 +18,12 @@ end chip soc/intel/alderlake + + # GPE configuration + register "pmc_gpe0_dw0" = "GPP_B" + register "pmc_gpe0_dw1" = "GPP_F" + register "pmc_gpe0_dw2" = "GPP_E" + register "platform_pmax" = "208" register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" # USB2_C0 @@ -393,7 +399,7 @@ register "uid" = "1" register "compat_string" = ""google,cros-ec-spi"" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_F15_IRQ)" - register "wake" = "GPE0_DW2_15" + register "wake" = "GPE0_DW1_15" register "has_power_resource" = "1" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D2)" -- To view, visit https://review.coreboot.org/c/coreboot/+/84112?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia1ad27786e0e3bd9c2110c8a28ab962c5567e16d Gerrit-Change-Number: 84112 Gerrit-PatchSet: 1 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: Update fsp submodule to upstream main
by Felix Singer (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Sean Rhodes. Felix Singer has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84111?usp=email ) Change subject: Update fsp submodule to upstream main ...................................................................... Patch Set 1: (1 comment) File 3rdparty/fsp: PS1: This commit is quite old. Newest commit is 68328e297e195a6cfb1949b60d971c032a172ba3 -- To view, visit https://review.coreboot.org/c/coreboot/+/84111?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ief40f675556bce662601d7d8db6660f72dc35961 Gerrit-Change-Number: 84111 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 28 Aug 2024 08:40:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: Update intel-microcode submodule to upstream main
by Felix Singer (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Elyes Haouas, Sean Rhodes. Felix Singer has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84110?usp=email ) Change subject: Update intel-microcode submodule to upstream main ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84110?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5cf5d78bcda07f742a8282b84a1c8336e6a23594 Gerrit-Change-Number: 84110 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 28 Aug 2024 08:37:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/brox: Disable Thunderbolt device
by Ren Kuo (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Bob Moragues, Eran Mitrani, Karthik Ramasubramanian, Subrata Banik. Ren Kuo has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/84093?usp=email ) Change subject: mb/google/brox: Disable Thunderbolt device ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84093?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I355852c780c552e6f9b2c28508f53580f392c1b9 Gerrit-Change-Number: 84093 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 28 Aug 2024 08:32:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/lattepanda: Add support for LattePanda Mu
by KunYi Chen (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Felix Held, Felix Singer, Martin L Roth, Nicholas Chin, Nicholas Sudsgaard, Paul Menzel. KunYi Chen has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email ) Change subject: mb/lattepanda: Add support for LattePanda Mu ...................................................................... Patch Set 12: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83719/comment/53c177fd_4b7d8155?us… : PS8, Line 2: KunYi > I see. It’s uncommon in “Western” sphere, to have CamelCase names. Often a space or hyphen is used. Thank you for your suggestion. I initially used CamelCase just to distinguish between different words. I'll keep this in mind for the future. Thanks again. Commit Message: https://review.coreboot.org/c/coreboot/+/83719/comment/0c251718_58ffeb74?us… : PS12, Line 20: Testing with Lite carrier board > Please also list the payload (and version). Acknowledged, okay, the payload is default setting mrchromebox/edk2 uefipayload_202309 File src/mainboard/lattepanda/mu/board_info.txt: https://review.coreboot.org/c/coreboot/+/83719/comment/fcc4fad9_ed4f7c67?us… : PS12, Line 1: Vendor name: DFRobot > Hmm, should the directory have the vendor included then? […] DFRobot uses 'LattePanda' as the brand for SBC/DevKit, so I think it's better to use LattePanda like this. please visit https://www.lattepanda.com/ File src/mainboard/lattepanda/mu/data.vbt: PS12: > Please mention in the commit message, how you created this file. Acknowledged, okay I use UEFITool to extract it. -- To view, visit https://review.coreboot.org/c/coreboot/+/83719?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I79696bdd837a221860b32f54629212c3346dca66 Gerrit-Change-Number: 83719 Gerrit-PatchSet: 12 Gerrit-Owner: KunYi Chen <kunyi.chen(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 28 Aug 2024 08:29:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: KunYi Chen <kunyi.chen(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/lattepanda: Add support for LattePanda Mu
by KunYi Chen (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Felix Held, Felix Singer, KunYi Chen, Martin L Roth, Nicholas Chin, Nicholas Sudsgaard. Hello Felix Held, Nicholas Chin, Nicholas Sudsgaard, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83719?usp=email to look at the new patch set (#13). Change subject: mb/lattepanda: Add support for LattePanda Mu ...................................................................... mb/lattepanda: Add support for LattePanda Mu Add initial support for the LattePanda Mu board, which features: - Intel Alder Lake-N N100 processor - 8GB LPDDR5 memory - 64GB eMMC storage - SO-DIMM 260-pin connector for function expansion This commit includes: - Basic board configuration - Memory initialization - Essential I/O setup - Used UEFITOOL to extract data.vbt file from original BIOS Testing with Lite carrier board - payload: mrchromebox/edk2 - edk2: uefipayload_202309 - Booting into installed Windows 11: Passed - USB 3.0/2.0: Working - HDMI output: Working - Realtek Ethernet: Working - S3 sleep mode: Failed - Power on after shutdown: Failed (requires power removal) - Installing Ubuntu 22.04: Failed - UART of SuperIO in OS: Missing - Environment Controller: Not supported - M.2/M Key: Not working (booting failed with SSD 512GB installed) Change-Id: I79696bdd837a221860b32f54629212c3346dca66 Signed-off-by: KunYi Chen <kunyi.chen(a)gmail.com> --- A configs/config.lattepanda_mu A src/mainboard/lattepanda/Kconfig A src/mainboard/lattepanda/Kconfig.name A src/mainboard/lattepanda/mu/Kconfig A src/mainboard/lattepanda/mu/Kconfig.name A src/mainboard/lattepanda/mu/Makefile.mk A src/mainboard/lattepanda/mu/board_info.txt A src/mainboard/lattepanda/mu/bootblock.c A src/mainboard/lattepanda/mu/data.vbt A src/mainboard/lattepanda/mu/devicetree.cb A src/mainboard/lattepanda/mu/dsdt.asl A src/mainboard/lattepanda/mu/gpio.c A src/mainboard/lattepanda/mu/include/baseboard/gpio.h A src/mainboard/lattepanda/mu/include/baseboard/variants.h A src/mainboard/lattepanda/mu/mainboard.c A src/mainboard/lattepanda/mu/memory.c A src/mainboard/lattepanda/mu/ramstage.c A src/mainboard/lattepanda/mu/romstage_fsp_params.c A src/mainboard/lattepanda/mu/spd/Makefile.mk A src/mainboard/lattepanda/mu/spd/mu_lp5_16gb.spd.hex A src/mainboard/lattepanda/mu/spd/mu_lp5_8gb.spd.hex 21 files changed, 695 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/83719/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/83719?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I79696bdd837a221860b32f54629212c3346dca66 Gerrit-Change-Number: 83719 Gerrit-PatchSet: 13 Gerrit-Owner: KunYi Chen <kunyi.chen(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: KunYi Chen <kunyi.chen(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: Update fsp submodule to upstream main
by Sean Rhodes (Code Review) 28 Aug '24

28 Aug '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84111?usp=email ) Change subject: Update fsp submodule to upstream main ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84111?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ief40f675556bce662601d7d8db6660f72dc35961 Gerrit-Change-Number: 84111 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 28 Aug 2024 08:28:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024