August 2024 - coreboot-gerrit - mail.coreboot.org

[XS] Change in coreboot[main]: security/vboot: Include new gbb flag to enforce CSE sync
by Yu-Ping Wu (Code Review) Aug. 1, 2024

Aug. 1, 2024

Attention is currently required from: Dinesh Gehlot, Julius Werner. Yu-Ping Wu has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83685?usp=email ) Change subject: security/vboot: Include new gbb flag to enforce CSE sync ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_refere… is merged. Please update the vboot submodule by `util/scripts/update_submodules -R ./3rdparty/vboot -c 1`, upload the patch, and rebase this one onto that. -- To view, visit https://review.coreboot.org/c/coreboot/+/83685?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6352959e1e898a90b4c6e12a22f8d6513f90ded9 Gerrit-Change-Number: 83685 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 01:57:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config
by Weimin Wu (Code Review) Aug. 1, 2024

Aug. 1, 2024

Attention is currently required from: Eric Lai, Karthik Ramasubramanian, zhongtian wu. Weimin Wu has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/83704?usp=email ) Change subject: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config ...................................................................... Patch Set 6: (3 comments) File src/mainboard/google/dedede/variants/awasuki/overridetree.cb: https://review.coreboot.org/c/coreboot/+/83704/comment/afe28fb0_96321b9b?us… : PS5, Line 1: fw_config : field TOUCH 5 : option TOUCH_ABSENT 0 : option TOUCH_PRESENT 1 : end : end > Please move this to variants/baseboard/devicetree.cb along with other fw_config. […] Done File src/mainboard/google/dedede/variants/awasuki/ramstage.c: https://review.coreboot.org/c/coreboot/+/83704/comment/a5f9071d_506f4ee1?us… : PS5, Line 9: /* H4 : AP_I2C_TS_SDA */ : PAD_NC(GPP_H4, NONE), : /* H5 : AP_I2C_TS_SCL */ : PAD_NC(GPP_H5, NONE), > Also you need to configure ENABLE, Reset and Stop/Report GPIOs as NC so that they are not floating o […] Done https://review.coreboot.org/c/coreboot/+/83704/comment/9aeb7032_ba580eae?us… : PS5, Line 24: if (!fw_config_probe(FW_CONFIG(TOUCH, TOUCH_PRESENT))) { : cfg->SerialIoI2cMode[PchSerialIoIndexI2C2] = PchSerialIoDisabled; : } : : if (!fw_config_probe(FW_CONFIG(TOUCH, TOUCH_PRESENT))) { : printk(BIOS_INFO, "Disable TS GPIO pins.\n"); : gpio_configure_pads(ts_disable_pad, ARRAY_SIZE(ts_disable_pad)); : } > Both the if blocks can be combined into one. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83704?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb Gerrit-Change-Number: 83704 Gerrit-PatchSet: 6 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 00:47:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config
by Weimin Wu (Code Review) Aug. 1, 2024

Aug. 1, 2024

Attention is currently required from: Eric Lai, Weimin Wu, zhongtian wu. Hello Eric Lai, Karthik Ramasubramanian, build bot (Jenkins), zhongtian wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83704?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by zhongtian wu, Verified+1 by build bot (Jenkins) Change subject: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config ...................................................................... mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config 1. Change driver form i2c/hid to i2c/generic. 2. Add fw_config for touchscreen. BUG=b:351968527 TEST=ectool cbi set 6 0x0x10200a0; touchscreen functions normally; Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/awasuki/overridetree.cb M src/mainboard/google/dedede/variants/awasuki/ramstage.c M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 3 files changed, 49 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83704/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/83704?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb Gerrit-Change-Number: 83704 Gerrit-PatchSet: 6 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>

1 0

[M] Change in coreboot[main]: mb/google/brox/var/greenbayupoc: update ALC236 verb table
by Karthik Ramasubramanian (Code Review) Aug. 1, 2024

Aug. 1, 2024

Attention is currently required from: Derek Huang, Garen Wu, Subrata Banik. Karthik Ramasubramanian has posted comments on this change by Garen Wu. ( https://review.coreboot.org/c/coreboot/+/83465?usp=email ) Change subject: mb/google/brox/var/greenbayupoc: update ALC236 verb table ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83465?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib9a8248c4a437fd204f40918d801a4a010a5c4df Gerrit-Change-Number: 83465 Gerrit-PatchSet: 1 Gerrit-Owner: Garen Wu <wu.garen(a)inventec.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Terry Cheong <htcheong(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eren Peng <peng.eren(a)inventec.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Garen Wu <wu.garen(a)inventec.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 00:14:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/brox/var/brox: Enable Class-D calibration
by Karthik Ramasubramanian (Code Review) Aug. 1, 2024

Aug. 1, 2024

Attention is currently required from: Paul Menzel, Subrata Banik, Terry Cheong. Karthik Ramasubramanian has posted comments on this change by Terry Cheong. ( https://review.coreboot.org/c/coreboot/+/82794?usp=email ) Change subject: mb/google/brox/var/brox: Enable Class-D calibration ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82794?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I776f5c24ce3c829cbd64840957c1431608cf2b85 Gerrit-Change-Number: 82794 Gerrit-PatchSet: 7 Gerrit-Owner: Terry Cheong <htcheong(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Terry Cheong <htcheong(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 00:08:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0