David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83720?usp=email )
Change subject: mb/google/nissa/var/riven: Disable CNVi WIFI and BT based on fw_config
......................................................................
mb/google/nissa/var/riven: Disable CNVi WIFI and BT based on fw_config
Disable CNVi WIFI and BT based on fw_config.
BUG=b:337169542
TEST=Dut boots fine with both Wifi6e & Wifi7 based cbi settings.
Change-Id: Icb925c02c73d3630be8b78debf608270b08854fe
Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/riven/fw_config.c
M src/mainboard/google/brya/variants/riven/overridetree.cb
2 files changed, 12 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/83720/1
diff --git a/src/mainboard/google/brya/variants/riven/fw_config.c b/src/mainboard/google/brya/variants/riven/fw_config.c
index b22463f..96fc781 100644
--- a/src/mainboard/google/brya/variants/riven/fw_config.c
+++ b/src/mainboard/google/brya/variants/riven/fw_config.c
@@ -65,6 +65,16 @@
PAD_NC(GPP_I18, NONE),
};
+void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config)
+{
+ if (!fw_config_probe(FW_CONFIG(WIFI_TYPE, WIFI_CNVI))) {
+ printk(BIOS_INFO, "CNVi bluetooth disabled by fw_config\n");
+ config->cnvi_bt_core = false;
+ printk(BIOS_INFO, "CNVi bluetooth audio offload disabled by fw_config\n");
+ config->cnvi_bt_audio_offload = false;
+ }
+}
+
void fw_config_gpio_padbased_override(struct pad_config *padbased_table)
{
if (!fw_config_is_provisioned()) {
diff --git a/src/mainboard/google/brya/variants/riven/overridetree.cb b/src/mainboard/google/brya/variants/riven/overridetree.cb
index 301d72a..044d411 100644
--- a/src/mainboard/google/brya/variants/riven/overridetree.cb
+++ b/src/mainboard/google/brya/variants/riven/overridetree.cb
@@ -230,11 +230,10 @@
probe WFC WFC_MIPI_OVTI8856
end
device ref cnvi_wifi on
+ probe WIFI_TYPE WIFI_CNVI
chip drivers/wifi/generic
register "enable_cnvi_ddr_rfim" = "true"
- device generic 0 on
- probe WIFI_TYPE WIFI_CNVI
- end
+ device generic 0 on end
end
end
device ref i2c1 on
--
To view, visit https://review.coreboot.org/c/coreboot/+/83720?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icb925c02c73d3630be8b78debf608270b08854fe
Gerrit-Change-Number: 83720
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Attention is currently required from: KunYi Chen.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83719?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/lattepanda: Add support for LattePanda Mu
......................................................................
mb/lattepanda: Add support for LattePanda Mu
Add initial support for the LattePanda Mu board, which features:
Intel Alder Lake-N N100 processor
8GB LPDDR5 memory
64GB eMMC storage
SO-DIMM 260-pin connector for function expansion
This commit includes:
Basic board configuration
Memory initialization
Essential I/O setup
TODO:
Verify and fine-tune ACPI tables
Test and optimize power management
Implement advanced features specific to this board
Testing with Lite carrier board
Booting into default installed Windows: Passed
Installing Ubuntu 22.04: Failed (system shuts down, unable to auto-reboot)
USB 3.0/2.0: Working
HDMI output: Working
S3 sleep mode: Failed
Power on after shutdown: Failed (requires power removal)
Ethernet port: Not working
UART of SuperIO in OS: Missing
Environment Controller: Not supported
Change-Id: I79696bdd837a221860b32f54629212c3346dca66
Signed-off-by: KunYi Chen <kunyi.chen(a)gmail.com>
---
A configs/config.lattepanda_mu
A src/mainboard/lattepanda/Kconfig
A src/mainboard/lattepanda/Kconfig.name
A src/mainboard/lattepanda/mu/Kconfig
A src/mainboard/lattepanda/mu/Kconfig.name
A src/mainboard/lattepanda/mu/Makefile.mk
A src/mainboard/lattepanda/mu/board_info.txt
A src/mainboard/lattepanda/mu/bootblock.c
A src/mainboard/lattepanda/mu/data.vbt
A src/mainboard/lattepanda/mu/devicetree.cb
A src/mainboard/lattepanda/mu/dsdt.asl
A src/mainboard/lattepanda/mu/gpio.c
A src/mainboard/lattepanda/mu/include/baseboard/gpio.h
A src/mainboard/lattepanda/mu/include/baseboard/variants.h
A src/mainboard/lattepanda/mu/mainboard.c
A src/mainboard/lattepanda/mu/memory.c
A src/mainboard/lattepanda/mu/ramstage.c
A src/mainboard/lattepanda/mu/romstage_fsp_params.c
A src/mainboard/lattepanda/mu/smihandler.c
A src/mainboard/lattepanda/mu/spd/Makefile.mk
A src/mainboard/lattepanda/mu/spd/empty.spd.hex
A src/mainboard/lattepanda/mu/spd/mu_lp5_16gb.spd.hex
A src/mainboard/lattepanda/mu/spd/mu_lp5_8gb.spd.hex
23 files changed, 902 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/83719/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83719?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I79696bdd837a221860b32f54629212c3346dca66
Gerrit-Change-Number: 83719
Gerrit-PatchSet: 2
Gerrit-Owner: KunYi Chen
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: KunYi Chen
Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Matt DeVillier, Matt DeVillier, Paul Menzel, Zheng Bao.
Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/83646?usp=email )
Change subject: mb/google/skyrim: Combine the function port_descriptors for variants
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83646/comment/c46bf726_2d6cd197?us… :
PS1, Line 8:
> Please elaborate.
Done
https://review.coreboot.org/c/coreboot/+/83646/comment/a28ec220_1390c505?us… :
PS1, Line 9: BUG=b:346716300
> I don't understand how this change relates to this bug
Done
File src/mainboard/google/skyrim/variants/baseboard/port_descriptors_combo.c:
PS1:
> Agree that having duplicate code is not a good thing. I am a little hesitant about this change. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83646?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I981e9c52c8e5fa32296e2e43be47411557133691
Gerrit-Change-Number: 83646
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jon Murphy <jpmurphy(a)google.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 07:15:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com>
Attention is currently required from: Bao Zheng, Jason Nien, Martin Roth, Matt DeVillier, Matt DeVillier, Zheng Bao.
Hello Jason Nien, Martin Roth, Matt DeVillier, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83646?usp=email
to look at the new patch set (#5).
Change subject: mb/google/skyrim: Combine the function port_descriptors for variants
......................................................................
mb/google/skyrim: Combine the function port_descriptors for variants
Remove the weak function. Combine all the getting descriptors together.
BUG=b:279144932
TEST=Build
Change-Id: I981e9c52c8e5fa32296e2e43be47411557133691
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/mainboard/google/skyrim/variants/baseboard/include/baseboard/port_descriptors.h
M src/mainboard/google/skyrim/variants/baseboard/port_descriptors.c
M src/mainboard/google/skyrim/variants/markarth/Makefile.mk
D src/mainboard/google/skyrim/variants/markarth/port_descriptors.c
M src/mainboard/google/skyrim/variants/winterhold/Makefile.mk
D src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c
6 files changed, 45 insertions(+), 117 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/83646/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83646?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I981e9c52c8e5fa32296e2e43be47411557133691
Gerrit-Change-Number: 83646
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jon Murphy <jpmurphy(a)google.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Attention is currently required from: Bao Zheng, Jason Nien, Martin Roth, Matt DeVillier, Matt DeVillier, Zheng Bao.
Hello Jason Nien, Martin Roth, Matt DeVillier, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83646?usp=email
to look at the new patch set (#4).
Change subject: mb/google/skyrim: Combine the function port_descriptors for variants
......................................................................
mb/google/skyrim: Combine the function port_descriptors for variants
Remove the weak function. Combine all the getting descriptors together.
BUG=b:279144932
TEST=Build
Change-Id: I981e9c52c8e5fa32296e2e43be47411557133691
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/mainboard/google/skyrim/variants/baseboard/include/baseboard/port_descriptors.h
M src/mainboard/google/skyrim/variants/baseboard/port_descriptors.c
M src/mainboard/google/skyrim/variants/markarth/Makefile.mk
D src/mainboard/google/skyrim/variants/markarth/port_descriptors.c
M src/mainboard/google/skyrim/variants/winterhold/Makefile.mk
D src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c
6 files changed, 44 insertions(+), 119 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/83646/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/83646?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I981e9c52c8e5fa32296e2e43be47411557133691
Gerrit-Change-Number: 83646
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jon Murphy <jpmurphy(a)google.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Attention is currently required from: Bao Zheng, Jason Nien, Martin Roth, Matt DeVillier, Matt DeVillier, Zheng Bao.
Hello Jason Nien, Martin Roth, Matt DeVillier, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83646?usp=email
to look at the new patch set (#3).
Change subject: mb/google/skyrim: Combine the function port_descriptors for variants
......................................................................
mb/google/skyrim: Combine the function port_descriptors for variants
Remove the weak function. Combine all the getting decriptors together.
BUG=b:279144932
TEST=Build
Change-Id: I981e9c52c8e5fa32296e2e43be47411557133691
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/mainboard/google/skyrim/variants/baseboard/include/baseboard/port_descriptors.h
M src/mainboard/google/skyrim/variants/baseboard/port_descriptors.c
M src/mainboard/google/skyrim/variants/markarth/Makefile.mk
D src/mainboard/google/skyrim/variants/markarth/port_descriptors.c
M src/mainboard/google/skyrim/variants/winterhold/Makefile.mk
D src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c
6 files changed, 44 insertions(+), 119 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/83646/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83646?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I981e9c52c8e5fa32296e2e43be47411557133691
Gerrit-Change-Number: 83646
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jon Murphy <jpmurphy(a)google.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
KunYi Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83718?usp=email )
Change subject: update FSP headers of ADL-N to latest version
......................................................................
update FSP headers of ADL-N to latest version
IoT ADL-N version update to MR5(5132_00)
Change-Id: I96fccbb92866fbc18c57187628612fda655cd7a7
Signed-off-by: KunYi Chen <kunyi.chen(a)gmail.com>
---
M src/vendorcode/intel/fsp/fsp2_0/alderlake_n/FspUpd.h
M src/vendorcode/intel/fsp/fsp2_0/alderlake_n/FspmUpd.h
M src/vendorcode/intel/fsp/fsp2_0/alderlake_n/FspsUpd.h
M src/vendorcode/intel/fsp/fsp2_0/alderlake_n/MemInfoHob.h
4 files changed, 2,648 insertions(+), 1,037 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/83718/1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83718?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I96fccbb92866fbc18c57187628612fda655cd7a7
Gerrit-Change-Number: 83718
Gerrit-PatchSet: 1
Gerrit-Owner: KunYi Chen
Attention is currently required from: Bao Zheng, Jason Nien, Martin Roth, Matt DeVillier, Matt DeVillier, Zheng Bao.
Hello Jason Nien, Martin Roth, Matt DeVillier, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83646?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/skyrim: Combine the function port_descriptors for variants
......................................................................
mb/google/skyrim: Combine the function port_descriptors for variants
Remove the weak function. Combine all the getting decriptors together.
BUG=b:346716300
TEST=Build
Change-Id: I981e9c52c8e5fa32296e2e43be47411557133691
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/mainboard/google/skyrim/variants/baseboard/include/baseboard/port_descriptors.h
M src/mainboard/google/skyrim/variants/baseboard/port_descriptors.c
M src/mainboard/google/skyrim/variants/markarth/Makefile.mk
D src/mainboard/google/skyrim/variants/markarth/port_descriptors.c
M src/mainboard/google/skyrim/variants/winterhold/Makefile.mk
D src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c
6 files changed, 44 insertions(+), 119 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/83646/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83646?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I981e9c52c8e5fa32296e2e43be47411557133691
Gerrit-Change-Number: 83646
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jon Murphy <jpmurphy(a)google.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Attention is currently required from: Deepti Deshatty, Li Feng, Li1 Feng, Subrata Banik, V Sowmya.
Varun Upadhyay has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/83656?usp=email )
Change subject: mb/google/trulo/var/orisa: Update ISH GPIO's configuration
......................................................................
Patch Set 3:
(2 comments)
This change is ready for review.
Patchset:
PS2:
> your patch needs rebasing as the underlying coreboot code had changed since you forked it.
Done
File src/mainboard/google/brya/variants/orisa/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83656/comment/68d25aff_fcd32671?us… :
PS2, Line 527: orisa_ish
> can we have generic name w/o associating any platform ? if you wish to attach a platform name, then […]
i have removed the firmware name config for the Orisa. Just keeping the GPIO's changes in this patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/83656?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I24745ba629c59c092ce676b29915e356a4d8d8af
Gerrit-Change-Number: 83656
Gerrit-PatchSet: 3
Gerrit-Owner: Varun Upadhyay <varun.upadhyay(a)intel.com>
Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Li Feng <li1.feng(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Li1 Feng <li1.feng(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Tanu Malhotra <tanu.malhotra(a)intel.com>
Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Attention: Li Feng <li1.feng(a)intel.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Li1 Feng <li1.feng(a)intel.com>
Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 06:30:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>