coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[S] Change in coreboot[main]: mb/google/brya/var/orisa: Remove mux references from typec port
by Amanda Hwang (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Caveh Jalali, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik. Amanda Hwang has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83722?usp=email ) Change subject: mb/google/brya/var/orisa: Remove mux references from typec port ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/orisa/overridetree.cb: https://review.coreboot.org/c/coreboot/+/83722/comment/752a4059_9f432fc3?us… : PS1, Line 525: device ref pmc hidden : end > nit […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83722?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a24fb69ebec87f65b679cde0e4a1a8827cd365d Gerrit-Change-Number: 83722 Gerrit-PatchSet: 2 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 09:36:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/riven: Disable CNVi WIFI and BT based on fw_config
by Subrata Banik (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Rishika Raj. Subrata Banik has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/83720?usp=email ) Change subject: mb/google/nissa/var/riven: Disable CNVi WIFI and BT based on fw_config ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/variants/riven/fw_config.c: https://review.coreboot.org/c/coreboot/+/83720/comment/05c6e7d6_cce1b173?us… : PS1, Line 70: if (!fw_config_probe(FW_CONFIG(WIFI_TYPE, WIFI_CNVI))) { should we check ``` if (!fw_config_is_provisioned()) { printk(BIOS_WARNING, "FW_CONFIG is not provisioned. Exiting...\n"); return; } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/83720?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb925c02c73d3630be8b78debf608270b08854fe Gerrit-Change-Number: 83720 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 09:10:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/brya/var/orisa: Remove mux references from typec port
by Subrata Banik (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Amanda Hwang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Rishika Raj. Subrata Banik has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83722?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/brya/var/orisa: Remove mux references from typec port ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/variants/orisa/overridetree.cb: https://review.coreboot.org/c/coreboot/+/83722/comment/42d20eae_c89be704?us… : PS1, Line 525: device ref pmc hidden : end nit ``` device ref pmc hidden end ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/83722?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a24fb69ebec87f65b679cde0e4a1a8827cd365d Gerrit-Change-Number: 83722 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 09:07:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: Kconfig: Reverse ARCH_SUPPORTS_CLANG
by Arthur Heymans (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Julius Werner, Jérémy Compostella, Philipp Hug, Ron Minnich. Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/81659?usp=email ) Change subject: Kconfig: Reverse ARCH_SUPPORTS_CLANG ...................................................................... Patch Set 2: (1 comment) File src/Kconfig: https://review.coreboot.org/c/coreboot/+/81659/comment/3e3bd5b6_ecb5848b?us… : PS1, Line 91: Opt-in flag for architectures that generally work well with CLANG. > Needs rewrite Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81659?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib28e7a4cb286b9f8b05be94dae3947179f43c746 Gerrit-Change-Number: 81659 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 08:30:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[XS] Change in coreboot[main]: soc/ti/am335x: Use Linker instead of compiler to link
by Arthur Heymans (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Martin L Roth. Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/70161?usp=email ) Change subject: soc/ti/am335x: Use Linker instead of compiler to link ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/70161/comment/46454783_edfb1e47?us… : PS3, Line 7: with clang > Not a huge deal, but this doesn't actually fix it "with clang" it forces GCC always. Maybe `Fix clang build of omap header - Force GCC` or something. I changed it to use the linker instead of the compiler as a linker frontend. That fixes it. -- To view, visit https://review.coreboot.org/c/coreboot/+/70161?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id6ba42b470349a4b138a65b2a037f16a65982ef7 Gerrit-Change-Number: 70161 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 08:30:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>

1 0

[S] Change in coreboot[main]: soc/ti/am335x: Change and optimize memlayout
by Arthur Heymans (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Martin L Roth, Paul Menzel. Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/70160?usp=email ) Change subject: soc/ti/am335x: Change and optimize memlayout ...................................................................... Patch Set 6: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/70160/comment/cbdc02b7_99d38336?us… : PS1, Line 9: larget > larger Done https://review.coreboot.org/c/coreboot/+/70160/comment/17e84a57_7d72d823?us… : PS1, Line 9: are slightly larget > It be great, if you added the actual numbers. Done https://review.coreboot.org/c/coreboot/+/70160/comment/d0aab3af_50c1d5cb?us… : PS1, Line 10: bootblock and romstage > Please mention the new sizes: … by 2 KB to 22 KB. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/70160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8719bc3728d4cc8dba8d939cc154c3fc0884d47b Gerrit-Change-Number: 70160 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 08:29:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: arch/arm: Add a few ARM targets as supported by CLANG
by Arthur Heymans (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Julius Werner, Paul Menzel. Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/69747?usp=email ) Change subject: arch/arm: Add a few ARM targets as supported by CLANG ...................................................................... Patch Set 22: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/69747/comment/e4446056_27f73531?us… : PS20, Line 7: arch/arm: Build test all arm targets with clang > This says "build test" but it looks like this CL is more about adding the ARCH_SUPPORTS_CLANG Kconfi […] Done File src/soc/nvidia/tegra124/Makefile.mk: https://review.coreboot.org/c/coreboot/+/69747/comment/f0d8237d_b4c21ae4?us… : PS22, Line 25: endif > I feel like it would be better to set CLANG_UNSUPPORTED than to do this tbh. […] Done File src/soc/qualcomm/ipq806x/Kconfig: https://review.coreboot.org/c/coreboot/+/69747/comment/74afde11_4e7e6b60?us… : PS20, Line 16: SOC_NVIDIA_TEGRA124 > Wrong SoC Done https://review.coreboot.org/c/coreboot/+/69747/comment/b8cc2429_76f2a4fd?us… : PS20, Line 16: SOC_NVIDIA_TEGRA124 > Wrong SoC Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8 Gerrit-Change-Number: 69747 Gerrit-PatchSet: 22 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 08:29:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[XS] Change in coreboot[main]: arch/arm: Add a few ARM targets as supported by CLANG
by Arthur Heymans (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Arthur Heymans, Paul Menzel. Hello Julius Werner, Martin L Roth, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69747?usp=email to look at the new patch set (#24). Change subject: arch/arm: Add a few ARM targets as supported by CLANG ...................................................................... arch/arm: Add a few ARM targets as supported by CLANG Some targets cannot be supported by clang as clang generates slightly larger binaries which the hardware won't accept. Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/arm/Kconfig M src/soc/qualcomm/ipq40xx/Kconfig M src/soc/qualcomm/ipq806x/Kconfig M src/soc/rockchip/rk3288/Kconfig 4 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/69747/24 -- To view, visit https://review.coreboot.org/c/coreboot/+/69747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8 Gerrit-Change-Number: 69747 Gerrit-PatchSet: 24 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[XS] Change in coreboot[main]: soc/ti/am335x: Remove superfluous formats
by Arthur Heymans (Code Review) 01 Aug '24

01 Aug '24

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83723?usp=email ) Change subject: soc/ti/am335x: Remove superfluous formats ...................................................................... soc/ti/am335x: Remove superfluous formats These formats are already included in memlayout.ld. Change-Id: I89d226440308ce3fbe00382698dcd8c88863e694 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/ti/am335x/header.ld 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/83723/1 diff --git a/src/soc/ti/am335x/header.ld b/src/soc/ti/am335x/header.ld index 84e0136..0018e81 100644 --- a/src/soc/ti/am335x/header.ld +++ b/src/soc/ti/am335x/header.ld @@ -1,8 +1,4 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* We use ELF as output format. So that we can debug the code in some form. */ -OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm") -OUTPUT_ARCH(arm) - #define OMAP_HEADER 1 #include "memlayout.ld" -- To view, visit https://review.coreboot.org/c/coreboot/+/83723?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I89d226440308ce3fbe00382698dcd8c88863e694 Gerrit-Change-Number: 83723 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[XS] Change in coreboot[main]: soc/ti/am335x: Use Linker instead of compiler to link
by Arthur Heymans (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Arthur Heymans, Martin L Roth. Hello Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70161?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/ti/am335x: Use Linker instead of compiler to link ...................................................................... soc/ti/am335x: Use Linker instead of compiler to link Clang does not work that well as a linker for the header as it will default to other linkers which do not work well here. Instead just use the linker directly. Change-Id: Id6ba42b470349a4b138a65b2a037f16a65982ef7 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/ti/am335x/Makefile.mk 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/70161/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/70161?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id6ba42b470349a4b138a65b2a037f16a65982ef7 Gerrit-Change-Number: 70161 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024