coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[S] Change in coreboot[main]: Kconfig: Reverse ARCH_SUPPORTS_CLANG
by Nico Huber (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Philipp Hug, Ron Minnich. Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/81659?usp=email ) Change subject: Kconfig: Reverse ARCH_SUPPORTS_CLANG ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81659?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib28e7a4cb286b9f8b05be94dae3947179f43c746 Gerrit-Change-Number: 81659 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 09:55:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: util/nvmtool: set Intel Gbe MAC addresses/checksum
by Michał Kopeć (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Leah Rowe. Michał Kopeć has posted comments on this change by Leah Rowe. ( https://review.coreboot.org/c/coreboot/+/67129?usp=email ) Change subject: util/nvmtool: set Intel Gbe MAC addresses/checksum ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File Documentation/util/nvmtool/index.md: https://review.coreboot.org/c/coreboot/+/67129/comment/af102c21_fbfaa427?us… : PS5, Line 75: This software *may* work with IFDv2 systems, if the GbE NVM data structure I've successfully tested this on a Meteor Lake platform (Clevo V540TU), seems to work well without issues. One thing of note, is that a clean, unpopulated GbE blob there only has part 0 populated, part 1 is all 0xFFs, so I needed to run `nvm copy 0` before setting the MAC. Not sure if that's also the case for other platforms. -- To view, visit https://review.coreboot.org/c/coreboot/+/67129?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb86cf100833f3407e0d0b45daee704cf0633546 Gerrit-Change-Number: 67129 Gerrit-PatchSet: 5 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 09:54:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/ti/am335x: Remove superfluous formats
by Nico Huber (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Arthur Heymans. Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83723?usp=email ) Change subject: soc/ti/am335x: Remove superfluous formats ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83723?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I89d226440308ce3fbe00382698dcd8c88863e694 Gerrit-Change-Number: 83723 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 01 Aug 2024 09:52:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/ti/am335x: Use Linker instead of compiler to link
by Nico Huber (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Arthur Heymans, Martin L Roth. Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/70161?usp=email ) Change subject: soc/ti/am335x: Use Linker instead of compiler to link ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70161?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id6ba42b470349a4b138a65b2a037f16a65982ef7 Gerrit-Change-Number: 70161 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 01 Aug 2024 09:50:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Add Fn key scancode
by Weimin Wu (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Weimin Wu. Hello zhongtian wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83724?usp=email to look at the new patch set (#3). Change subject: mb/google/dedede/var/awasuki: Add Fn key scancode ...................................................................... mb/google/dedede/var/awasuki: Add Fn key scancode The Fn key on awasuki emits a scancode of 94 (0x5e). BUG=b:355538142 TEST=Flash awasuki, boot to Linux kernel, and verify that KEY_FN is generated when pressed using `evtest`. Change-Id: Ic7aa183bf314fed4901133dc70d848d84fab0784 Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/83724/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/83724?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic7aa183bf314fed4901133dc70d848d84fab0784 Gerrit-Change-Number: 83724 Gerrit-PatchSet: 3 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Add Fn key scancode
by zhongtian wu (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Weimin Wu. zhongtian wu has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/83724?usp=email ) Change subject: mb/google/dedede/var/awasuki: Add Fn key scancode ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83724?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic7aa183bf314fed4901133dc70d848d84fab0784 Gerrit-Change-Number: 83724 Gerrit-PatchSet: 2 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 09:48:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/ti/am335x: Change and optimize memlayout
by Nico Huber (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Arthur Heymans, Martin L Roth, Paul Menzel. Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/70160?usp=email ) Change subject: soc/ti/am335x: Change and optimize memlayout ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8719bc3728d4cc8dba8d939cc154c3fc0884d47b Gerrit-Change-Number: 70160 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 01 Aug 2024 09:48:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Add Fn key scancode
by Weimin Wu (Code Review) 01 Aug '24

01 Aug '24

Weimin Wu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/83724?usp=email ) Change subject: mb/google/dedede/var/awasuki: Add Fn key scancode ...................................................................... mb/google/dedede/var/awasuki: Add Fn key scancode The Fn key on awasuki emits a scancode of 94 (0x5e). BUG=b:351968527 TEST=Flash awasuki, boot to Linux kernel, and verify that KEY_FN is generated when pressed using `evtest`. Change-Id: Ic7aa183bf314fed4901133dc70d848d84fab0784 Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/83724/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83724?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic7aa183bf314fed4901133dc70d848d84fab0784 Gerrit-Change-Number: 83724 Gerrit-PatchSet: 2 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/dedede/awasuki: Add Fn key scancode
by Weimin Wu (Code Review) 01 Aug '24

01 Aug '24

Weimin Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83724?usp=email ) Change subject: mb/google/dedede/awasuki: Add Fn key scancode ...................................................................... mb/google/dedede/awasuki: Add Fn key scancode The Fn key on awasuki emits a scancode of 94 (0x5e). BUG=b:351968527 TEST=Flash awasuki, boot to Linux kernel, and verify that KEY_FN is generated when pressed using `evtest`. Change-Id: Ic7aa183bf314fed4901133dc70d848d84fab0784 Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/83724/1 diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index bdd2f4c..e17b68e 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -1,5 +1,8 @@ ## SPDX-License-Identifier: GPL-2.0-only +config ACPI_FNKEY_GEN_SCANCODE + default 94 if BOARD_GOOGLE_AWASUKI + config BOARD_GOOGLE_BASEBOARD_DEDEDE def_bool n select BOARD_ROMSIZE_KB_16384 if !BOARD_ROMSIZE_KB_32768 -- To view, visit https://review.coreboot.org/c/coreboot/+/83724?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic7aa183bf314fed4901133dc70d848d84fab0784 Gerrit-Change-Number: 83724 Gerrit-PatchSet: 1 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/brya/var/orisa: Remove mux references from typec port
by Subrata Banik (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Amanda Hwang, Caveh Jalali, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Rishika Raj. Subrata Banik has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83722?usp=email ) Change subject: mb/google/brya/var/orisa: Remove mux references from typec port ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83722?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a24fb69ebec87f65b679cde0e4a1a8827cd365d Gerrit-Change-Number: 83722 Gerrit-PatchSet: 2 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 09:38:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024