Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Martin L Roth, Wonkyu Kim.
Hello Anil Kumar K, Bora Guvendik, Martin L Roth, Subrata Banik, Wonkyu Kim, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84107?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: payloads/depthcharge: Add default 64-bit libpayload config
......................................................................
payloads/depthcharge: Add default 64-bit libpayload config
Add CONFIG_LP_DEFCONFIG_OVERRIDE_X64 flag to select default 64-bit
config file in payloads/libpayload/configs directory.
This is used in standalone environment. The existing libpayload
deconfig file is for boards with 32-bit format and deconfig_64
file is added for 64-bit without adding specific
board.[board name] file in libpayload.
BUG=none
TEST=Build with this new flag and check that the libpayload and
depthcharge.elf are built in 64-bit format.
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: Iac07cf9e3c11e49955c69553407be76ef4f8c060
---
M payloads/external/Makefile.mk
M payloads/external/depthcharge/Kconfig
M payloads/external/depthcharge/Makefile
A payloads/libpayload/configs/defconfig_64
4 files changed, 28 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/84107/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/84107?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac07cf9e3c11e49955c69553407be76ef4f8c060
Gerrit-Change-Number: 84107
Gerrit-PatchSet: 5
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Attention is currently required from: Arthur Heymans, Benjamin Doron, Felix Held, Jakub Czapiga, Martin L Roth, Patrick Rudolph, Paul Menzel, Werner Zeh.
Matt DeVillier has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/79160?usp=email )
Change subject: Documentation: Improve x86_64
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS2:
> Two patches would be nice. […]
I agree, Benjamin do you mind splitting this up?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79160?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia5ba51be629a8c878aad64d3297176457cf8e855
Gerrit-Change-Number: 79160
Gerrit-PatchSet: 7
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 28 Aug 2024 17:28:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Karthik Ramasubramanian, Kenneth Chan, Nick Vaccaro, Ren Kuo.
Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84112?usp=email )
Change subject: mb/google/brox/jubilant: Update GPE0 routing
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Looks reasonable to me. Deferring to coreboot eng team on this one.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84112?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia1ad27786e0e3bd9c2110c8a28ab962c5567e16d
Gerrit-Change-Number: 84112
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 28 Aug 2024 17:24:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Karthik Ramasubramanian, Kenneth Chan, Nick Vaccaro, Peter Ou, Ren Kuo.
Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84106?usp=email )
Change subject: mb/google/brox/jubilant: update dptf settings
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Deferrring to the corebooe eng team on this one.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84106?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0043c728f1302e86c84849653f443dc560a51654
Gerrit-Change-Number: 84106
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 28 Aug 2024 17:23:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Arthur Heymans, Martin L Roth, Maximilian Brune.
Matt DeVillier has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/77287?usp=email )
Change subject: payloads: Remove Linux option
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
is this patch still needed/wanted? Needs a manual rebase
--
To view, visit https://review.coreboot.org/c/coreboot/+/77287?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I47588cfd2747c224d00d88a7ad95752eb5eb269b
Gerrit-Change-Number: 77287
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 28 Aug 2024 17:23:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Karthik Ramasubramanian, Kenneth Chan, Nick Vaccaro, Peter Ou, Ren Kuo.
Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84106?usp=email )
Change subject: mb/google/brox/jubilant: update dptf settings
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> There are some build failures. Can you please check? […]
I see this in the EC code base.
5816089: jubilant: config ec fan control | https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/5816089
--
To view, visit https://review.coreboot.org/c/coreboot/+/84106?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0043c728f1302e86c84849653f443dc560a51654
Gerrit-Change-Number: 84106
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 28 Aug 2024 17:22:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83442?usp=email )
Change subject: util/scripts: Add script to capture commands from build
......................................................................
util/scripts: Add script to capture commands from build
This allows better debugging of the build by writing all the commands
run by the build into a file by replacing the standard shell.
Run with:
make SHELL="${PWD}/util/scripts/capture_commands.sh"
This will allow us to verify that the commands being run are posix
compliant.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I67efc5096747c2e746642639f88273132e070e49
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83442
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
A util/scripts/capture_commands.sh
M util/scripts/description.md
2 files changed, 19 insertions(+), 0 deletions(-)
Approvals:
Matt DeVillier: Looks good to me, approved
build bot (Jenkins): Verified
Felix Singer: Looks good to me, but someone else must approve
diff --git a/util/scripts/capture_commands.sh b/util/scripts/capture_commands.sh
new file mode 100755
index 0000000..9e2e08f
--- /dev/null
+++ b/util/scripts/capture_commands.sh
@@ -0,0 +1,17 @@
+#!/usr/bin/env sh
+## SPDX-License-Identifier: BSD-3-Clause
+
+# This script allows us to capture all the commands run in the shell by the
+# coreboot build. This is better than using 'make v=1' because it captures
+# commands right from the beginning of the build, and sends the output of any
+# command to the interactive shell.
+
+# To use, run:
+# make SHELL="${PWD}/util/scripts/capture_commands.sh"
+
+REALSHELL=${REALSHELL:-sh}
+OUTPUT_DIR=${TOP:-/tmp}
+CAPTURE_FILE=${CAPTURE_FILE:-commands.txt}
+
+env echo "$*" | sed 's/^-c '// >> "${OUTPUT_DIR}/${CAPTURE_FILE}"
+"${REALSHELL}" "$@"
diff --git a/util/scripts/description.md b/util/scripts/description.md
index 1c67f07..91a108c 100644
--- a/util/scripts/description.md
+++ b/util/scripts/description.md
@@ -1,4 +1,6 @@
__scripts__
+ * capture_commands.sh - Write all commands from the build to a file.
+ `Shell`
* _config_ - Manipulate options in a .config file from the command
line `Bash`
* _cross-repo-cherrypick_ - Pull in patches from another tree from a
--
To view, visit https://review.coreboot.org/c/coreboot/+/83442?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67efc5096747c2e746642639f88273132e070e49
Gerrit-Change-Number: 83442
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Martin L Roth.
Matt DeVillier has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83442?usp=email )
Change subject: util/scripts: Add script to capture commands from build
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83442?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67efc5096747c2e746642639f88273132e070e49
Gerrit-Change-Number: 83442
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Wed, 28 Aug 2024 17:14:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Martin L Roth, Wonkyu Kim.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84107?usp=email )
Change subject: payloads/depthcharge: Add default 64-bit libpayload config
......................................................................
Patch Set 4:
(2 comments)
File payloads/external/depthcharge/Kconfig:
https://review.coreboot.org/c/coreboot/+/84107/comment/b0073568_8538038a?us… :
PS4, Line 68: default n if LP_DEFCONFIG_OVERRIDE
I don't believe you need this line. default is `n` unless selected
https://review.coreboot.org/c/coreboot/+/84107/comment/8cc492d8_5370ff0a?us… :
PS4, Line 70: The Depthcharge makefile looks for a file config.<boardname> in the
: libpayload/configs directory. Say Y here to use the file defconfig
: instead. This is can be a convenience for development purposes, or
: if the defaults in defconfig are sufficient for your system.
this should somehow convey that one needs to select this config to boot a 64-bit payload
--
To view, visit https://review.coreboot.org/c/coreboot/+/84107?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac07cf9e3c11e49955c69553407be76ef4f8c060
Gerrit-Change-Number: 84107
Gerrit-PatchSet: 4
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Comment-Date: Wed, 28 Aug 2024 17:06:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Riku Viitanen.
Elyes Haouas has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79583?usp=email )
Change subject: mb/hp/snb_ivb_desktops: Add 8200 USDT variant
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_usdt/early_init.c:
https://review.coreboot.org/c/coreboot/+/79583/comment/a7bc2808_5fe81ae0?us… :
PS5, Line 6: #include <southbridge/intel/bd82x6x/pch.h>
if I'm not wrong, southbridge/Intel/... is not used
--
To view, visit https://review.coreboot.org/c/coreboot/+/79583?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1cba7a5e664758eba7ea2ab8a55658b307d1d173
Gerrit-Change-Number: 79583
Gerrit-PatchSet: 5
Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Keith Hui <buurin(a)gmail.com>
Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Comment-Date: Wed, 28 Aug 2024 17:01:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No