Attention is currently required from: Alexander Couzens, Angel Pons, Martin L Roth, Nicholas Chin.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/79025?usp=email )
Change subject: nb/intel/haswell: Move SPD addresses to devicetree
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
Just found out I need to apply this to Broadwell MRC as well, which is done with the newest patchset. It probably needs some fresh eyeballs.
Commit Message:
https://review.coreboot.org/c/coreboot/+/79025/comment/6113ae16_0df83de5?us… :
PS3, Line 9: Introduce a sandybridge-style devicetree setting for SPD addresses, and
> > `Possible unwrapped commit description (prefer a maximum 72 chars per line)` […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79025?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I574aec9cb6a47c8aaf275ae06c7e1fb695534b34
Gerrit-Change-Number: 79025
Gerrit-PatchSet: 4
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 15 Aug 2024 00:41:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: coreboot org <coreboot.org(a)gmail.com>
Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83908?usp=email )
Change subject: soc/intel/xeon_sp/uncore_acpi: use is_dev_on_domain0 where possible
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83908?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8b0c52a9176288039e6414a09c3fe0662db79e4b
Gerrit-Change-Number: 83908
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 00:38:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Alexander Couzens, Angel Pons, Keith Hui, Martin L Roth.
Hello Alexander Couzens, Angel Pons, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79025?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: nb/intel/haswell: Move SPD addresses to devicetree
......................................................................
nb/intel/haswell: Move SPD addresses to devicetree
Introduce a sandybridge-style devicetree setting for SPD addresses,
and use it instead of runtime code in mb_get_spd_map() for all
haswell boards without CONFIG(HAVE_SPD_IN_CBFS) - effectively all
boards except google/slippy.
Patch also covers recently added Z97 boards using Broadwell MRC.
TEST=abuild passes for all haswell boards.
Change-Id: I574aec9cb6a47c8aaf275ae06c7e1fb695534b34
Signed-off-by: Keith Hui <buurin(a)gmail.com>
---
M src/mainboard/asrock/b85m_pro4/devicetree.cb
M src/mainboard/asrock/b85m_pro4/romstage.c
M src/mainboard/asrock/fatal1ty_z87_professional/devicetree.cb
M src/mainboard/asrock/fatal1ty_z87_professional/romstage.c
M src/mainboard/asrock/h81m-hds/devicetree.cb
M src/mainboard/asrock/h81m-hds/romstage.c
M src/mainboard/asrock/z87e-itx/devicetree.cb
M src/mainboard/asrock/z87e-itx/romstage.c
M src/mainboard/asrock/z87m_oc_formula/devicetree.cb
M src/mainboard/asrock/z87m_oc_formula/romstage.c
M src/mainboard/asrock/z97_extreme6/devicetree.cb
M src/mainboard/asrock/z97_extreme6/romstage.c
M src/mainboard/asrock/z97e-itx_ac/devicetree.cb
M src/mainboard/asrock/z97e-itx_ac/romstage.c
M src/mainboard/dell/e7240/devicetree.cb
M src/mainboard/dell/e7240/romstage.c
M src/mainboard/dell/optiplex_9020/devicetree.cb
M src/mainboard/dell/optiplex_9020/romstage.c
M src/mainboard/google/beltino/devicetree.cb
M src/mainboard/google/beltino/romstage.c
M src/mainboard/hp/folio_9480m/devicetree.cb
M src/mainboard/hp/folio_9480m/romstage.c
M src/mainboard/intel/baskingridge/devicetree.cb
M src/mainboard/intel/baskingridge/romstage.c
M src/mainboard/lenovo/haswell/romstage.c
M src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
M src/mainboard/lenovo/haswell/variants/t440p/romstage.c
M src/mainboard/lenovo/haswell/variants/w541/devicetree.cb
M src/mainboard/lenovo/haswell/variants/w541/romstage.c
M src/mainboard/msi/h81m-p33/devicetree.cb
M src/mainboard/msi/h81m-p33/romstage.c
M src/mainboard/supermicro/x10slm-f/devicetree.cb
M src/mainboard/supermicro/x10slm-f/romstage.c
M src/northbridge/intel/haswell/broadwell_mrc/raminit.c
M src/northbridge/intel/haswell/chip.h
M src/northbridge/intel/haswell/haswell_mrc/raminit.c
M src/northbridge/intel/haswell/native_raminit/spd_bitmunching.c
37 files changed, 41 insertions(+), 135 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/79025/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/79025?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I574aec9cb6a47c8aaf275ae06c7e1fb695534b34
Gerrit-Change-Number: 79025
Gerrit-PatchSet: 4
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Attention is currently required from: Alper Nebi Yasak, Nico Huber.
Julius Werner has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/80364?usp=email )
Change subject: mainboard/qemu-aarch64: Get top of memory from device-tree blob
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80364?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4cc888b57cf98e0797ce7f9ddfa2eb34d14cd9c1
Gerrit-Change-Number: 80364
Gerrit-PatchSet: 6
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 23:24:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83466?usp=email )
Change subject: [IT'S A PAIN - plan to deprecate ?] chromeec submodule
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/83466?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I534208aa0c628efe69b1ba14889d76511fd3bc3d
Gerrit-Change-Number: 83466
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/81611?usp=email )
Change subject: Documentation: Add Erying Polestar G613 Pro
......................................................................
Patch Set 5:
(2 comments)
File Documentation/mainboard/erying/tgl_matx.md:
https://review.coreboot.org/c/coreboot/+/81611/comment/412e3f06_e640403b?us… :
PS4, Line 112: - Intel Management Engine blob is required, as it manages: PMC (Power Management Controller), SA (System Agent), USB Controller and many more.
: System Agent manages critical components, such as memory controller or PCI-E lane bifurfication. Therefore, system will simply not POST without this blob present in the build.
> Can you reflow these to 72 characters?
Hopefully that's better 😊
File Documentation/mainboard/erying/tgl_matx_board.jpg:
PS4:
> This image is too large our documentation won't handle it well. […]
I'm an author of this picture, wouldn't have included it otherwise (as I'm aware about potential copyright issue).
Resized to ~700px with GIMP as requested
--
To view, visit https://review.coreboot.org/c/coreboot/+/81611?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d60508dbde10373b0da2fb4ece0992760d3121c
Gerrit-Change-Number: 81611
Gerrit-PatchSet: 5
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 21:01:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: coreboot org <coreboot.org(a)gmail.com>
Attention is currently required from: Alicja Michalska.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81611?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: Documentation: Add Erying Polestar G613 Pro
......................................................................
Documentation: Add Erying Polestar G613 Pro
Documentation entry has to be submitted with board tree that's currently
being reviewed upstream.
Change-Id: I5d60508dbde10373b0da2fb4ece0992760d3121c
Signed-off-by: Alicja Michalska <ahplka19(a)gmail.com>
---
A Documentation/mainboard/erying/tgl_matx.md
A Documentation/mainboard/erying/tgl_matx_board.jpg
M Documentation/mainboard/index.md
3 files changed, 151 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/81611/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/81611?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d60508dbde10373b0da2fb4ece0992760d3121c
Gerrit-Change-Number: 81611
Gerrit-PatchSet: 5
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>