Attention is currently required from: Julius Werner, Nick Vaccaro, Vladimir Serbinenko.
Felix Held has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/81505?usp=email )
Change subject: Support loading legacy stage
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Sorry, but I don't think it's worth adding this extra complexity to coreboot, because your underlyin […]
the main problem wth vboot that i see is that it's both very tightly integrated in to coreboot (coreboot doesn't even build without it) but also has a very unstable abi which breaks compatibility every few years. solving this problem properly for the future would require vboot to not break the abi any more
--
To view, visit https://review.coreboot.org/c/coreboot/+/81505?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ae29a6227235c86f9f846986c18b361c3b3c78d
Gerrit-Change-Number: 81505
Gerrit-PatchSet: 2
Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 18:07:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Krystian Hebel, Patrick Rudolph.
Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83421?usp=email )
Change subject: drivers/efi: add optional ESRT-friendly coreboot table tag
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83421/comment/1030d605_72c396c5?us… :
PS4, Line 7: ESRT
> Could you define this somewhere in the commit message? It's not familiar to everyone. […]
Updated commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83421?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic1b768d7bed43edf7ca8e41552087734054de033
Gerrit-Change-Number: 83421
Gerrit-PatchSet: 5
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 18:02:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: coreboot org <coreboot.org(a)gmail.com>
Attention is currently required from: Krystian Hebel, Patrick Rudolph, Sergii Dmytruk.
Hello Christian Walter, Krystian Hebel, Patrick Rudolph, build bot (Jenkins), coreboot org,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83421?usp=email
to look at the new patch set (#5).
Change subject: drivers/efi: add optional ESRT-friendly coreboot table tag
......................................................................
drivers/efi: add optional ESRT-friendly coreboot table tag
EFI System Resource Table (ESRT) is an informational structure that
reports basic details about current system or device firmware. This is
chiefly used to perform firmware updates.
New CONFIG_DRIVERS_EFI_FW_INFO is off by default, enabling it adds
DRIVERS_EFI_FW_{GUID,VERSION,LSV} to be used to specify firmware
version/update information.
Existing forms of versions wouldn't be sufficient because there is no
universal way of converting string versions to 32-bit unsigned integers
and there are no GUIDs or lowest supported versions.
Change-Id: Ic1b768d7bed43edf7ca8e41552087734054de033
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M src/commonlib/include/commonlib/coreboot_tables.h
M src/drivers/efi/Kconfig
M src/drivers/efi/Makefile.mk
A src/drivers/efi/info.c
M src/include/boot/coreboot_tables.h
M src/lib/coreboot_table.c
6 files changed, 89 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/83421/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83421?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic1b768d7bed43edf7ca8e41552087734054de033
Gerrit-Change-Number: 83421
Gerrit-PatchSet: 5
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Attention is currently required from: Felix Held, Joel Linn, Nicholas Sudsgaard, Paul Menzel, Vladimir Serbinenko.
Matt DeVillier has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/82737?usp=email )
Change subject: superio/ite/it8728f: Support setting power state after power failure
......................................................................
Patch Set 4:
(1 comment)
File src/superio/ite/it8728f/superio.c:
https://review.coreboot.org/c/coreboot/+/82737/comment/a1140a8c_629f1004?us… :
PS3, Line 54: %
> nit: `%u`
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/82737?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3dcc4f032bc5f629fb916c4122beb8dc096bab20
Gerrit-Change-Number: 82737
Gerrit-PatchSet: 4
Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 17:53:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Attention is currently required from: Alper Nebi Yasak, Arthur Heymans, Felix Held, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/80378?usp=email )
Change subject: mainboard/qemu-riscv: Add PCI support
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/emulation/qemu-riscv/mainboard.c:
https://review.coreboot.org/c/coreboot/+/80378/comment/3cfd7ddc_e8eb7235?us… :
PS2, Line 42: res->base = ALIGN_UP((uintptr_t)_dram + (uintptr_t)cbmem_top(),
> `cbmem_top()` via probing RAM is limited to detecting up to 16 GiB after CB:36486 even if there's mo […]
probing is not an issue anymore.
But you should probably rebase once more.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80378?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie57b35620af82c681d1f0d78fa8e514e4df0d2ac
Gerrit-Change-Number: 80378
Gerrit-PatchSet: 2
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 14 Aug 2024 17:51:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Attention is currently required from: Alper Nebi Yasak, Julius Werner, Nico Huber.
Maximilian Brune has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/80364?usp=email )
Change subject: mainboard/qemu-aarch64: Get top of memory from device-tree blob
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80364?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4cc888b57cf98e0797ce7f9ddfa2eb34d14cd9c1
Gerrit-Change-Number: 80364
Gerrit-PatchSet: 6
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 17:50:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Fabian Groffen, Keith Hui, Keith Hui, Martin L Roth.
Felix Held has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/75145?usp=email )
Change subject: mb/asus/p8z77-m: Drop GPIO by I/O
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> Keith, Sorry, I'm confused by the last comment. […]
i'd expect that this isn't needed after the underlying bug got fixed
--
To view, visit https://review.coreboot.org/c/coreboot/+/75145?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I22654f3c77082bf163ab7000ec467ab7085a0534
Gerrit-Change-Number: 75145
Gerrit-PatchSet: 4
Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org>
Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org>
Gerrit-Comment-Date: Wed, 14 Aug 2024 17:48:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Martin L Roth has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80130?usp=email )
Change subject: Makefile: Finish switch to Makefile.mak from .inc
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'll try to finish this before the next release.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80130?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0dbc7ed204047b5575b303f57f6cf607f688ad9
Gerrit-Change-Number: 80130
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 14 Aug 2024 17:48:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Ayan Agrawal, Daniel Maslowski, Daniel Maslowski, Felix Singer, Martin L Roth, ron minnich.
Maximilian Brune has posted comments on this change by Ayan Agrawal. ( https://review.coreboot.org/c/coreboot/+/77410?usp=email )
Change subject: qemu-riscv: Improve Documentation
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
needs rebase since some things have changed upstream.
For example we don't have to select a specific DRAM size anymore, since we now get it from the devicetree supplied by QEMU.
--
To view, visit https://review.coreboot.org/c/coreboot/+/77410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6dbddb6d8801c456196142c3c7d0a2cbf2ed0fb7
Gerrit-Change-Number: 77410
Gerrit-PatchSet: 11
Gerrit-Owner: Ayan Agrawal <ayanagr03(a)gmail.com>
Gerrit-Reviewer: Daniel Maslowski <cyrevolt(a)googlemail.com>
Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Ayan Agrawal <ayanagr03(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Attention: Daniel Maslowski <cyrevolt(a)googlemail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 17:48:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No