Attention is currently required from: Felix Singer.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/77732?usp=email )
Change subject: drivers/ocp/ewl: Remove space after a cast
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/ocp/ewl/ewl.c:
https://review.coreboot.org/c/coreboot/+/77732/comment/9cae466a_7e29e890?us… :
PS2, Line 66: (EWL_ENTRY_HEADER *)&(hob->status.Buffer[offset])
> Agreed.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/77732?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I50ee0adc2f70ad593815783078145cc4b494f70c
Gerrit-Change-Number: 77732
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Thu, 15 Aug 2024 05:02:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: coreboot org <coreboot.org(a)gmail.com>
Attention is currently required from: Martin L Roth, Nicholas Chin.
KunYi Chen has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )
Change subject: mb/lattepanda: Add support for LattePanda Mu
......................................................................
Patch Set 6:
(3 comments)
Patchset:
PS6:
done, modify description
and remove extra line
Commit Message:
https://review.coreboot.org/c/coreboot/+/83719/comment/676e30af_ed4e6e51?us… :
PS5, Line 27: Power on after shutdown: Failed (requires power removal)
> > `Possible unwrapped commit description (prefer a maximum 72 chars per line)` […]
Acknowledged
File src/mainboard/lattepanda/mu/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/83719/comment/2ddc20a9_6b29a1f2?us… :
PS5, Line 8:
> Nit: remove extra line
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/83719?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I79696bdd837a221860b32f54629212c3346dca66
Gerrit-Change-Number: 83719
Gerrit-PatchSet: 6
Gerrit-Owner: KunYi Chen
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 03:51:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: KunYi Chen, Nicholas Chin.
Hello Nicholas Chin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83719?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/lattepanda: Add support for LattePanda Mu
......................................................................
mb/lattepanda: Add support for LattePanda Mu
Add initial support for the LattePanda Mu board, which features:
Intel Alder Lake-N N100 processor
8GB LPDDR5 memory
64GB eMMC storage
SO-DIMM 260-pin connector for function expansion
This commit includes:
Basic board configuration
Memory initialization
Essential I/O setup
Testing with Lite carrier board
Booting into default installed Windows: Passed
USB 3.0/2.0: Working
HDMI output: Working
Realtek Ethernet: Working
S3 sleep mode: Failed
Power on after shutdown: Failed (requires power removal)
Installing Ubuntu 22.04: Failed
UART of SuperIO in OS: Missing
Environment Controller: Not supported
M.2/M Key: Not working (booting failed with SSD 512GB installed)
Change-Id: I79696bdd837a221860b32f54629212c3346dca66
Signed-off-by: KunYi Chen <kunyi.chen(a)gmail.com>
---
A configs/config.lattepanda_mu
A src/mainboard/lattepanda/Kconfig
A src/mainboard/lattepanda/Kconfig.name
A src/mainboard/lattepanda/mu/Kconfig
A src/mainboard/lattepanda/mu/Kconfig.name
A src/mainboard/lattepanda/mu/Makefile.mk
A src/mainboard/lattepanda/mu/board_info.txt
A src/mainboard/lattepanda/mu/bootblock.c
A src/mainboard/lattepanda/mu/data.vbt
A src/mainboard/lattepanda/mu/devicetree.cb
A src/mainboard/lattepanda/mu/dsdt.asl
A src/mainboard/lattepanda/mu/gpio.c
A src/mainboard/lattepanda/mu/include/baseboard/gpio.h
A src/mainboard/lattepanda/mu/include/baseboard/variants.h
A src/mainboard/lattepanda/mu/mainboard.c
A src/mainboard/lattepanda/mu/memory.c
A src/mainboard/lattepanda/mu/ramstage.c
A src/mainboard/lattepanda/mu/romstage_fsp_params.c
A src/mainboard/lattepanda/mu/spd/Makefile.mk
A src/mainboard/lattepanda/mu/spd/empty.spd.hex
A src/mainboard/lattepanda/mu/spd/mu_lp5_16gb.spd.hex
A src/mainboard/lattepanda/mu/spd/mu_lp5_8gb.spd.hex
22 files changed, 762 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/83719/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/83719?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I79696bdd837a221860b32f54629212c3346dca66
Gerrit-Change-Number: 83719
Gerrit-PatchSet: 6
Gerrit-Owner: KunYi Chen
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: KunYi Chen
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik.
Kenneth Chan has posted comments on this change by Kenneth Chan. ( https://review.coreboot.org/c/coreboot/+/83878?usp=email )
Change subject: mb/google/brya/var/nova: Set up soundbar-related gpios
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brya/variants/nova/gpio.c:
https://review.coreboot.org/c/coreboot/+/83878/comment/93f5ef55_571f8603?us… :
PS5, Line 44: PAD_CFG_GPO
> do we need to lock these pads ?
I don't know it can be unlocked in vt-2 or not. The output value need to be changed in vt-2 for updating. So, I don't lock these pads.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83878?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I49815aa3e3192e98170861c4d168c8136def5ccd
Gerrit-Change-Number: 83878
Gerrit-PatchSet: 5
Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 15 Aug 2024 03:02:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Jakub Czapiga, Maximilian Brune, Yu-Ping Wu.
Julius Werner has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83914?usp=email )
Change subject: commonlib/bsd/string: Fix pointer overflow for strnlen()
......................................................................
Patch Set 1:
(1 comment)
File src/commonlib/bsd/string.c:
https://review.coreboot.org/c/coreboot/+/83914/comment/f6e714f4_ddab41ec?us… :
PS1, Line 19: str + maxlen + 1
> Can we just make this `MAX(str + maxlen + 1, SIZE_MAX)`? It's not practically possible to have a str […]
edit: sorry, that was supposed to be `MIN()`, of course. Actually, neither of those is great. Hmmm...
```
if (end <= ptr)
end = (void *)UINTPTR_MAX;
```
? (That coincidentally solves the issue about the string looping around the end of the address space as well.)
--
To view, visit https://review.coreboot.org/c/coreboot/+/83914?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic9d983b11391f5e05c2bceb262682aced5206f94
Gerrit-Change-Number: 83914
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 02:30:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Jakub Czapiga, Maximilian Brune, Yu-Ping Wu.
Julius Werner has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83914?usp=email )
Change subject: commonlib/bsd/string: Fix pointer overflow for strnlen()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/commonlib/bsd/string.c:
https://review.coreboot.org/c/coreboot/+/83914/comment/9ad649eb_79be9c02?us… :
PS1, Line 19: str + maxlen + 1
Can we just make this `MAX(str + maxlen + 1, SIZE_MAX)`? It's not practically possible to have a string of SIZE_MAX length.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83914?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic9d983b11391f5e05c2bceb262682aced5206f94
Gerrit-Change-Number: 83914
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 02:27:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83830?usp=email )
Change subject: commonlib/bsd: Add strlen() and strnlen() functions
......................................................................
Patch Set 3:
(1 comment)
File src/commonlib/bsd/string.c:
https://review.coreboot.org/c/coreboot/+/83830/comment/d3fcb9ac_0837f2ec?us… :
PS3, Line 16: maxlen
> Yes, that's right. An '-1' is not being evaluated at the moment. Thank you for fixing the issue.
Fixed in CB:83914.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83830?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1203ec9affabe493bd14b46662d212b08240cced
Gerrit-Change-Number: 83830
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 02:20:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Felix Held, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Rishika Raj, Shou-Chieh Hsu, Subrata Banik.
Roger Wang has posted comments on this change by Roger Wang. ( https://review.coreboot.org/c/coreboot/+/83904?usp=email )
Change subject: mb/google/nissa/var/sundance: Adjust GPIO GPP_C1 to no_pull-up
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83904/comment/9213bd73_f11d7524?us… :
PS1, Line 9: Due to internal pull-up resistor of 65Kohm in /RST pin in GT7986U(Touch Controller, we will change GPP_C1 from PP&internal pull-up to OD&no pull-up in PCH GPIO Table.
> > `Possible unwrapped commit description (prefer a maximum 72 chars per line)`
>
> Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83904?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I84d1b42a39bebbcd610cebc46f979018fc79238f
Gerrit-Change-Number: 83904
Gerrit-PatchSet: 2
Gerrit-Owner: Roger Wang <roger2.wang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 15 Aug 2024 01:27:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Roger Wang <roger2.wang(a)lcfc.corp-partner.google.com>