Attention is currently required from: Jérémy Compostella, Shuo Liu, yuchi.chen(a)intel.com.
Felix Singer has posted comments on this change by yuchi.chen(a)intel.com. ( https://review.coreboot.org/c/coreboot/+/83321?usp=email )
Change subject: src/soc/intel/snowridge: add support for Intel Atom Snow Ridge SoC
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83321/comment/f9156a20_73c54479?us… :
PS3, Line 7: src/
Remove "src"
File src/soc/intel/snowridge/COPYING-NOTICE:
PS3:
This probably does not belong here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83321?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32ad836dfaaff0d1816eac41e5a7d19ece11080f
Gerrit-Change-Number: 83321
Gerrit-PatchSet: 3
Gerrit-Owner: yuchi.chen(a)intel.com
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: yuchi.chen(a)intel.com
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 10:59:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jérémy Compostella, Shuo Liu, yuchi.chen(a)intel.com.
Felix Singer has posted comments on this change by yuchi.chen(a)intel.com. ( https://review.coreboot.org/c/coreboot/+/83315?usp=email )
Change subject: src/soc/intel/common/block/include/intelblocks/gpio.h: add new field
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83315/comment/ad5456f1_05bb3363?us… :
PS2, Line 7: src/soc/intel/common/block/include/intelblocks/gpio.h
This prefix is not supposed to be a full path to the file that is changed, but it could be though. However, it's more meant to be a topic so that people get a rough idea what this change is about. Also, we don't add "src" if the changes are limited to that directory, since most changes happen there.
How about:
```
soc/intel/common/intelblocks/gpio.h: Allow specifying the pad ownership
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/83315?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I30a934fd00a7a42cb156341da1954e4e4b1231d8
Gerrit-Change-Number: 83315
Gerrit-PatchSet: 2
Gerrit-Owner: yuchi.chen(a)intel.com
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: yuchi.chen(a)intel.com
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 10:54:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jérémy Compostella, Shuo Liu, yuchi.chen(a)intel.com.
Felix Singer has posted comments on this change by yuchi.chen(a)intel.com. ( https://review.coreboot.org/c/coreboot/+/83314?usp=email )
Change subject: add CPU and PCIe definitions for SNR
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83314/comment/b27e317e_ee6247a6?us… :
PS1, Line 7: add CPU and PCIe definitions for SNR
Suggestion:
```
soc/intel/common: add CPU and PCIe IDs for Snow Ridge platform
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/83314?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f5d612765bbe9adffe0b6c7a4151f32b33e88b4
Gerrit-Change-Number: 83314
Gerrit-PatchSet: 1
Gerrit-Owner: yuchi.chen(a)intel.com
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: yuchi.chen(a)intel.com
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 10:45:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81907?usp=email )
Change subject: util/lint: Add lint rule to avoid duplicated includes
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/81907?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia14c73f0bffa6ee4b73254d71836f793af8771c4
Gerrit-Change-Number: 81907
Gerrit-PatchSet: 13
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/82713?usp=email )
Change subject: util/lint: Warn if {stddef,stdint,string}.h included but not used
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/82713?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I94104df7a2e25c0197b4027eb7fddd52cbc4c6ad
Gerrit-Change-Number: 82713
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>