coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
557 discussions

[XS] Change in coreboot[main]: Makefile.mk: Use Walloc-size GCC option
by Felix Held (Code Review) 02 Jul '24

02 Jul '24

Felix Held has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82734?usp=email ) Change subject: Makefile.mk: Use Walloc-size GCC option ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: this breaks the build when using a slightly older toolchain version -- To view, visit https://review.coreboot.org/c/coreboot/+/82734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia26dcf097db125a5a734660d08d875459179241b Gerrit-Change-Number: 82734 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 20:47:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/common: Add fpt_support to override CSME and HECI disables
by Sean Rhodes (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Felix Singer, Paul Menzel. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83265?usp=email ) Change subject: soc/intel/common: Add fpt_support to override CSME and HECI disables ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Wouldn't it be better to document what the ME and the HECI interface can be / is used for instead of […] If users read documentation sure. I was just thinking it should be one easy option - AFAIK, CMOS options can depend/control one another and having to change two options for one thing to work isn't user friendly -- To view, visit https://review.coreboot.org/c/coreboot/+/83265?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I695fa96c5057303730492139904dfcc1d989880b Gerrit-Change-Number: 83265 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 02 Jul 2024 20:00:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[S] Change in coreboot[main]: soc/intel/common: Add fpt_support to override CSME and HECI disables
by Felix Singer (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Paul Menzel, Sean Rhodes. Felix Singer has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83265?usp=email ) Change subject: soc/intel/common: Add fpt_support to override CSME and HECI disables ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Wouldn't it be better to document what the ME and the HECI interface can be / is used for instead of introducing an option which overrides another option? I feel that's quite confusing. -- To view, visit https://review.coreboot.org/c/coreboot/+/83265?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I695fa96c5057303730492139904dfcc1d989880b Gerrit-Change-Number: 83265 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 02 Jul 2024 19:55:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: Makefiles: Add site_local-target to run early in the build
by Felix Held (Code Review) 02 Jul '24

02 Jul '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83198?usp=email ) Change subject: Makefiles: Add site_local-target to run early in the build ...................................................................... Makefiles: Add site_local-target to run early in the build This double-colon target doesn't do anything unless it's implemented by another makefile. It's intended to be used only by the site-local makefile to allow it to run any necessary steps before the actual coreboot build begins. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I01f98c9cf8375bca21ab87f9becf66a25402c758 Reviewed-on: https://review.coreboot.org/c/coreboot/+/83198 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M Makefile M Makefile.mk 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Matt DeVillier: Looks good to me, but someone else must approve diff --git a/Makefile b/Makefile index bc6fabc..cc73900 100644 --- a/Makefile +++ b/Makefile @@ -222,8 +222,7 @@ # The primary target needs to be here before we include the # other files - -real-all: real-target +real-all: site-local-target real-target # must come rather early .SECONDARY: diff --git a/Makefile.mk b/Makefile.mk index a16089d..bae34e0 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -90,6 +90,13 @@ .PHONY: show_notices show_notices:: | show_coreboot +# This rule allows the site-local makefile to run before starting the actual +# coreboot build. It should not be used in the regular coreboot makefiles. +# Note: This gets run after the immediate makefile code like updating the +# submodules, but before any other targets. +.PHONY: site-local-target +site-local-target:: + ####################################################################### # our phony targets PHONY+= clean-abuild coreboot check-style build_complete -- To view, visit https://review.coreboot.org/c/coreboot/+/83198?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I01f98c9cf8375bca21ab87f9becf66a25402c758 Gerrit-Change-Number: 83198 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/intel/mtlrvp: Set cnvi_wifi bluetooth companion device
by Jérémy Compostella (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Cliff Huang. Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83310?usp=email ) Change subject: mb/intel/mtlrvp: Set cnvi_wifi bluetooth companion device ...................................................................... Patch Set 1: -Code-Review Copied votes on follow-up patch sets have been updated: * Copied Code-Review vote has been removed from patch set 2 (was Code-Review-1) since the new Code-Review=0 vote is not copyable (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN"). -- To view, visit https://review.coreboot.org/c/coreboot/+/83310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I66c9b75d2aaa1b221313b037defcd2c579fd6b61 Gerrit-Change-Number: 83310 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 18:20:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/intel/mtlrvp: Set cnvi_wifi bluetooth companion device
by Jérémy Compostella (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Cliff Huang. Hello Cliff Huang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83310?usp=email to look at the new patch set (#2). Change subject: mb/intel/mtlrvp: Set cnvi_wifi bluetooth companion device ...................................................................... mb/intel/mtlrvp: Set cnvi_wifi bluetooth companion device To publish the Bluetooth Regulator Domain Settings under the right ACPI device scope, the wifi generic driver requires the bluetooth companion to be set accordingly. BUG=b:348345301 TEST=BRDS method is added to the CNVW device and return the data supplied by the SAR binary blob Change-Id: I66c9b75d2aaa1b221313b037defcd2c579fd6b61 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/83310/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I66c9b75d2aaa1b221313b037defcd2c579fd6b61 Gerrit-Change-Number: 83310 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>

1 0

[XS] Change in coreboot[main]: mb/google/mtlrvp: Set cnvi_wifi bluetooth companion device
by Jérémy Compostella (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Cliff Huang. Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83310?usp=email ) Change subject: mb/google/mtlrvp: Set cnvi_wifi bluetooth companion device ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: headline is wrong. -- To view, visit https://review.coreboot.org/c/coreboot/+/83310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I66c9b75d2aaa1b221313b037defcd2c579fd6b61 Gerrit-Change-Number: 83310 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 18:19:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/mtlrvp: Set cnvi_wifi bluetooth companion device
by Jérémy Compostella (Code Review) 02 Jul '24

02 Jul '24

Jérémy Compostella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83310?usp=email ) Change subject: mb/google/mtlrvp: Set cnvi_wifi bluetooth companion device ...................................................................... mb/google/mtlrvp: Set cnvi_wifi bluetooth companion device To publish the Bluetooth Regulator Domain Settings under the right ACPI device scope, the wifi generic driver requires the bluetooth companion to be set accordingly. BUG=b:348345301 TEST=BRDS method is added to the CNVW device and return the data supplied by the SAR binary blob Change-Id: I66c9b75d2aaa1b221313b037defcd2c579fd6b61 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/83310/1 diff --git a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb index a0f27f0..010cae2 100644 --- a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb +++ b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb @@ -402,8 +402,8 @@ device ref usb2_port9 on end end chip drivers/usb/acpi - register "desc" = ""USB2 Type-A Port 10"" - register "type" = "UPC_TYPE_A" + register "desc" = ""USB2 Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" register "group" = "ACPI_PLD_GROUP(10, 1)" device ref usb2_port10 on end end @@ -426,6 +426,7 @@ chip drivers/wifi/generic register "wake" = "GPE0_PME_B0" register "enable_cnvi_ddr_rfim" = "true" + use usb2_port10 as bluetooth_companion device generic 0 on end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/83310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I66c9b75d2aaa1b221313b037defcd2c579fd6b61 Gerrit-Change-Number: 83310 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[M] Change in coreboot[main]: drivers/wifi: Support Bluetooth Regulator Domain Settings
by Jérémy Compostella (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Eric Lai, YH Lin, dinesh.sharma(a)intel.com. Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83200?usp=email ) Change subject: drivers/wifi: Support Bluetooth Regulator Domain Settings ...................................................................... Patch Set 10: (1 comment) File src/drivers/wifi/generic/acpi.c: https://review.coreboot.org/c/coreboot/+/83200/comment/2bff339e_be59f09b?us… : PS9, Line 684: if (path) { > > I am confused, the path isn't `wifi (cnvi)`. On rex0 for instance it is `\_SB.PCI0.XHCI.RHUB. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83200?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iebe95815c944d045f4cf686abcd1874a8a45e209 Gerrit-Change-Number: 83200 Gerrit-PatchSet: 10 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dinesh.sharma(a)intel.com Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: dinesh.sharma(a)intel.com Gerrit-Comment-Date: Tue, 02 Jul 2024 17:50:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[M] Change in coreboot[main]: drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC
by Subrata Banik (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Bob Moragues, Bora Guvendik, Cliff Huang, Eric Lai, Hannah Williams, Jérémy Compostella, Poornima Tom, Ravishankar Sarawadi, YH Lin, dinesh.sharma(a)intel.com. Subrata Banik has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/81790?usp=email ) Change subject: drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81790?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie76794825f1a0104d199c078aa4ffc714aa95b17 Gerrit-Change-Number: 81790 Gerrit-PatchSet: 12 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dinesh.sharma(a)intel.com Gerrit-CC: Bob Moragues <moragues(a)google.com> Gerrit-CC: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: dinesh.sharma(a)intel.com Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 17:01:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

← Newer
1
...
26
27
28
29
30
31
32
...
56
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024