coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[S] Change in coreboot[main]: src: Enforce CSE sync with pertinent GBB flag
by Dinesh Gehlot (Code Review) 30 Jul '24

30 Jul '24

Dinesh Gehlot has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83686?usp=email ) Change subject: src: Enforce CSE sync with pertinent GBB flag ...................................................................... src: Enforce CSE sync with pertinent GBB flag The patch enforces CSE sync when the GBB flag GBB_FLAG_FORCE_CSME_SYNC is enabled and the system is currently booting from the RO section. Additionally, it integrates forced CSE sync into eSOL decision-making. This patch is an enhancement of CB:5705989 featuring the new GBB flag. BUG=b:353053317 TEST=Verified forced CSE sync on rex0 with GBB 0x200000 Cq-Depend: chromium:5718196 Change-Id: I228bc8ebf58719776f6c39e0bfbb7ad53d9bfb7f Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> --- M src/soc/intel/common/block/cse/cse_lite.c 1 file changed, 31 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/83686/1 diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c index 0917897..333a799 100644 --- a/src/soc/intel/common/block/cse/cse_lite.c +++ b/src/soc/intel/common/block/cse/cse_lite.c @@ -769,6 +769,22 @@ return CB_SUCCESS; } +static bool is_cse_sync_enforced(void) +{ + /* + * Force test CSE firmware update scenario if below conditions are being met: + * - CSE Update not required + * - VB2_GBB_FLAG_FORCE_CSME_SYNC flag is set + * - CSE FW is in RO + */ + struct vb2_context *ctx = vboot_get_context(); + if ((vb2api_gbb_get_flags(ctx) & VB2_GBB_FLAG_FORCE_CSME_SYNC) && + cse_get_current_bp() == RO) { + return true; + } + return false; +} + static enum cse_update_status cse_check_update_status(struct region_device *target_rdev) { int ret; @@ -787,12 +803,18 @@ cbfs_rw_version.build); ret = cse_compare_sub_part_version(&cbfs_rw_version, cse_get_rw_version()); - if (ret == 0) + if (ret == 0) { + if (is_cse_sync_enforced()) { + printk(BIOS_WARNING, "Force CSE Firmware upgrade for Autotest\n"); + return CSE_UPDATE_UPGRADE; + } return CSE_UPDATE_NOT_REQUIRED; - else if (ret < 0) - return CSE_UPDATE_DOWNGRADE; - else - return CSE_UPDATE_UPGRADE; + } else { + if (ret < 0) + return CSE_UPDATE_DOWNGRADE; + else + return CSE_UPDATE_UPGRADE; + } } static enum cb_err cse_write_rw_region(const struct region_device *target_rdev, @@ -1042,6 +1064,10 @@ if (get_cse_ver_from_cbfs(&cbfs_rw_version) == CB_ERR) return false; + /* Check if CSE sync is enforced */ + if (is_cse_sync_enforced()) { + return true; + } return !!cse_compare_sub_part_version(&cbfs_rw_version, cse_get_rw_version()); } -- To view, visit https://review.coreboot.org/c/coreboot/+/83686?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I228bc8ebf58719776f6c39e0bfbb7ad53d9bfb7f Gerrit-Change-Number: 83686 Gerrit-PatchSet: 1 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>

1 0

[XS] Change in coreboot[main]: src: Include new gbb flag to enforce cse sync
by Dinesh Gehlot (Code Review) 30 Jul '24

30 Jul '24

Dinesh Gehlot has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83685?usp=email ) Change subject: src: Include new gbb flag to enforce cse sync ...................................................................... src: Include new gbb flag to enforce cse sync This patch adds a GBB flag to coreboot, which, when enabled, enforces CSME sync even if the current CSME version matches the version in CBFS. BUG=b:353053317 TEST=futility gbb --help Cq-Depend: chromium:5718196 Change-Id: I6352959e1e898a90b4c6e12a22f8d6513f90ded9 Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> --- M src/security/vboot/Kconfig M src/security/vboot/Makefile.mk 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/83685/1 diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig index e30e8ee..e6abf18 100644 --- a/src/security/vboot/Kconfig +++ b/src/security/vboot/Kconfig @@ -451,6 +451,10 @@ bool "Enable USB Device Controller" default n +config GBB_FLAG_FORCE_CSME_SYNC + bool "Enforce CSE Sync" + default n + endmenu # GBB menu "Vboot Keys" diff --git a/src/security/vboot/Makefile.mk b/src/security/vboot/Makefile.mk index 48a6c9d..591976a 100644 --- a/src/security/vboot/Makefile.mk +++ b/src/security/vboot/Makefile.mk @@ -265,6 +265,7 @@ $(call bool-to-mask,$(CONFIG_GBB_FLAG_FORCE_MANUAL_RECOVERY),0x4000) \ $(call bool-to-mask,$(CONFIG_GBB_FLAG_DISABLE_FWMP),0x8000) \ $(call bool-to-mask,$(CONFIG_GBB_FLAG_ENABLE_UDC),0x10000) \ + $(call bool-to-mask,$(CONFIG_GBB_FLAG_FORCE_CSME_SYNC),0x20000) \ ) ifneq ($(CONFIG_GBB_BMPFV_FILE),) -- To view, visit https://review.coreboot.org/c/coreboot/+/83685?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6352959e1e898a90b4c6e12a22f8d6513f90ded9 Gerrit-Change-Number: 83685 Gerrit-PatchSet: 1 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>

1 0

[L] Change in coreboot[main]: mb/google/nissa: Create teliks variant
by Eric Lai (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik. Eric Lai has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/83408?usp=email ) Change subject: mb/google/nissa: Create teliks variant ...................................................................... Patch Set 16: (1 comment) File src/mainboard/google/brya/variants/teliks/data.vbt: PS16: > > vbt file is just to ensure compilation passes. […] need check with Matt -- To view, visit https://review.coreboot.org/c/coreboot/+/83408?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I744f4d7c2d35544d3a8a8f76e24bad3298442768 Gerrit-Change-Number: 83408 Gerrit-PatchSet: 16 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 30 Jul 2024 07:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: [TEST ONLY] acpigen_ps2_keybd: Move KEY_DELETE to rest_of_keymaps
by Tyler Wang (Code Review) 30 Jul '24

30 Jul '24

Tyler Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83684?usp=email ) Change subject: [TEST ONLY] acpigen_ps2_keybd: Move KEY_DELETE to rest_of_keymaps ...................................................................... [TEST ONLY] acpigen_ps2_keybd: Move KEY_DELETE to rest_of_keymaps This patch supports those keyboard has delete key but without numpad. To prevent KEY_DELETE be defined twice, move it from numeric_keypad_keymaps to rest_of_keymaps. Change-Id: Ib922a2b52fa7152ba3d9deb44e2c8200b2a3802c --- M src/acpi/acpigen_ps2_keybd.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/83684/1 diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index 43a1ece..8691207 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -69,7 +69,6 @@ KEYMAP(0xc7, KEY_HOME), KEYMAP(0xcf, KEY_END), /* Row-1 */ - KEYMAP(0xd3, KEY_DELETE), KEYMAP(0xb5, KEY_KPSLASH), KEYMAP(0x37, KEY_KPASTERISK), KEYMAP(0x4a, KEY_KPMINUS), @@ -99,6 +98,7 @@ static uint32_t rest_of_keymaps[] = { /* Row-0 */ KEYMAP(0x01, KEY_ESC), + KEYMAP(0xd3, KEY_DELETE), /* Row-1 */ KEYMAP(0x29, KEY_GRAVE), KEYMAP(0x02, KEY_1), -- To view, visit https://review.coreboot.org/c/coreboot/+/83684?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib922a2b52fa7152ba3d9deb44e2c8200b2a3802c Gerrit-Change-Number: 83684 Gerrit-PatchSet: 1 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>

1 0

[L] Change in coreboot[main]: mb/google/nissa: Create teliks variant
by Subrata Banik (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng. Subrata Banik has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/83408?usp=email ) Change subject: mb/google/nissa: Create teliks variant ...................................................................... Patch Set 16: (1 comment) File src/mainboard/google/brya/variants/teliks/data.vbt: PS16: > vbt file is just to ensure compilation passes. I don't see any makefile entries of data.vbt in coreboot code for Brya folder. Unless there is something like this ``` $(call add_vbt_to_cbfs, vbt_teliks.bin, data.vbt) ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/83408?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I744f4d7c2d35544d3a8a8f76e24bad3298442768 Gerrit-Change-Number: 83408 Gerrit-PatchSet: 16 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 30 Jul 2024 07:13:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>

1 0

[L] Change in coreboot[main]: mb/google/nissa: Create teliks variant
by Qinghong Zeng (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Qinghong Zeng has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/83408?usp=email ) Change subject: mb/google/nissa: Create teliks variant ...................................................................... Patch Set 16: (1 comment) File src/mainboard/google/brya/variants/teliks/data.vbt: PS16: > this is for windwos build purpose. They can't get chrome vbt. Kind like dummy or copied one. vbt file is just to ensure compilation passes. -- To view, visit https://review.coreboot.org/c/coreboot/+/83408?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I744f4d7c2d35544d3a8a8f76e24bad3298442768 Gerrit-Change-Number: 83408 Gerrit-PatchSet: 16 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Jul 2024 06:05:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Remove linker warning on RWX segments
by Arthur Heymans (Code Review) 30 Jul '24

30 Jul '24

Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83559?usp=email ) Change subject: Makefile.mk: Remove linker warning on RWX segments ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > This breaks building with binutils < 2.39. > > ``` > coreboot-sdk/bin/aarch64-elf-ld.bfd: unrecognized option '--no-warn-rwx-segments' > ``` > > Similar to CB:77147 and CB:82658, can we revert this? So binutils 2.39 is almost 2 years old. Can you upgrade your toolchain instead? https://patchwork.ozlabs.org/project/uboot/patch/20220802083023.1488625-1-j… Linux has an option to see if linker options exist. Maybe you can try to implement that? -- To view, visit https://review.coreboot.org/c/coreboot/+/83559?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e0f51c69dabaea314ac45924474d446a9ab68f4 Gerrit-Change-Number: 83559 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 30 Jul 2024 05:38:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[L] Change in coreboot[main]: mb/google/nissa: Create teliks variant
by Eric Lai (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik. Eric Lai has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/83408?usp=email ) Change subject: mb/google/nissa: Create teliks variant ...................................................................... Patch Set 16: (1 comment) File src/mainboard/google/brya/variants/teliks/data.vbt: PS16: > do we need custome vbt file here ? we can keep the vbt file inside overlays ? this is for windwos build purpose. They can't get chrome vbt. Kind like dummy or copied one. -- To view, visit https://review.coreboot.org/c/coreboot/+/83408?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I744f4d7c2d35544d3a8a8f76e24bad3298442768 Gerrit-Change-Number: 83408 Gerrit-PatchSet: 16 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 30 Jul 2024 05:18:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/brya/var/xol: Using baseboard's PchPmSlpAMinAssert settings
by Eric Lai (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Raymond Chung. Eric Lai has posted comments on this change by Raymond Chung. ( https://review.coreboot.org/c/coreboot/+/83683?usp=email ) Change subject: mb/google/brya/var/xol: Using baseboard's PchPmSlpAMinAssert settings ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia4b7b7ab5dc9afeb3505dfd2b42d0d397aed7a5c Gerrit-Change-Number: 83683 Gerrit-PatchSet: 1 Gerrit-Owner: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com> Gerrit-CC: Edward Doan <edoan(a)google.com> Gerrit-CC: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-CC: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Jul 2024 05:17:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/google/nissa: Create teliks variant
by Subrata Banik (Code Review) 30 Jul '24

30 Jul '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng. Subrata Banik has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/83408?usp=email ) Change subject: mb/google/nissa: Create teliks variant ...................................................................... Patch Set 16: (1 comment) File src/mainboard/google/brya/variants/teliks/data.vbt: PS16: do we need custome vbt file here ? we can keep the vbt file inside overlays ? -- To view, visit https://review.coreboot.org/c/coreboot/+/83408?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I744f4d7c2d35544d3a8a8f76e24bad3298442768 Gerrit-Change-Number: 83408 Gerrit-PatchSet: 16 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 30 Jul 2024 04:43:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024