Attention is currently required from: Elyes Haouas, Felix Singer, Jan Samek, Martin L Roth, Maximilian Brune.
Nico Huber has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82758?usp=email )
Change subject: Revert "Makefile: Warn if flexible array members are not at the end"
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82758?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I179d0bc0db3e863645ae4c87e1534c5c20025dfb
Gerrit-Change-Number: 82758
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jan Samek <samekh(a)email.cz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Jan Samek <samekh(a)email.cz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sun, 02 Jun 2024 23:22:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82769?usp=email )
Change subject: nb/via/cx700: Implement FSB tuning
......................................................................
nb/via/cx700: Implement FSB tuning
This northbridge provides a lot of knobs for fine-grained tuning of the
FSB drivers. The programming manual calls this "Host AGTL+ I/O Driving
Control". We program the known good values for use with a VIA C7 CPU,
and warn about use with different CPUs.
The numbers were pulled out of raminit of the original CX700 port.
Originally, there was a write to 0x83 as well, to set bit 1 which
triggers a soft reset of the CPU. It was amidst a table, so it
seems unclear if it was put there intentionally.
Change-Id: I24ba6cfaab2ca3069952a6c399a065caea7b49f2
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M src/northbridge/via/cx700/romstage.c
1 file changed, 43 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/82769/1
diff --git a/src/northbridge/via/cx700/romstage.c b/src/northbridge/via/cx700/romstage.c
index f4c5584..f6999a3 100644
--- a/src/northbridge/via/cx700/romstage.c
+++ b/src/northbridge/via/cx700/romstage.c
@@ -1,10 +1,53 @@
/* SPDX-License-Identifier: GPL-2.0-only */
+#include <stddef.h>
+#include <stdint.h>
+#include <commonlib/bsd/helpers.h>
+#include <device/pci_ops.h>
+#include <static_devices.h>
#include <romstage_common.h>
#include <halt.h>
+static void tune_fsb(void)
+{
+ if (!CONFIG(CPU_VIA_C7)) {
+ printk(BIOS_WARNING,
+ "FSB settings are known for VIA C7 CPUs, P4 compat. is unknown.\n");
+ }
+ static const struct {
+ uint8_t reg;
+ uint8_t val;
+ } fsb_settings[] = {
+ { 0x70, 0x33 },
+ { 0x71, 0x11 },
+ { 0x72, 0x33 },
+ { 0x73, 0x11 },
+ { 0x74, 0x20 },
+ { 0x75, 0x2e },
+ { 0x76, 0x64 },
+ { 0x77, 0x00 },
+ { 0x78, 0x44 },
+ { 0x79, 0xaa },
+ { 0x7a, 0x33 },
+ { 0x7b, 0xaa },
+ { 0x7c, 0x00 },
+ { 0x7e, 0x33 },
+ { 0x7f, 0x33 },
+ { 0x80, 0x44 },
+ { 0x81, 0x44 },
+ { 0x82, 0x44 },
+ };
+ for (size_t i = 0; i < ARRAY_SIZE(fsb_settings); ++i)
+ pci_write_config8(_sdev_host_if, fsb_settings[i].reg, fsb_settings[i].val);
+}
+
void __noreturn romstage_main(void)
{
+ /* Allows access to all northbridge PCI devfn's */
+ pci_write_config8(_sdev_host_ctrl, 0x4f, 0x01);
+
+ tune_fsb();
+
/* Needed for __noreturn */
halt();
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/82769?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I24ba6cfaab2ca3069952a6c399a065caea7b49f2
Gerrit-Change-Number: 82769
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82767?usp=email )
Change subject: nb/via/cx700: Add south module devices to chipset.cb
......................................................................
nb/via/cx700: Add south module devices to chipset.cb
Change-Id: Ibd7a7b8c9e1461fa665bb72082489b9a48da63c3
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M src/northbridge/via/cx700/chipset.cb
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/82767/1
diff --git a/src/northbridge/via/cx700/chipset.cb b/src/northbridge/via/cx700/chipset.cb
index 192fe22..d236bfb 100644
--- a/src/northbridge/via/cx700/chipset.cb
+++ b/src/northbridge/via/cx700/chipset.cb
@@ -10,6 +10,18 @@
device pci 00.7 alias north_end on end
device pci 01.0 alias north_pci on end
+ device pci 0f.0 alias ata off end
+ device pci 10.0 alias uhci0 off end
+ device pci 10.1 alias uhci1 off end
+ device pci 10.2 alias uhci2 off end
+ device pci 10.4 alias ehci off end
+ device pci 11.0 alias lpc on end
+ device pci 11.7 alias south_end on end
+ device pci 13.0 alias pci0 off
+ device pci 01.0 alias hda off end
+ end
+ device pci 13.1 alias pci1 off end
+
end
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/82767?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibd7a7b8c9e1461fa665bb72082489b9a48da63c3
Gerrit-Change-Number: 82767
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Angel Pons.
Jan Philipp Groß has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82760?usp=email )
Change subject: mb/asrock: Add Z97E-ITX/ac (Haswell/Broadwell)
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
> Welcome to coreboot Gerrit!
Thank you Angel!
Patchset:
PS2:
Thank you Angel!
--
To view, visit https://review.coreboot.org/c/coreboot/+/82760?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3b940e9281814e8360900221714c0dfa3ae39540
Gerrit-Change-Number: 82760
Gerrit-PatchSet: 2
Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Sun, 02 Jun 2024 22:49:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>