coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[M] Change in coreboot[main]: Documentation/mainboard/lenovo: Add ThinkCentre M710s
by Nicholas Sudsgaard (Code Review) 03 Jun '24

03 Jun '24

Attention is currently required from: Angel Pons. Nicholas Sudsgaard has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80411?usp=email ) Change subject: Documentation/mainboard/lenovo: Add ThinkCentre M710s ...................................................................... Patch Set 17: (2 comments) File Documentation/mainboard/lenovo/thinkcentre_m710s.md: https://review.coreboot.org/c/coreboot/+/80411/comment/7dd93d91_231c75a4?us… : PS17, Line 5: that even dummies could follow through > I would prefer to avoid such expressions. […] Thanks for the detailed review! I agree that most of this documentation doesn't belong here, I'll get rid of everything except the mainboard specific stuff. Also, I think most of your questions would be answered by the fact that I had little idea what I was doing. Sorry for the late reply I've been a bit busy. :P https://review.coreboot.org/c/coreboot/+/80411/comment/b363027d_30b96513?us… : PS17, Line 148: 'W25Q64BV/W25Q64CV/W25Q64FV' > Earlier you stated that the chip is a `W25Q64JV`. […] I don't think flashrom has support for `W25Q64JV` specifically (at least when I wrote the documentation). When I looked at the datasheet back then, I think it was very similar to `W25Q64BV/W25Q64CV/W25Q64FV`, so I just used it instead (I haven't had an issues with it). Thinking about it now I should probably look into it a little further. -- To view, visit https://review.coreboot.org/c/coreboot/+/80411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I90311257a28bd463712c4d43f8b83baa745509cc Gerrit-Change-Number: 80411 Gerrit-PatchSet: 17 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Jun 2024 05:31:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[S] Change in coreboot[main]: superio/ite/it8728f: Support setting power state after power failure
by Nicholas Sudsgaard (Code Review) 03 Jun '24

03 Jun '24

Attention is currently required from: Felix Held, Joel Linn, Vladimir Serbinenko. Nicholas Sudsgaard has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/82737?usp=email ) Change subject: superio/ite/it8728f: Support setting power state after power failure ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/superio/ite/it8728f/superio.c: https://review.coreboot.org/c/coreboot/+/82737/comment/bb9cdf62_bb77fbe7?us… : PS3, Line 54: % nit: `%u` -- To view, visit https://review.coreboot.org/c/coreboot/+/82737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3dcc4f032bc5f629fb916c4122beb8dc096bab20 Gerrit-Change-Number: 82737 Gerrit-PatchSet: 3 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Jun 2024 05:00:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/brox: Disable Tccold Handshake
by Ashish Kumar Mishra (Code Review) 03 Jun '24

03 Jun '24

Ashish Kumar Mishra has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/82105?usp=email ) Change subject: mb/google/brox: Disable Tccold Handshake ...................................................................... Abandoned Will raise this patch when required for fix for Brox. Dropping for now. -- To view, visit https://review.coreboot.org/c/coreboot/+/82105?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifcc5937bb78d3226100df5db1b9e7737083963a7 Gerrit-Change-Number: 82105 Gerrit-PatchSet: 1 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/brask/var/bujia: change ALC5650 to ALC5682I-VS
by Derek Huang (Code Review) 03 Jun '24

03 Jun '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Shon Wang, Subrata Banik, YH Lin. Derek Huang has posted comments on this change by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/82774?usp=email ) Change subject: mb/google/brask/var/bujia: change ALC5650 to ALC5682I-VS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82774?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I38e5c58b3ef3fbe709b98601975ae3821bb77213 Gerrit-Change-Number: 82774 Gerrit-PatchSet: 1 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 03 Jun 2024 03:59:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/brask/var/bujia: change ALC5650 to ALC5682I-VS
by Eric Lai (Code Review) 03 Jun '24

03 Jun '24

Attention is currently required from: Derek Huang, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Shon Wang, Subrata Banik, YH Lin. Eric Lai has posted comments on this change by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/82774?usp=email ) Change subject: mb/google/brask/var/bujia: change ALC5650 to ALC5682I-VS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82774?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I38e5c58b3ef3fbe709b98601975ae3821bb77213 Gerrit-Change-Number: 82774 Gerrit-PatchSet: 1 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 03 Jun 2024 03:46:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/brask/var/bujia: change ALC5650 to ALC5682I-VS
by Shon Wang (Code Review) 03 Jun '24

03 Jun '24

Attention is currently required from: Derek Huang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, YH Lin. Shon Wang has posted comments on this change by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/82774?usp=email ) Change subject: mb/google/brask/var/bujia: change ALC5650 to ALC5682I-VS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Do you want add FW config or drop the previous board for audio support? just drop the previous board. thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/82774?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I38e5c58b3ef3fbe709b98601975ae3821bb77213 Gerrit-Change-Number: 82774 Gerrit-PatchSet: 1 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Jun 2024 03:40:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/brask/var/bujia: change ALC5650 to ALC5682I-VS
by Eric Lai (Code Review) 03 Jun '24

03 Jun '24

Attention is currently required from: Derek Huang, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Shon Wang, Subrata Banik, YH Lin. Eric Lai has posted comments on this change by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/82774?usp=email ) Change subject: mb/google/brask/var/bujia: change ALC5650 to ALC5682I-VS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Do you want add FW config or drop the previous board for audio support? -- To view, visit https://review.coreboot.org/c/coreboot/+/82774?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I38e5c58b3ef3fbe709b98601975ae3821bb77213 Gerrit-Change-Number: 82774 Gerrit-PatchSet: 1 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 03 Jun 2024 03:08:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/brask/var/bujia: change ALC5650 to ALC5682I-VS
by Shon Wang (Code Review) 03 Jun '24

03 Jun '24

Shon Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82774?usp=email ) Change subject: mb/google/brask/var/bujia: change ALC5650 to ALC5682I-VS ...................................................................... mb/google/brask/var/bujia: change ALC5650 to ALC5682I-VS Due to system spec change, change audio codec ALC5650 to ALC5682I-VS BUG=b:329787697 TEST= USE="-project_all project_bujia" emerge-brask coreboot Change-Id: I38e5c58b3ef3fbe709b98601975ae3821bb77213 Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/bujia/overridetree.cb 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/82774/1 diff --git a/src/mainboard/google/brya/variants/bujia/overridetree.cb b/src/mainboard/google/brya/variants/bujia/overridetree.cb index 9d7e4ce..f3589b9 100644 --- a/src/mainboard/google/brya/variants/bujia/overridetree.cb +++ b/src/mainboard/google/brya/variants/bujia/overridetree.cb @@ -159,14 +159,15 @@ end device ref i2c0 on chip drivers/i2c/generic - register "hid" = ""10EC5650"" + register "hid" = ""RTL5682"" register "name" = ""RT58"" - register "desc" = ""Realtek RT5650"" + register "desc" = ""Headset Codec"" register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A23)" + # Set the jd_src to RT5668_JD1 for jack detection register "property_count" = "1" register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" - register "property_list[0].name" = ""realtek,jd-mode"" - register "property_list[0].integer" = "2" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" device i2c 1a on end end end # I2C0 -- To view, visit https://review.coreboot.org/c/coreboot/+/82774?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I38e5c58b3ef3fbe709b98601975ae3821bb77213 Gerrit-Change-Number: 82774 Gerrit-PatchSet: 1 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: lib/device_tree.c: Fix wrong check for FDT validity
by Maximilian Brune (Code Review) 03 Jun '24

03 Jun '24

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82773?usp=email ) Change subject: lib/device_tree.c: Fix wrong check for FDT validity ...................................................................... lib/device_tree.c: Fix wrong check for FDT validity Obviously one should return NULL if a FDT is not valid an not the other way around. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I77c0e187b841e60965daac17025110181bdd32bc --- M src/lib/device_tree.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/82773/1 diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c index 2bfd5dd..bddb9ba 100644 --- a/src/lib/device_tree.c +++ b/src/lib/device_tree.c @@ -607,7 +607,7 @@ const struct fdt_header *header = (const struct fdt_header *)blob; tree->header = header; - if (fdt_is_valid(blob)) + if (!fdt_is_valid(blob)) return NULL; uint32_t struct_offset = be32toh(header->structure_offset); -- To view, visit https://review.coreboot.org/c/coreboot/+/82773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77c0e187b841e60965daac17025110181bdd32bc Gerrit-Change-Number: 82773 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: Revert "tree: Use Wcalloc-transposed-args command option"
by Nico Huber (Code Review) 03 Jun '24

03 Jun '24

Attention is currently required from: Elyes Haouas, Felix Singer. Nico Huber has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82759?usp=email ) Change subject: Revert "tree: Use Wcalloc-transposed-args command option" ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Reverting the code change is probably not necessary. -- To view, visit https://review.coreboot.org/c/coreboot/+/82759?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I74ef8de1f7d38e1e0519c3b41e79fd9b11d8e16f Gerrit-Change-Number: 82759 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 02 Jun 2024 23:23:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024