Attention is currently required from: Máté Kukri, Nicholas Chin.
Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/81022?usp=email )
Change subject: mb/asrock: Add Z87E-ITX (Haswell)
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81022?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I56c22d8f5505f9a4da25f8b4406b00978af1a586
Gerrit-Change-Number: 81022
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sun, 02 Jun 2024 16:36:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Angel Pons, Máté Kukri, Nicholas Chin.
Hello Angel Pons, Máté Kukri, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81022?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons, Verified+1 by build bot (Jenkins)
Change subject: mb/asrock: Add Z87E-ITX (Haswell)
......................................................................
mb/asrock: Add Z87E-ITX (Haswell)
This was done using Haswell autoport, with manual fixes to get the
output to build against current main. I do not physically have this
board; I was sent the output of autoport with some fixes on top of
which I added additional changes. The VBT was copied from
/sys/kernel/debug/dri/0/i915_vbt on version 2.70 of the vendor firmware.
The flash chip is 8MiB in a socketed DIP8 package, making it easy to
externally flash to recover from a brick.
Working:
- Haswell MRC.bin
- S3 suspend and resume
- Libgfxinit
- HDMI
- DVI-I (including passive DVI to VGA adapter)
- DisplayPort
- SATA ports
- mSATA SSD
- mPCIe WiFi slot
- Rear USB ports
- USB 3.0 header
- Audio header
- Ethernet
- x16 PCIe slot
- EHCI debug with the CH347 (top USB 2.0 port by the PS/2 connector)
- edk2 (MrChromebox uefipayload_202309)
Not Tested:
- PS/2 keyboard/mouse
- eSATA
- USB 2.0 header
Change-Id: I56c22d8f5505f9a4da25f8b4406b00978af1a586
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
A src/mainboard/asrock/z87e-itx/Kconfig
A src/mainboard/asrock/z87e-itx/Kconfig.name
A src/mainboard/asrock/z87e-itx/Makefile.mk
A src/mainboard/asrock/z87e-itx/acpi/ec.asl
A src/mainboard/asrock/z87e-itx/acpi/platform.asl
A src/mainboard/asrock/z87e-itx/acpi/superio.asl
A src/mainboard/asrock/z87e-itx/board_info.txt
A src/mainboard/asrock/z87e-itx/bootblock.c
A src/mainboard/asrock/z87e-itx/data.vbt
A src/mainboard/asrock/z87e-itx/devicetree.cb
A src/mainboard/asrock/z87e-itx/dsdt.asl
A src/mainboard/asrock/z87e-itx/gma-mainboard.ads
A src/mainboard/asrock/z87e-itx/gpio.c
A src/mainboard/asrock/z87e-itx/hda_verb.c
A src/mainboard/asrock/z87e-itx/romstage.c
15 files changed, 510 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/81022/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/81022?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I56c22d8f5505f9a4da25f8b4406b00978af1a586
Gerrit-Change-Number: 81022
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: Nico Huber, Paul Menzel.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/82632?usp=email )
Change subject: sio/nuvoton: Implement a common ramstage ACPI LDN helper
......................................................................
Patch Set 6:
(3 comments)
Patchset:
PS5:
> You mean pc_keyboard_init(), right? That's kind of always deprecated and disabled […]
Maybe rip the aux device part out of pc_keyboard_init(), and when the conditions are right, swap the port and run it, if the mouse isn't there, swap it back?
File src/superio/nuvoton/common/common.c:
https://review.coreboot.org/c/coreboot/+/82632/comment/bfaf4685_2796ea99?us… :
PS5, Line 53: /* TODO: Show proper message for "keep". */
> Oh yeah that's how! Thanks for the tip
Done
https://review.coreboot.org/c/coreboot/+/82632/comment/bf05199d_4646ff21?us… :
PS5, Line 61: KB_WAKEUP_ANYKEY
> Or nvram option?
I just removed the mouse wakeup. Can't do it with a USB mouse either.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82632?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibaddcaa2d77c5b06ddfbb6dbaac00df5e72dd4bd
Gerrit-Change-Number: 82632
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 02 Jun 2024 13:18:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com>
Attention is currently required from: Keith Hui, Nico Huber, Paul Menzel.
Hello Nico Huber, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82632?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+1 by Nico Huber, Verified+1 by build bot (Jenkins)
Change subject: sio/nuvoton: Implement a common ramstage ACPI LDN helper
......................................................................
sio/nuvoton: Implement a common ramstage ACPI LDN helper
With few exceptions, Nuvoton super I/O chips have the same
configuration registers.
This patch provides a helper function for configuring the ACPI logical
device on Nuvoton SIOs, covering system power state after power loss
and switching PS/2 port roles between keyboard and mouse, both
controllable using nvram options.
This patch covers nct5572d, nct6776, nct6779d, nct6791d. Change all to
use this common code, and add HAVE_POWER_STATE_AFTER_FAILURE Kconfig to
all that don't have it already.
It extends these features to Nuvoton SIOs that currently lack them, with
additional improvements:
1. Enable waking up the system from PS/2 keyboard.
2. Establish an "off" state for "user-defined" power state after
failure. This mode is not used by coreboot.
The nvram options have to be added individually to mainboards.
TEST=Both features boot tested on asus/p8z77-m which uses
sio/nuvoton/nct6779d.
Change-Id: Ibaddcaa2d77c5b06ddfbb6dbaac00df5e72dd4bd
Signed-off-by: Keith Hui <buurin(a)gmail.com>
---
M src/superio/nuvoton/Makefile.mk
A src/superio/nuvoton/common/common.c
A src/superio/nuvoton/common/common.h
M src/superio/nuvoton/nct5572d/superio.c
M src/superio/nuvoton/nct6776/Kconfig
M src/superio/nuvoton/nct6776/superio.c
M src/superio/nuvoton/nct6779d/Kconfig
M src/superio/nuvoton/nct6779d/superio.c
M src/superio/nuvoton/nct6791d/Kconfig
M src/superio/nuvoton/nct6791d/superio.c
10 files changed, 118 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/82632/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/82632?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibaddcaa2d77c5b06ddfbb6dbaac00df5e72dd4bd
Gerrit-Change-Number: 82632
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Attention is currently required from: Elyes Haouas, Felix Singer.
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82759?usp=email
to look at the new patch set (#2).
Change subject: Revert "tree: Use Wcalloc-transposed-args command option"
......................................................................
Revert "tree: Use Wcalloc-transposed-args command option"
This reverts commit b3db3abd6311924930f3250c9f9fc3157fbbf7da.
Reason for revert: `Wcalloc-transposed-args` is new command option came with GCC-14. older versions will not support it.
Change-Id: I74ef8de1f7d38e1e0519c3b41e79fd9b11d8e16f
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Makefile.mk
M src/southbridge/intel/common/rcba_pirq.c
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/82759/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82759?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I74ef8de1f7d38e1e0519c3b41e79fd9b11d8e16f
Gerrit-Change-Number: 82759
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Elyes Haouas, Felix Singer, Jan Samek, Martin L Roth, Maximilian Brune.
Hello Felix Singer, Jan Samek, Martin L Roth, Maximilian Brune, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82758?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: Revert "Makefile: Warn if flexible array members are not at the end"
......................................................................
Revert "Makefile: Warn if flexible array members are not at the end"
This reverts commit f4acef92.
Reason for revert: '-Wflex-array-member-not-at-end' is new command
option came with GCC-14. older versions will not support it.
Change-Id: I179d0bc0db3e863645ae4c87e1534c5c20025dfb
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Makefile.mk
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/82758/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82758?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I179d0bc0db3e863645ae4c87e1534c5c20025dfb
Gerrit-Change-Number: 82758
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jan Samek <samekh(a)email.cz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Jan Samek <samekh(a)email.cz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82658?usp=email )
Change subject: tree: Use Wcalloc-transposed-args command option
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Same here, such things belong into xcompile. And it's part of `-Wextra` […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/82658?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I77b6f4d2eda487b087ba5665b588999633c33e8d
Gerrit-Change-Number: 82658
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 02 Jun 2024 10:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/77147?usp=email )
Change subject: Makefile: Warn if flexible array members are not at the end
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
> I agree. We should use version checks for stuff like this. Thanks for pointing it out.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/77147?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib704f7659d3b431ce7eebb4432c5b1a4272de3d2
Gerrit-Change-Number: 77147
Gerrit-PatchSet: 10
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jan Samek <samekh(a)email.cz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sun, 02 Jun 2024 10:47:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>