coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[XS] Change in coreboot[main]: mb/google/brox: Add romstage early graphics
by Sowmya Aralguppe (Code Review) 23 May '24

23 May '24

Attention is currently required from: Ashish Kumar Mishra, Karthik Ramasubramanian, Krishna P Bhat D, Paul Menzel, Shelley Chen. Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/81931?usp=email ) Change subject: mb/google/brox: Add romstage early graphics ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81931/comment/… [View More]

1 0

[XS] Change in coreboot[main]: mb/google/brox: Add romstage early graphics
by Sowmya Aralguppe (Code Review) 23 May '24

23 May '24

Attention is currently required from: Ashish Kumar Mishra, Karthik Ramasubramanian, Krishna P Bhat D, Shelley Chen, Sowmya Aralguppe. Hello Ashish Kumar Mishra, Karthik Ramasubramanian, Krishna P Bhat D, Shelley Chen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81931?usp=email to look at the new patch set (#8). Change subject: mb/google/brox: Add romstage early graphics .................................................… [View More]..................... mb/google/brox: Add romstage early graphics Select MAINBOARD_USE_EARLY_LIBGFXINIT for brox to enable SOL image. This patch enables Sign of Life image during MRC training. BUG=b:335369811 TEST=Able to boot to ChromeOS with SOL image. CPU log: [0m[DEBUG] Boot Count incremented to 21[0m [0m[INFO ] CBFS: Found 'fspm.bin' @0x90f80 size 0xd0000 in mcache @0xfef89b10[0m [0m[INFO ] VB2:vb2_digest_init() 851968 bytes, hash algo 2, HW acceleration enabled[0m [0m[DEBUG] FMAP: area RW_MRC_CACHE found @ f10000 (65536 bytes)[0m [1m[NOTE ] MRC: no data in 'RW_MRC_CACHE'[0m [0m[SPEW ] bootmode is set to: 0 (boot with full config)[0m [0.384818] DP PHY mode status not complete [0.388911] DP PHY mode status not complete [0.393197] DP PHY mode status not complete [0.397484] DP PHY mode status not complete [0.401771] DP PHY mode status not complete [0.406057] DP PHY mode status not complete [0.410345] DP PHY mode status not complete [0.414632] DP PHY mode status not complete [0.418916] DP PHY mode status not complete [0.423203] DP PHY mode status not complete [0.427491] DP PHY mode status not complete [0.431777] DP PHY mode status not complete [0m[INFO ] Informing user on-display of memory training.[0m [0m[DEBUG] FMAP: area COREBOOT found @ 1877000 (7901184 bytes)[0m [1;4m[WARN ] CBFS: 'preram_locales' not found.[0m [7m[ERROR] ux_locales_get_text: preram_locales not found.[0m [0m[DEBUG] FMAP: area RW_ELOG found @ f20000 (16384 bytes)[0m [0m[INFO ] ELOG: NV offset 0xf20000 size 0x4000[0m [0m[INFO ] ELOG: area is 4096 bytes, full threshold 3842, shrink size 1024[0m [0m[INFO ] ELOG: Event(B8) added with size 10 at 2024-05-13 01:28:03 Change-Id: I1d4795825960bc58f8f7ef494b01aa975f3bc346 Signed-off-by: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> --- M src/mainboard/google/brox/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/81931/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/81931?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d4795825960bc58f8f7ef494b01aa975f3bc346 Gerrit-Change-Number: 81931 Gerrit-PatchSet: 8 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> [View Less]

1 0

[S] Change in coreboot[main]: AUTHORS: Update with 24.05 release info
by Elyes Haouas (Code Review) 23 May '24

23 May '24

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/82617?usp=email ) Change subject: AUTHORS: Update with 24.05 release info ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/82617?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.… [View More]

1 0

[XS] Change in coreboot[main]: mb/google/ovis/var/deku: Increase TDP PL1 value from 28 W to 33 W
by Tony Huang (Code Review) 23 May '24

23 May '24

Attention is currently required from: Derek Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun. Tony Huang has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/82615?usp=email ) Change subject: mb/google/ovis/var/deku: Increase TDP PL1 value from 28 W to 33 W ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82615/comment/… [View More]

1 0

[XS] Change in coreboot[main]: mb/google/ovis/var/deku: Increase TDP PL1 value from 28 W to 33 W
by Tony Huang (Code Review) 23 May '24

23 May '24

Attention is currently required from: Derek Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Tony Huang. Hello Derek Huang, Dinesh Gehlot, Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82615?usp=email to look at the new patch set (#2). Change subject: mb/google/ovis/var/deku: Increase TDP PL1 value from 28 W to 33 W ........… [View More].............................................................. mb/google/ovis/var/deku: Increase TDP PL1 value from 28 W to 33 W Adjust settings as recommended by thermal team. Set PL1 max value tdp_pl1_override from 28W to 33W. PL2, PL4 remain the same as CPU default. BUG=b:308704811 BRANCH=firmware-rex-15709.B TEST=emerge-ovis coreboot chromeos-bootimage built bootleg and verified test result by thermal team Change-Id: Iad0bca913496dda666ba9bcfe5f6fce1a6396692 Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/deku/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/82615/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad0bca913496dda666ba9bcfe5f6fce1a6396692 Gerrit-Change-Number: 82615 Gerrit-PatchSet: 2 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> [View Less]

1 0

[XS] Change in coreboot[main]: AUTHORS: Remove whitespaces at end of line
by Elyes Haouas (Code Review) 23 May '24

23 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82623?usp=email ) Change subject: AUTHORS: Remove whitespaces at end of line ...................................................................... AUTHORS: Remove whitespaces at end of line Change-Id: I8445ac2e1bfca6cbf9d4d544318eec666948a8c4 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M AUTHORS 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:… [View More]

1 0

[S] Change in coreboot[main]: mb/google/rex/var/deku: Update DPTF parameters
by Tony Huang (Code Review) 23 May '24

23 May '24

Attention is currently required from: Sumeet R Pawnikar. Tony Huang has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/82434?usp=email ) Change subject: mb/google/rex/var/deku: Update DPTF parameters ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82434/comment/c8ba3d0c_d2b35eba?us… : PS6, Line 9: Adjust settings as recommended by thermal team.… [View More]

1 0

[XS] Change in coreboot[main]: mb/google/ovis/var/deku: Set TCC_offset to 5
by Tony Huang (Code Review) 23 May '24

23 May '24

Attention is currently required from: Derek Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun. Tony Huang has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/82614?usp=email ) Change subject: mb/google/ovis/var/deku: Set TCC_offset to 5 ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82614/comment/9475f242_6e82a250?us… : … [View More]

1 0

[S] Change in coreboot[main]: mb/google/rex/var/deku: Update DPTF parameters
by Paul Menzel (Code Review) 23 May '24

23 May '24

Attention is currently required from: Sumeet R Pawnikar, Tony Huang. Paul Menzel has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/82434?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/rex/var/deku: Update DPTF parameters ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/… [View More]

1 0

[XS] Change in coreboot[main]: mb/google/ovis/var/deku: Set TCC_offset to 5
by Paul Menzel (Code Review) 23 May '24

23 May '24

Attention is currently required from: Derek Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Tony Huang. Paul Menzel has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/82614?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/ovis/var/deku: Set TCC_offset to 5 ...................................................................... Patch Set 1: (1 comment) … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024