coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[S] Change in coreboot[main]: AUTHORS: Update with 24.05 release info
by Martin L Roth (Code Review) 23 May '24

23 May '24

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82617?usp=email ) Change subject: AUTHORS: Update with 24.05 release info ...................................................................... AUTHORS: Update with 24.05 release info This adds the Authors from the 24.02 tag to the 24.05 tag. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Icb53c62c9a122ccdf2548cc2eebc8b0316a844ef --- M AUTHORS 1 file changed, 29 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/82617/1 diff --git a/AUTHORS b/AUTHORS index d135a6a..eded91f 100644 --- a/AUTHORS +++ b/AUTHORS @@ -39,7 +39,9 @@ Alexey Buyanov Alexey Vazhnov Alice Sell +Alicja Michalska Allen-KH Cheng +Alper Nebi Yasak Amanda Hwang American Megatrends International, LLC Amersel @@ -62,6 +64,7 @@ Annie Chen Anton Kochkov Ao Zhong +Appukuttan V K Arashk Mahshidfar Arec Kao Ariel Fang @@ -93,6 +96,7 @@ Boris Barbulovski Boris Mittelberg Brandon Breitenstein +Brandon Weeks Brian Norris Bryant Ou Carl-Daniel Hailfinger @@ -101,6 +105,7 @@ Cavium Inc. Chao Gui Chen-Tsung Hsieh +Chen. Gang C Chia-Ling Hou Chien-Chih Tseng Chris Wang @@ -128,6 +133,7 @@ Daisuke Nojiri Damien Zammit Dan Callaghan +Dan Campbell Daniel Campello Daniel Gröber Daniel Kang @@ -181,6 +187,7 @@ Eltan B.V. Elyes Haouas Eran Mitrani +Eren Peng Eric Biederman Eric Lai Eric Peers @@ -194,13 +201,16 @@ Evgeny Zinoviev Fabian Groffen Fabian Kunkel +Fabian Meyer Fabio Aiuto Fabrice Bellard Facebook, Inc. +Fei Yan Felix Friedlander Felix Held Felix Singer Fengquan Chen +Filip Lewiński Flora Fu Florian Laufenböck Francois Toguo Fotso @@ -234,6 +244,7 @@ Harsha B R Harshit Sharma Henry C Chen +Herbert Wu Hewlett Packard Enterprise Development LP Hewlett-Packard Development Company, L.P. Himanshu Sahdev @@ -286,6 +297,7 @@ jason-ch chen Jason-jh Lin Jay Patel +Jean Lucas Jeff Chase Jeff Daly Jeff Li @@ -307,6 +319,7 @@ Joe Pillow Joe Tessler Joel Kitching +Joel Linn Joey Peng Johanna Schander John Su @@ -325,6 +338,7 @@ Jörg Mische Joseph Smith Josie Nordrum +Juan José García-Castro Crespo Julia Tsai Julian Schroeder Julian Stecklina @@ -337,6 +351,7 @@ Kapil Porwal Karol Zmyslowski Karthik Ramasubramanian +Kei Hiroyoshi Keith Hui Keith Packard Kenneth Chan @@ -367,9 +382,11 @@ Leah Rowe Lean Sheng Tan Lei Wen +Lennart Eichhorn Lenovo Group Ltd Leo Chou Li-Ta Lo +Li1 Feng Liam Flaherty Libra Li Libretrend LDA @@ -397,6 +414,7 @@ Marc Jones Marco Chen Marek Kasiewicz +Marek Maślanka Marek Vasut Mario Scheithauer Marius Gröger @@ -465,10 +483,12 @@ Nancy.Lin Naresh Solanki Nathan Lu +Naveen R. Iyer Neill Corlett Network Appliance Inc. Nicholas Chin Nicholas Sielicki +Nicholas Sudsgaard Nick Barker Nick Chen Nick Vaccaro @@ -502,6 +522,7 @@ Paul Menzel Paul2 Huang Paulo Alcantara +Pavan Holla Pavel Sayekat Paz Zcharya PC Engines GmbH @@ -520,6 +541,7 @@ Philipp Hug Piotr Kleinschmidt Po Xu +Poornima Tom Prasad Malisetty Prashant Malani Pratik Vishwakarma @@ -529,6 +551,7 @@ Purism SPC Purism, SPC Qii Wang +Qinghong Zeng Qualcomm Technologies, Inc. Quanta Computer INC Raihow Shi @@ -572,6 +595,7 @@ Rockchip, Inc. Rocky Phagura Roger Lu +Roger Wang Roja Rani Yarubandi Romain Lievin Roman Zippel @@ -746,11 +770,13 @@ Won Chung Wonkyu Kim Wuxy +Xiang W Xin Ji Xixi Chen Xuxin Xiong YADRO Yan Liu +Yang Wu Yann Collet Yaroslav Kurlaev YH Lin @@ -767,6 +793,7 @@ Yuchen He Yuchen Huang Yunlong Jia +Yuval Peress Zachary Yedidia Zanxi Chen Zhanyong Wang @@ -776,10 +803,11 @@ Zhiqiang Ma Zhixing Ma Zhiyong Tao -zhongtian wu +Zhongtian Wu Zhuohao Lee Ziang Wang Zoey Wu Zoltan Baldaszti 小田喜陽彦 +忧郁沙茶陳建宏 \ No newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/82617?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb53c62c9a122ccdf2548cc2eebc8b0316a844ef Gerrit-Change-Number: 82617 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/orisa: Generate RAM ID for Micron MT62F512M32D2DR...
by Eric Lai (Code Review) 23 May '24

23 May '24

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82586?usp=email ) Change subject: mb/google/nissa/var/orisa: Generate RAM ID for Micron MT62F512M32D2DR-031 WT:B ...................................................................... mb/google/nissa/var/orisa: Generate RAM ID for Micron MT62F512M32D2DR-031 WT:B Add Micron part MT62F512M32D2DR-031 WT:B only for Orisa. DRAM Part Name ID to assign MT62F512M32D2DR-031 WT:B 0 (0000) BUG=b:337178014 BRANCH=firmware-nissa-15217.B TEST=emerge-nissa coreboot Change-Id: I559ed817250c40795e6c613794d4f65c636f5fc5 Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82586 Reviewed-by: Eric Lai <ericllai(a)google.com> Reviewed-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Reviewed-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/brya/variants/orisa/memory/Makefile.mk M src/mainboard/google/brya/variants/orisa/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/orisa/memory/mem_parts_used.txt 3 files changed, 11 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Dtrain Hsu: Looks good to me, approved Ian Feng: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/orisa/memory/Makefile.mk b/src/mainboard/google/brya/variants/orisa/memory/Makefile.mk index eace2e4..28a0bee 100644 --- a/src/mainboard/google/brya/variants/orisa/memory/Makefile.mk +++ b/src/mainboard/google/brya/variants/orisa/memory/Makefile.mk @@ -1,5 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! -# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. +# Generated by: +# util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/orisa/memory src/mainboard/google/brya/variants/orisa/memory/mem_parts_used.txt -SPD_SOURCES = placeholder +SPD_SOURCES = +SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 0(0b0000) Parts = MT62F512M32D2DR-031 WT:B diff --git a/src/mainboard/google/brya/variants/orisa/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/orisa/memory/dram_id.generated.txt index fa24790..7f1a1837 100644 --- a/src/mainboard/google/brya/variants/orisa/memory/dram_id.generated.txt +++ b/src/mainboard/google/brya/variants/orisa/memory/dram_id.generated.txt @@ -1 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Generated by: +# util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/orisa/memory src/mainboard/google/brya/variants/orisa/memory/mem_parts_used.txt + DRAM Part Name ID to assign +MT62F512M32D2DR-031 WT:B 0 (0000) diff --git a/src/mainboard/google/brya/variants/orisa/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/orisa/memory/mem_parts_used.txt index 2499005..fc41c85 100644 --- a/src/mainboard/google/brya/variants/orisa/memory/mem_parts_used.txt +++ b/src/mainboard/google/brya/variants/orisa/memory/mem_parts_used.txt @@ -9,3 +9,4 @@ # See util/spd_tools/README.md for more details and instructions. # Part Name +MT62F512M32D2DR-031 WT:B -- To view, visit https://review.coreboot.org/c/coreboot/+/82586?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I559ed817250c40795e6c613794d4f65c636f5fc5 Gerrit-Change-Number: 82586 Gerrit-PatchSet: 4 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/orisa: Generate RAM ID for Micron MT62F512M32D2DR...
by Dtrain Hsu (Code Review) 22 May '24

22 May '24

Attention is currently required from: Amanda Hwang, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik. Dtrain Hsu has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/82586?usp=email ) Change subject: mb/google/nissa/var/orisa: Generate RAM ID for Micron MT62F512M32D2DR-031 WT:B ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82586?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I559ed817250c40795e6c613794d4f65c636f5fc5 Gerrit-Change-Number: 82586 Gerrit-PatchSet: 3 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 23 May 2024 02:49:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/orisa: Generate RAM ID for Micron MT62F512M32D2DR...
by Ian Feng (Code Review) 22 May '24

22 May '24

Attention is currently required from: Amanda Hwang, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik. Ian Feng has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/82586?usp=email ) Change subject: mb/google/nissa/var/orisa: Generate RAM ID for Micron MT62F512M32D2DR-031 WT:B ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82586?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I559ed817250c40795e6c613794d4f65c636f5fc5 Gerrit-Change-Number: 82586 Gerrit-PatchSet: 3 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 23 May 2024 02:08:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/rex/var/deku: Update DPTF parameters
by Tony Huang (Code Review) 22 May '24

22 May '24

Attention is currently required from: Eric Lai, Subrata Banik, Sumeet R Pawnikar. Tony Huang has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/82434?usp=email ) Change subject: mb/google/rex/var/deku: Update DPTF parameters ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/rex/variants/deku/overridetree.cb: https://review.coreboot.org/c/coreboot/+/82434/comment/bf2fccfe_40cd2a7f?us… : PS5, Line 22: # Temporary setting TCC of 105C = Tj max (110) - TCC_Offset (5) : register "tcc_offset" = "5" : : register "power_limits_config[MTL_P_682_482_CORE]" = "{ : .tdp_pl1_override = 33, : .tdp_pl2_override = 64, : .tdp_pl4 = 120, : }" > ideally i would expect to see these two changes separately […] Hi Subrata, Please hekp review. thanks Set TCC_offset https://review.coreboot.org/c/coreboot/+/82614 TDP override https://review.coreboot.org/c/coreboot/+/82615 -- To view, visit https://review.coreboot.org/c/coreboot/+/82434?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I710682771bd0679ae4b44dd43be68f60e8984b2e Gerrit-Change-Number: 82434 Gerrit-PatchSet: 6 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Thu, 23 May 2024 01:25:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/ovis/var/deku: Override TDP PL1 value
by Tony Huang (Code Review) 22 May '24

22 May '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun. Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82615?usp=email ) Change subject: mb/google/ovis/var/deku: Override TDP PL1 value ...................................................................... mb/google/ovis/var/deku: Override TDP PL1 value Adjust settings as recommended by thermal team. Set PL1 max value tdp_pl1_override from 28W to 33W. BUG=b:308704811 BRANCH=firmware-rex-15709.B TEST=emerge-ovis coreboot chromeos-bootimage built bootleg and verified test result by thermal team Change-Id: Iad0bca913496dda666ba9bcfe5f6fce1a6396692 Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/deku/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/82615/1 diff --git a/src/mainboard/google/rex/variants/deku/overridetree.cb b/src/mainboard/google/rex/variants/deku/overridetree.cb index 8344e3b..496af45 100644 --- a/src/mainboard/google/rex/variants/deku/overridetree.cb +++ b/src/mainboard/google/rex/variants/deku/overridetree.cb @@ -30,6 +30,12 @@ # Temporary setting TCC of 105C = Tj max (110) - TCC_Offset (5) register "tcc_offset" = "5" + register "power_limits_config[MTL_P_682_482_CORE]" = "{ + .tdp_pl1_override = 33, + .tdp_pl2_override = 64, + .tdp_pl4 = 120, + }" + register "serial_io_i2c_mode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoDisabled, [PchSerialIoIndexI2C1] = PchSerialIoDisabled, -- To view, visit https://review.coreboot.org/c/coreboot/+/82615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad0bca913496dda666ba9bcfe5f6fce1a6396692 Gerrit-Change-Number: 82615 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/google/ovis/var/deku: Set TCC_offset to 5
by Tony Huang (Code Review) 22 May '24

22 May '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun. Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82614?usp=email ) Change subject: mb/google/ovis/var/deku: Set TCC_offset to 5 ...................................................................... mb/google/ovis/var/deku: Set TCC_offset to 5 Adjust settings as recommended by thermal team. Set tcc_offset value to 5 in devicetree. BUG=b:308704811 BRANCH=firmware-rex-15709.B TEST=emerge-ovis coreboot chromeos-bootimage built bootleg and verified test result by thermal team Change-Id: I30f54ae6017c54c91ff9b432bba0ebd5bfc65ab9 Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/deku/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/82614/1 diff --git a/src/mainboard/google/rex/variants/deku/overridetree.cb b/src/mainboard/google/rex/variants/deku/overridetree.cb index 5e3f250..8344e3b 100644 --- a/src/mainboard/google/rex/variants/deku/overridetree.cb +++ b/src/mainboard/google/rex/variants/deku/overridetree.cb @@ -27,6 +27,9 @@ [DDI_PORT_4] = DDI_ENABLE_HPD, }" + # Temporary setting TCC of 105C = Tj max (110) - TCC_Offset (5) + register "tcc_offset" = "5" + register "serial_io_i2c_mode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoDisabled, [PchSerialIoIndexI2C1] = PchSerialIoDisabled, -- To view, visit https://review.coreboot.org/c/coreboot/+/82614?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I30f54ae6017c54c91ff9b432bba0ebd5bfc65ab9 Gerrit-Change-Number: 82614 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[S] Change in coreboot[main]: mb/google/rex/var/deku: Update DPTF parameters
by Tony Huang (Code Review) 22 May '24

22 May '24

Attention is currently required from: Eric Lai, Sumeet R Pawnikar, Tony Huang. Hello Derek Huang, Dinesh Gehlot, Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Sumeet R Pawnikar, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82434?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+2 by Eric Lai, Code-Review+2 by Sumeet R Pawnikar, Verified+1 by build bot (Jenkins) Change subject: mb/google/rex/var/deku: Update DPTF parameters ...................................................................... mb/google/rex/var/deku: Update DPTF parameters Adjust settings as recommended by thermal team. Update DPTF parameters based on b:308704811#comment4. BUG=b:308704811 BRANCH=firmware-rex-15709.B TEST=emerge-ovis coreboot chromeos-bootimage built bootleg and verified test result by thermal team Change-Id: I710682771bd0679ae4b44dd43be68f60e8984b2e Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/deku/overridetree.cb 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/82434/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/82434?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I710682771bd0679ae4b44dd43be68f60e8984b2e Gerrit-Change-Number: 82434 Gerrit-PatchSet: 6 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>

1 0

[S] Change in coreboot[main]: Update 24.05 release notes with final statistics
by Martin L Roth (Code Review) 22 May '24

22 May '24

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82613?usp=email ) Change subject: Update 24.05 release notes with final statistics ...................................................................... Update 24.05 release notes with final statistics The pre-release notes never capture everything, so we need to do an update to finalize them after the release is tagged. This captures on additional SoC added right before the release and updates the statistics. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Id3efcd15597e4fee0bdbca76e474974ae32d3263 --- M Documentation/releases/coreboot-24.05-relnotes.md 1 file changed, 10 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/82613/1 diff --git a/Documentation/releases/coreboot-24.05-relnotes.md b/Documentation/releases/coreboot-24.05-relnotes.md index 9575f2e..86910b8 100644 --- a/Documentation/releases/coreboot-24.05-relnotes.md +++ b/Documentation/releases/coreboot-24.05-relnotes.md @@ -149,6 +149,7 @@ ### Updated SoCs * Added src/soc/ibm/power9 +* Added src/soc/intel/xeon_sp/gnr * Added src/soc/sifive/fu740 @@ -156,15 +157,15 @@ Statistics from the 24.02 to the 24.05 release -------------------------------------------- -* Total Commits: 722 -* Average Commits per day: 8.55 -* Total lines added: 302523 -* Average lines added per commit: 419.01 -* Number of patches adding more than 100 lines: 57 -* Average lines added per small commit: 37.80 -* Total lines removed: 16089 -* Average lines removed per commit: 22.28 -* Total difference between added and removed: 286434 +* Total Commits: 739 +* Average Commits per day: 8.64 +* Total lines added: 304721 +* Average lines added per commit: 412.34 +* Number of patches adding more than 100 lines: 60 +* Average lines added per small commit: 37.74 +* Total lines removed: 16195 +* Average lines removed per commit: 21.91 +* Total difference between added and removed: 288526 * Total authors: 131 * New authors: 23 -- To view, visit https://review.coreboot.org/c/coreboot/+/82613?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id3efcd15597e4fee0bdbca76e474974ae32d3263 Gerrit-Change-Number: 82613 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>

1 0

[M] Change in coreboot[main]: mb/google/ovis/var/deku: Set PsysPL2 value to 178W
by Derek Huang (Code Review) 22 May '24

22 May '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, Tony Huang. Derek Huang has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/82200?usp=email ) Change subject: mb/google/ovis/var/deku: Set PsysPL2 value to 178W ...................................................................... Patch Set 33: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82200?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9ce3a8f843a87e81d404778aaf250b876b6801eb Gerrit-Change-Number: 82200 Gerrit-PatchSet: 33 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 23 May 2024 00:51:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024