coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[XS] Change in coreboot[main]: Makefile: Identify deprecated one-element or zero-length arrays
by Elyes Haouas (Code Review) 22 May '24

22 May '24

Attention is currently required from: Elyes Haouas, Jan Samek, Martin L Roth, Maximilian Brune. Hello Felix Singer, Jan Samek, Martin L Roth, Maximilian Brune, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/77147?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-Review+1 by Maximilian Brune Change subject: Makefile: Identify deprecated one-element or zero-length arrays ...................................................................... Makefile: Identify deprecated one-element or zero-length arrays Older style of one-element or zero-length arrays have been deprecated since last millennium. Use -Wflex-array-member-not-at-end to identify them. Change-Id: Ib704f7659d3b431ce7eebb4432c5b1a4272de3d2 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/77147/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/77147?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib704f7659d3b431ce7eebb4432c5b1a4272de3d2 Gerrit-Change-Number: 77147 Gerrit-PatchSet: 8 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jan Samek <samekh(a)email.cz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Jan Samek <samekh(a)email.cz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[L] Change in coreboot[main]: libpayload: Add x86_64 (64-bit) support
by Subrata Banik (Code Review) 22 May '24

22 May '24

Attention is currently required from: Arthur Heymans, Julius Werner, Kapil Porwal. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81968?usp=email to look at the new patch set (#73). Change subject: libpayload: Add x86_64 (64-bit) support ...................................................................... libpayload: Add x86_64 (64-bit) support This patch introduces x86_64 (64-bit) support to the payload, building upon the existing x86 (32-bit) architecture. Files necessary for 64-bit compilation are now guarded by the `CONFIG_LP_ARCH_X86_64` Kconfig option. BUG=b:242829490 TEST=Able to verify all valid combinations between coreboot and payload with this patch. Payload Entry Point Behavior with below code. +----------------+--------------------+----------------------------+ | LP_ARCH_X86_64 | Payload Entry Mode | Description | +----------------+--------------------+----------------------------+ | No | 32-bit | Direct protected mode init | +----------------+--------------------+----------------------------+ | Yes | 32-bit | Protected to long mode | +----------------+--------------------+----------------------------+ | Yes | 64-bit | Long mode initialization | +----------------+--------------------+----------------------------+ Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M payloads/libpayload/Kconfig M payloads/libpayload/Makefile M payloads/libpayload/Makefile.mk M payloads/libpayload/arch/x86/Makefile.mk M payloads/libpayload/arch/x86/exception.c A payloads/libpayload/arch/x86/exception_asm_64.S R payloads/libpayload/arch/x86/exec.c M payloads/libpayload/arch/x86/gdb.c A payloads/libpayload/arch/x86/head_64.S M payloads/libpayload/arch/x86/libpayload.ldscript A payloads/libpayload/arch/x86/pt.S M payloads/libpayload/arch/x86/string.c M payloads/libpayload/bin/lpgcc M payloads/libpayload/drivers/storage/ahci_common.c M payloads/libpayload/drivers/usb/uhci.c M payloads/libpayload/include/x86/arch/exception.h M payloads/libpayload/libc/Makefile.mk M payloads/libpayload/vboot/Makefile.mk 18 files changed, 755 insertions(+), 58 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81968/73 -- To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585 Gerrit-Change-Number: 81968 Gerrit-PatchSet: 73 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[M] Change in coreboot[main]: arch/arm64: Support calling a trusted monitor
by Benjamin Doron (Code Review) 22 May '24

22 May '24

Attention is currently required from: Arthur Heymans, David Milosevic, Julius Werner. Benjamin Doron has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/78284?usp=email ) Change subject: arch/arm64: Support calling a trusted monitor ...................................................................... Patch Set 19: (1 comment) File src/arch/arm64/smc.c: https://review.coreboot.org/c/coreboot/+/78284/comment/88439fa2_8b5d2637?us… : PS16, Line 41: void > You should not make that decision based on how this is implemented on the other side, the point of h […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78284?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I158db0b971aba722b3995d52162146aa406d1644 Gerrit-Change-Number: 78284 Gerrit-PatchSet: 19 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Wed, 22 May 2024 18:24:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[M] Change in coreboot[main]: arch/arm64: Support calling a trusted monitor
by Benjamin Doron (Code Review) 22 May '24

22 May '24

Attention is currently required from: Arthur Heymans, Benjamin Doron, David Milosevic. Hello David Milosevic, Julius Werner, Lean Sheng Tan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78284?usp=email to look at the new patch set (#19). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: arch/arm64: Support calling a trusted monitor ...................................................................... arch/arm64: Support calling a trusted monitor Implement support for generating an SMC to call a trusted monitor. Some functions are provided to read the SoC ID from the monitor, if supported. Change-Id: I158db0b971aba722b3995d52162146aa406d1644 Signed-off-by: Benjamin Doron <benjamin.doron(a)9elements.com> --- M src/arch/arm64/Makefile.mk A src/arch/arm64/include/armv8/arch/smc.h A src/arch/arm64/smc.c A src/arch/arm64/smc_asm.S 4 files changed, 140 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/78284/19 -- To view, visit https://review.coreboot.org/c/coreboot/+/78284?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I158db0b971aba722b3995d52162146aa406d1644 Gerrit-Change-Number: 78284 Gerrit-PatchSet: 19 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>

1 0

[L] Change in coreboot[main]: libpayload: Add x86_64 (64-bit) support
by Subrata Banik (Code Review) 22 May '24

22 May '24

Attention is currently required from: Arthur Heymans, Julius Werner, Kapil Porwal. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81968?usp=email to look at the new patch set (#72). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: libpayload: Add x86_64 (64-bit) support ...................................................................... libpayload: Add x86_64 (64-bit) support This patch introduces x86_64 (64-bit) support to the payload, building upon the existing x86 (32-bit) architecture. Files necessary for 64-bit compilation are now guarded by the `CONFIG_LP_ARCH_X86_64` Kconfig option. BUG=b:242829490 TEST=Able to verify all valid combinations between coreboot and payload with this patch. Payload Entry Point Behavior with below code. +----------------+--------------------+----------------------------+ | LP_ARCH_X86_64 | Payload Entry Mode | Description | +----------------+--------------------+----------------------------+ | No | 32-bit | Direct protected mode init | +----------------+--------------------+----------------------------+ | Yes | 32-bit | Protected to long mode | +----------------+--------------------+----------------------------+ | Yes | 64-bit | Long mode initialization | +----------------+--------------------+----------------------------+ Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M payloads/libpayload/Kconfig M payloads/libpayload/Makefile M payloads/libpayload/Makefile.mk M payloads/libpayload/arch/x86/Makefile.mk M payloads/libpayload/arch/x86/exception.c A payloads/libpayload/arch/x86/exception_asm_64.S R payloads/libpayload/arch/x86/exec.c M payloads/libpayload/arch/x86/gdb.c A payloads/libpayload/arch/x86/head_64.S M payloads/libpayload/arch/x86/libpayload.ldscript A payloads/libpayload/arch/x86/pt.S M payloads/libpayload/arch/x86/string.c M payloads/libpayload/bin/lpgcc M payloads/libpayload/drivers/storage/ahci_common.c M payloads/libpayload/drivers/usb/uhci.c M payloads/libpayload/include/x86/arch/exception.h M payloads/libpayload/libc/Makefile.mk M payloads/libpayload/vboot/Makefile.mk 18 files changed, 755 insertions(+), 58 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81968/72 -- To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585 Gerrit-Change-Number: 81968 Gerrit-PatchSet: 72 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[S] Change in coreboot[main]: util/smmstoretool: add uint64 data type
by Sergii Dmytruk (Code Review) 22 May '24

22 May '24

Sergii Dmytruk has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82611?usp=email ) Change subject: util/smmstoretool: add uint64 data type ...................................................................... util/smmstoretool: add uint64 data type It's in particular useful for working with variables that contain 64-bit pointers, like CapsuleUpdateData* global variables defined by UEFI specification. Change-Id: I4b46b41cdc5f69d4ca189659bef1e44f64c0d554 Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M util/smmstoretool/data.c M util/smmstoretool/data.h M util/smmstoretool/main.c 3 files changed, 38 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/82611/1 diff --git a/util/smmstoretool/data.c b/util/smmstoretool/data.c index 778bf8a..41d3b75 100644 --- a/util/smmstoretool/data.c +++ b/util/smmstoretool/data.c @@ -57,6 +57,16 @@ if (data_size >= 4) printf("%u\n", *(uint32_t *)data); break; + case DATA_TYPE_UINT64: + if (data_size != 8) { + fprintf(stderr, + "warning: expected size of 8, got %zu\n", + data_size); + } + + if (data_size >= 8) + printf("%llu\n", (unsigned long long)*(uint64_t *)data); + break; case DATA_TYPE_ASCII: for (size_t i = 0; i < data_size; ++i) { char c = data[i]; @@ -78,20 +88,24 @@ static uint64_t parse_uint(const char source[], const char type[], - unsigned long long max) + unsigned long long max, + bool *failed) { char *end; unsigned long long uint = strtoull(source, &end, /*base=*/0); if (*end != '\0') { fprintf(stderr, "Trailing characters in \"%s\": %s\n", source, end); - return UINT64_MAX; + *failed = true; + return 0; } if (uint > max) { fprintf(stderr, "Invalid %s value: %llu\n", type, uint); - return UINT64_MAX; + *failed = true; + return 0; } + *failed = false; return uint; } @@ -100,7 +114,8 @@ switch (type) { void *data; bool boolean; - unsigned long long uint; + uint64_t uint; + bool failed; case DATA_TYPE_BOOL: if (str_eq(source, "true")) { @@ -118,8 +133,8 @@ *(uint8_t *)data = boolean; return data; case DATA_TYPE_UINT8: - uint = parse_uint(source, "uint8", UINT8_MAX); - if (uint == UINT64_MAX) + uint = parse_uint(source, "uint8", UINT8_MAX, &failed); + if (failed) return NULL; *data_size = 1; @@ -127,8 +142,8 @@ *(uint8_t *)data = uint; return data; case DATA_TYPE_UINT16: - uint = parse_uint(source, "uint16", UINT16_MAX); - if (uint == UINT64_MAX) + uint = parse_uint(source, "uint16", UINT16_MAX, &failed); + if (failed) return NULL; *data_size = 2; @@ -136,14 +151,23 @@ *(uint16_t *)data = uint; return data; case DATA_TYPE_UINT32: - uint = parse_uint(source, "uint32", UINT32_MAX); - if (uint == UINT64_MAX) + uint = parse_uint(source, "uint32", UINT32_MAX, &failed); + if (failed) return NULL; *data_size = 4; data = xmalloc(*data_size); *(uint32_t *)data = uint; return data; + case DATA_TYPE_UINT64: + uint = parse_uint(source, "uint64", UINT64_MAX, &failed); + if (failed) + return NULL; + + *data_size = 8; + data = xmalloc(*data_size); + *(uint64_t *)data = uint; + return data; case DATA_TYPE_ASCII: *data_size = strlen(source) + 1; return strdup(source); @@ -167,6 +191,8 @@ *type = DATA_TYPE_UINT16; else if (str_eq(str, "uint32")) *type = DATA_TYPE_UINT32; + else if (str_eq(str, "uint64")) + *type = DATA_TYPE_UINT64; else if (str_eq(str, "ascii")) *type = DATA_TYPE_ASCII; else if (str_eq(str, "unicode")) diff --git a/util/smmstoretool/data.h b/util/smmstoretool/data.h index 13bd7bc..58e6c7d 100644 --- a/util/smmstoretool/data.h +++ b/util/smmstoretool/data.h @@ -12,6 +12,7 @@ DATA_TYPE_UINT8, DATA_TYPE_UINT16, DATA_TYPE_UINT32, + DATA_TYPE_UINT64, DATA_TYPE_ASCII, DATA_TYPE_UNICODE, DATA_TYPE_RAW, diff --git a/util/smmstoretool/main.c b/util/smmstoretool/main.c index f5228d6..df0ee84 100644 --- a/util/smmstoretool/main.c +++ b/util/smmstoretool/main.c @@ -125,6 +125,7 @@ fprintf(f, " * uint8 (0-255)\n"); fprintf(f, " * uint16 (0-65535)\n"); fprintf(f, " * uint32 (0-4294967295)\n"); + fprintf(f, " * uint64 (0-18446744073709551615)\n"); fprintf(f, " * ascii (NUL-terminated)\n"); fprintf(f, " * unicode (widened and NUL-terminated)\n"); fprintf(f, " * raw (output only; raw bytes on output)\n"); -- To view, visit https://review.coreboot.org/c/coreboot/+/82611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4b46b41cdc5f69d4ca189659bef1e44f64c0d554 Gerrit-Change-Number: 82611 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: util/smmstoretool: fix uint{16,32} not being listed by help
by Sergii Dmytruk (Code Review) 22 May '24

22 May '24

Sergii Dmytruk has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82610?usp=email ) Change subject: util/smmstoretool: fix uint{16,32} not being listed by help ...................................................................... util/smmstoretool: fix uint{16,32} not being listed by help These data types were added during review of CB:79080 but they weren't added to the help message. Change-Id: I6e79d65c80c292c3f5d2a2611e602db5cc6cf374 Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M util/smmstoretool/main.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/82610/1 diff --git a/util/smmstoretool/main.c b/util/smmstoretool/main.c index 4857b62..f5228d6 100644 --- a/util/smmstoretool/main.c +++ b/util/smmstoretool/main.c @@ -123,6 +123,8 @@ fprintf(f, "Types and their values:\n"); fprintf(f, " * bool (true, false)\n"); fprintf(f, " * uint8 (0-255)\n"); + fprintf(f, " * uint16 (0-65535)\n"); + fprintf(f, " * uint32 (0-4294967295)\n"); fprintf(f, " * ascii (NUL-terminated)\n"); fprintf(f, " * unicode (widened and NUL-terminated)\n"); fprintf(f, " * raw (output only; raw bytes on output)\n"); -- To view, visit https://review.coreboot.org/c/coreboot/+/82610?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6e79d65c80c292c3f5d2a2611e602db5cc6cf374 Gerrit-Change-Number: 82610 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: mb/google/brox/var/brox: Remove mux references from typec port
by Prashant Malani (Code Review) 22 May '24

22 May '24

Attention is currently required from: Caveh Jalali, Karthik Ramasubramanian, Paul Menzel. Prashant Malani has posted comments on this change by Prashant Malani. ( https://review.coreboot.org/c/coreboot/+/82599?usp=email ) Change subject: mb/google/brox/var/brox: Remove mux references from typec port ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82599/comment/b00dab95_b9a1afa6?us… : PS1, Line 9: mux > Please link to this change. Done https://review.coreboot.org/c/coreboot/+/82599/comment/f0382468_787508dc?us… : PS1, Line 13: TEST=Run system reboot; configure mux kernel errors no longer seen. > Please paste these error. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82599?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93e498b12b109c0e649a23a4a49868976a9ee06b Gerrit-Change-Number: 82599 Gerrit-PatchSet: 1 Gerrit-Owner: Prashant Malani <pmalani(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 22 May 2024 17:02:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Prashant Malani <pmalani(a)chromium.org>

1 0

[XS] Change in coreboot[main]: mb/google/brox/var/brox: Remove mux references from typec port
by Prashant Malani (Code Review) 22 May '24

22 May '24

Attention is currently required from: Caveh Jalali, Karthik Ramasubramanian, Prashant Malani. Hello Caveh Jalali, Karthik Ramasubramanian, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82599?usp=email to look at the new patch set (#2). Change subject: mb/google/brox/var/brox: Remove mux references from typec port ...................................................................... mb/google/brox/var/brox: Remove mux references from typec port The Type-C kernel driver no longer programs the AP mux, as of https://review.coreboot.org/c/coreboot/+/82077. So remove device references to the TCSS Mux control device from the Type-C port driver. This eliminates the following kernel error which was observed as a result of the kernel trying to program muxes it no longer has control over: [ 4.618600] cros-ec-typec GOOG0014:00: Failed to get mux info for port: 0, err = -95 [ 4.618608] cros-ec-typec GOOG0014:00: Configure muxes failed, err = -95 BUG=b:341331428 TEST=Run system reboot; configure mux kernel errors no longer seen. Change-Id: I93e498b12b109c0e649a23a4a49868976a9ee06b Signed-off-by: Prashant Malani <pmalani(a)chromium.org> --- M src/mainboard/google/brox/variants/brox/overridetree.cb 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/82599/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82599?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93e498b12b109c0e649a23a4a49868976a9ee06b Gerrit-Change-Number: 82599 Gerrit-PatchSet: 2 Gerrit-Owner: Prashant Malani <pmalani(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[S] Change in coreboot[main]: mb/prodrive/hermes: Tidy up hda_verb.c
by Felix Held (Code Review) 22 May '24

22 May '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82396?usp=email ) Change subject: mb/prodrive/hermes: Tidy up hda_verb.c ...................................................................... mb/prodrive/hermes: Tidy up hda_verb.c Use the `AZALIA_PIN_CFG_NC(0)` macro instead of `0x411111f0` and tidy up some comments (align them and be consistent with capitalisation). Tested with BUILD_TIMELESS=1, prodrive/hermes remains identical. Change-Id: I1ff1197b1309fc0e5b978d6d36867a3f1a68c67c Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82396 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/mainboard/prodrive/hermes/hda_verb.c 1 file changed, 18 insertions(+), 18 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved diff --git a/src/mainboard/prodrive/hermes/hda_verb.c b/src/mainboard/prodrive/hermes/hda_verb.c index 5876df5..d1ad64f 100644 --- a/src/mainboard/prodrive/hermes/hda_verb.c +++ b/src/mainboard/prodrive/hermes/hda_verb.c @@ -12,22 +12,22 @@ AZALIA_SUBVENDOR(0, 0x1d336700), /* Pin widgets */ - AZALIA_PIN_CFG(0, 0x11, 0x411111f0), /* SPDIF-OUT2 - disabled */ - AZALIA_PIN_CFG(0, 0x12, 0x411111f0), /* digital MIC - disabled */ - AZALIA_PIN_CFG(0, 0x14, 0x01014430), /* PORT D - rear line out */ - AZALIA_PIN_CFG(0, 0x16, 0x411111f0), /* PORT G - disabled */ - AZALIA_PIN_CFG(0, 0x17, 0x411111f0), /* PORT H - disabled */ - AZALIA_PIN_CFG(0, 0x18, 0x01a19c50), /* PORT B - rear mic in */ - AZALIA_PIN_CFG(0, 0x1c, 0x411111f0), /* CD audio - disabled */ - AZALIA_PIN_CFG(0, 0x1d, 0x4004c601), /* BEEPIN */ - AZALIA_PIN_CFG(0, 0x1e, 0x01452160), /* SPDIF-OUT */ - AZALIA_PIN_CFG(0, 0x1f, 0x01c52170), /* SPDIF-IN */ + AZALIA_PIN_CFG(0, 0x11, AZALIA_PIN_CFG_NC(0)), /* SPDIF-OUT2 - disabled */ + AZALIA_PIN_CFG(0, 0x12, AZALIA_PIN_CFG_NC(0)), /* Digital MIC - disabled */ + AZALIA_PIN_CFG(0, 0x14, 0x01014430), /* Port D - rear line out */ + AZALIA_PIN_CFG(0, 0x16, AZALIA_PIN_CFG_NC(0)), /* Port G - disabled */ + AZALIA_PIN_CFG(0, 0x17, AZALIA_PIN_CFG_NC(0)), /* Port H - disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x01a19c50), /* Port B - rear mic in */ + AZALIA_PIN_CFG(0, 0x1c, AZALIA_PIN_CFG_NC(0)), /* CD audio - disabled */ + AZALIA_PIN_CFG(0, 0x1d, 0x4004c601), /* BEEPIN */ + AZALIA_PIN_CFG(0, 0x1e, 0x01452160), /* SPDIF-OUT */ + AZALIA_PIN_CFG(0, 0x1f, 0x01c52170), /* SPDIF-IN */ /* Config for R02 and older */ - AZALIA_PIN_CFG(0, 0x19, 0x02214c40), /* port F - front hp out */ - AZALIA_PIN_CFG(0, 0x1a, 0x901001f0), /* port C - internal speaker */ - AZALIA_PIN_CFG(0, 0x1b, 0x01813c10), /* port E - rear line in/mic - Blue */ - AZALIA_PIN_CFG(0, 0x15, 0x02a19c20), /* port A - audio hdr input */ + AZALIA_PIN_CFG(0, 0x19, 0x02214c40), /* Port F - front hp out */ + AZALIA_PIN_CFG(0, 0x1a, 0x901001f0), /* Port C - internal speaker */ + AZALIA_PIN_CFG(0, 0x1b, 0x01813c10), /* Port E - rear line in/mic - Blue */ + AZALIA_PIN_CFG(0, 0x15, 0x02a19c20), /* Port A - audio hdr input */ /* * VerbTable: CFL Display Audio Codec @@ -67,10 +67,10 @@ AZALIA_ARRAY_SIZES; static const u32 r04_verb_data[] = { - AZALIA_PIN_CFG(0, 0x19, 0x02a19c20), /* PORT F - front mic in */ - AZALIA_PIN_CFG(0, 0x1a, 0x01813c51), /* PORT C - rear line in (mic support) */ - AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), /* PORT E - disabled */ - AZALIA_PIN_CFG(0, 0x15, 0x411111f0), /* PORT A - disabled */ + AZALIA_PIN_CFG(0, 0x19, 0x02a19c20), /* Port F - front mic in */ + AZALIA_PIN_CFG(0, 0x1a, 0x01813c51), /* Port C - rear line in (mic support) */ + AZALIA_PIN_CFG(0, 0x1b, AZALIA_PIN_CFG_NC(0)), /* Port E - disabled */ + AZALIA_PIN_CFG(0, 0x15, AZALIA_PIN_CFG_NC(0)), /* Port A - disabled */ }; static u32 get_port_c_vref_cfg(uint8_t blue_rear_vref) -- To view, visit https://review.coreboot.org/c/coreboot/+/82396?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1ff1197b1309fc0e5b978d6d36867a3f1a68c67c Gerrit-Change-Number: 82396 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024