coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[M] Change in coreboot[main]: Add weak function for SMP hart count
by Maximilian Brune (Code Review) 22 May '24

22 May '24

Attention is currently required from: Philipp Hug, ron minnich. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/81082?usp=email ) Change subject: Add weak function for SMP hart count ...................................................................... Patch Set 2: (3 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/81082/comment/e590508e_59731f5d?us… : PS1, Line 8: needs updating File src/arch/riscv/smp.c: https://review.coreboot.org/c/coreboot/+/81082/comment/1f3845d0_2a36b8d3?us… : PS1, Line 49: * use a poor mans timeout to not wait indefinitiely > this might be too early, the hart_count could e.g. […] Counting the cpu nodes in FDT this early works (at least for QEMU), but I get your point about troubleshooting. You mean we should just simply stop (wfi) all harts in `smp_pause`? I cooked something up in the latest patchset that moves most of this stuff to `smp_resume`. Let me know what you think. File src/arch/riscv/smp.c: https://review.coreboot.org/c/coreboot/+/81082/comment/35d39bbc_e3eafc3a?us… : PS2, Line 56: //TODO not sure if we need a timeout here or if the time waiting for smp_resume to be called is enough of a timeout take care of that. -- To view, visit https://review.coreboot.org/c/coreboot/+/81082?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icc53185991fed4dbed032a52e51ff71d085ad587 Gerrit-Change-Number: 81082 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 22 May 2024 13:48:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Philipp Hug <philipp(a)hug.cx> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: mb/intel/mtlrvp: Include fw_config.c file
by Felix Held (Code Review) 22 May '24

22 May '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82559?usp=email ) Change subject: mb/intel/mtlrvp: Include fw_config.c file ...................................................................... mb/intel/mtlrvp: Include fw_config.c file Update Makefile to include fw_config file for mtlrvp board. Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> Change-Id: Id41cd8b015a796f7a959ceccf85106a48d15ae35 Reviewed-on: https://review.coreboot.org/c/coreboot/+/82559 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Bora Guvendik <bora.guvendik(a)intel.com> Reviewed-by: Jamie Ryu <jamie.m.ryu(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/intel/mtlrvp/Makefile.mk 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jamie Ryu: Looks good to me, approved Angel Pons: Looks good to me, approved build bot (Jenkins): Verified Bora Guvendik: Looks good to me, approved diff --git a/src/mainboard/intel/mtlrvp/Makefile.mk b/src/mainboard/intel/mtlrvp/Makefile.mk index d8144c8..6c93add 100644 --- a/src/mainboard/intel/mtlrvp/Makefile.mk +++ b/src/mainboard/intel/mtlrvp/Makefile.mk @@ -8,6 +8,7 @@ ramstage-y += ec.c ramstage-y += mainboard.c +ramstage-$(CONFIG_FW_CONFIG) += fw_config.c smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c -- To view, visit https://review.coreboot.org/c/coreboot/+/82559?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id41cd8b015a796f7a959ceccf85106a48d15ae35 Gerrit-Change-Number: 82559 Gerrit-PatchSet: 2 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <angel.pons(a)9elements.com>

1 0

[XS] Change in coreboot[main]: Revert "mb/google/brox: Update verb table to fix headset detection"
by Felix Held (Code Review) 22 May '24

22 May '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82273?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Revert "mb/google/brox: Update verb table to fix headset detection" ...................................................................... Revert "mb/google/brox: Update verb table to fix headset detection" This reverts commit f867c9c5473156617691d78350c362cd993bfcdd. The new verb table breaks external mic detection on brox. Revert and use old verb tables instead. BUG=b:330433089 BRANCH=main TEST=Verified headset on Brox When connected to audiojack in power_save state of legacy hda driver, headset is detected and audio is resumed. Change-Id: I0d8c092de6166b2c62f5ecc3deaf4960128e6106 Signed-off-by: Terry Cheong <htcheong(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82273 Reviewed-by: Eric Lai <ericllai(a)google.com> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Shelley Chen <shchen(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h b/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h index 482c0a6..c0b0eb0 100644 --- a/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h +++ b/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h @@ -110,9 +110,9 @@ * To set LDO1/LDO2 as default (used for headset) */ 0x02050008, - 0x0204EA0C, + 0x02046A0C, 0x02050008, - 0x0204EA0C, + 0x02046A0C, }; const u32 pc_beep_verbs[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/82273?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0d8c092de6166b2c62f5ecc3deaf4960128e6106 Gerrit-Change-Number: 82273 Gerrit-PatchSet: 4 Gerrit-Owner: Terry Cheong <htcheong(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Terry Cheong <htcheong(a)google.com>

1 0

[XS] Change in coreboot[main]: [test xcompile] fix scan-build for x86
by Elyes Haouas (Code Review) 22 May '24

22 May '24

Attention is currently required from: Martin L Roth. Hello Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82575?usp=email to look at the new patch set (#2). Change subject: [test xcompile] fix scan-build for x86 ...................................................................... [test xcompile] fix scan-build for x86 Change-Id: Ifb81d16c4883004aa2fa2dd0323b935492bafd58 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/xcompile/xcompile 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/82575/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82575?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb81d16c4883004aa2fa2dd0323b935492bafd58 Gerrit-Change-Number: 82575 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[S] Change in coreboot[main]: Documentation/index.md: Add coreboot's blob policy
by Werner Zeh (Code Review) 22 May '24

22 May '24

Attention is currently required from: David Hendricks, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Patrick Georgi, Paul Menzel, Subrata Banik, Werner Zeh. Hello David Hendricks, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Patrick Georgi, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82086?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Documentation/index.md: Add coreboot's blob policy ...................................................................... Documentation/index.md: Add coreboot's blob policy Every now and then we have discussions about blobs and how and if they should be introduced or handled. This patch adds a clear statement on the project's view on this topic to avoid unclear situations in the future. Change-Id: I20bc0b345c129ecd59aa1190647d89f6d4e07d46 Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M Documentation/index.md 1 file changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/82086/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/82086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I20bc0b345c129ecd59aa1190647d89f6d4e07d46 Gerrit-Change-Number: 82086 Gerrit-PatchSet: 5 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Georgi Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>

1 0

[S] Change in coreboot[main]: Documentation/index.md: Add coreboot's blob policy
by Werner Zeh (Code Review) 22 May '24

22 May '24

Attention is currently required from: David Hendricks, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Patrick Georgi, Paul Menzel, Subrata Banik. Hello David Hendricks, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Patrick Georgi, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82086?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by David Hendricks, Code-Review+1 by Matt DeVillier, Verified+1 by build bot (Jenkins) Change subject: Documentation/index.md: Add coreboot's blob policy ...................................................................... Documentation/index.md: Add coreboot's blob policy Every now and then we have discussions about blobs and how and if they should be introduced or handled. This patch adds a clear statement on the project's view on this topic to avoid unclear situations in the future. Change-Id: I20bc0b345c129ecd59aa1190647d89f6d4e07d46 Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M Documentation/index.md 1 file changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/82086/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/82086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I20bc0b345c129ecd59aa1190647d89f6d4e07d46 Gerrit-Change-Number: 82086 Gerrit-PatchSet: 4 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Georgi Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>

1 0

[S] Change in coreboot[main]: Documentation/index.md: Add coreboot's blob policy
by Werner Zeh (Code Review) 22 May '24

22 May '24

Attention is currently required from: Lean Sheng Tan, Martin L Roth, Patrick Georgi, Paul Menzel, Subrata Banik. Werner Zeh has posted comments on this change by Werner Zeh. ( https://review.coreboot.org/c/coreboot/+/82086?usp=email ) Change subject: Documentation/index.md: Add coreboot's blob policy ...................................................................... Patch Set 3: (3 comments) File Documentation/index.md: https://review.coreboot.org/c/coreboot/+/82086/comment/674b14f6_9be79e72?us… : PS3, Line 154: proprietary UEFI : implementations > Remove UEFI? I will replace it with "proprietary firmware implementations" to make it clear that the scope is still the firmware layer. https://review.coreboot.org/c/coreboot/+/82086/comment/91857ef0_46571192?us… : PS3, Line 177: Please see additionally > Remove the trailing space? Acknowledged https://review.coreboot.org/c/coreboot/+/82086/comment/03ec3c2c_0c1ab354?us… : PS3, Line 179: > Where should that discussion take place? There are various possible ways on how these discussions can take place (mailing list, dedicated calls, face-2-face meetings on conferences, ...). I do not want to name any of them here in particular to not limit the scope in any way. This paragraph is there to make it clear that the community will be taken into account in such cases. And if, for some reason, the community fails to negotiate, ultimately the leadership will decide. > The commit message should elaborate a way forward to replace the blob. You mean the commit message of a patch that introduces the new blob? > Also, a new blob should be announced on the mailing list? Well, this could be a preferred way but must not be the only possibility. -- To view, visit https://review.coreboot.org/c/coreboot/+/82086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I20bc0b345c129ecd59aa1190647d89f6d4e07d46 Gerrit-Change-Number: 82086 Gerrit-PatchSet: 3 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Georgi Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 22 May 2024 10:25:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: mb/google/brya: Add romstage early graphics for nissa
by Subrata Banik (Code Review) 22 May '24

22 May '24

Attention is currently required from: Eric Lai, Haribalaraman Ramasubramanian, Kapil Porwal, Nick Vaccaro, Paul Menzel, Ronak Kanabar, V Sowmya. Subrata Banik has posted comments on this change by Ronak Kanabar. ( https://review.coreboot.org/c/coreboot/+/78932?usp=email ) Change subject: mb/google/brya: Add romstage early graphics for nissa ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb: https://review.coreboot.org/c/coreboot/+/78932/comment/80d23728_55b97b4f?us… : PS7, Line 178: #+-----------------------------+---------------------------------------+-----+ > currently i915_gpu_panel_config we dose not have member to override T8. this we need to add for all. yes this must IMO. we are seeing issues with most of the panel where T8 override hasn't been enabled and default set to 1ms. -- To view, visit https://review.coreboot.org/c/coreboot/+/78932?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I33cfc5d1f8c25c344e598befd21c50a78a65275a Gerrit-Change-Number: 78932 Gerrit-PatchSet: 7 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Wed, 22 May 2024 10:25:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Ronak Kanabar <ronak.kanabar(a)intel.com>

1 0

[S] Change in coreboot[main]: mb/google/brya: Add romstage early graphics for nissa
by Ronak Kanabar (Code Review) 22 May '24

22 May '24

Attention is currently required from: Eric Lai, Haribalaraman Ramasubramanian, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik, V Sowmya. Ronak Kanabar has posted comments on this change by Ronak Kanabar. ( https://review.coreboot.org/c/coreboot/+/78932?usp=email ) Change subject: mb/google/brya: Add romstage early graphics for nissa ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb: https://review.coreboot.org/c/coreboot/+/78932/comment/bc6eb522_e7e8d9be?us… : PS7, Line 178: #+-----------------------------+---------------------------------------+-----+ > don't we allow T8 override […] currently i915_gpu_panel_config we dose not have member to override T8. this we need to add for all. -- To view, visit https://review.coreboot.org/c/coreboot/+/78932?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I33cfc5d1f8c25c344e598befd21c50a78a65275a Gerrit-Change-Number: 78932 Gerrit-PatchSet: 7 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 22 May 2024 10:20:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp: Add PD_TYPE_CLUSTER
by Paul Menzel (Code Review) 22 May '24

22 May '24

Attention is currently required from: Angel Pons, Arthur Heymans, Chen, Gang C, Christian Walter, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Shuo Liu, Tim Chu, Ziang Wang. Paul Menzel has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/81443?usp=email ) Change subject: soc/intel/xeon_sp: Add PD_TYPE_CLUSTER ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81443/comment/faf91244_434db5dc?us… : PS6, Line 9: Add a new proximity type to represent the sub-NUMA : cluster (SNC). : : This patch doesn't actually enable SNC. To fully enable : SNC, SoC codes need to override soc_get_cluster_count(), : soc_set_cpu_node_id() and memory_to_pd(), and call : soc_set_cpu_node_id() in its per-CPU init routine. Please re-flow for 72 characters per line. File src/soc/intel/xeon_sp/spr/chip.c: https://review.coreboot.org/c/coreboot/+/81443/comment/d44711ae_7eb3f5e1?us… : PS6, Line 178: if (pds.pds[i].pd_type != PD_TYPE_GENERIC_INITIATOR) Excuse my ignorance, but could these hunks be explained in the commit message? -- To view, visit https://review.coreboot.org/c/coreboot/+/81443?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I32558983780f302ff4893901540a90baebf47add Gerrit-Change-Number: 81443 Gerrit-PatchSet: 6 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 22 May 2024 09:54:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024