coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[XS] Change in coreboot[main]: mb/google/ovis/var/deku: Override TDP PL1 value
by Paul Menzel (Code Review) 23 May '24

23 May '24

Attention is currently required from: Derek Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Tony Huang. Paul Menzel has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/82615?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/ovis/var/deku: Override TDP PL1 value ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82615/comment/eb2d7602_cf5db584?us… : PS1, Line 7: Override TDP PL1 value More specific: > Increase TDP PL1 value from 28 W to 33 W File src/mainboard/google/rex/variants/deku/overridetree.cb: https://review.coreboot.org/c/coreboot/+/82615/comment/61414405_4e3bd79f?us… : PS1, Line 35: .tdp_pl2_override = 64, : .tdp_pl4 = 120, Are these the same as before? -- To view, visit https://review.coreboot.org/c/coreboot/+/82615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad0bca913496dda666ba9bcfe5f6fce1a6396692 Gerrit-Change-Number: 82615 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 23 May 2024 07:12:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: include: Remove unused <string.h>
by Elyes Haouas (Code Review) 23 May '24

23 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82622?usp=email ) Change subject: include: Remove unused <string.h> ...................................................................... include: Remove unused <string.h> Change-Id: Ide2824cbc8525f861d36cefebf2741e009f13a12 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/include/bootstate.h M src/include/rmodule.h 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/82622/1 diff --git a/src/include/bootstate.h b/src/include/bootstate.h index 30231ce..ab055af 100644 --- a/src/include/bootstate.h +++ b/src/include/bootstate.h @@ -3,7 +3,6 @@ #define BOOTSTATE_H #include <assert.h> -#include <string.h> #include <stddef.h> /* Only declare main() when in ramstage. */ #if ENV_RAMSTAGE diff --git a/src/include/rmodule.h b/src/include/rmodule.h index bf26ad0..72faecc 100644 --- a/src/include/rmodule.h +++ b/src/include/rmodule.h @@ -4,7 +4,6 @@ #include <stdint.h> #include <stddef.h> -#include <string.h> #include <commonlib/rmodule-defs.h> enum { -- To view, visit https://review.coreboot.org/c/coreboot/+/82622?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide2824cbc8525f861d36cefebf2741e009f13a12 Gerrit-Change-Number: 82622 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: arch/riscv/include/vm.h: Remove unused <string.h>
by Elyes Haouas (Code Review) 23 May '24

23 May '24

Attention is currently required from: Philipp Hug, ron minnich. Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82621?usp=email ) Change subject: arch/riscv/include/vm.h: Remove unused <string.h> ...................................................................... arch/riscv/include/vm.h: Remove unused <string.h> Change-Id: I910cd5bd6ee524ebb43955615f20a8aa24395b13 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/arch/riscv/include/vm.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/82621/1 diff --git a/src/arch/riscv/include/vm.h b/src/arch/riscv/include/vm.h index c1894c7..9219f10 100644 --- a/src/arch/riscv/include/vm.h +++ b/src/arch/riscv/include/vm.h @@ -3,7 +3,6 @@ #ifndef _VM_H #define _VM_H -#include <string.h> #include <stdint.h> #include <arch/encoding.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/82621?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I910cd5bd6ee524ebb43955615f20a8aa24395b13 Gerrit-Change-Number: 82621 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: ron minnich <rminnich(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/intel/beechnutcity_crb/romstage: Remove unused <string.h>
by Elyes Haouas (Code Review) 23 May '24

23 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82620?usp=email ) Change subject: mb/intel/beechnutcity_crb/romstage: Remove unused <string.h> ...................................................................... mb/intel/beechnutcity_crb/romstage: Remove unused <string.h> Change-Id: I14bb98dad11d34d4e1c6fd1374ace0a5306b070f Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/intel/beechnutcity_crb/romstage.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/82620/1 diff --git a/src/mainboard/intel/beechnutcity_crb/romstage.c b/src/mainboard/intel/beechnutcity_crb/romstage.c index 9cd8ccc..f0e67af 100644 --- a/src/mainboard/intel/beechnutcity_crb/romstage.c +++ b/src/mainboard/intel/beechnutcity_crb/romstage.c @@ -9,7 +9,6 @@ #include <soc/ddr.h> #include <soc/iio.h> #include <soc/romstage.h> -#include <string.h> #include "chip.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/82620?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I14bb98dad11d34d4e1c6fd1374ace0a5306b070f Gerrit-Change-Number: 82620 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: mb/intel/avenuecity_crb/romstage: Remove unused <string.h>
by Elyes Haouas (Code Review) 23 May '24

23 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82619?usp=email ) Change subject: mb/intel/avenuecity_crb/romstage: Remove unused <string.h> ...................................................................... mb/intel/avenuecity_crb/romstage: Remove unused <string.h> Change-Id: I49694e85263939092cd28db3499705e1a19e3d7a Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/intel/avenuecity_crb/romstage.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/82619/1 diff --git a/src/mainboard/intel/avenuecity_crb/romstage.c b/src/mainboard/intel/avenuecity_crb/romstage.c index 9cd8ccc..f0e67af 100644 --- a/src/mainboard/intel/avenuecity_crb/romstage.c +++ b/src/mainboard/intel/avenuecity_crb/romstage.c @@ -9,7 +9,6 @@ #include <soc/ddr.h> #include <soc/iio.h> #include <soc/romstage.h> -#include <string.h> #include "chip.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/82619?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49694e85263939092cd28db3499705e1a19e3d7a Gerrit-Change-Number: 82619 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp/gnr: Add IIO config utils
by Elyes Haouas (Code Review) 23 May '24

23 May '24

Attention is currently required from: Shuo Liu. Elyes Haouas has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/81318?usp=email ) Change subject: soc/intel/xeon_sp/gnr: Add IIO config utils ...................................................................... Patch Set 52: (1 comment) File src/soc/intel/xeon_sp/gnr/soc_iio.c: https://review.coreboot.org/c/coreboot/+/81318/comment/7dcad2f4_de882bae?us… : PS52, Line 4: <string.h> is unused https://review.coreboot.org/c/coreboot/+/82618 -- To view, visit https://review.coreboot.org/c/coreboot/+/81318?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If7146761db6f73a0c4b0d31b010c0d30a42bf690 Gerrit-Change-Number: 81318 Gerrit-PatchSet: 52 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Comment-Date: Thu, 23 May 2024 06:50:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/intel/xeon_sp/gnr/soc_iio: Remove unused <string.h>
by Elyes Haouas (Code Review) 23 May '24

23 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82618?usp=email ) Change subject: soc/intel/xeon_sp/gnr/soc_iio: Remove unused <string.h> ...................................................................... soc/intel/xeon_sp/gnr/soc_iio: Remove unused <string.h> Change-Id: I8d4500edaa0739921831a3b04131046599c35a87 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/intel/xeon_sp/gnr/soc_iio.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/82618/1 diff --git a/src/soc/intel/xeon_sp/gnr/soc_iio.c b/src/soc/intel/xeon_sp/gnr/soc_iio.c index 1404dad..230d407 100644 --- a/src/soc/intel/xeon_sp/gnr/soc_iio.c +++ b/src/soc/intel/xeon_sp/gnr/soc_iio.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <soc/iio.h> -#include <string.h> #include <fsp/util.h> #include <IioPcieConfigUpd.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/82618?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d4500edaa0739921831a3b04131046599c35a87 Gerrit-Change-Number: 82618 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: Update 24.05 release notes with final statistics
by Angel Pons (Code Review) 23 May '24

23 May '24

Attention is currently required from: Felix Singer, Jason Glenesk, Martin L Roth. Angel Pons has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/82613?usp=email ) Change subject: Update 24.05 release notes with final statistics ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82613?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id3efcd15597e4fee0bdbca76e474974ae32d3263 Gerrit-Change-Number: 82613 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 23 May 2024 06:48:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel: Fix pointer size mismatch errors in crashlog
by Subrata Banik (Code Review) 23 May '24

23 May '24

Attention is currently required from: Appukuttan V K, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Wonkyu Kim. Subrata Banik has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82481?usp=email ) Change subject: soc/intel: Fix pointer size mismatch errors in crashlog ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/common/block/crashlog/crashlog.c: https://review.coreboot.org/c/coreboot/+/82481/comment/594b4d37_d28c7c0b?us… : PS2, Line 166: u32 desc_table_addr > Acknowledged i don't believe you have ack the feedback. Can you please take a look? ideally we wish to replace `u32 desc_table_addr` with `uintptr_t desc_table_addr` -- To view, visit https://review.coreboot.org/c/coreboot/+/82481?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d0814a8b767270ec140341bfb51d0782469545d Gerrit-Change-Number: 82481 Gerrit-PatchSet: 4 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 23 May 2024 06:39:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Appukuttan V K <appukuttan.vk(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jakub Czapiga <czapiga(a)google.com>

1 0

[XL] Change in coreboot[main]: vc/intel/fsp/mtl: Add x86_64 FSP headers
by Subrata Banik (Code Review) 23 May '24

23 May '24

Attention is currently required from: Appukuttan V K, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun. Subrata Banik has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82473?usp=email ) Change subject: vc/intel/fsp/mtl: Add x86_64 FSP headers ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/82473/comment/8028a13c_fbcfc29a?us… : PS5, Line 350: PLATFORM_USES_FSP2_4 `PLATFORM_USES_FSP2_4` value for both 32-bit and 64-bit MTL FSP hence, selecting this forbid us to switch to 32-bit FSP seamlessly. Ideally we wish to keep MTL/Rex build support for 32-bit and 64-bit in parallel for scoping the performance impact. Ideally you wish to use different FSP stream for 64-bit support as MTL-FSP doesn't officially support 64-bit FSP. how about below code change ``` config FSP_HEADER_PATH string "Location of FSP headers" default "src/vendorcode/intel/fsp/fsp2_0/meteorlake/x86_64/" if HAVE_X86_64_SUPPORT default "src/vendorcode/intel/fsp/fsp2_0/meteorlake/x86_32/" ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/82473?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib41b57e794311db729ac65a968f562aa127e86c3 Gerrit-Change-Number: 82473 Gerrit-PatchSet: 5 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 23 May 2024 06:37:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024