Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Varshit Pandya.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81627?usp=email
to look at the new patch set (#9).
Change subject: mb/google/brya: Create trulo variant
......................................................................
mb/google/brya: Create trulo variant
This patch adds a new variant trulo for the baseboard trulo.
TEST=abuild -a -x -p none -t google/brya
Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/Kconfig.name
A src/mainboard/google/brya/variants/trulo/include/variant/ec.h
A src/mainboard/google/brya/variants/trulo/include/variant/gpio.h
A src/mainboard/google/brya/variants/trulo/memory/Makefile.mk
A src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt
A src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt
A src/mainboard/google/brya/variants/trulo/overridetree.cb
8 files changed, 58 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/81627/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/81627?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d
Gerrit-Change-Number: 81627
Gerrit-PatchSet: 9
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Michał Żygowski.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80453?usp=email )
Change subject: drivers/crb: Check for PTT before attempting to initialize CRB TPM
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80453?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0ec6217b0e321b7d7a9410b70defde3c3195fc3
Gerrit-Change-Number: 80453
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Comment-Date: Thu, 04 Apr 2024 11:20:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Andrey Petrov, Appukuttan V K, Ronak Kanabar, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81663?usp=email )
Change subject: drivers/intel/fsp2_0:Dedicated caller function for ap procedure calls
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81663/comment/8d36507e_bc0f6e72 :
PS1, Line 7: drivers/intel/fsp2_0:Dedicated caller function for ap procedure calls
Please add a space after the colon, and make the summary a statement by adding a verb in imperative mood. For example:
> Add dedicated …
--
To view, visit https://review.coreboot.org/c/coreboot/+/81663?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64e65b2941207375d5e27c84aa26061e7e72a7f6
Gerrit-Change-Number: 81663
Gerrit-PatchSet: 1
Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Comment-Date: Thu, 04 Apr 2024 11:20:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Elyes Haouas, Martin L Roth.
Hello Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81419?usp=email
to look at the new patch set (#8).
Change subject: [for test] upgrade crossgcc
......................................................................
[for test] upgrade crossgcc
Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M util/crossgcc/buildgcc
R util/crossgcc/patches/acpica-G20240322_iasl.patch
R util/crossgcc/patches/gcc-14-20240331_asan_shadow_offset_callback.patch
R util/crossgcc/patches/gcc-14-20240331_gnat.patch
R util/crossgcc/patches/gcc-14-20240331_libcpp.patch
R util/crossgcc/patches/gcc-14-20240331_libgcc.patch
R util/crossgcc/patches/gcc-14-20240331_musl_poisoned_calloc.patch
R util/crossgcc/patches/gcc-14-20240331_rv32iafc.patch
A util/crossgcc/sum/G20240322.tar.gz.cksum
D util/crossgcc/sum/R06_28_23.tar.gz.cksum
D util/crossgcc/sum/clang-17.0.6.src.tar.xz.cksum
A util/crossgcc/sum/clang-18.1.3.src.tar.xz.cksum
D util/crossgcc/sum/clang-tools-extra-17.0.6.src.tar.xz.cksum
A util/crossgcc/sum/clang-tools-extra-18.1.3.src.tar.xz.cksum
D util/crossgcc/sum/cmake-17.0.6.src.tar.xz.cksum
A util/crossgcc/sum/cmake-18.1.3.src.tar.xz.cksum
D util/crossgcc/sum/cmake-3.28.3.tar.gz.cksum
A util/crossgcc/sum/cmake-3.29.1.tar.gz.cksum
D util/crossgcc/sum/compiler-rt-17.0.6.src.tar.xz.cksum
A util/crossgcc/sum/compiler-rt-18.1.3.src.tar.xz.cksum
D util/crossgcc/sum/gcc-13.2.0.tar.xz.cksum
A util/crossgcc/sum/gcc-14-20240331.tar.xz.cksum
D util/crossgcc/sum/libunwind-17.0.6.src.tar.xz.cksum
A util/crossgcc/sum/libunwind-18.1.3.src.tar.xz.cksum
D util/crossgcc/sum/lld-17.0.6.src.tar.xz.cksum
A util/crossgcc/sum/lld-18.1.3.src.tar.xz.cksum
D util/crossgcc/sum/llvm-17.0.6.src.tar.xz.cksum
A util/crossgcc/sum/llvm-18.1.3.src.tar.xz.cksum
A util/crossgcc/sum/runtimes-18.1.3.src.tar.xz.cksum
29 files changed, 53 insertions(+), 53 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/81419/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/81419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb
Gerrit-Change-Number: 81419
Gerrit-PatchSet: 8
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset
Attention is currently required from: Andrey Petrov, Appukuttan V K, Arthur Heymans, Bora Guvendik, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Matt DeVillier, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Shuo Liu, Subrata Banik, Tim Chu, Wonkyu Kim.
Appukuttan V K has uploaded a new patch set (#34) to the change originally created by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/80277?usp=email )
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: drivers/intel/fsp2_0: Support FSP 2.4 64-bits
......................................................................
drivers/intel/fsp2_0: Support FSP 2.4 64-bits
FSP 2.4 brings FSP 64-bits support which requires some adjustments in
coreboot:
FSP/UEFI uses the Microsoft x64 calling convention. Appropriate
attribute has to be set to all functions calling or called by
the FSP.
BUG=b:329034258
TEST=verified on Lunar Lake RVP board (lnlrvp)
Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec99
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
---
D 3rdparty/vboot
M src/drivers/intel/fsp2_0/fsp_debug_event.c
M src/drivers/intel/fsp2_0/include/fsp/fsp_debug_event.h
M src/drivers/intel/fsp2_0/include/fsp/soc_binding.h
M src/drivers/intel/fsp2_0/include/fsp/util.h
M src/drivers/intel/fsp2_0/ppi/mp_service1.c
M src/drivers/intel/fsp2_0/ppi/mp_service2.c
M src/include/efi/efi_datatype.h
8 files changed, 27 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/80277/34
--
To view, visit https://review.coreboot.org/c/coreboot/+/80277?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec99
Gerrit-Change-Number: 80277
Gerrit-PatchSet: 34
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newpatchset